JonasToth (Jonas Toth)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2016, 11:13 AM (37 w, 6 d)

Recent Activity

Fri, Jul 14

JonasToth added reviewers for D34654: Allow passing a regex for headers to exclude from clang-tidy: aaron.ballman, alexfh, hokein.

i added reviewers, since it seems nobody takes care of this check.
remove if this was bad.

Fri, Jul 14, 6:36 AM · Restricted Project

May 31 2017

JonasToth added a comment to D31370: [clang-tidy] Prototype to check for exception specification.

The matcher in D33537 could be reused here as well. Maybe I should make it common, but it is more complex than any of the common matchers.

May 31 2017, 12:19 PM

May 4 2017

JonasToth added a comment to D31370: [clang-tidy] Prototype to check for exception specification.

this check is somewhat duplicated to a check currently in review, which seemed to be abondened?

May 4 2017, 12:03 PM
JonasToth removed a reviewer for D32690: [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls: JonasToth.
May 4 2017, 5:52 AM · Restricted Project

May 2 2017

JonasToth added a comment to D32690: [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls.

i like the generalization.

May 2 2017, 10:48 AM · Restricted Project
JonasToth added inline comments to D32743: [clang-tidy] Add new cert-dcl21-cpp check. .
May 2 2017, 10:36 AM · Restricted Project

Apr 30 2017

JonasToth added a comment to D32690: [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls.

Nothing to complain from my side.
Would it make sense to add boost pairs/tuples support?
I could imagine modernize checks that would transform boost structures into the stl ones, but that's another discussion probably.

Apr 30 2017, 4:52 PM · Restricted Project
JonasToth accepted D32678: [clang-tidy] Fix naming convention in modernize-use-emplace.
Apr 30 2017, 1:41 PM · Restricted Project

Apr 25 2017

JonasToth added inline comments to D32346: [clang-tidy] New readability check for strlen argument.
Apr 25 2017, 5:30 AM
JonasToth added a comment to D32346: [clang-tidy] New readability check for strlen argument.

#include <string.h>
void dostuff(const char *P) {

if (strncmp(P+2,"xyz",3)==0) {}

}

Iam not super familiar with C, but the intend of the function is to check the following:

P = "foxyz", P2 = "abxyz", P3 = "opxyz", ...

And if P matches this kind of string pattern.

Apr 25 2017, 3:52 AM
JonasToth added inline comments to D32346: [clang-tidy] New readability check for strlen argument.
Apr 25 2017, 3:36 AM

Apr 24 2017

JonasToth added inline comments to D32346: [clang-tidy] New readability check for strlen argument.
Apr 24 2017, 7:26 AM

Apr 23 2017

JonasToth added reviewers for D32395: [clang-tidy] modernize-use-emplace: remove unnecessary make_pair calls: aaron.ballman, alexfh, hokein.
Apr 23 2017, 3:21 AM · Restricted Project
JonasToth added a comment to D32395: [clang-tidy] modernize-use-emplace: remove unnecessary make_pair calls.

please note this enhancement in the ReleaseNotes.

Apr 23 2017, 3:20 AM · Restricted Project

Apr 21 2017

JonasToth added a comment to D32346: [clang-tidy] New readability check for strlen argument.

My thoughts on the check added.
Have you run it over a big codebase? What is the turnout?

Apr 21 2017, 3:57 AM

Apr 11 2017

JonasToth added inline comments to D31887: [clangd] Add documentation page.
Apr 11 2017, 4:29 AM · Restricted Project

Apr 4 2017

JonasToth added a comment to D31648: [clang-tidy] new performance-expensive-value-param check.

Could this check be considered as part of the Default Arguments in CppCoreGuidelines? If yes, we could alias it into the cppcoreguideline-module.

Apr 4 2017, 8:05 AM

Mar 30 2017

JonasToth added a comment to D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.

@jbcoe I dont have them, Thank you for commiting :)

Mar 30 2017, 2:35 AM

Mar 28 2017

JonasToth added inline comments to D31370: [clang-tidy] Prototype to check for exception specification.
Mar 28 2017, 1:57 AM
JonasToth planned changes to D31370: [clang-tidy] Prototype to check for exception specification.

commented review

Mar 28 2017, 1:41 AM
JonasToth updated the diff for D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
  • [Docs] Typos fixed
  • [Doc] improve documentation on what is done in the delegation constructor check
Mar 28 2017, 1:21 AM
JonasToth added inline comments to D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
Mar 28 2017, 1:20 AM

Mar 27 2017

JonasToth added a comment to D30547: [clang-tidy] Forwarding reference overload in constructors.

Why does diff contain so many files?
Could you maybe merge the latest master into your branch?

Mar 27 2017, 5:15 AM · Restricted Project

Mar 25 2017

JonasToth updated the diff for D31370: [clang-tidy] Prototype to check for exception specification.
  • [Doc] short descript in header added
Mar 25 2017, 9:15 AM
JonasToth added inline comments to D31370: [clang-tidy] Prototype to check for exception specification.
Mar 25 2017, 9:13 AM
JonasToth created D31370: [clang-tidy] Prototype to check for exception specification.
Mar 25 2017, 9:10 AM
JonasToth abandoned D30746: [clang-tidy] new check for throw expressions in destructors.
Mar 25 2017, 4:02 AM
JonasToth updated the diff for D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
  • minor fix, commas not needed in enumeration
Mar 25 2017, 4:01 AM
JonasToth added a comment to D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.

nontypo fixes.

Mar 25 2017, 3:59 AM
JonasToth updated the diff for D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
  • [Doc] grammar and content fixed
Mar 25 2017, 3:59 AM
JonasToth planned changes to D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.

fixed the easier issues.

Mar 25 2017, 3:48 AM
JonasToth updated the diff for D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
  • [Doc] fix the bad grammar and typos
Mar 25 2017, 3:48 AM
JonasToth added inline comments to D31365: [scan-build-py] compilation module rewrite.
Mar 25 2017, 3:00 AM

Mar 22 2017

JonasToth retitled D31252: [clang-tidy] add readability-compound-statement-size check. from Clang-tidy: add readability-compound-statement-size check. to [clang-tidy] add readability-compound-statement-size check..
Mar 22 2017, 1:06 PM · Restricted Project
JonasToth added a comment to D31252: [clang-tidy] add readability-compound-statement-size check..

Another thought from me:

Mar 22 2017, 1:04 PM · Restricted Project
JonasToth added a comment to D31252: [clang-tidy] add readability-compound-statement-size check..

Hi and welcome to the clang/llvm community :)

Mar 22 2017, 12:58 PM · Restricted Project

Mar 20 2017

JonasToth updated subscribers of D30746: [clang-tidy] new check for throw expressions in destructors.

@aaron.ballman i asked on the mailing list and we had a little discussion for a general noexcept check. Most were the opinion that flow analysis should be enough.
@mboehme answered on the mailing list, i will just cite the part thats somewhat addressed to you:

Mar 20 2017, 8:11 AM

Mar 19 2017

JonasToth updated the diff for D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
  • [Fix] typo for code duplication
Mar 19 2017, 12:48 PM
JonasToth added inline comments to D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
Mar 19 2017, 12:47 PM
JonasToth updated the diff for D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
  • [Fix] wrong alias mentioned by jonathan
Mar 19 2017, 12:47 PM
JonasToth added a comment to D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.

@jbcoe Yeah that is actually a good point. Can the aliases be configured independent with default arguments? That would be a good improvement as well. For example function-size could take different default parameters.

Mar 19 2017, 12:19 PM
JonasToth updated the diff for D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
  • [Doc] add rule to every mention of the rule number
Mar 19 2017, 12:14 PM
JonasToth updated the diff for D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.

Update the aliases to reflect the new name and link to the related rules in High Integrity C++

  • [Merge] Transition to hicpp wording
  • [Rename] rename safety files
  • Substitute safety with hicpp
  • [Doc] references to the section in hicpp added
Mar 19 2017, 12:07 PM
JonasToth accepted D31128: Rename the safety module to be hicpp.

thank you very much for dealing with this issue :)
I will update the aliases. But maybe later this week since i have an exam. :)

Mar 19 2017, 10:02 AM
JonasToth added inline comments to D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
Mar 19 2017, 8:44 AM

Mar 15 2017

JonasToth added a comment to D30896: [Clang-tidy] add check misc-prefer-switch-for-enums.

@jbcoe and @aaron.ballman i think an valid warning would be if there is another check in an else if statement.
so singular if(enum_value == Enum::Kind) is still ok, but another branch checking on the enum is suspiscious.

Mar 15 2017, 11:00 AM · Restricted Project

Mar 13 2017

JonasToth added a comment to D30896: [Clang-tidy] add check misc-prefer-switch-for-enums.

alright. then i have a good check for myself to write ;)

Mar 13 2017, 10:53 AM · Restricted Project
JonasToth added a comment to D30896: [Clang-tidy] add check misc-prefer-switch-for-enums.

I like that check. But I think it could take another feature.
In my opinion it would be valueable to check if enums are compared against ints as well.

Mar 13 2017, 9:03 AM · Restricted Project

Mar 12 2017

JonasToth added a comment to D30746: [clang-tidy] new check for throw expressions in destructors.

that is true as well.
lets see what the static analysis brings. maybe its easy to achieve something there.

Mar 12 2017, 11:10 AM
JonasToth added a comment to D30746: [clang-tidy] new check for throw expressions in destructors.

yeah you are right.
i will look for some codebases, maybe some interesting results there.

Mar 12 2017, 11:02 AM
JonasToth added a comment to D30746: [clang-tidy] new check for throw expressions in destructors.

I agree with the static analysis. Iam not capable so atm, since i have no clue how to write sensefull static analysis :) But i would like to learn it.

Mar 12 2017, 10:38 AM

Mar 8 2017

JonasToth added a comment to D30746: [clang-tidy] new check for throw expressions in destructors.

@aaron.ballman I would like to make this more valuable and mor applicable to other rulesets as well.
Do you think it would be enough to do the same bad logic in deallocation, without deep analysis of the exceptions that can occur and if they are caught some where?

Mar 8 2017, 11:58 PM
JonasToth updated the diff for D30746: [clang-tidy] new check for throw expressions in destructors.
  • issues by mgehre fixed
Mar 8 2017, 11:49 PM
JonasToth updated the diff for D30746: [clang-tidy] new check for throw expressions in destructors.

add more complicated problematic destructor to see if hasAncestor does what i think

Mar 8 2017, 9:40 AM
JonasToth added reviewers for D30746: [clang-tidy] new check for throw expressions in destructors: hokein, aaron.ballman.
Mar 8 2017, 9:36 AM
JonasToth updated the diff for D30746: [clang-tidy] new check for throw expressions in destructors.
  • [Fix] link to documentation was wrong
Mar 8 2017, 9:34 AM
JonasToth updated the diff for D30746: [clang-tidy] new check for throw expressions in destructors.
  • [Doc] adjust docs
Mar 8 2017, 9:30 AM
JonasToth created D30746: [clang-tidy] new check for throw expressions in destructors.
Mar 8 2017, 9:23 AM

Mar 4 2017

JonasToth added inline comments to D30547: [clang-tidy] Forwarding reference overload in constructors.
Mar 4 2017, 4:08 AM · Restricted Project

Mar 2 2017

JonasToth added a comment to D30547: [clang-tidy] Forwarding reference overload in constructors.

added my thoughts. i like the check, seems really thought out :)

Mar 2 2017, 12:45 PM · Restricted Project
JonasToth added a comment to D30547: [clang-tidy] Forwarding reference overload in constructors.

please add the check in the release notes as well.

Mar 2 2017, 12:31 PM · Restricted Project

Mar 1 2017

JonasToth added inline comments to D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
Mar 1 2017, 10:10 AM
JonasToth updated the diff for D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.

fix the link in release notes

Mar 1 2017, 9:21 AM · Restricted Project

Feb 28 2017

JonasToth added inline comments to D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
Feb 28 2017, 11:30 PM
JonasToth added inline comments to D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
Feb 28 2017, 8:57 AM

Feb 27 2017

JonasToth added a comment to D29561: [clang-tidy] Add parametercount for readibility-function-size.

fixed typo, updated diff

Feb 27 2017, 2:28 AM
JonasToth updated the diff for D29561: [clang-tidy] Add parametercount for readibility-function-size.
  • [Fix] typo fixed
Feb 27 2017, 2:28 AM

Feb 26 2017

JonasToth updated the diff for D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.

[Fix] typos in the module file - actually builds now :D

Feb 26 2017, 4:50 AM
JonasToth created D30383: [clang-tidy] aliases for safety module from section 8 to 12 done.
Feb 26 2017, 4:42 AM
JonasToth added a comment to D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.

mark as done

Feb 26 2017, 3:11 AM · Restricted Project
JonasToth updated the diff for D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.

I worked on it, sry for the long delay.
Release Note adjusted, checker doc adjusted as well. As it turns out, it is possible
to have empty lists for the function lists, so i removed this requirement in the doc.

Feb 26 2017, 3:10 AM · Restricted Project
JonasToth added a comment to D29561: [clang-tidy] Add parametercount for readibility-function-size.

i adjusted the docs and release notes.

Feb 26 2017, 3:01 AM
JonasToth updated the diff for D29561: [clang-tidy] Add parametercount for readibility-function-size.
Feb 26 2017, 3:00 AM
JonasToth updated the diff for D29561: [clang-tidy] Add parametercount for readibility-function-size.
  • [Doc] adjust doc for the checker
Feb 26 2017, 2:56 AM

Feb 6 2017

JonasToth added a comment to D29561: [clang-tidy] Add parametercount for readibility-function-size.

i dont have commit rights, can you land it for me please?

Feb 6 2017, 10:16 AM
JonasToth updated the diff for D29561: [clang-tidy] Add parametercount for readibility-function-size.

Reverted formatting change to testing code

Feb 6 2017, 9:50 AM
JonasToth added a comment to D29267: [clang-tidy] safety-no-assembler.

@alexfh Can we defer moving this to a compiler diagnostic? I'm keen to get a target in place for people to write more safety checks.

Feb 6 2017, 3:41 AM · Restricted Project
JonasToth added a comment to D29267: [clang-tidy] safety-no-assembler.

alright :)

Feb 6 2017, 3:03 AM · Restricted Project
JonasToth added a comment to D29267: [clang-tidy] safety-no-assembler.

out of curiousity:
i would like to contribute to the safety module as well. but currently there is no starting point in master. is there a way to get some code that i can start with? I think the module file where the registration happens would be enough.

Feb 6 2017, 2:58 AM · Restricted Project

Feb 5 2017

JonasToth added a comment to D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.

alrighty :)
i dont have commit rights though.
please some commit when accepted finally. :)

Feb 5 2017, 12:52 PM · Restricted Project
JonasToth updated the diff for D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.

fix two typos pointed out by aaron

Feb 5 2017, 12:52 PM · Restricted Project
JonasToth added inline comments to D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.
Feb 5 2017, 11:24 AM · Restricted Project
JonasToth updated the diff for D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.

Adjust to issues aaron pointed out.

Feb 5 2017, 11:24 AM · Restricted Project
JonasToth updated the summary of D29561: [clang-tidy] Add parametercount for readibility-function-size.
Feb 5 2017, 3:51 AM
JonasToth created D29561: [clang-tidy] Add parametercount for readibility-function-size.
Feb 5 2017, 3:49 AM

Feb 4 2017

JonasToth updated the diff for D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.

updated doc strings

Feb 4 2017, 6:07 AM · Restricted Project
JonasToth added a comment to D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.

oversaw the docs, but fixed now as well

Feb 4 2017, 6:06 AM · Restricted Project
JonasToth updated the diff for D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.

renamed function as requested.

Feb 4 2017, 2:40 AM · Restricted Project
JonasToth added inline comments to D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.
Feb 4 2017, 2:35 AM · Restricted Project

Jan 27 2017

JonasToth added inline comments to D29118: [clang-tidy] safety-no-vector-bool.
Jan 27 2017, 7:21 AM · Restricted Project

Jan 25 2017

JonasToth added inline comments to D29118: [clang-tidy] safety-no-vector-bool.
Jan 25 2017, 2:24 AM · Restricted Project
JonasToth added a comment to D29118: [clang-tidy] safety-no-vector-bool.

i think the test is not mentioned in the release notes is it?

Jan 25 2017, 2:13 AM · Restricted Project

Jan 24 2017

JonasToth added inline comments to D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.
Jan 24 2017, 10:08 AM · Restricted Project
JonasToth updated the diff for D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.

refactored like requested.

Jan 24 2017, 9:06 AM · Restricted Project

Jan 23 2017

JonasToth added a reviewer for D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker: alexfh.
Jan 23 2017, 1:29 AM · Restricted Project
JonasToth added a comment to D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.

ping

Jan 23 2017, 12:47 AM · Restricted Project

Jan 12 2017

JonasToth added inline comments to D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.
Jan 12 2017, 1:18 PM · Restricted Project
JonasToth updated the diff for D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.

Adjusted the ugly string parsing part.

Jan 12 2017, 1:17 PM · Restricted Project

Jan 11 2017

JonasToth updated the diff for D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.

fixed issues pointed out by aaron

Jan 11 2017, 8:13 AM · Restricted Project
JonasToth added inline comments to D28239: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker.
Jan 11 2017, 8:12 AM · Restricted Project