JonasToth (Jonas Toth)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2016, 11:13 AM (46 w, 2 d)

Recent Activity

Sun, Sep 17

JonasToth added inline comments to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.
Sun, Sep 17, 3:34 AM · Restricted Project
JonasToth added a comment to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.

For my part the current state is ok. @alexfh and @aaron.ballman but should do their review before committing.
I would be interested in a exampleoutput for any real project.

Sun, Sep 17, 1:20 AM · Restricted Project

Sat, Sep 16

JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

Informationen my part think that both switch and else should stay here for now. Running it over llvm gave really a lot of warnings, and that a rather good codebase.

Sat, Sep 16, 5:38 AM · Restricted Project
JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

I think will be good idea to extend -Wswitch diagnostics.

Ok. But it will introduce new warnings to llvm codebase itself. I prepare some example output i found right now.

If number of them will not be huge, it'll be worth to fix before extended -Wswitch will be committed.

Sat, Sep 16, 4:59 AM · Restricted Project
JonasToth added a comment to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.

I see, forgot that.
The doc were the interesting part for me, I trust that you test the code correctlty :)

Sat, Sep 16, 4:37 AM · Restricted Project
JonasToth added a comment to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.

I built the patch locally, here is my output:

Sat, Sep 16, 2:49 AM · Restricted Project

Fri, Sep 15

JonasToth added inline comments to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.
Fri, Sep 15, 12:21 PM · Restricted Project
JonasToth added a comment to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.

I did read through it now. In general, the code is sound with my understanding of the complexity metric and there is a almost one to one wording to the document, which is nice.
Since we chatted in IRC directly, i would give a short summary to avoid forgetting what we talked about :)

Fri, Sep 15, 8:32 AM · Restricted Project
JonasToth added a comment to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.

Looking up to the Visitor, i will do this next.

Fri, Sep 15, 7:36 AM · Restricted Project

Wed, Sep 13

JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

What about GNU extension case 1 ... 3: ?

Wed, Sep 13, 11:12 AM · Restricted Project
JonasToth updated the summary of D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
Wed, Sep 13, 7:27 AM · Restricted Project
JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

I think will be good idea to extend -Wswitch diagnostics.

Wed, Sep 13, 7:20 AM · Restricted Project
JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

fixed first stuff, sorry for noise.

Wed, Sep 13, 7:06 AM · Restricted Project
JonasToth updated the diff for D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
  • fix the first issues i found
Wed, Sep 13, 7:06 AM · Restricted Project
JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

I added a clarifying comment for some outcommented code still in the patch. I would like to have a bit of discussion on it.
Maybe some parts of the check could be warning-area, i just implemented it here to have it on one place.

Wed, Sep 13, 6:59 AM · Restricted Project
JonasToth retitled D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches from [clang-tidy] Add new hicpp-multiway-paths-covered check, for missing branches to [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
Wed, Sep 13, 6:52 AM · Restricted Project
JonasToth created D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
Wed, Sep 13, 6:52 AM · Restricted Project
JonasToth closed D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
Wed, Sep 13, 12:54 AM

Tue, Sep 12

JonasToth added a comment to D36354: [clang-tidy] Implement type-based check for `gsl::owner`.

Recommited with fix in rL313067

Tue, Sep 12, 1:02 PM
JonasToth committed rL313067: [clang-tidy] Implement type-based check for `gsl::owner`.
[clang-tidy] Implement type-based check for `gsl::owner`
Tue, Sep 12, 1:02 PM
JonasToth updated the diff for D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
  • make matcher for ctor initialization more readable
Tue, Sep 12, 12:49 PM
JonasToth committed rL313059: [clang-tidy] Revert Implement type-based check for gsl::owner.
[clang-tidy] Revert Implement type-based check for gsl::owner
Tue, Sep 12, 11:37 AM
JonasToth reopened D36354: [clang-tidy] Implement type-based check for `gsl::owner`.

This Patch broke the buildbot for vs-2015.
I will revert, when i figured out how to do this in svn :/

Tue, Sep 12, 11:17 AM
JonasToth added a comment to rL313043: [clang-tidy] Implement type-based check for `gsl::owner`.

review in D36354

Tue, Sep 12, 9:26 AM
JonasToth added a comment to D36354: [clang-tidy] Implement type-based check for `gsl::owner`.

commited in rL313043

Tue, Sep 12, 9:26 AM
JonasToth committed rL313043: [clang-tidy] Implement type-based check for `gsl::owner`.
[clang-tidy] Implement type-based check for `gsl::owner`
Tue, Sep 12, 9:22 AM
JonasToth closed D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
Tue, Sep 12, 9:17 AM
JonasToth updated the diff for D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
  • fix, that deleted destructors are caught as problem as well
  • clarify one comment, duplicated avoid was misleading
Tue, Sep 12, 9:12 AM
JonasToth updated the diff for D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
  • fix typos
Tue, Sep 12, 8:56 AM
JonasToth updated the diff for D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
  • address review comments, especially improve diagnostic for return types, that should be owner but arent
Tue, Sep 12, 8:41 AM

Mon, Sep 11

JonasToth committed rL312901: [clang-tidy] add more aliases for the hicpp module.
[clang-tidy] add more aliases for the hicpp module
Mon, Sep 11, 2:22 AM
JonasToth closed D37664: [clang-tidy] add more aliases for the hicpp module.
Mon, Sep 11, 2:11 AM
JonasToth updated the diff for D37664: [clang-tidy] add more aliases for the hicpp module.
  • [Doc] add list of aliased checks in release notes
Mon, Sep 11, 2:06 AM
JonasToth added a comment to D33826: [clang-tidy] avoid pointer cast to more strict alignment check.

There is an exception to the general rule (EXP36-C-EX2), stating that the result of malloc and friends is allowed to be casted to stricter alignments, since the pointer is known to be of correct alignment.
Could you add a testcase for this case, i think there would currenlty be a false positive.

Mon, Sep 11, 1:56 AM · Restricted Project

Sat, Sep 9

JonasToth updated the diff for D37664: [clang-tidy] add more aliases for the hicpp module.
  • fix minor doc errors
Sat, Sep 9, 6:22 AM
JonasToth created D37664: [clang-tidy] add more aliases for the hicpp module.
Sat, Sep 9, 6:18 AM
JonasToth added a comment to D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
  • Adressed some review comments.
  • Added testcases, where the owner<> annotation might be hidden by a typedef or using, like int using heap_int = gsl::owner<int*>;
Sat, Sep 9, 5:40 AM
JonasToth updated the diff for D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
  • Merge branch 'master'
  • mention current problems with typedefs of owner<> and adjust test cases
Sat, Sep 9, 5:40 AM

Fri, Sep 8

JonasToth added inline comments to D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
Fri, Sep 8, 11:57 AM

Thu, Sep 7

JonasToth added a comment to D36354: [clang-tidy] Implement type-based check for `gsl::owner`.

ping

Thu, Sep 7, 9:33 AM

Wed, Aug 30

JonasToth committed rL312141: [clang-tidy] fix buildbot.
[clang-tidy] fix buildbot
Wed, Aug 30, 10:22 AM
JonasToth added a comment to rL312137: clang-tools-extra/test/clang-tidy/hicpp-signed-bitwise.cpp: Appease *-win32 to….

Thank you for fixing this.
Why is std=c++11 necessary? I think this check should apply to older standards as well.

Wed, Aug 30, 10:10 AM
JonasToth closed D37301: [clang-tidy] fix buildbot hicpp-signed-bitwise.
Wed, Aug 30, 9:32 AM
JonasToth created D37301: [clang-tidy] fix buildbot hicpp-signed-bitwise.
Wed, Aug 30, 9:25 AM
JonasToth committed rL312134: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
[clang-tidy] Improve hicpp-exception-baseclass to handle generic code better
Wed, Aug 30, 9:02 AM
JonasToth closed D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
Wed, Aug 30, 9:02 AM
JonasToth added a comment to D36354: [clang-tidy] Implement type-based check for `gsl::owner`.

language in the docuementation improved

Wed, Aug 30, 8:48 AM
JonasToth updated the diff for D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
  • fix typos and bad language
Wed, Aug 30, 8:47 AM
JonasToth added inline comments to D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
Wed, Aug 30, 8:45 AM
JonasToth updated the diff for D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
  • adjusted expected diagnostics
  • adjust diagnostics and remove private inheritance cases
Wed, Aug 30, 8:25 AM
JonasToth added inline comments to D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
Wed, Aug 30, 8:06 AM
JonasToth updated the diff for D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
  • adjusted the diagnostic for member variables
Wed, Aug 30, 8:00 AM
JonasToth added inline comments to D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
Wed, Aug 30, 7:44 AM
JonasToth committed rL312122: [clang-tidy] hicpp bitwise operations on signed integers.
[clang-tidy] hicpp bitwise operations on signed integers
Wed, Aug 30, 6:33 AM
JonasToth closed D36586: [clang-tidy] hicpp bitwise operations on signed integers.
Wed, Aug 30, 6:33 AM
JonasToth updated the diff for D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
  • added inheritance cases, adjusted matcher is required
Wed, Aug 30, 6:24 AM
JonasToth added inline comments to D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
Wed, Aug 30, 6:22 AM
JonasToth added inline comments to D36586: [clang-tidy] hicpp bitwise operations on signed integers.
Wed, Aug 30, 6:06 AM
JonasToth updated the diff for D36586: [clang-tidy] hicpp bitwise operations on signed integers.
  • added additional testcases, like @aaron.ballman requested
  • fixed diagnostics
Wed, Aug 30, 6:04 AM
JonasToth added a comment to D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix.

alright. i thought it would do something different, but the enforcement to handle all notes is a good thing. forget what i wrote :)

Wed, Aug 30, 5:37 AM · Restricted Project
JonasToth added a comment to D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.

@aaron.ballman is it ok for you as well? otherwise i would commit it.

Wed, Aug 30, 5:25 AM
JonasToth added a comment to D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix.

Note can be handled right now as well. E.g.

// CHECK-MESSAGES: [[@LINE-2]]:3: note: type deduction did not result in an owner
Wed, Aug 30, 5:21 AM · Restricted Project
JonasToth added inline comments to D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
Wed, Aug 30, 5:17 AM
JonasToth resigned from D37210: [refactor] add a refactoring action rule that returns symbol occurrences.

sry. misconfigured herald :(

Wed, Aug 30, 5:14 AM
JonasToth resigned from D37291: [refactor] Use a RefactoringResultConsumer instead of tagged refactoring rule classes.
Wed, Aug 30, 5:13 AM
JonasToth added inline comments to D36586: [clang-tidy] hicpp bitwise operations on signed integers.
Wed, Aug 30, 2:32 AM
JonasToth added a comment to D36354: [clang-tidy] Implement type-based check for `gsl::owner`.

addressed some issues, not all yet

Wed, Aug 30, 2:19 AM
JonasToth updated the diff for D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
  • fix spelling and grammar errors
  • adjust unit test to new diagnostics
Wed, Aug 30, 2:19 AM
JonasToth updated the diff for D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.

struggling with arc...

Wed, Aug 30, 2:10 AM
JonasToth updated the diff for D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.

fix patch, to diff against master again

Wed, Aug 30, 2:09 AM
JonasToth updated the diff for D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
  • removing trailing comments
Wed, Aug 30, 2:07 AM
JonasToth committed rL312102: [clang-tidy] test commit for granted access.
[clang-tidy] test commit for granted access
Wed, Aug 30, 12:51 AM

Tue, Aug 29

JonasToth added inline comments to D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
Tue, Aug 29, 11:59 PM

Sat, Aug 26

JonasToth added inline comments to D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
Sat, Aug 26, 2:37 AM

Fri, Aug 25

JonasToth updated subscribers of D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
Fri, Aug 25, 8:30 AM

Thu, Aug 24

JonasToth abandoned D31370: [clang-tidy] Prototype to check for exception specification.

exception checking seems to end in the front end for such cases, so nothing to do here anymore. reimplement if there is need later.

Thu, Aug 24, 9:18 AM
JonasToth updated the diff for D36586: [clang-tidy] hicpp bitwise operations on signed integers.
  • fix indendation in testcase
Thu, Aug 24, 9:16 AM
JonasToth updated the diff for D36586: [clang-tidy] hicpp bitwise operations on signed integers.
  • get up to date with master
  • added testcase for enums
Thu, Aug 24, 9:12 AM
JonasToth added inline comments to D36586: [clang-tidy] hicpp bitwise operations on signed integers.
Thu, Aug 24, 8:41 AM

Wed, Aug 23

JonasToth added inline comments to D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
Wed, Aug 23, 8:57 AM
JonasToth updated the diff for D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
  • handle typedefs correctly now
Wed, Aug 23, 8:53 AM
JonasToth added a comment to D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.

as noted in one comment, there are false positives with the current matcher, since it does not look through typedefs/aliases. is there a way to do this easily?

Wed, Aug 23, 8:35 AM
JonasToth added inline comments to D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
Wed, Aug 23, 8:32 AM
JonasToth updated the diff for D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
  • adjusting diagnostics
Wed, Aug 23, 8:31 AM
JonasToth updated the diff for D36354: [clang-tidy] Implement type-based check for `gsl::owner`.

remove unnecessary outcommented lines

Wed, Aug 23, 7:12 AM
JonasToth added a comment to D36354: [clang-tidy] Implement type-based check for `gsl::owner`.

i think the diagnostics are better now, i added the expected and received type everywhere i could.

Wed, Aug 23, 7:09 AM
JonasToth updated the diff for D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
  • adjust the diagnostics to include the types
Wed, Aug 23, 7:08 AM
JonasToth added inline comments to D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
Wed, Aug 23, 6:20 AM
JonasToth updated the diff for D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
  • remove duplicated release note
Wed, Aug 23, 6:19 AM
JonasToth updated the diff for D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
  • test case fixed expected warning
  • address review comments from aaron
Wed, Aug 23, 5:19 AM
JonasToth added a comment to D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
Wed, Aug 23, 5:18 AM
JonasToth created D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
Wed, Aug 23, 5:07 AM
JonasToth closed D36583: [clang-tidy] add checker for hicpp to ensure all exceptions are derived from std::exception.

the new code to fix the issues is in D37060, so i will close this revision.

Wed, Aug 23, 5:07 AM

Tue, Aug 22

JonasToth added reviewers for D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons: aaron.ballman, hokein.
Tue, Aug 22, 9:28 AM · Restricted Project
JonasToth added a comment to D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons.

I added my thoughts for the check. Many variables in your code could be const, i didn't mention all cases.

Tue, Aug 22, 9:27 AM · Restricted Project

Aug 19 2017

JonasToth updated the diff for D36583: [clang-tidy] add checker for hicpp to ensure all exceptions are derived from std::exception.

added more generic cases, and improved the matcher, thanks to @lebedev.ri

Aug 19 2017, 7:50 AM
JonasToth updated the diff for D36583: [clang-tidy] add checker for hicpp to ensure all exceptions are derived from std::exception.

plain macros seem to be handled correctly. Only troublemaker are templates.

Aug 19 2017, 6:16 AM
JonasToth updated the diff for D36583: [clang-tidy] add checker for hicpp to ensure all exceptions are derived from std::exception.

i did work on the generic code with macros and templates.
i could not reproduce all issues, but in general template exception cause problems with diagnostics and with catching these cases.

Aug 19 2017, 6:07 AM
JonasToth updated the diff for D36583: [clang-tidy] add checker for hicpp to ensure all exceptions are derived from std::exception.
  • master remerged into this branch
  • improve testcases for generic code
Aug 19 2017, 6:00 AM

Aug 18 2017

JonasToth added a comment to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.

Did I run it over clang or athletic like that? I would be interested in an overall output.
I added my thoughts. This check seems very valuable.

Aug 18 2017, 6:50 AM · Restricted Project