JonasToth (Jonas Toth)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2016, 11:13 AM (93 w, 2 d)

Recent Activity

Today

JonasToth added inline comments to D50619: [clang-tidy] Handle unresolved expressions in ExprMutationAnalyzer.
Wed, Aug 15, 1:01 AM

Yesterday

JonasToth added inline comments to D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly.
Tue, Aug 14, 8:40 AM
JonasToth removed a reviewer for D50697: [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier: JonasToth.
Tue, Aug 14, 8:36 AM
JonasToth added reviewers for D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All: krasimir, hokein.
Tue, Aug 14, 5:38 AM · Restricted Project
JonasToth added a comment to D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All.

Updated patch created by "svn diff --diff-cmd=diff -x -U999999"

Tue, Aug 14, 5:37 AM · Restricted Project
JonasToth retitled D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All from Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All to [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All.
Tue, Aug 14, 5:08 AM · Restricted Project
JonasToth added a comment to D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All.

Please create the diffs with full context (git diff -U 9999999) and add an test-case.

Tue, Aug 14, 5:07 AM · Restricted Project
JonasToth updated the diff for D50697: [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier.

Using git for the diff, add testcase

Tue, Aug 14, 4:11 AM
JonasToth updated the summary of D50697: [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier.
Tue, Aug 14, 4:00 AM
JonasToth created D50697: [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier.
Tue, Aug 14, 4:00 AM
JonasToth added inline comments to D50542: [clang-tidy] Add abseil-no-internal-deps check.
Tue, Aug 14, 1:10 AM · Restricted Project

Mon, Aug 13

JonasToth added inline comments to D50542: [clang-tidy] Add abseil-no-internal-deps check.
Mon, Aug 13, 1:02 PM · Restricted Project
JonasToth added inline comments to D50580: [clang-tidy] Abseil: no namespace check.
Mon, Aug 13, 1:01 PM · Restricted Project
JonasToth added inline comments to D50619: [clang-tidy] Handle unresolved expressions in ExprMutationAnalyzer.
Mon, Aug 13, 9:24 AM
JonasToth added a comment to D50619: [clang-tidy] Handle unresolved expressions in ExprMutationAnalyzer.

Please add a test for the same usecase as in Sema.

Mon, Aug 13, 9:23 AM
JonasToth added inline comments to D50542: [clang-tidy] Add abseil-no-internal-deps check.
Mon, Aug 13, 9:13 AM · Restricted Project
JonasToth added inline comments to D50542: [clang-tidy] Add abseil-no-internal-deps check.
Mon, Aug 13, 9:11 AM · Restricted Project
JonasToth added a comment to D45444: [clang-tidy] implement new check for const-correctness.

Thank you very much :)

Mon, Aug 13, 12:24 AM

Sat, Aug 11

JonasToth updated the diff for D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly.
  • update to current master of clang introduce CHECK-NOTES
  • use new BeginLoc api
Sat, Aug 11, 4:15 AM
JonasToth updated the diff for D45444: [clang-tidy] implement new check for const-correctness.
  • explicitly ignore lambdas in VarDecls
Sat, Aug 11, 3:51 AM
JonasToth added a comment to D50580: [clang-tidy] Abseil: no namespace check.

Could it happen that some template specializations or so need to land in absl?

Sat, Aug 11, 3:44 AM · Restricted Project
JonasToth added a comment to D50447: [clang-tidy] Omit cases where loop variable is not used in loop body in performance-for-range-copy..

Could there even be a false positive? In a sense, the variable is never
used, so it does not matter, not?

Sat, Aug 11, 3:33 AM
JonasToth added a comment to D45444: [clang-tidy] implement new check for const-correctness.

Always the same with the templates ;) So uninstantiated templates should
just be ignored.

Sat, Aug 11, 3:32 AM
JonasToth added a comment to D50542: [clang-tidy] Add abseil-no-internal-deps check.

No concerns except the small nits from my side.

Sat, Aug 11, 3:27 AM · Restricted Project

Fri, Aug 10

JonasToth added a comment to D50542: [clang-tidy] Add abseil-no-internal-deps check.

Thank you for your first contribution to LLVM btw :)

Fri, Aug 10, 9:26 AM · Restricted Project
JonasToth added inline comments to D50542: [clang-tidy] Add abseil-no-internal-deps check.
Fri, Aug 10, 9:10 AM · Restricted Project
JonasToth added inline comments to D50389: [clang-tidy] Abseil: integral division of Duration check.
Fri, Aug 10, 9:06 AM · Restricted Project
JonasToth added a comment to D50389: [clang-tidy] Abseil: integral division of Duration check.

LGTM with only the formatting question.

Fri, Aug 10, 8:29 AM · Restricted Project
JonasToth added a comment to D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix.

LGTM

Fri, Aug 10, 8:02 AM · Restricted Project
JonasToth added inline comments to D50389: [clang-tidy] Abseil: integral division of Duration check.
Fri, Aug 10, 7:16 AM · Restricted Project
JonasToth added inline comments to D50389: [clang-tidy] Abseil: integral division of Duration check.
Fri, Aug 10, 2:21 AM · Restricted Project
JonasToth added a comment to D50447: [clang-tidy] Omit cases where loop variable is not used in loop body in performance-for-range-copy..

Do you think it is a bad idea? If the variable is not used it is ok to
ignore it in this particular circumstance. Other warnings/check should
deal with such a situation IMHO.

Fri, Aug 10, 2:16 AM
JonasToth added inline comments to D50542: [clang-tidy] Add abseil-no-internal-deps check.
Fri, Aug 10, 2:14 AM · Restricted Project

Thu, Aug 9

JonasToth added a comment to D50447: [clang-tidy] Omit cases where loop variable is not used in loop body in performance-for-range-copy..

LGTM, but alex or aaron should allow the commit ;)

Thu, Aug 9, 9:24 AM

Wed, Aug 8

JonasToth updated the diff for D45444: [clang-tidy] implement new check for const-correctness.
  • fix bug with AnalyzeValues==false skipping whole check, adjust test code to 'const' instead of const
Wed, Aug 8, 1:33 PM
JonasToth added a comment to D50447: [clang-tidy] Omit cases where loop variable is not used in loop body in performance-for-range-copy..
Wed, Aug 8, 8:08 AM
JonasToth added a comment to D50447: [clang-tidy] Omit cases where loop variable is not used in loop body in performance-for-range-copy..

Given it is about the performance in loops and the optimizer?! can
better work with the copy-and-don't-use it might make sense to just
check if the variable is dereferenced in the scope of the loop (any
declRefExpr exists).

Wed, Aug 8, 8:04 AM
JonasToth added a comment to D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

@alexfh or @aaron.ballman could you take a final look on this one?

Wed, Aug 8, 7:21 AM · Restricted Project
JonasToth added a comment to D50447: [clang-tidy] Omit cases where loop variable is not used in loop body in performance-for-range-copy..

Is the type important, or specifics about the variable (e.g. the name?)
The _ variable names are sometimes used for RAII variables/lambdas
that shall just do some cleanup, e.g. gsl::finally().

Wed, Aug 8, 7:20 AM
JonasToth added inline comments to D50447: [clang-tidy] Omit cases where loop variable is not used in loop body in performance-for-range-copy..
Wed, Aug 8, 6:54 AM
JonasToth added a comment to D50447: [clang-tidy] Omit cases where loop variable is not used in loop body in performance-for-range-copy..

If whitelisting works, thats fine. But I agree with @lebedev.ri that a contribution/improvement to the ExprMutAnalyzer is the better option. This is especially the case, because multiple checks (and maybe even some other parts then clang-tidy) will utilize this analysis.

Wed, Aug 8, 6:53 AM
JonasToth added a comment to D45444: [clang-tidy] implement new check for const-correctness.

Could you give a concrete example of this?

vi llvm/lib/Demangle/ItaniumDemangle.cpp +1762

Wed, Aug 8, 1:09 AM

Tue, Aug 7

JonasToth added a comment to D45444: [clang-tidy] implement new check for const-correctness.

For reference, here is the output for llvm/lib.

Tue, Aug 7, 3:17 PM
JonasToth added inline comments to D50389: [clang-tidy] Abseil: integral division of Duration check.
Tue, Aug 7, 2:44 PM · Restricted Project
JonasToth added a comment to D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

No nothing. I think it is barely noticable in general. From prior long
runs i notices the scrambled messages, but it was only a small fraction.
So most of the time the threads dont seem to interfere, which makes the
lock kinda low-cost.

Tue, Aug 7, 10:24 AM · Restricted Project
JonasToth added a comment to D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

I do run it over llvm/lib, there is no visible effect. from my experience maybe 1-5% of the lines are interleafed without the patch, too.

Tue, Aug 7, 10:04 AM · Restricted Project
JonasToth added a comment to D50389: [clang-tidy] Abseil: integral division of Duration check.

Hi deannagarcia and thank you for your first contribution :)

Tue, Aug 7, 9:15 AM · Restricted Project
JonasToth added a comment to D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

Lets say running it over whole LLVM for one check? I will apply this path locally, because i have to analyze llvm right now anyway.

Tue, Aug 7, 8:20 AM · Restricted Project
JonasToth added a comment to D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

I forgot: Did you measure how much of a time penalty this brings? Just out of curiosity, correct script is more important then fast script :)

Tue, Aug 7, 7:22 AM · Restricted Project
JonasToth added a comment to D49851: [clang-tidy] run-clang-tidy add synchronisation to the output.

I would like to have this patch in, because i currently have a 1MB output file, and the missing synchronization really destroys cleaning with grep and sed :(

Tue, Aug 7, 7:21 AM · Restricted Project

Mon, Aug 6

JonasToth added a comment to D45444: [clang-tidy] implement new check for const-correctness.

However, I'm wondering how this should integrate with other const-correctness efforts like readability-non-const-parameter?

Mon, Aug 6, 2:10 PM
JonasToth updated the diff for D45444: [clang-tidy] implement new check for const-correctness.
  • address review issues, todos/fixmes and diag nit
Mon, Aug 6, 2:04 PM
JonasToth added inline comments to D45444: [clang-tidy] implement new check for const-correctness.
Mon, Aug 6, 2:02 PM
JonasToth added inline comments to D45444: [clang-tidy] implement new check for const-correctness.
Mon, Aug 6, 2:01 PM
JonasToth added a comment to D50307: [clang-rename] make clang-rename.py vim integration python3 compatible.

@hokein Do you think this should go into the 7.0 release?

Mon, Aug 6, 2:09 AM
JonasToth committed rC338996: [clang-rename] make clang-rename.py vim integration python3 compatible.
[clang-rename] make clang-rename.py vim integration python3 compatible
Mon, Aug 6, 2:08 AM
JonasToth committed rL338996: [clang-rename] make clang-rename.py vim integration python3 compatible.
[clang-rename] make clang-rename.py vim integration python3 compatible
Mon, Aug 6, 2:08 AM
JonasToth closed D50307: [clang-rename] make clang-rename.py vim integration python3 compatible.
Mon, Aug 6, 2:08 AM
JonasToth updated the diff for D50307: [clang-rename] make clang-rename.py vim integration python3 compatible.
  • rebase
Mon, Aug 6, 2:01 AM

Sun, Aug 5

JonasToth updated the diff for D45444: [clang-tidy] implement new check for const-correctness.
  • update ReleaseNotes
Sun, Aug 5, 9:27 AM
JonasToth added reviewers for D50307: [clang-rename] make clang-rename.py vim integration python3 compatible: aaron.ballman, hokein.
Sun, Aug 5, 9:25 AM
JonasToth updated the diff for D45444: [clang-tidy] implement new check for const-correctness.
  • fix typo
Sun, Aug 5, 9:19 AM
JonasToth added inline comments to D45444: [clang-tidy] implement new check for const-correctness.
Sun, Aug 5, 9:15 AM
JonasToth updated the diff for D45444: [clang-tidy] implement new check for const-correctness.
  • revert breaking change in LocalVar matcher.
Sun, Aug 5, 9:14 AM
JonasToth updated the diff for D45444: [clang-tidy] implement new check for const-correctness.
  • doc list
Sun, Aug 5, 8:51 AM
JonasToth added inline comments to D45444: [clang-tidy] implement new check for const-correctness.
Sun, Aug 5, 8:48 AM
JonasToth updated the diff for D45444: [clang-tidy] implement new check for const-correctness.
  • Merge branch 'master' into check_const
  • [Misc] rename and first review comments
  • language stuff
Sun, Aug 5, 8:48 AM
JonasToth added a comment to D45444: [clang-tidy] implement new check for const-correctness.

I'm sorry for the delay in reviewing this; I'm not certain how it fell off my radar for so long!

Sun, Aug 5, 8:21 AM
JonasToth updated the diff for D50307: [clang-rename] make clang-rename.py vim integration python3 compatible.
  • remove double blank line
Sun, Aug 5, 6:54 AM
JonasToth created D50307: [clang-rename] make clang-rename.py vim integration python3 compatible.
Sun, Aug 5, 6:53 AM

Fri, Aug 3

JonasToth updated the diff for D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly.
  • add better diagnostics about template instantiated exception types
Fri, Aug 3, 2:47 PM
JonasToth added a comment to D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix.

@lebedev.ri and @alexfh i would change the tests in https://reviews.llvm.org/D48714 to use CHECK-NOTES. Is it ok, to commit this one?

Fri, Aug 3, 2:03 PM · Restricted Project
JonasToth added inline comments to D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly.
Fri, Aug 3, 2:00 PM
JonasToth updated the diff for D40854: [clang-tidy] WIP implement cppcoreguidelines check for mixed integer arithmetic.
  • get check up to date
Fri, Aug 3, 11:54 AM
JonasToth updated the diff for D45444: [clang-tidy] implement new check for const-correctness.

get check up to 8.0

Fri, Aug 3, 11:48 AM

Tue, Jul 31

JonasToth retitled D50102: [clang-tidy] Use ExprMutationAnalyzer in performance-unnecessary-value-param from Use ExprMutationAnalyzer in performance-unnecessary-value-param to [clang-tidy] Use ExprMutationAnalyzer in performance-unnecessary-value-param.
Tue, Jul 31, 3:20 PM
JonasToth added a comment to D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement..

I think clang/lib/Analysis is a good place.

I think it should in theory be possible, though I need some advice about where exactly is the best place in clang.

Repository:

rCTE Clang Tools Extra

https://reviews.llvm.org/D45679

Tue, Jul 31, 1:27 PM · Restricted Project
JonasToth updated the diff for D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly.

correct rebase.

Tue, Jul 31, 8:35 AM
JonasToth updated the diff for D45444: [clang-tidy] implement new check for const-correctness.
  • Merge branch 'master' into check_const
Tue, Jul 31, 8:34 AM
JonasToth updated the diff for D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly.

rebase to master

Tue, Jul 31, 8:33 AM
JonasToth updated the diff for D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly.

rebase to master

Tue, Jul 31, 8:31 AM
JonasToth committed rCTE338393: [clang-tidy] add all clang-tidy modules to plugin.
[clang-tidy] add all clang-tidy modules to plugin
Tue, Jul 31, 8:24 AM
JonasToth committed rL338393: [clang-tidy] add all clang-tidy modules to plugin.
[clang-tidy] add all clang-tidy modules to plugin
Tue, Jul 31, 8:24 AM
JonasToth closed D50060: [clang-tidy] add all clang-tidy modules to plugin.
Tue, Jul 31, 8:24 AM
JonasToth updated the diff for D50060: [clang-tidy] add all clang-tidy modules to plugin.
  • rebase
Tue, Jul 31, 8:23 AM
JonasToth added a reviewer for D50060: [clang-tidy] add all clang-tidy modules to plugin: ilya-biryukov.
Tue, Jul 31, 6:55 AM
JonasToth added a comment to D50060: [clang-tidy] add all clang-tidy modules to plugin.

I reordered the anchoring list to be in alphabetical order as well!

Tue, Jul 31, 6:49 AM
JonasToth created D50060: [clang-tidy] add all clang-tidy modules to plugin.
Tue, Jul 31, 6:48 AM
JonasToth added a comment to D49114: [clang-tidy] Add a check for "magic numbers".

The state of this patch:

  • user interface is as agreed-upon, giving end-users the capability to filter out floats and ints as it makes sense for their code base
  • code is clean
  • documentation is up to date
  • default ignore lists are sensible

    There is one outstanding improvement request - to combine the two float/double lists into a single APFloat but that requires more refactoring outside this check and the benefit lies mainly in a future extensibility and the saving of a couple hundred bytes.

    @aaron.ballman - can we get this merged as-is and improve it later? I'd like to see this check available in Clang7.
Tue, Jul 31, 6:16 AM

Fri, Jul 27

JonasToth added a comment to D49890: Clang-Tidy Export Problem.

Actually, maybe this patch is relevant for clang-tooling itself (where the compilation-database stuff actually is). @alexfh what is your opinion on that?

Fri, Jul 27, 7:57 AM · Restricted Project
JonasToth added inline comments to D49890: Clang-Tidy Export Problem.
Fri, Jul 27, 7:53 AM · Restricted Project
JonasToth added inline comments to D49890: Clang-Tidy Export Problem.
Fri, Jul 27, 7:29 AM · Restricted Project
JonasToth added a comment to D49890: Clang-Tidy Export Problem.

I'm not sure what this differential *actually* does.

Fri, Jul 27, 7:27 AM · Restricted Project
JonasToth added inline comments to D49890: Clang-Tidy Export Problem.
Fri, Jul 27, 4:54 AM · Restricted Project

Thu, Jul 26

JonasToth added a comment to D45444: [clang-tidy] implement new check for const-correctness.

@aaron.ballman Are you missing something in this check/tests? I think i will remove the big comment with my thoughts on what has to be done, or do you think it would help for reference?

Thu, Jul 26, 6:41 AM
JonasToth added a comment to D49114: [clang-tidy] Add a check for "magic numbers".

I did not find any major issue :)

Thu, Jul 26, 6:23 AM
JonasToth committed rL338022: [ASTMatchers] fix the missing documentation for new decltypeType matcher.
[ASTMatchers] fix the missing documentation for new decltypeType matcher
Thu, Jul 26, 6:02 AM
JonasToth committed rC338022: [ASTMatchers] fix the missing documentation for new decltypeType matcher.
[ASTMatchers] fix the missing documentation for new decltypeType matcher
Thu, Jul 26, 6:02 AM
JonasToth closed D49850: [ASTMatchers] fix the missing documentation for new decltypeType matcher.
Thu, Jul 26, 6:02 AM
JonasToth updated the diff for D49850: [ASTMatchers] fix the missing documentation for new decltypeType matcher.

rebase

Thu, Jul 26, 6:01 AM