User Details
- User Since
- Oct 31 2016, 11:13 AM (361 w, 57 m)
Sep 26 2022
- remove unproductive check-fixes line
Sep 19 2022
Sep 17 2022
ping @njames93 :)
Sep 4 2022
_Edit_: If overloaded operators are ignored and the check only applies to pointers, int and bool the following is irrelevant. But I did not spot such a guard.
If this is the case, it of course opens the question about at least optional<> types and how to handle those.
Sep 1 2022
during the original implementation of the fix-util I had the plan to provide an option for east-vs-west const, but during the discussions we came to the conclusion that clang-format should do this (the patches were already pending at that point in time).
Aug 31 2022
Aug 29 2022
just my 2 cents
Aug 26 2022
@njames93 friendly ping, for https://reviews.llvm.org/D130793 as well :)
Aug 19 2022
- mention C limitation
- remove bad change from diff
- split patch
- remove unnecessary includes
Aug 5 2022
- improve test
- add test with typedef
- [docs] improve documentation for misc-const-correctness
Jul 30 2022
Jul 29 2022
Jul 24 2022
Thank you very much for all you patience, reviews and tests!
I hope that the following improvements are now simpler to integrate and that the test matures well. :)
Jul 10 2022
@njames93 @LegalizeAdulthood I did integrate the requested changes regarding warning for bad configs, refactoring of map-access and the directory structure of test-files and documentation.
- refactor: adjust warning message for mis-configuration to show which check is configured wrong
- fix: doc list and release-notes reference
- test: move tests into group specific directory
- refactor: use more idiomatic c++ for scope-based analyzer creation/access
- feat: provide config validation if analysis if completely configured off
- refactor: move documentation as well
- test: add test for incorrect configurations
Jun 8 2022
Jun 7 2022
ping :)
@njames93 I added more CHECK-FIXES and CHECK-FIXES-NOT statements in the tests.
Jun 4 2022
May 29 2022
- addded CHECK-FIXES in clang-tidy tests
- merged latest main into branch
May 20 2022
friendly ping :) (maybe @njames93 ?)
May 6 2022
- fix documentation reference
May 5 2022
Thank you for the review! I adjusted the patch.
- addressing review comments and remove unrelated changes
Apr 24 2022
- fix: remove clangAnalysis link in cppcoreguidelines and add it in misc
- refactor: rename check to 'misc-const-correctness' and adjust the tests accordingly
- docs: adjust release notes and adjust check docs slightly
Sorry for the long delay, i simply forgot.
The patch is commited! :)
Mar 28 2022
ok. then i will continue under misc-const-correctness. thank you for the clarifications!
Mar 25 2022
Sorry, for my own sanity, I've stopped reviewing C++ Core Guideline reviews for their diagnostic behavior until the guideline authors put effort into specifying realistic enforcement guidance.
Mar 20 2022
ping @aaron.ballman @njames93 :)
Mar 2 2022
LGTM, but please adjust the naming nit to a better name.
Feb 22 2022
Feb 21 2022
won't happen anymore realistically.
LGTM with a small nit.
Another full run on LLVM with:
Feb 20 2022
- address reviews comments, part 1
- Merge branch 'main' into feature_rebase_const_transform_20210808
- fixing iterator-to-bool conversion and addressing other more review comments
Feb 7 2022
Feb 4 2022
Feb 2 2022
Feb 1 2022
Jan 29 2022
ping @aaron.ballman just in case the patch is now down on the list, I am sorry for my high latency :(
- use boolean for options
- fix snafoo on arc usage
- use boolean for option parsing
Jan 15 2022
- fix: adjust unit test for new array-pointer condition in range-based for loops
- fix release note ordering
- improve documentation a bit
addressed all outstanding review comments.
- Merge branch 'main' into feature_rebase_const_transform_20210808
- fix: address other review comments
- remove one false positive with pointers in a range-based for loop on arrays
- Merge branch 'main' into feature_rebase_const_transform_20210808
- fix: fixes for most review comments
Dec 15 2021
@aaron.ballman ping for review :)
Oct 7 2021
ping
Sep 5 2021
I analyzed the false positive and its probably not so simple to fix.
- add reproducer for '__unaligned' bug
- Merge branch 'main' into feature_rebase_const_transform_20210808
- minor adjustments for comments
Aug 23 2021
thanks for your testing! i will look at the __unaligned issue, not sure if clang supports it, its an MSVC extension, is it?
Aug 17 2021
Aug 15 2021
The check in the latest form can properly transform llvm/lib and clang/ and requires 28 manual fixes afterwards (values and references are transformed, no other modifications).
Some are good and not an issue with the analysis itself, some may or may not be an issue with the analysis itself. I think it is more a template meta programming thing.
- fix: auto and type-dependent initializers fixed by ignoring them correctly in the matcher
- fix docs on limitations
- fix: deduplicate diagnostics from template instantiations
- write documentation for const-analysis check
- Merge branch 'main' into feature_rebase_const_transform_20210808
Aug 9 2021
Whats left from my personal todo is adjusting the documentation.
I think then this check can work as linter and if you want as fixer as well, but this has to be enable explicitly.
- remove transformation as default option, now it must be activated by the user explicitly
- register only for C++
- add a test-case for VLAs
- retry upload of patch to be a diff to main
- rebase to master
- fix a crash where a scope matched but non of its variables, leading to nullptr dereference (found with the current test-suite)
- remove outcommenting of tests that showed undesirable behavior