JonasToth (Jonas Toth)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2016, 11:13 AM (102 w, 1 d)

Recent Activity

Sun, Oct 14

JonasToth added a comment to D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length.

I am in contact with the guy that actually discovered this breakage. It seems to be a weird and hard to reproduce error, but happens on x86 as well. So it is a compile/header something combination that results in the error. I am pretty sure that will take a while until we figured it out :/

Sun, Oct 14, 3:44 AM · Restricted Project

Sat, Oct 13

JonasToth added inline comments to D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4).
Sat, Oct 13, 2:54 AM · Restricted Project
JonasToth requested changes to D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length.
Sat, Oct 13, 2:36 AM · Restricted Project
JonasToth reopened D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length.
Sat, Oct 13, 2:34 AM · Restricted Project
JonasToth committed rCTE344442: Revert "[clang-tidy] New checker for not null-terminated result caused by….
Revert "[clang-tidy] New checker for not null-terminated result caused by…
Sat, Oct 13, 2:33 AM
JonasToth committed rL344442: Revert "[clang-tidy] New checker for not null-terminated result caused by….
Revert "[clang-tidy] New checker for not null-terminated result caused by…
Sat, Oct 13, 2:33 AM
JonasToth committed rL344441: Revert "[doc] fix markup in clang-tidy bugprone-not-null-terminated-result".
Revert "[doc] fix markup in clang-tidy bugprone-not-null-terminated-result"
Sat, Oct 13, 2:32 AM
JonasToth committed rCTE344441: Revert "[doc] fix markup in clang-tidy bugprone-not-null-terminated-result".
Revert "[doc] fix markup in clang-tidy bugprone-not-null-terminated-result"
Sat, Oct 13, 2:32 AM
JonasToth added a comment to D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length.

Unfortunatly this check does not compile on some ARM platforms. It seems that a matcher exceeds the recursion limit in template instantations.

Sat, Oct 13, 2:30 AM · Restricted Project
JonasToth added inline comments to D53025: [clang-tidy] implement new check for const return types..
Sat, Oct 13, 2:03 AM · Restricted Project
JonasToth added inline comments to D52771: [clang-tidy] Non-private member variables in classes (MISRA, CppCoreGuidelines, HICPP).
Sat, Oct 13, 1:52 AM · Restricted Project
JonasToth accepted D53187: [clang-tidy] Optimize query in bugprone-exception-escape.

I think further optimization steps should be done is separate patches. However, this is the biggest step.

Sat, Oct 13, 1:46 AM · Restricted Project

Fri, Oct 12

JonasToth added a comment to D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length.

Committed with https://reviews.llvm.org/rCTE344374

Fri, Oct 12, 11:51 AM · Restricted Project
JonasToth added inline comments to D53025: [clang-tidy] implement new check for const return types..
Fri, Oct 12, 11:50 AM · Restricted Project
JonasToth committed rC344388: [Doc] fix second error in UsersManual.
[Doc] fix second error in UsersManual
Fri, Oct 12, 10:59 AM
JonasToth committed rL344388: [Doc] fix second error in UsersManual.
[Doc] fix second error in UsersManual
Fri, Oct 12, 10:59 AM
JonasToth committed rL344384: [clangd] NFC fix semicolon warning.
[clangd] NFC fix semicolon warning
Fri, Oct 12, 10:49 AM
JonasToth committed rCTE344384: [clangd] NFC fix semicolon warning.
[clangd] NFC fix semicolon warning
Fri, Oct 12, 10:49 AM
JonasToth committed rL344382: [Doc] fix BB, add code-block type.
[Doc] fix BB, add code-block type
Fri, Oct 12, 10:46 AM
JonasToth committed rC344382: [Doc] fix BB, add code-block type.
[Doc] fix BB, add code-block type
Fri, Oct 12, 10:45 AM
JonasToth committed rCTE344379: [doc] fix markup in clang-tidy bugprone-not-null-terminated-result.
[doc] fix markup in clang-tidy bugprone-not-null-terminated-result
Fri, Oct 12, 10:38 AM
JonasToth committed rL344379: [doc] fix markup in clang-tidy bugprone-not-null-terminated-result.
[doc] fix markup in clang-tidy bugprone-not-null-terminated-result
Fri, Oct 12, 10:37 AM
JonasToth committed rCTE344374: [clang-tidy] New checker for not null-terminated result caused by strlen()….
[clang-tidy] New checker for not null-terminated result caused by strlen()…
Fri, Oct 12, 10:25 AM
JonasToth closed D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length.
Fri, Oct 12, 10:25 AM · Restricted Project
JonasToth committed rL344374: [clang-tidy] New checker for not null-terminated result caused by strlen()….
[clang-tidy] New checker for not null-terminated result caused by strlen()…
Fri, Oct 12, 10:24 AM
JonasToth added a comment to D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length.

The patch does not apply clean, could you please take a look at it?

Fri, Oct 12, 10:11 AM · Restricted Project
JonasToth updated the diff for D41648: [clang-tidy] implement cppcoreguidelines macro rules.
  • make the logic with variadic clear
Fri, Oct 12, 8:29 AM
JonasToth added inline comments to D52771: [clang-tidy] Non-private member variables in classes (MISRA, CppCoreGuidelines, HICPP).
Fri, Oct 12, 8:11 AM · Restricted Project
JonasToth updated the diff for D41648: [clang-tidy] implement cppcoreguidelines macro rules.
  • remove unused enum in header file, no idea what i intended to do with it :D
Fri, Oct 12, 7:59 AM
JonasToth added a comment to D41648: [clang-tidy] implement cppcoreguidelines macro rules.

Updated

Fri, Oct 12, 7:57 AM
JonasToth updated the diff for D41648: [clang-tidy] implement cppcoreguidelines macro rules.
  • add tests and adjust doc
  • one more test case
Fri, Oct 12, 7:57 AM
JonasToth added a comment to D52892: [Clang-tidy] readability check to convert numerical constants to std::numeric_limits.

I like the thrust of this check, but we already have the readability-magic-numbers check and I think that this functionality would fit naturally there. That check finds numerical constants and recommends turning them into named constants, but for special values it seems reasonable to recommend using numeric_limits instead. What do others think of that, from an organizational perspective?

Fri, Oct 12, 7:03 AM · Restricted Project
JonasToth added inline comments to D53025: [clang-tidy] implement new check for const return types..
Fri, Oct 12, 6:58 AM · Restricted Project
JonasToth updated the diff for D51949: [clang-tidy] new check 'readability-isolate-declaration'.
  • fix headline in doc
Fri, Oct 12, 6:43 AM · Restricted Project
JonasToth added a comment to D53187: [clang-tidy] Optimize query in bugprone-exception-escape.

Thousands? After the query optimization the max was 173, and that only for a single function. The next number was 64.

Fri, Oct 12, 6:42 AM · Restricted Project
JonasToth added a comment to D51949: [clang-tidy] new check 'readability-isolate-declaration'.

Unfortunately, I won't be able to review the code in the upcoming few weeks as I caught a cold and I'm trying to get better before the LLVM Meeting, so if there is anyone else interested in reviewing proposed changes please feel free to jump in.

Fri, Oct 12, 6:31 AM · Restricted Project
JonasToth added a comment to D53187: [clang-tidy] Optimize query in bugprone-exception-escape.

I think that with this optimization it is not so expensive anymore. I do not think it was an endless loop in the bugreport but it was insufferable execution time. Maybe we could speed it up a little more by changing it totally to a width-first CFG visitor. Then we could apply your solution as well (not removing visited function from the call stack) so the algorithm would visit every called function (for every function that should not throw) only once along the shortest path. This would not introduce new false positives neither would it lose true positives.

Fri, Oct 12, 6:26 AM · Restricted Project
JonasToth accepted D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy.
Fri, Oct 12, 6:01 AM · Restricted Project
JonasToth added a comment to D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy.

I see, probably not worth it. Its one-time effort anyway right?
LGTM

Fri, Oct 12, 5:58 AM · Restricted Project
JonasToth accepted D53194: [clang-tidy] Fix check_clang_tidy.py trivially passing default CHECK.

Did you verify it actually works?
Otherwise LGTM and because its a bug-fix you can commit and other concerns can be done post-commit.

Fri, Oct 12, 5:55 AM · Restricted Project
JonasToth added a comment to D53187: [clang-tidy] Optimize query in bugprone-exception-escape.

This looks reasonable to me but could you please explain a bit what the issue was in the bugreport? So a very deep hierarchy causing the problem makes sense, but why was "ignoring first" the difference maker?
Would it make sense to add a warning in the documentation that this check can be very expensive? And are there measures to speed the process up somehow?

Fri, Oct 12, 5:52 AM · Restricted Project

Thu, Oct 11

JonasToth added a comment to D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy.

LG in principle, just the SmallVec thing could be done if you agree. I don't insist on it, but it looks like a performance benefit to me.

Thu, Oct 11, 7:47 AM · Restricted Project

Wed, Oct 10

JonasToth added a comment to D46027: [clang-tidy] Fix PR35824.

What is the status of the PR?

Wed, Oct 10, 11:09 AM

Tue, Oct 9

JonasToth added a comment to D53025: [clang-tidy] implement new check for const return types..

welcome to the LLVM community and thank you very much for working on that check!
If you have any questions or other issues don't hesitate to ask ;)

Tue, Oct 9, 1:22 PM · Restricted Project
JonasToth added inline comments to D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy.
Tue, Oct 9, 6:41 AM · Restricted Project
JonasToth committed rCTE344046: [clang-tidy] NFC fix warnings from missing braces.
[clang-tidy] NFC fix warnings from missing braces
Tue, Oct 9, 6:31 AM
JonasToth committed rL344046: [clang-tidy] NFC fix warnings from missing braces.
[clang-tidy] NFC fix warnings from missing braces
Tue, Oct 9, 6:31 AM
JonasToth committed rL344044: [clangd] fix miscompiling lower_bound call.
[clangd] fix miscompiling lower_bound call
Tue, Oct 9, 6:26 AM
JonasToth committed rCTE344044: [clangd] fix miscompiling lower_bound call.
[clangd] fix miscompiling lower_bound call
Tue, Oct 9, 6:26 AM
JonasToth added inline comments to D52892: [Clang-tidy] readability check to convert numerical constants to std::numeric_limits.
Tue, Oct 9, 2:42 AM · Restricted Project
JonasToth added inline comments to D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy.
Tue, Oct 9, 2:34 AM · Restricted Project

Mon, Oct 8

JonasToth added inline comments to D52933: Fix incorrect Twine usage in CFGPrinter.
Mon, Oct 8, 5:06 AM
JonasToth added a comment to D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes.

The change looks good in principle. I think it would make sense to migrate one test already, to use the new capability and check if everything works as expected. The current tests still run fine?

Mon, Oct 8, 5:02 AM · Restricted Project

Sun, Oct 7

JonasToth updated the diff for D51949: [clang-tidy] new check 'readability-isolate-declaration'.
  • address review comments, simplifying code
Sun, Oct 7, 10:25 AM · Restricted Project
JonasToth added a comment to D51949: [clang-tidy] new check 'readability-isolate-declaration'.

@kbobyrev is it ok for you if I stick with the Optional<> style in the check?

Sun, Oct 7, 10:25 AM · Restricted Project
JonasToth added inline comments to D52933: Fix incorrect Twine usage in CFGPrinter.
Sun, Oct 7, 4:22 AM
JonasToth added inline comments to D52933: Fix incorrect Twine usage in CFGPrinter.
Sun, Oct 7, 4:05 AM
JonasToth added a comment to D52219: [analyzer] (1/n) Support pointee mutation analysis in ExprMutationAnalyzer..

I think you can commit, there was enough opportunity to respond and we pinged directly as well.

Sun, Oct 7, 4:00 AM

Sat, Oct 6

JonasToth added a comment to D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping.

I'd greatly appreciate it if someone could review this before I commit it next week.

Sat, Oct 6, 1:11 PM

Fri, Oct 5

JonasToth added a comment to D52771: [clang-tidy] Non-private member variables in classes (MISRA, CppCoreGuidelines, HICPP).

C.131 seems to imply a minimal amount of trivial getters/setters before
diagnosing.

Fri, Oct 5, 7:27 AM · Restricted Project
JonasToth committed rCTE343850: [clang-tidy] NFC refactor lexer-utils to be usable without ASTContext.
[clang-tidy] NFC refactor lexer-utils to be usable without ASTContext
Fri, Oct 5, 7:17 AM
JonasToth committed rL343850: [clang-tidy] NFC refactor lexer-utils to be usable without ASTContext.
[clang-tidy] NFC refactor lexer-utils to be usable without ASTContext
Fri, Oct 5, 7:17 AM
JonasToth closed D52684: [clang-tidy] NFC refactor lexer-utils to be usable without ASTContext.
Fri, Oct 5, 7:17 AM · Restricted Project
JonasToth retitled D52684: [clang-tidy] NFC refactor lexer-utils to be usable without ASTContext from [clang-tidy] NFC refactor lexer-utils slightly to be easier to use to [clang-tidy] NFC refactor lexer-utils to be usable without ASTContext.
Fri, Oct 5, 7:17 AM · Restricted Project
JonasToth added inline comments to D52690: [clang-tidy] NFC use CHECK-NOTES in tests for misc-misplaced-const.
Fri, Oct 5, 6:56 AM
JonasToth added a comment to D52771: [clang-tidy] Non-private member variables in classes (MISRA, CppCoreGuidelines, HICPP).

I can't help but notice how badly C.133 and C.9 interact with C.131 and I'm worried we will wind up with clang-tidy checks that leave the user in an impossible situation where they need to make data members private and provide trivial accessors for them. Do you have thoughts on how to avoid that? The C++ Core Guidelines seem silent on the matter -- this might be worth raising with the authors.

Fri, Oct 5, 6:54 AM · Restricted Project
JonasToth added inline comments to D52771: [clang-tidy] Non-private member variables in classes (MISRA, CppCoreGuidelines, HICPP).
Fri, Oct 5, 6:49 AM · Restricted Project
JonasToth closed D51332: [clang-tidy] Replace deprecated std::ios_base aliases.

Commited in https://reviews.llvm.org/rL343848.
Thank you for the patch!

Fri, Oct 5, 6:43 AM
JonasToth committed rL343848: [clang-tidy] Replace deprecated std::ios_base aliases.
[clang-tidy] Replace deprecated std::ios_base aliases
Fri, Oct 5, 6:39 AM
JonasToth committed rCTE343848: [clang-tidy] Replace deprecated std::ios_base aliases.
[clang-tidy] Replace deprecated std::ios_base aliases
Fri, Oct 5, 6:39 AM
JonasToth added a comment to D52892: [Clang-tidy] readability check to convert numerical constants to std::numeric_limits.

@aaron.ballman I have a question for an expert: How would bitfields relate to this check? Can there be a similar pattern for them and do they need to be handled here?

Fri, Oct 5, 2:51 AM · Restricted Project
JonasToth added a comment to D52880: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up.

This patch does not fix the underlying issue. I do have a candidate that might cause it, but I am not sure if it is functionally preserving (tests seems to work though!). I think it is best if @baloghadamsoftware takes a look at it as well!

Fri, Oct 5, 12:04 AM

Thu, Oct 4

JonasToth added a comment to D52892: [Clang-tidy] readability check to convert numerical constants to std::numeric_limits.

thanks for working on this! I have one question: Why are variables _not_ considered in the check but only constants? IMHO it would make sense to transform these as well.

Thu, Oct 4, 10:22 AM · Restricted Project
JonasToth committed rL343797: [clang-tidy] fix failing unit tests.
[clang-tidy] fix failing unit tests
Thu, Oct 4, 9:43 AM
JonasToth committed rCTE343797: [clang-tidy] fix failing unit tests.
[clang-tidy] fix failing unit tests
Thu, Oct 4, 9:43 AM
JonasToth committed rL343796: [clangd] fix another ambigous constructor in DexTest.
[clangd] fix another ambigous constructor in DexTest
Thu, Oct 4, 9:31 AM
JonasToth committed rCTE343796: [clangd] fix another ambigous constructor in DexTest.
[clangd] fix another ambigous constructor in DexTest
Thu, Oct 4, 9:31 AM
JonasToth committed rL343792: [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments.
[clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments
Thu, Oct 4, 9:01 AM
JonasToth committed rCTE343792: [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments.
[clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments
Thu, Oct 4, 9:01 AM
JonasToth closed D52688: [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments.
Thu, Oct 4, 9:01 AM
JonasToth committed rCTE343791: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init.
[clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init
Thu, Oct 4, 8:58 AM
JonasToth committed rL343791: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init.
[clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init
Thu, Oct 4, 8:58 AM
JonasToth closed D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init.
Thu, Oct 4, 8:58 AM
JonasToth closed D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init.
Thu, Oct 4, 8:58 AM
JonasToth added a comment to D51332: [clang-tidy] Replace deprecated std::ios_base aliases.

from my side is nothing outstanding

Thu, Oct 4, 8:53 AM
JonasToth committed rCTE343789: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up.
[clang-tidy] fix PR39167, bugprone-exception-escape hangs-up
Thu, Oct 4, 8:51 AM
JonasToth committed rL343789: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up.
[clang-tidy] fix PR39167, bugprone-exception-escape hangs-up
Thu, Oct 4, 8:51 AM
JonasToth closed D52880: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up.
Thu, Oct 4, 8:51 AM
JonasToth closed D52880: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up.
Thu, Oct 4, 8:51 AM
JonasToth committed rL343788: [clang-tidy] Added pointer types to clang-tidy readability-identifier-naming….
[clang-tidy] Added pointer types to clang-tidy readability-identifier-naming…
Thu, Oct 4, 8:51 AM
JonasToth committed rCTE343788: [clang-tidy] Added pointer types to clang-tidy readability-identifier-naming….
[clang-tidy] Added pointer types to clang-tidy readability-identifier-naming…
Thu, Oct 4, 8:51 AM
JonasToth closed D52882: [clang-tidy] Added pointer types to clang-tidy readability-identifier-naming check..
Thu, Oct 4, 8:51 AM
JonasToth added a comment to D52882: [clang-tidy] Added pointer types to clang-tidy readability-identifier-naming check..

Committed on your behalf

Thu, Oct 4, 8:51 AM
JonasToth added a comment to D52880: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up.

Have you figured out why exactly does the check hang? Disabling it for -fno-exceptions may just hide a logical problem in the check.

(disabling it for these cases seems to be the right thing to do anyways, but it might be nice to use the opportunity to investigate the possible issue deeper)

Thu, Oct 4, 8:47 AM
JonasToth added inline comments to D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy.
Thu, Oct 4, 6:30 AM · Restricted Project
JonasToth added a comment to D52880: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up.

Needs a test.

Thu, Oct 4, 4:06 AM
JonasToth added a comment to D52880: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up.

This should definitly be backported, as exception-escape is in 7.0 and it hangs up on no-except builds

Thu, Oct 4, 3:59 AM
JonasToth added a comment to D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).

Thanks for clarification :)

Thanks! Do you agree this is ready to land now?

Thu, Oct 4, 3:57 AM · Restricted Project
JonasToth created D52880: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up.
Thu, Oct 4, 3:56 AM
JonasToth added a comment to D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149).

Thanks for clarification :)

Thu, Oct 4, 3:21 AM · Restricted Project