JonasToth (Jonas Toth)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2016, 11:13 AM (54 w, 6 d)

Recent Activity

Today

JonasToth added inline comments to D39027: [docs][refactor] Add a new tutorial that talks about how one can implement refactoring actions.
Sun, Nov 19, 4:08 AM

Yesterday

JonasToth added inline comments to D39027: [docs][refactor] Add a new tutorial that talks about how one can implement refactoring actions.
Sat, Nov 18, 1:16 PM
JonasToth committed rCTE318600: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
[clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches
Sat, Nov 18, 11:50 AM
JonasToth committed rL318600: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
[clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches
Sat, Nov 18, 11:49 AM
JonasToth closed D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches by committing rL318600: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
Sat, Nov 18, 11:49 AM · Restricted Project
JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

finalize

Sat, Nov 18, 11:44 AM · Restricted Project
JonasToth updated the diff for D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
  • fix nits
Sat, Nov 18, 11:44 AM · Restricted Project

Fri, Nov 17

JonasToth updated the diff for D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
  • - fix ReleaseNotes
Fri, Nov 17, 8:25 AM · Restricted Project
JonasToth updated the diff for D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
  • address more comments, especially doc
Fri, Nov 17, 8:17 AM · Restricted Project
JonasToth added inline comments to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
Fri, Nov 17, 8:05 AM · Restricted Project
JonasToth updated the diff for D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
  • rebase to master
  • address review comments from aaron
  • handle bools correctly
Fri, Nov 17, 8:05 AM · Restricted Project

Wed, Nov 8

JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

@aaron.ballman and @alexfh ping.

Wed, Nov 8, 12:28 AM · Restricted Project

Wed, Nov 1

JonasToth updated the diff for D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
  • remove double whitespace
Wed, Nov 1, 8:37 AM · Restricted Project

Tue, Oct 31

JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

@aaron.ballman could you take a (i think) finishing look on the check? Most issues should be resolved and i think its ready for the finishing line :)

Tue, Oct 31, 10:22 AM · Restricted Project
JonasToth updated the diff for D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
  • fix rebasing issues in docs
Tue, Oct 31, 10:21 AM · Restricted Project
JonasToth updated the diff for D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
  • improved docs and comments
  • remove some newlines
  • use ternary operator instead of smallvec
Tue, Oct 31, 10:18 AM · Restricted Project

Fri, Oct 27

JonasToth committed rL316767: [clang-tidy] Fix bug 34845, offending standard bitmask types.
[clang-tidy] Fix bug 34845, offending standard bitmask types
Fri, Oct 27, 7:44 AM
JonasToth closed D39099: [clang-tidy] Fix bug 34845, offending standard bitmask types by committing rL316767: [clang-tidy] Fix bug 34845, offending standard bitmask types.
Fri, Oct 27, 7:44 AM
JonasToth updated the diff for D39099: [clang-tidy] Fix bug 34845, offending standard bitmask types.
  • remove conflict markers
Fri, Oct 27, 7:33 AM
JonasToth updated the diff for D39099: [clang-tidy] Fix bug 34845, offending standard bitmask types.
  • adjust run line and include
  • remove whitespace
Fri, Oct 27, 7:27 AM
JonasToth added inline comments to D39099: [clang-tidy] Fix bug 34845, offending standard bitmask types.
Fri, Oct 27, 7:23 AM
JonasToth added a comment to D39099: [clang-tidy] Fix bug 34845, offending standard bitmask types.

ping :)

Fri, Oct 27, 6:24 AM
JonasToth added inline comments to D39367: [clang-tidy] Add support for operator new[] in check bugprone-misplaced-operator-in-strlen-in-alloc.
Fri, Oct 27, 4:31 AM · Restricted Project
JonasToth added a comment to D39367: [clang-tidy] Add support for operator new[] in check bugprone-misplaced-operator-in-strlen-in-alloc.

Should the release notes be modified as well?

Fri, Oct 27, 4:28 AM · Restricted Project
JonasToth added reviewers for D39367: [clang-tidy] Add support for operator new[] in check bugprone-misplaced-operator-in-strlen-in-alloc: aaron.ballman, hokein.
Fri, Oct 27, 4:28 AM · Restricted Project

Wed, Oct 25

JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

simplified the if-else stuff

Wed, Oct 25, 7:41 AM · Restricted Project
JonasToth updated the diff for D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
  • Merge 'master'
  • address review comments
Wed, Oct 25, 7:40 AM · Restricted Project

Oct 20 2017

JonasToth added inline comments to D39099: [clang-tidy] Fix bug 34845, offending standard bitmask types.
Oct 20 2017, 11:59 AM
JonasToth updated the diff for D39099: [clang-tidy] Fix bug 34845, offending standard bitmask types.
  • address review comments
  • fix run line, check-clang-tidy will not be invoked
Oct 20 2017, 11:58 AM
JonasToth added inline comments to D39099: [clang-tidy] Fix bug 34845, offending standard bitmask types.
Oct 20 2017, 10:28 AM
JonasToth added a comment to D33537: [clang-tidy] Exception Escape Checker.

I agree that we should not spend too much effort on making warnings from the compiler and tidy disjunct.

Oct 20 2017, 10:06 AM · Restricted Project

Oct 19 2017

JonasToth updated the diff for D39099: [clang-tidy] Fix bug 34845, offending standard bitmask types.
  • remove debug output
Oct 19 2017, 9:50 AM
JonasToth updated the diff for D39099: [clang-tidy] Fix bug 34845, offending standard bitmask types.
  • fix run line for unit test, unwanted change
Oct 19 2017, 9:45 AM
JonasToth created D39099: [clang-tidy] Fix bug 34845, offending standard bitmask types.
Oct 19 2017, 9:44 AM
JonasToth updated the diff for D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
  • Improve docs, grammar
Oct 19 2017, 1:09 AM · Restricted Project

Oct 18 2017

JonasToth committed rL316094: [clang-tidy] Fix 32bit platform MSVC.
[clang-tidy] Fix 32bit platform MSVC
Oct 18 2017, 9:40 AM
JonasToth added a comment to rL316093: [clang-tidy] Fix buildbot for msvc.

Sorry for Brainlagg. The offense was in line 13, which is size_t. Dunno why i mixed it :/

Oct 18 2017, 9:31 AM
JonasToth committed rL316093: [clang-tidy] Fix buildbot for msvc.
[clang-tidy] Fix buildbot for msvc
Oct 18 2017, 9:28 AM
JonasToth committed rL316092: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning….
[clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning…
Oct 18 2017, 9:14 AM
JonasToth closed D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory' by committing rL316092: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning….
Oct 18 2017, 9:14 AM
JonasToth updated the diff for D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
  • fix test line
Oct 18 2017, 9:00 AM
JonasToth updated the diff for D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
  • addressed review comments
Oct 18 2017, 8:53 AM
JonasToth added inline comments to D39027: [docs][refactor] Add a new tutorial that talks about how one can implement refactoring actions.
Oct 18 2017, 7:21 AM
JonasToth updated the diff for D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
  • address review comments
Oct 18 2017, 1:37 AM · Restricted Project
JonasToth added inline comments to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
Oct 18 2017, 1:36 AM · Restricted Project
JonasToth updated the diff for D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
  • address review comments
Oct 18 2017, 12:43 AM
JonasToth added inline comments to D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
Oct 18 2017, 12:34 AM

Oct 16 2017

JonasToth added inline comments to D38399: [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise.
Oct 16 2017, 12:47 AM

Oct 13 2017

JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.


Example output for llvm/lib/Target/X86
Running it over the whole llvm/lib codebase generates a lot of warnings. Please note, that it seems to be common to write code like this:

int Val;
switch(Val) {
  case 1: // something
  case 2: // something else
  case 16: // magic
}
llvm_unreachable("reason");

In some cases it has been taken care that no fallthrough happens, but it's not so simple to spot. Using default: llvm_unreachable("reason"); would comply with the check.

Oct 13 2017, 12:25 PM · Restricted Project
JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

Improved check a lot. Hope reviewers now have an easier time reading it.

Oct 13 2017, 12:03 PM · Restricted Project
JonasToth added inline comments to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
Oct 13 2017, 12:02 PM · Restricted Project
JonasToth updated the diff for D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

major codechange

Oct 13 2017, 12:00 PM · Restricted Project
JonasToth added inline comments to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
Oct 13 2017, 8:46 AM · Restricted Project
JonasToth updated the diff for D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

ping: I don't understand the lack of feedback. This check should not be a frontend warning,
since it warns for perfectly valid code. It is supposed to give stronger guarantees
for developers requiring this.

Oct 13 2017, 8:02 AM · Restricted Project
JonasToth added inline comments to D38688: [clang-tidy] Misc redundant expressions checker updated for macros.
Oct 13 2017, 7:37 AM · Restricted Project
JonasToth updated the diff for D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
  • update doc to explicitly mention, that std::vector<owner<>> does not work properly
Oct 13 2017, 1:37 AM

Oct 12 2017

JonasToth updated the diff for D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
  • add unittesting both for legacy function and demonstrate bad result with std::vector
Oct 12 2017, 3:09 AM

Oct 10 2017

JonasToth updated the diff for D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
  • list of legacy functions updated, test come later
Oct 10 2017, 11:17 AM
JonasToth added a comment to D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.

work on the list of considered functions for legacy resource functions.

Oct 10 2017, 11:16 AM

Oct 6 2017

JonasToth added inline comments to D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
Oct 6 2017, 1:03 AM

Oct 4 2017

JonasToth closed D38411: [clang-tidy] Emit note for variable declaration that are later deleted.

committed in rL314913

Oct 4 2017, 9:51 AM · Restricted Project
JonasToth committed rL314913: [clang-tidy] Emit note for variable declaration that are later deleted.
[clang-tidy] Emit note for variable declaration that are later deleted
Oct 4 2017, 9:51 AM
JonasToth updated the diff for D38411: [clang-tidy] Emit note for variable declaration that are later deleted.

merge master

Oct 4 2017, 9:48 AM · Restricted Project
JonasToth added inline comments to D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
Oct 4 2017, 9:39 AM

Oct 3 2017

JonasToth committed rL314816: [clang-tidy] fix buildbot hicpp-signed-bitwise.
[clang-tidy] fix buildbot hicpp-signed-bitwise
Oct 3 2017, 10:10 AM
JonasToth committed rL314812: [clang-tidy] potentially fix buildbot .
[clang-tidy] potentially fix buildbot
Oct 3 2017, 9:55 AM
JonasToth added a comment to D38411: [clang-tidy] Emit note for variable declaration that are later deleted.
  • fixed review comments
Oct 3 2017, 9:47 AM · Restricted Project
JonasToth updated the diff for D38411: [clang-tidy] Emit note for variable declaration that are later deleted.
  • adress aarons nits
Oct 3 2017, 9:41 AM · Restricted Project
JonasToth committed rL314811: [clang-tidy] Remove target specification hicpp-signed-bitwise.
[clang-tidy] Remove target specification hicpp-signed-bitwise
Oct 3 2017, 9:29 AM
JonasToth committed rL314808: [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise.
[clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise
Oct 3 2017, 9:26 AM
JonasToth closed D38399: [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise.
Oct 3 2017, 9:24 AM
JonasToth updated the diff for D38399: [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise.
  • add the target declaration for test case back
Oct 3 2017, 9:15 AM
JonasToth added a comment to D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check..

Do we already have other cppcoreguidelines checks that provides fixes with symbols from the the gsl ?

Oct 3 2017, 9:12 AM · Restricted Project

Oct 2 2017

JonasToth added inline comments to D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
Oct 2 2017, 11:19 AM
JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

ping. is there something obviously wrong with this check?

Oct 2 2017, 11:11 AM · Restricted Project
JonasToth added a comment to D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check..

One more reason for this check being in clang-tidy would be automatically inserting narrow_cast<T>(v), which is the utility of the gsl to make narrowing casts explicitly visible.
Doing might be the result of future work.

Oct 2 2017, 11:06 AM · Restricted Project
JonasToth added a reviewer for D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.: aaron.ballman.
Oct 2 2017, 9:45 AM · Restricted Project

Sep 29 2017

JonasToth created D38411: [clang-tidy] Emit note for variable declaration that are later deleted.
Sep 29 2017, 10:00 AM · Restricted Project
JonasToth added inline comments to D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
Sep 29 2017, 9:02 AM
JonasToth updated the diff for D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
  • fix typos and wrong comment about false positive
Sep 29 2017, 8:50 AM
JonasToth added inline comments to D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
Sep 29 2017, 8:50 AM
JonasToth updated the diff for D38399: [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise.
  • silence lit the good way
Sep 29 2017, 8:36 AM
JonasToth added inline comments to D38399: [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise.
Sep 29 2017, 8:31 AM
JonasToth created D38399: [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise.
Sep 29 2017, 4:47 AM
JonasToth updated the diff for D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
  • Clean up stuff that slipped through
Sep 29 2017, 4:06 AM
JonasToth created D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
Sep 29 2017, 3:59 AM

Sep 26 2017

JonasToth added reviewers for D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces: alexfh, aaron.ballman.
Sep 26 2017, 10:02 PM · Restricted Project
JonasToth added a comment to D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces.

Could you add a test case for nested namespaces? I think it should be in a new file with C++17 enabled.

Sep 26 2017, 10:00 PM · Restricted Project

Sep 25 2017

JonasToth added a comment to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.

Hi Roman, there are still some comments marked as not done from my review. Maybe other reviewers wait for there 'resolution', but from my side there are resolved.
One more attempt to get the review rolling.

Sep 25 2017, 5:02 AM · Restricted Project
JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

ping :)

Sep 25 2017, 5:02 AM · Restricted Project

Sep 17 2017

JonasToth added inline comments to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.
Sep 17 2017, 3:34 AM · Restricted Project
JonasToth added a comment to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.

For my part the current state is ok. but @alexfh and @aaron.ballman should do their review before committing.
I would be interested in a exampleoutput for any real project.

Sep 17 2017, 1:20 AM · Restricted Project

Sep 16 2017

JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

I on my part think that both switch and else should stay here for now. Running it over llvm gave really a lot of warnings, and that a rather good codebase.

Sep 16 2017, 5:38 AM · Restricted Project
JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

I think will be good idea to extend -Wswitch diagnostics.

Ok. But it will introduce new warnings to llvm codebase itself. I prepare some example output i found right now.

If number of them will not be huge, it'll be worth to fix before extended -Wswitch will be committed.

Sep 16 2017, 4:59 AM · Restricted Project
JonasToth added a comment to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.

I see, forgot that.
The doc were the interesting part for me, I trust that you test the code correctlty :)

Sep 16 2017, 4:37 AM · Restricted Project
JonasToth added a comment to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.

I built the patch locally, here is my output:

Sep 16 2017, 2:49 AM · Restricted Project

Sep 15 2017

JonasToth added inline comments to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.
Sep 15 2017, 12:21 PM · Restricted Project
JonasToth added a comment to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.

I did read through it now. In general, the code is sound with my understanding of the complexity metric and there is a almost one to one wording to the document, which is nice.
Since we chatted in IRC directly, i would give a short summary to avoid forgetting what we talked about :)

Sep 15 2017, 8:32 AM · Restricted Project
JonasToth added a comment to D36836: [clang-tidy] Implement readability-function-cognitive-complexity check.

Looking up to the Visitor, i will do this next.

Sep 15 2017, 7:36 AM · Restricted Project

Sep 13 2017

JonasToth added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

What about GNU extension case 1 ... 3: ?

Sep 13 2017, 11:12 AM · Restricted Project