Page MenuHomePhabricator

JonasToth (Jonas Toth)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2016, 11:13 AM (129 w, 2 d)

Recent Activity

Wed, Apr 10

JonasToth added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Wed, Apr 10, 6:10 AM · Restricted Project, Restricted Project
JonasToth added reviewers for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment: alexfh, hokein, aaron.ballman.
Wed, Apr 10, 6:04 AM · Restricted Project, Restricted Project

Tue, Apr 9

JonasToth added a comment to D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check.

Hey Dennis,

Tue, Apr 9, 11:43 AM · Restricted Project, Restricted Project
JonasToth resigned from D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers.
Tue, Apr 9, 10:51 AM · Restricted Project
JonasToth accepted D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files..

How does that happen to be a problem? It feels that stdout.write and stderr.write should be unconnected? (if you know the reason I would like to know it too :))
Please note, that run-clang-tidy has an export-feature for the diagnostics and fix-its which might make it easier to analyze the output of clang-tidy.

Tue, Apr 9, 4:09 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Apr 7

JonasToth accepted D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

LGTM

Sun, Apr 7, 5:25 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Apr 1

JonasToth added inline comments to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.
Mon, Apr 1, 9:36 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Mar 28

JonasToth added a comment to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

I think it's the easiest way to specify the bits of the ineteger type to limit the catches. In real life, I met with this overflow / infinite loop problem with 16-bit short type, so I think the real use cases are 8 and 16 bit integers. It seems intuitive to me to use the size of the loop variable's type to separate those catches which can lead broken functionality in practice from those use cases which are just integer incompatibilities.

Thu, Mar 28, 11:42 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth added a comment to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

I think the idea is good and implementation, too. If we iterate all checks anyway (probably?) we could think about adding a severity to the checks, too?

Thu, Mar 28, 11:40 AM · Restricted Project, Restricted Project

Wed, Mar 27

JonasToth added a comment to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

I think in general this is a good direction. What do you think about other heuristics?
E.g. one could say that a vector will not contain more then X GB or similar. That is probably more complicated to figure out though.

Wed, Mar 27, 9:33 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth added reviewers for D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable: alexfh, aaron.ballman, hokein.
Wed, Mar 27, 9:28 AM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2019

JonasToth added inline comments to D59650: [NFC] ExceptionEscapeCheck: small refactoring .
Mar 21 2019, 2:43 PM · Restricted Project, Restricted Project
JonasToth added a comment to D59650: [NFC] ExceptionEscapeCheck: small refactoring .

Looks like pointless code duplication that is easily avoidable.

Mar 21 2019, 2:23 PM · Restricted Project, Restricted Project
JonasToth added a comment to D59650: [NFC] ExceptionEscapeCheck: small refactoring .

Why not having normal overloads? The analysis for Stmt is implemented with the private methods. Explicit template specialization is a bit overkill and so easily understood (but not too complex in this case either).l

Mar 21 2019, 1:29 PM · Restricted Project, Restricted Project

Mar 19 2019

JonasToth added a comment to D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture.

What happens on [=]() ..., direct capture [&Columns]()... and [Columns]()...?

Mar 19 2019, 7:34 AM · Restricted Project

Mar 18 2019

JonasToth added a comment to D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept.

Ping! Any news regarding this patch?

Mar 18 2019, 7:56 AM · Restricted Project, Restricted Project

Mar 15 2019

JonasToth added a comment to D54395: [clang-tidy] implement utility-function to add 'const' to variables.

ping :)

Mar 15 2019, 11:43 AM · Restricted Project
JonasToth added a comment to D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py.

From my side its LGTM, but I would let @serge-sans-paille accept, as he is probably more familiar with python then I am.

Mar 15 2019, 7:44 AM · Restricted Project
JonasToth added a comment to D59318: [clang-tidy] add an overload for diag method that allows users to provide a diagnostic name rather than using the check name when building a diagnostic..

What is the reason you want this change to happen? I think this gives the chance to create inconsistencies which we should avoid.

Mar 15 2019, 7:37 AM · Restricted Project, Restricted Project
JonasToth retitled D59318: [clang-tidy] add an overload for diag method that allows users to provide a diagnostic name rather than using the check name when building a diagnostic. from Add an overload for ClangTidy's diag method that allows users to provide a diagnostic name rather than using the check name when building a diagnostic. to [clang-tidy] add an overload for diag method that allows users to provide a diagnostic name rather than using the check name when building a diagnostic..
Mar 15 2019, 7:36 AM · Restricted Project, Restricted Project

Mar 7 2019

JonasToth added a comment to D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator.

@lebedev.ri @kallehuttunen what do you think of putting this into context of the proposal (i believe its being standardized with c++20) of operator==() = default and the spaceship-operator.
This check could serve as a basis to modernize the operator== to the default if appropriate and warn/diagnose in the other cases.
WDYT?

Mar 7 2019, 11:49 AM · Restricted Project, Restricted Project
JonasToth added a comment to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

IMHO the check is close to being finished. please address the notes and mark them as done if finished with it. So its clear to see whats outstanding.
In my opinion the user-facing documentation misses a "Limitations" sections that shows the artificial goto example, that would show that the used mechanism doesn't handle it.

Mar 7 2019, 4:16 AM · Restricted Project
JonasToth added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 7 2019, 4:10 AM · Restricted Project

Mar 5 2019

JonasToth added inline comments to rL354796: Update status page with papers/issues adopted in Kona.
Mar 5 2019, 2:56 AM

Mar 3 2019

JonasToth added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 3 2019, 11:19 AM · Restricted Project

Mar 2 2019

JonasToth added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 2 2019, 1:15 PM · Restricted Project
JonasToth added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 2 2019, 1:15 PM · Restricted Project

Mar 1 2019

JonasToth added inline comments to D58819: [clang-format] clang-format off/on not respected when using C Style comments.
Mar 1 2019, 12:43 PM · Restricted Project, Restricted Project, Restricted Project
JonasToth added inline comments to D58819: [clang-format] clang-format off/on not respected when using C Style comments.
Mar 1 2019, 10:22 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 1 2019, 10:22 AM · Restricted Project

Feb 28 2019

JonasToth accepted D57087: [clang-tidy] add OverrideMacro to modernize-use-override check.

LGTM

Feb 28 2019, 10:26 AM · Restricted Project, Restricted Project
JonasToth added a comment to D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.

@JonasToth I left a comment in the commit needed to fix the index.rst, which I don't think your later review fixes, sphinx complained about the rst file being an unreferenced octtree

https://reviews.llvm.org/rG5fbeff797a9dba504f08f14c4fa59b6f1076fe72#inline-2691

Feb 28 2019, 10:19 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth committed rGab10947b345e: [clang-tidy] fix documentation link in list of clang-tidy checks (authored by JonasToth).
[clang-tidy] fix documentation link in list of clang-tidy checks
Feb 28 2019, 9:54 AM
JonasToth committed rCTE355108: [clang-tidy] fix documentation link in list of clang-tidy checks.
[clang-tidy] fix documentation link in list of clang-tidy checks
Feb 28 2019, 9:54 AM
JonasToth committed rL355108: [clang-tidy] fix documentation link in list of clang-tidy checks.
[clang-tidy] fix documentation link in list of clang-tidy checks
Feb 28 2019, 9:54 AM
JonasToth added inline comments to rG5fbeff797a9d: [clang-tidy] redirection in list of checks adjusted.
Feb 28 2019, 9:54 AM
JonasToth committed rG5fbeff797a9d: [clang-tidy] redirection in list of checks adjusted (authored by JonasToth).
[clang-tidy] redirection in list of checks adjusted
Feb 28 2019, 7:57 AM
JonasToth committed rL355102: [clang-tidy] redirection in list of checks adjusted.
[clang-tidy] redirection in list of checks adjusted
Feb 28 2019, 7:57 AM
JonasToth committed rCTE355102: [clang-tidy] redirection in list of checks adjusted.
[clang-tidy] redirection in list of checks adjusted
Feb 28 2019, 7:57 AM
JonasToth added a comment to rL355097: [clang-tidy] tryfix documenation continued.

Hmm, yeah. The laptop i have here right now does not have the dependencies installed, so yeah (you can see from all the commits i needed to do get all errors that existed).
Most of the time it works though.

Feb 28 2019, 7:50 AM
JonasToth committed rGed571d77d2f0: [clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of… (authored by JonasToth).
[clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of…
Feb 28 2019, 7:47 AM
JonasToth committed rL355100: [clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of….
[clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of…
Feb 28 2019, 7:46 AM
JonasToth committed rCTE355100: [clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of….
[clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of…
Feb 28 2019, 7:46 AM
JonasToth committed rG3a24cb00ebcd: [clang-tidy] documentation fixing the actual correct file (authored by JonasToth).
[clang-tidy] documentation fixing the actual correct file
Feb 28 2019, 7:39 AM
JonasToth committed rL355098: [clang-tidy] documentation fixing the actual correct file.
[clang-tidy] documentation fixing the actual correct file
Feb 28 2019, 7:39 AM
JonasToth committed rCTE355098: [clang-tidy] documentation fixing the actual correct file.
[clang-tidy] documentation fixing the actual correct file
Feb 28 2019, 7:39 AM
JonasToth committed rGeae176f14276: [clang-tidy] tryfix documenation continued (authored by JonasToth).
[clang-tidy] tryfix documenation continued
Feb 28 2019, 7:28 AM
JonasToth committed rCTE355097: [clang-tidy] tryfix documenation continued.
[clang-tidy] tryfix documenation continued
Feb 28 2019, 7:28 AM
JonasToth committed rL355097: [clang-tidy] tryfix documenation continued.
[clang-tidy] tryfix documenation continued
Feb 28 2019, 7:27 AM
JonasToth added a comment to D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.

Thank you for the patch!

Feb 28 2019, 7:22 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth committed rGdf5871997944: [clang-tidy] another issue in documentation, double empty line seemed to… (authored by JonasToth).
[clang-tidy] another issue in documentation, double empty line seemed to…
Feb 28 2019, 7:19 AM
JonasToth committed rCTE355095: [clang-tidy] another issue in documentation, double empty line seemed to….
[clang-tidy] another issue in documentation, double empty line seemed to…
Feb 28 2019, 7:18 AM
JonasToth committed rL355095: [clang-tidy] another issue in documentation, double empty line seemed to….
[clang-tidy] another issue in documentation, double empty line seemed to…
Feb 28 2019, 7:18 AM
JonasToth committed rG0023b130cf89: [clang-tidy] attempt to fix documentation build-error (authored by JonasToth).
[clang-tidy] attempt to fix documentation build-error
Feb 28 2019, 7:02 AM
JonasToth added a comment to rGc526e02668b3: [clang-tidy] Add the abseil-time-subtraction check.

This patch introduced a build-failure for the documentation builders (see http://lab.llvm.org:8011/builders/clang-tools-sphinx-docs/builds/38188/steps/docs-clang-tools-html/logs/stdio).
Please take a look at the buildbots after you committed something (http://lab.llvm.org:8011/console) to avoid such issues.

Feb 28 2019, 7:02 AM
JonasToth committed rL355094: [clang-tidy] attempt to fix documentation build-error.
[clang-tidy] attempt to fix documentation build-error
Feb 28 2019, 7:00 AM
JonasToth committed rCTE355094: [clang-tidy] attempt to fix documentation build-error.
[clang-tidy] attempt to fix documentation build-error
Feb 28 2019, 7:00 AM
JonasToth committed rGda666233fe7d: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions (authored by JonasToth).
[clang-tidy] added cppcoreguidelines-explicit-virtual-functions
Feb 28 2019, 6:55 AM
JonasToth committed rCTE355093: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.
[clang-tidy] added cppcoreguidelines-explicit-virtual-functions
Feb 28 2019, 6:55 AM
JonasToth committed rL355093: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.
[clang-tidy] added cppcoreguidelines-explicit-virtual-functions
Feb 28 2019, 6:55 AM
JonasToth closed D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.
Feb 28 2019, 6:55 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth edited reviewers for D58756: Fix typo in comment for function "static void initializeWorkList" in "/lib/Analysis/CFLAndersAliasAnalysis.cpp", added: george.karpenkov, NoQ, xazax.hun; removed: JonasToth.
Feb 28 2019, 6:47 AM · Restricted Project
JonasToth added a comment to D58756: Fix typo in comment for function "static void initializeWorkList" in "/lib/Analysis/CFLAndersAliasAnalysis.cpp".

i have no clue if that is correct. i added some reviews from the CSA guys.

Feb 28 2019, 6:45 AM · Restricted Project
JonasToth added a comment to D58764: [clang-tidy] ignore predefined expressions in cppcoreguidelines-pro-bounds-array-to-pointer-decay check.

You can abondon this. A short justification (with reference to the other revision) on the bug report would be great!

Feb 28 2019, 5:37 AM · Restricted Project, Restricted Project
JonasToth accepted D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives..

LGTM.

Feb 28 2019, 5:29 AM · Restricted Project, Restricted Project
JonasToth added inline comments to D54395: [clang-tidy] implement utility-function to add 'const' to variables.
Feb 28 2019, 5:24 AM · Restricted Project
JonasToth updated the diff for D54395: [clang-tidy] implement utility-function to add 'const' to variables.
  • address review comments
  • rebase to master
Feb 28 2019, 5:22 AM · Restricted Project
JonasToth added a comment to D56160: [clang-tidy] modernize-use-trailing-return-type check.

From my side only the nits are left.

Feb 28 2019, 5:11 AM · Restricted Project
JonasToth added a comment to D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.

I'm happy to land this ASAP but I don't have commit rights

So one of us could land it for you.. (I've not personally done that before as I'm a bit green too! but I do have commit rights)

Its pretty easy to get commit rights, and given your looking at multiple issues I'd recommend it.. (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)

Feb 28 2019, 4:43 AM · Restricted Project, Restricted Project, Restricted Project

Feb 27 2019

JonasToth added a comment to D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.

I think this change is worth mentioning in the release notes as well (cte/docs/ReleaseNotes.rst)

Feb 27 2019, 12:02 PM · Restricted Project, Restricted Project, Restricted Project
JonasToth edited reviewers for D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions, added: aaron.ballman, hokein, JonasToth; removed: alexfh_.
Feb 27 2019, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
JonasToth added a comment to D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.

Welcome to the LLVM community and thank you for the patch lewmpk!

Feb 27 2019, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
JonasToth added a comment to D54395: [clang-tidy] implement utility-function to add 'const' to variables.

another ping. @alexfh and @aaron.ballman you commented on prior versions. Would be nice if you could take a (final) look at this patch!

Feb 27 2019, 8:10 AM · Restricted Project
JonasToth added a comment to D56160: [clang-tidy] modernize-use-trailing-return-type check.

It took me far too long to come up with an update. Honestly, I was quite demotivated as it turned out preventing name collisions of unqualifed names after the rewrite was more difficult than I thought. Especially because this error occurs sparsely when I test the check on bigger code bases. The current approach with the AST visitor seems to work best and maybe I can even extend it at some point to automatically qualify colliding names. But for now, I would be really glad if we could achieve a state of the check that you guys can accept and commit.

Feb 27 2019, 8:05 AM · Restricted Project
JonasToth accepted D58137: [clang-tidy] Add the abseil-time-subtraction check.

I am happy now :)
Thank you for the patch, LGTM

Feb 27 2019, 4:38 AM · Restricted Project, Restricted Project
JonasToth added inline comments to D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives..
Feb 27 2019, 4:33 AM · Restricted Project, Restricted Project
JonasToth accepted D58606: [clang-tidy] misc-string-integer-assignment: fix false positive.

LGTM.
is there a bug or similar? If yes please mention it somewhere in the summary or so and close it :)

Feb 27 2019, 4:33 AM · Restricted Project, Restricted Project, Restricted Project

Feb 26 2019

JonasToth committed rGc1e8cbd5c3f0: [clang-tidy] undo bitfields in ExceptionAnalyzer (authored by JonasToth).
[clang-tidy] undo bitfields in ExceptionAnalyzer
Feb 26 2019, 10:16 AM
JonasToth committed rL354903: [clang-tidy] undo bitfields in ExceptionAnalyzer.
[clang-tidy] undo bitfields in ExceptionAnalyzer
Feb 26 2019, 10:16 AM
JonasToth committed rCTE354903: [clang-tidy] undo bitfields in ExceptionAnalyzer.
[clang-tidy] undo bitfields in ExceptionAnalyzer
Feb 26 2019, 10:16 AM
JonasToth added inline comments to D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
Feb 26 2019, 1:59 AM · Restricted Project

Feb 23 2019

JonasToth added inline comments to D58137: [clang-tidy] Add the abseil-time-subtraction check.
Feb 23 2019, 6:35 AM · Restricted Project, Restricted Project

Feb 20 2019

JonasToth committed rG32d5b252b928: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer (authored by JonasToth).
[clang-tidy] refactor ExceptionAnalyzer further to give ternary answer
Feb 20 2019, 1:05 PM
JonasToth committed rL354517: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
[clang-tidy] refactor ExceptionAnalyzer further to give ternary answer
Feb 20 2019, 1:04 PM
JonasToth committed rCTE354517: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
[clang-tidy] refactor ExceptionAnalyzer further to give ternary answer
Feb 20 2019, 1:04 PM
JonasToth closed D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
Feb 20 2019, 1:04 PM · Restricted Project
JonasToth updated the diff for D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
  • be explicit about the State enumerator values
Feb 20 2019, 11:34 AM · Restricted Project
JonasToth added a comment to D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.

all comments resolved. I will land this now.

Feb 20 2019, 11:34 AM · Restricted Project
JonasToth updated the diff for D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
  • [Refactor] move support classes into the analyzer
  • [Refactor] move bigger methods into implementation file
  • minor adjustments
Feb 20 2019, 11:33 AM · Restricted Project

Feb 16 2019

JonasToth added inline comments to D58137: [clang-tidy] Add the abseil-time-subtraction check.
Feb 16 2019, 10:09 AM · Restricted Project, Restricted Project
JonasToth added inline comments to D58137: [clang-tidy] Add the abseil-time-subtraction check.
Feb 16 2019, 8:10 AM · Restricted Project, Restricted Project

Feb 14 2019

JonasToth added inline comments to D57966: [clang-tidy] add camelBackOrCase casing style to readability-identifier-naming to support change to variable naming policy (if adopted).
Feb 14 2019, 6:25 AM · Restricted Project, Restricted Project
JonasToth added a comment to D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.

ping :)

Feb 14 2019, 12:15 AM · Restricted Project
JonasToth added inline comments to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .
Feb 14 2019, 12:14 AM · Restricted Project, Restricted Project

Feb 13 2019

JonasToth added a comment to D57662: [clang-tidy] Parallelize clang-tidy-diff.py .

Just a question.. If clang tidy is running with -fix in parallel, what stops each clang-tidy invocation altering a common header at the same time?

Feb 13 2019, 11:59 AM · Restricted Project, Restricted Project

Feb 8 2019

JonasToth accepted D57852: [clang-tidy] Don't use assignment for value-initialized enums.

LGTM

Feb 8 2019, 3:52 AM · Restricted Project
JonasToth added a comment to D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.

Good idea :)

Feb 8 2019, 3:45 AM · Restricted Project
JonasToth updated the diff for D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
  • [Refactor] move support classes into the analyzer
  • [Refactor] move bigger methods into implementation file
Feb 8 2019, 3:45 AM · Restricted Project

Feb 7 2019

Herald added a project to D54395: [clang-tidy] implement utility-function to add 'const' to variables: Restricted Project.

ping

Feb 7 2019, 7:34 AM · Restricted Project
JonasToth added inline comments to D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
Feb 7 2019, 7:34 AM · Restricted Project