Page MenuHomePhabricator

JonasToth (Jonas Toth)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2016, 11:13 AM (120 w, 2 d)

Recent Activity

Today

JonasToth committed rG32d5b252b928: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer (authored by JonasToth).
[clang-tidy] refactor ExceptionAnalyzer further to give ternary answer
Wed, Feb 20, 1:05 PM
JonasToth committed rL354517: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
[clang-tidy] refactor ExceptionAnalyzer further to give ternary answer
Wed, Feb 20, 1:04 PM
JonasToth committed rCTE354517: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
[clang-tidy] refactor ExceptionAnalyzer further to give ternary answer
Wed, Feb 20, 1:04 PM
JonasToth closed D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
Wed, Feb 20, 1:04 PM · Restricted Project
JonasToth updated the diff for D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
  • be explicit about the State enumerator values
Wed, Feb 20, 11:34 AM · Restricted Project
JonasToth added a comment to D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.

all comments resolved. I will land this now.

Wed, Feb 20, 11:34 AM · Restricted Project
JonasToth updated the diff for D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
  • [Refactor] move support classes into the analyzer
  • [Refactor] move bigger methods into implementation file
  • minor adjustments
Wed, Feb 20, 11:33 AM · Restricted Project

Sat, Feb 16

JonasToth added inline comments to D58137: [clang-tidy] Add the abseil-time-subtraction check.
Sat, Feb 16, 10:09 AM · Restricted Project, Restricted Project
JonasToth added inline comments to D58137: [clang-tidy] Add the abseil-time-subtraction check.
Sat, Feb 16, 8:10 AM · Restricted Project, Restricted Project

Thu, Feb 14

JonasToth added inline comments to D57966: [clang-tidy] add camelBackOrCase casing style to readability-identifier-naming to support change to variable naming policy (if adopted).
Thu, Feb 14, 6:25 AM · Restricted Project, Restricted Project
JonasToth added a comment to D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.

ping :)

Thu, Feb 14, 12:15 AM · Restricted Project
JonasToth added inline comments to D57662: [clang-tidy] Parallelise clang-tidy-diff.py .
Thu, Feb 14, 12:14 AM · Restricted Project, Restricted Project

Wed, Feb 13

JonasToth added a comment to D57662: [clang-tidy] Parallelise clang-tidy-diff.py .

Just a question.. If clang tidy is running with -fix in parallel, what stops each clang-tidy invocation altering a common header at the same time?

Wed, Feb 13, 11:59 AM · Restricted Project, Restricted Project

Fri, Feb 8

JonasToth accepted D57852: [clang-tidy] Don't use assignment for value-initialized enums.

LGTM

Fri, Feb 8, 3:52 AM · Restricted Project
JonasToth added a comment to D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.

Good idea :)

Fri, Feb 8, 3:45 AM · Restricted Project
JonasToth updated the diff for D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
  • [Refactor] move support classes into the analyzer
  • [Refactor] move bigger methods into implementation file
Fri, Feb 8, 3:45 AM · Restricted Project

Thu, Feb 7

Herald added a project to D54395: [clang-tidy] implement utility-function to add 'const' to variables: Restricted Project.

ping

Thu, Feb 7, 7:34 AM · Restricted Project
JonasToth added inline comments to D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
Thu, Feb 7, 7:34 AM · Restricted Project
JonasToth created D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.
Thu, Feb 7, 3:41 AM · Restricted Project
JonasToth closed D57770: [clang-tidy] Fixed a std::bind() transformation.
Thu, Feb 7, 3:02 AM
JonasToth committed rGa822b1155eb7: [clang-tidy] Fixed a std::bind() transformation (authored by JonasToth).
[clang-tidy] Fixed a std::bind() transformation
Thu, Feb 7, 3:01 AM
JonasToth added a comment to D57770: [clang-tidy] Fixed a std::bind() transformation.

Landed in rL353389. Thank you for the patch!

Thu, Feb 7, 3:01 AM
JonasToth committed rL353389: [clang-tidy] Fixed a std::bind() transformation.
[clang-tidy] Fixed a std::bind() transformation
Thu, Feb 7, 3:01 AM
JonasToth committed rCTE353389: [clang-tidy] Fixed a std::bind() transformation.
[clang-tidy] Fixed a std::bind() transformation
Thu, Feb 7, 3:01 AM
JonasToth added a comment to D57852: [clang-tidy] Don't use assignment for value-initialized enums.

How are the semantics for enum class in this case?

Thu, Feb 7, 2:40 AM · Restricted Project

Wed, Feb 6

JonasToth added inline comments to D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604).
Wed, Feb 6, 1:28 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth added a comment to D57770: [clang-tidy] Fixed a std::bind() transformation.

@oleg.smolsky I can commit for you. Please note, that LLVM changed its license recently and this patch will land under the new license.
Please confirm that this is ok for you (more info on the license see https://llvm.org/docs/DeveloperPolicy.html#relicensing). I will wait so long :)

Wed, Feb 6, 12:03 AM

Tue, Feb 5

JonasToth added inline comments to D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604).
Tue, Feb 5, 11:33 PM · Restricted Project, Restricted Project, Restricted Project
JonasToth added a comment to D57770: [clang-tidy] Fixed a std::bind() transformation.

Definitly! I just asked because it would be better to mention it in the message ;)
Do you have commit rights?

Tue, Feb 5, 11:03 AM
JonasToth accepted D57770: [clang-tidy] Fixed a std::bind() transformation.

LGTM, was there a bug report for that issue?

Tue, Feb 5, 10:58 AM

Sun, Feb 3

JonasToth accepted D57665: [clang-tidy] Handle unions with existing default-member-init.

LGTM, please close the bug report and notify for the fix with the request to check in the real-project if it actually fixes the issue. Thanks :)

Sun, Feb 3, 3:01 PM · Restricted Project, Restricted Project

Fri, Feb 1

JonasToth accepted D57571: [clang-tidy] A new OpenMP module.

LGTM. Committing both revision together would be good :)

Fri, Feb 1, 3:41 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jan 31

JonasToth updated the diff for D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept.
  • Merge branch 'master' into feature-introduce-noexcept
Thu, Jan 31, 2:49 AM · Restricted Project, Restricted Project
JonasToth committed rCTE352741: [clang-tidy] refactor bugprone-exception-escape analysis into class.
[clang-tidy] refactor bugprone-exception-escape analysis into class
Thu, Jan 31, 2:48 AM
JonasToth committed rL352741: [clang-tidy] refactor bugprone-exception-escape analysis into class.
[clang-tidy] refactor bugprone-exception-escape analysis into class
Thu, Jan 31, 2:46 AM
JonasToth closed D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class.
Thu, Jan 31, 2:46 AM · Restricted Project
JonasToth updated the diff for D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class.
  • [Misc] rewrite parts of a comment that were unprecise.
Thu, Jan 31, 2:42 AM · Restricted Project
JonasToth added a comment to D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class.

@baloghadamsoftware Do you see any problems with the refactoring, especially the new FunctionDecl*-Caching is not exactly a refactoring. If you have any thoughts on that would be great to hear!

Yes, it looks a good improvement, I expect another huge speedup. (We had a previous huge speedup after I optimized the matcher expression in 7.0.1 because in 7.0.0 it seemed to hang, it was really bad).

Thu, Jan 31, 2:40 AM · Restricted Project

Mon, Jan 28

JonasToth added a comment to D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class.

Hello! I am glad to see that this check gets improved by the community. I also think a "modernize" check which marks functions with noexcept is also useful.

Mon, Jan 28, 5:02 AM · Restricted Project
JonasToth added a comment to D54395: [clang-tidy] implement utility-function to add 'const' to variables.

ping.

Mon, Jan 28, 3:01 AM · Restricted Project
JonasToth accepted D57185: [clang-tidy] Add the abseil-duration-addition check.

LGTM

Mon, Jan 28, 2:56 AM · Restricted Project

Sun, Jan 27

JonasToth accepted D57113: [clang-tidy] openmp-use-default-none - a new check.

LGTM with the few language nits.
The new matchers look better and are more matcher style, gj :)

Sun, Jan 27, 5:07 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jan 25

JonasToth committed rCTE352231: [clang-tidy] fix unit tests for dropped _Float16 support in X86.
[clang-tidy] fix unit tests for dropped _Float16 support in X86
Fri, Jan 25, 11:05 AM
JonasToth committed rL352231: [clang-tidy] fix unit tests for dropped _Float16 support in X86.
[clang-tidy] fix unit tests for dropped _Float16 support in X86
Fri, Jan 25, 11:05 AM
JonasToth closed D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86.
Fri, Jan 25, 11:05 AM
JonasToth updated the diff for D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86.
  • last nit, remove the disabled in hexadecimal
Fri, Jan 25, 11:03 AM
JonasToth updated the diff for D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86.
  • Revert "add REQUIRES: <arch> for the readability unit-tests where necessary" as its not necessary because only the frontend is run
Fri, Jan 25, 11:02 AM
JonasToth updated the diff for D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86.
  • add REQUIRES: <arch> for the readability unit-tests where necessary
Fri, Jan 25, 10:59 AM
JonasToth created D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86.
Fri, Jan 25, 10:51 AM
JonasToth added inline comments to D57185: [clang-tidy] Add the abseil-duration-addition check.
Fri, Jan 25, 8:10 AM · Restricted Project
JonasToth added a comment to D55523: [clang-tidy] Linting .rst documentation.

The question now is: should we split the rst linting from other aspects? Imho yes and put the .rst-linting into LLVM space. We can still have a local .arclint-file to force only the CTE ppl into using it.

I'd keep the rst linting separate from the other linters, the "include" part will ensure only the .rst files in the review will be checked.

The monorepo-vs-non-monorepo is still interesting as we can specify both correct paths, can we?

No we can only have one path, which would need it to be different in monorepo-vs-non-monorepo, but this would be true for the clang-format linter suggested in D49116 too, so that linter will only work for the main llvm repo, (not clang or CTE)

The .arclint file will only work in CTE with the same .arclint file (copied into CTE) if both the .arclint file and the scripts are put into a new utils directory in tools/extra to match that of llvm (and if the clang repo wanted the same again it would need to be duplicate)

Fri, Jan 25, 8:10 AM · Restricted Project
JonasToth added inline comments to D57185: [clang-tidy] Add the abseil-duration-addition check.
Fri, Jan 25, 7:30 AM · Restricted Project
JonasToth added inline comments to D57113: [clang-tidy] openmp-use-default-none - a new check.
Fri, Jan 25, 7:22 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth added a comment to D55523: [clang-tidy] Linting .rst documentation.

The question now is: should we split the rst linting from other aspects? Imho yes and put the .rst-linting into LLVM space. We can still have a local .arclint-file to force only the CTE ppl into using it.
But in principle I would like to have that.
The monorepo-vs-non-monorepo is still interesting as we can specify both correct paths, can we?

Fri, Jan 25, 7:22 AM · Restricted Project
JonasToth added inline comments to D57113: [clang-tidy] openmp-use-default-none - a new check.
Fri, Jan 25, 6:59 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth added a comment to D49116: Setup clang-format as an Arcanist linter.

@JonasToth we could have a got at making an .arclint configuration that would run the validate_check.py with the --rst option to pass a rst filename

Fri, Jan 25, 6:45 AM
JonasToth added inline comments to D57113: [clang-tidy] openmp-use-default-none - a new check.
Fri, Jan 25, 6:33 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth updated subscribers of D49116: Setup clang-format as an Arcanist linter.

Drive-by +1, really would like to see clang-format and linters integrated for automatic nitting.

The revision is up for grabs. Last I checked, the only issue was that I did not have a Windows machine to test the change.

Fri, Jan 25, 5:57 AM
JonasToth added inline comments to D57113: [clang-tidy] openmp-use-default-none - a new check.
Fri, Jan 25, 5:48 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth added a comment to D57225: Don't run misc-non-private-member-variables-in-classes check on LLVM..

it is very noisy (in other projects too) and i would prefer a different warning policy for that check as well (e.g. one warning per class, not for every field it warns against).

Fri, Jan 25, 5:40 AM
JonasToth added a comment to D49116: Setup clang-format as an Arcanist linter.

Drive-by +1, really would like to see clang-format and linters integrated for automatic nitting.

Fri, Jan 25, 3:14 AM
JonasToth updated subscribers of D55523: [clang-tidy] Linting .rst documentation.

Phabrciator can use Herald rules to react to a change in a revision

If that is a gobal rule it can run a Harbormaster build plan, I can't tell if this will work (because I don't have permission on the LLVM phabricator) but someone has already set up a arc lint + arc unit build plan

it may be possible to use that, if thats the case we may just be able to set up the validation of .rst files are as a arc linter in .arcconfig (without needing people to use arc to submit the reviews)

alternatively Harbormaster can make an HTTP request to a CI system, passing information about the review PHID, its then actually very simple json and wget or curl type calls to talk back to Phabricator to insert review comments

see https://reviews.llvm.org/conduit/method/differential.createinline/

So you could imagine, someone makes a review, and a CI system pulls the contents, runs some simple checks (like are you clang-formatted) then inserts a review comment back into the reivew..

This means you don't really need to hack in php (although I've customized our own phabricator its very easy as it has an extensibility mechanism)

Phabricator is very powerful, we are only really scratching the surface.. take a look here at some of the things you can do...

https://reviews.llvm.org/conduit/

To be honest it would probably best if we made contact with whoever is the administrator of Phabricator (do we know who that is?), because there are some very simple things that can be added to make life a little easier.. (for example like using the bugtraq.logregex and bugtraq.url settings to automatically turn Bugzilla PR numbers in messages into hyperlinks) (http://www.howtobuildsoftware.com/index.php/how-do/bFAT/issue-tracking-phabricator-link-to-issue-page-from-within-phabricator)

Fri, Jan 25, 3:02 AM · Restricted Project
JonasToth added inline comments to D57185: [clang-tidy] Add the abseil-duration-addition check.
Fri, Jan 25, 2:34 AM · Restricted Project
JonasToth added a comment to D55523: [clang-tidy] Linting .rst documentation.

A few questions:

  1. why do we want to lint just clang-tidy docs and not all LLVM's .rst files?

Proposal was made on llvm-dev, but it didn't attract interest.

Maybe I'll just put the script over on github in a clang-utils project so its easier to download...and then Abandon this review here....then we can always point people at it if they find it useful.

Fri, Jan 25, 2:19 AM · Restricted Project
JonasToth updated the diff for D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept.
  • rebase to latest patch
Fri, Jan 25, 12:44 AM · Restricted Project, Restricted Project
JonasToth updated the diff for D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class.
  • revert doc change as well
Fri, Jan 25, 12:29 AM · Restricted Project
JonasToth added a comment to D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class.

Reverted the changes. Maybe the comma thingie will just stay as is ;)

Fri, Jan 25, 12:27 AM · Restricted Project
JonasToth updated the diff for D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class.
  • revert the option configuration change for comma/semicolon
Fri, Jan 25, 12:24 AM · Restricted Project
JonasToth added a comment to D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept.

Hmm, i think this diff is incorrect. Doesn't it also include the changes from D57100 ?

Fri, Jan 25, 12:19 AM · Restricted Project, Restricted Project

Thu, Jan 24

JonasToth added inline comments to D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class.
Thu, Jan 24, 2:49 AM · Restricted Project

Wed, Jan 23

JonasToth updated the diff for D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept.
  • rebase to current refactoring
Wed, Jan 23, 11:03 AM · Restricted Project, Restricted Project
JonasToth added a parent revision for D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept: D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class.
Wed, Jan 23, 11:02 AM · Restricted Project, Restricted Project
JonasToth added a child revision for D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class: D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept.
Wed, Jan 23, 11:02 AM · Restricted Project
JonasToth added a project to D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept: Restricted Project.
Wed, Jan 23, 11:00 AM · Restricted Project, Restricted Project
JonasToth updated the diff for D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class.
  • add license to exceptionanalyzer
Wed, Jan 23, 11:00 AM · Restricted Project
JonasToth added inline comments to D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class.
Wed, Jan 23, 10:57 AM · Restricted Project
JonasToth created D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept.
Wed, Jan 23, 10:54 AM · Restricted Project, Restricted Project
JonasToth updated the diff for D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class.
  • [Fix] make class name correct
Wed, Jan 23, 10:42 AM · Restricted Project
JonasToth added inline comments to D57087: [clang-tidy] add OverrideMacro to modernize-use-override check.
Wed, Jan 23, 7:43 AM · Restricted Project
JonasToth updated the diff for D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class.
  • adjust doc to say semicolon separated list instead of comma
Wed, Jan 23, 7:34 AM · Restricted Project
JonasToth added a comment to D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class.

Two passing-by remarks:

  1. I would *love* for this check to produce less cryptic reports :) It currently does not output any details whatsoever. It's really unhelpful.
Wed, Jan 23, 7:31 AM · Restricted Project
JonasToth added a comment to D56160: [clang-tidy] modernize-use-trailing-return check.

Thank you again @JonasToth for all your valueable input! I could almost successfully run my check on the llvm/lib subfolder. I created a compilation database from within Visual Studio using an extension called SourceTrail. One of the issues was the following:

Wed, Jan 23, 7:24 AM · Restricted Project
JonasToth added a project to D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class: Restricted Project.
Wed, Jan 23, 7:16 AM · Restricted Project
JonasToth created D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class.
Wed, Jan 23, 7:14 AM · Restricted Project
JonasToth added a comment to D54395: [clang-tidy] implement utility-function to add 'const' to variables.

ping :)

Wed, Jan 23, 6:11 AM · Restricted Project

Jan 21 2019

JonasToth committed rC351743: [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers.
[clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers
Jan 21 2019, 5:27 AM
JonasToth committed rL351743: [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers.
[clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers
Jan 21 2019, 5:27 AM
JonasToth closed D56917: [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers.
Jan 21 2019, 5:27 AM
JonasToth updated the diff for D56917: [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers.
  • use only the small reproducer
Jan 21 2019, 5:22 AM

Jan 19 2019

JonasToth added inline comments to D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods.
Jan 19 2019, 1:13 PM · Restricted Project

Jan 18 2019

JonasToth added a comment to D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra.

the closest I can see is

https://www.perforce.com/resources/qac/high-integrity-cpp-coding-standard#statements

which take you to section 6 of the standard, but I see no id or name tags to get you to 6.3.1

Jan 18 2019, 1:03 PM · Restricted Project
JonasToth accepted D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra.

very good idea. This reminds me, that i wanted to fix the hicpp links, as they restructured their website. thanks ;)
Changes LGTM!

Jan 18 2019, 12:08 PM · Restricted Project
JonasToth added a comment to D56610: [clangd] A code action to qualify an unqualified name.

Is this for something like add const?
If yes, there is clang-tidy effort on that, see https://reviews.llvm.org/D54943 and https://reviews.llvm.org/D54395 for a similar effort. Would be best to share the code instead of reinventing it :)

No, this action is not about adding a type qualifier (like const or volatile), it adds a namespace qualifier, e.g.

using namespace std;

vector<int> foo; // --> std::vector<int> foo;

Moreover, it's just an example to illustrate how one could write a simple action like that in clangd.

Jan 18 2019, 10:46 AM · Restricted Project
JonasToth committed rCTE351569: [clang-tidy] add reproducer for PR39949 into test-suite.
[clang-tidy] add reproducer for PR39949 into test-suite
Jan 18 2019, 10:08 AM
JonasToth committed rL351569: [clang-tidy] add reproducer for PR39949 into test-suite.
[clang-tidy] add reproducer for PR39949 into test-suite
Jan 18 2019, 10:08 AM
JonasToth closed D56918: [clang-tidy] add reproducer for PR39949 into test-suite.
Jan 18 2019, 10:07 AM · Restricted Project
JonasToth added a comment to D56610: [clangd] A code action to qualify an unqualified name.

Is this for something like add const?
If yes, there is clang-tidy effort on that, see https://reviews.llvm.org/D54943 and https://reviews.llvm.org/D54395 for a similar effort. Would be best to share the code instead of reinventing it :)

Jan 18 2019, 9:57 AM · Restricted Project
JonasToth created D56918: [clang-tidy] add reproducer for PR39949 into test-suite.
Jan 18 2019, 9:19 AM · Restricted Project
JonasToth created D56917: [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers.
Jan 18 2019, 8:56 AM
JonasToth added a comment to D54141: [clang-tidy] add deduplication support for run-clang-tidy.py.

LLVM is very chatty as well, I don't consider LLVM to be a bad code-base. Take readability-braces-around-statements for example.

Do we need a llvm-elide-braces-for-small-statements?

This would make a great pre-review check

Jan 18 2019, 6:01 AM · Restricted Project