Page MenuHomePhabricator

JonasToth (Jonas Toth)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2016, 11:13 AM (155 w, 9 h)

Recent Activity

Tue, Oct 15

JonasToth accepted D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands.

LGTM.
But i was inactive for a long time, if @aaron.ballman accepts as well you can commit instantly. Otherwise please let the other people that commented some time to react. :)

Tue, Oct 15, 1:46 PM · Restricted Project, Restricted Project

Sat, Oct 12

JonasToth committed rL374644: Request commit access for jonastoth.
Request commit access for jonastoth
Sat, Oct 12, 1:23 AM

Fri, Oct 11

JonasToth added a comment to D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands.

Do you know who is responsible for it? Because i haven't worked with documentation before and don't know what i need to do to update it.

Fri, Oct 11, 10:33 AM · Restricted Project, Restricted Project
JonasToth resigned from D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length.
Fri, Oct 11, 3:52 AM · Restricted Project, Restricted Project
JonasToth added a comment to D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands.

The new switch needs documentation as well, and maybe even a note in the release notes (as it is publicly discussed as issue?).
Otherwise I am fine with the changes!

Fri, Oct 11, 3:52 AM · Restricted Project, Restricted Project

Thu, Oct 10

JonasToth added a comment to D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands.

In my opinion this check should be disabled in case of integer literals, since there are a lot of existing code (even in system libraries) where user can do nothing, e.g.:

I think that this check should behave how the coding standard dictates it behaves. By my reading of HIC++, the check is behaving by design. I think there are a few ways forward though (not mutually exclusive):

0) See if the HIC++ folks are interested in clarifying their standard for integer literals and if they are, modify the check

  1. Add an off-by-default option that suppresses the diagnostic with positive integer literals so that users can explicitly decide to deviate locally
  2. Document that this happens and is expected behavior; users can disable the check if they don't wish to conform to that standard.
Thu, Oct 10, 2:12 AM · Restricted Project, Restricted Project

Sep 12 2019

JonasToth added a comment to D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index.

Sorry for the long delay!

Sep 12 2019, 3:02 AM · Restricted Project

Jul 30 2019

JonasToth added a comment to D64671: [clang-tidy] New check: misc-init-local-variables.

A general comment: "misc" is a sort of a heap of checks that otherwise don't have a good home. This one would probably better go to bugprone (or maybe there's a relevant CERT or C++ Core Guidelines rule?).

The closest I could find is ES.20 "Always initialize an object": https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es20-always-initialize-an-object

So a potential name for this could be "cppcoreguidelines-init-variables". However that rule is about initializing all variables, even those in structs and classes. This is about local variables.

Jul 30 2019, 6:19 AM · Restricted Project

Jul 10 2019

JonasToth added a comment to D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types.

Just as Sidenote in case you were not aware: There is a check in clang-tidy for gsl::owner (https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-owning-memory.html)
It will benefit from your annotation and can be simplified.

Jul 10 2019, 2:30 AM · Restricted Project, Restricted Project

May 26 2019

JonasToth added a comment to D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

Could you please run this check over LLVM and give a short report of your finding? I would imagine that there is a lot of duplication, given the include-heavy nature of big c++ code bases.

May 26 2019, 2:35 AM · Restricted Project

May 20 2019

JonasToth added a comment to D62125: Run ClangTidy tests in all C++ language modes.

Wow, a lot of work!

May 20 2019, 1:35 AM · Restricted Project, Restricted Project

May 16 2019

JonasToth added a comment to D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

Hi shixiao,

May 16 2019, 10:02 AM · Restricted Project
JonasToth added a comment to D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403).

Given this revision is accepted and seems ready to go: Do you need someone to commit on your behalf?

May 16 2019, 6:42 AM · Restricted Project, Restricted Project
JonasToth added a comment to D61850: Removed superfluous and slightly annoying newlines in run-clang-tidy's output..

Thans for the patch!

May 16 2019, 5:47 AM · Restricted Project, Restricted Project
JonasToth committed rGf12c9730ef0d: [clang-tidy] Removed superfluous and slightly annoying newlines in run-clang… (authored by JonasToth).
[clang-tidy] Removed superfluous and slightly annoying newlines in run-clang…
May 16 2019, 5:40 AM
JonasToth committed rCTE360883: [clang-tidy] Removed superfluous and slightly annoying newlines in run-clang….
[clang-tidy] Removed superfluous and slightly annoying newlines in run-clang…
May 16 2019, 5:39 AM
JonasToth committed rL360883: [clang-tidy] Removed superfluous and slightly annoying newlines in run-clang….
[clang-tidy] Removed superfluous and slightly annoying newlines in run-clang…
May 16 2019, 5:39 AM
JonasToth closed D61850: Removed superfluous and slightly annoying newlines in run-clang-tidy's output..
May 16 2019, 5:39 AM · Restricted Project, Restricted Project
JonasToth committed rG792dc04166da: [clang-tidy] Handle member variables in readability-simplify-boolean-expr (authored by JonasToth).
[clang-tidy] Handle member variables in readability-simplify-boolean-expr
May 16 2019, 5:34 AM
JonasToth committed rL360882: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.
[clang-tidy] Handle member variables in readability-simplify-boolean-expr
May 16 2019, 5:34 AM
JonasToth committed rCTE360882: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.
[clang-tidy] Handle member variables in readability-simplify-boolean-expr
May 16 2019, 5:33 AM
JonasToth closed D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.
May 16 2019, 5:33 AM · Restricted Project, Restricted Project
JonasToth added a comment to D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr.

Thank you for the patch and sorry for the long delay.

May 16 2019, 5:33 AM · Restricted Project, Restricted Project
JonasToth accepted D61850: Removed superfluous and slightly annoying newlines in run-clang-tidy's output..

LGTM then, i can commit for you again?

May 16 2019, 4:48 AM · Restricted Project, Restricted Project
JonasToth committed rG3cbf3c841289: [clang-tidy] Do not list enabled checks when -quiet is given to run-clang-tidy. (authored by JonasToth).
[clang-tidy] Do not list enabled checks when -quiet is given to run-clang-tidy.
May 16 2019, 2:22 AM
JonasToth added a comment to D61849: Do not list enabled checks when -quiet is given to run-clang-tidy..

Yes someone has to do it on behalf of you.
I did so for you. After a view good patches you can get commit rights from chris lattner, until then the reviewer can commit for you.

May 16 2019, 2:22 AM · Restricted Project, Restricted Project
JonasToth committed rCTE360869: [clang-tidy] Do not list enabled checks when -quiet is given to run-clang-tidy..
[clang-tidy] Do not list enabled checks when -quiet is given to run-clang-tidy.
May 16 2019, 2:20 AM
JonasToth committed rL360869: [clang-tidy] Do not list enabled checks when -quiet is given to run-clang-tidy..
[clang-tidy] Do not list enabled checks when -quiet is given to run-clang-tidy.
May 16 2019, 2:20 AM
JonasToth closed D61849: Do not list enabled checks when -quiet is given to run-clang-tidy..
May 16 2019, 2:20 AM · Restricted Project, Restricted Project

May 15 2019

JonasToth added a comment to D61850: Removed superfluous and slightly annoying newlines in run-clang-tidy's output..

[...] please ensure that e.g. clang-analyzer-* output looks proper as well and -quiet does, too.

OK, are there any (unit) tests which I should run? If yes, how exactly? I have a successfully built a fork of https://github.com/llvm/llvm-project via ninja locally, but the documentation for the various subprojects is still a bit hard to find to me. Is there a ninja target for clang-tidy-related tests? Any hints to get started would be highly appreciated.

This and the other output-related patches are my first submissions here, and they are intentionally simple to get the workflow right. My real intention is trying to improve/fix the readability-identifier-naming check/fixer, which still has a few issues.

May 15 2019, 1:35 AM · Restricted Project, Restricted Project

May 13 2019

JonasToth accepted D61849: Do not list enabled checks when -quiet is given to run-clang-tidy..

LGTM

May 13 2019, 11:31 AM · Restricted Project, Restricted Project
JonasToth added a comment to D61850: Removed superfluous and slightly annoying newlines in run-clang-tidy's output..

I agree with the direction, please ensure that e.g. clang-analyzer-* output looks proper as well and -quiet does, too.

May 13 2019, 11:31 AM · Restricted Project, Restricted Project
JonasToth added inline comments to D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static.
May 13 2019, 11:31 AM · Restricted Project, Restricted Project, Restricted Project

May 11 2019

JonasToth added inline comments to D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static.
May 11 2019, 3:04 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth updated subscribers of D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static.

Hey, I do like your check!

May 11 2019, 2:55 AM · Restricted Project, Restricted Project, Restricted Project

May 7 2019

JonasToth accepted D54757: [clang-tidy] new check: bugprone-branch-clone.

Did you run the new version over a big project like llvm again?
If yes LGTM from my side, if not please do that before committing to ensure no new/other problems creeped in.

May 7 2019, 10:03 AM · Restricted Project, Restricted Project
JonasToth added a comment to D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.

My understanding of the directory layout guidance in the docs is that different styles get different directories.

May 7 2019, 12:44 AM · Restricted Project, Restricted Project

May 6 2019

JonasToth added a comment to D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.

Hi trixirt and thanks for the patch!

May 6 2019, 12:32 AM · Restricted Project, Restricted Project

May 3 2019

JonasToth accepted D61475: Update an information about ReSharper C++ and clang-tidy custom binary integration.

LGTM

May 3 2019, 3:06 AM · Restricted Project, Restricted Project, Restricted Project

May 2 2019

JonasToth added a comment to D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule..

I like the new framework!

May 2 2019, 5:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 10 2019

JonasToth added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 10 2019, 6:10 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth added reviewers for D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment: alexfh, hokein, aaron.ballman.
Apr 10 2019, 6:04 AM · Restricted Project, Restricted Project, Restricted Project

Apr 9 2019

JonasToth added a comment to D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check.

Hey Dennis,

Apr 9 2019, 11:43 AM · Restricted Project, Restricted Project
JonasToth resigned from D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers.
Apr 9 2019, 10:51 AM · Restricted Project
JonasToth accepted D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files..

How does that happen to be a problem? It feels that stdout.write and stderr.write should be unconnected? (if you know the reason I would like to know it too :))
Please note, that run-clang-tidy has an export-feature for the diagnostics and fix-its which might make it easier to analyze the output of clang-tidy.

Apr 9 2019, 4:09 AM · Restricted Project, Restricted Project, Restricted Project

Apr 7 2019

JonasToth accepted D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

LGTM

Apr 7 2019, 5:25 AM · Restricted Project, Restricted Project, Restricted Project

Apr 1 2019

JonasToth added inline comments to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.
Apr 1 2019, 9:36 AM · Restricted Project, Restricted Project, Restricted Project

Mar 28 2019

JonasToth added a comment to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

I think it's the easiest way to specify the bits of the ineteger type to limit the catches. In real life, I met with this overflow / infinite loop problem with 16-bit short type, so I think the real use cases are 8 and 16 bit integers. It seems intuitive to me to use the size of the loop variable's type to separate those catches which can lead broken functionality in practice from those use cases which are just integer incompatibilities.

Mar 28 2019, 11:42 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth added a comment to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

I think the idea is good and implementation, too. If we iterate all checks anyway (probably?) we could think about adding a severity to the checks, too?

Mar 28 2019, 11:40 AM · Restricted Project, Restricted Project

Mar 27 2019

JonasToth added a comment to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.

I think in general this is a good direction. What do you think about other heuristics?
E.g. one could say that a vector will not contain more then X GB or similar. That is probably more complicated to figure out though.

Mar 27 2019, 9:33 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth added reviewers for D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable: alexfh, aaron.ballman, hokein.
Mar 27 2019, 9:28 AM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2019

JonasToth added inline comments to D59650: [NFC] ExceptionEscapeCheck: small refactoring .
Mar 21 2019, 2:43 PM · Restricted Project, Restricted Project
JonasToth added a comment to D59650: [NFC] ExceptionEscapeCheck: small refactoring .

Looks like pointless code duplication that is easily avoidable.

Mar 21 2019, 2:23 PM · Restricted Project, Restricted Project
JonasToth added a comment to D59650: [NFC] ExceptionEscapeCheck: small refactoring .

Why not having normal overloads? The analysis for Stmt is implemented with the private methods. Explicit template specialization is a bit overkill and so easily understood (but not too complex in this case either).l

Mar 21 2019, 1:29 PM · Restricted Project, Restricted Project

Mar 19 2019

JonasToth added a comment to D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture.

What happens on [=]() ..., direct capture [&Columns]()... and [Columns]()...?

Mar 19 2019, 7:34 AM · Restricted Project

Mar 18 2019

JonasToth added a comment to D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept.

Ping! Any news regarding this patch?

Mar 18 2019, 7:56 AM · Restricted Project, Restricted Project

Mar 15 2019

JonasToth added a comment to D54395: [clang-tidy] implement utility-function to add 'const' to variables.

ping :)

Mar 15 2019, 11:43 AM · Restricted Project
JonasToth added a comment to D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py.

From my side its LGTM, but I would let @serge-sans-paille accept, as he is probably more familiar with python then I am.

Mar 15 2019, 7:44 AM · Restricted Project
JonasToth added a comment to D59318: [clang-tidy] add an overload for diag method that allows users to provide a diagnostic name rather than using the check name when building a diagnostic..

What is the reason you want this change to happen? I think this gives the chance to create inconsistencies which we should avoid.

Mar 15 2019, 7:37 AM · Restricted Project, Restricted Project
JonasToth retitled D59318: [clang-tidy] add an overload for diag method that allows users to provide a diagnostic name rather than using the check name when building a diagnostic. from Add an overload for ClangTidy's diag method that allows users to provide a diagnostic name rather than using the check name when building a diagnostic. to [clang-tidy] add an overload for diag method that allows users to provide a diagnostic name rather than using the check name when building a diagnostic..
Mar 15 2019, 7:36 AM · Restricted Project, Restricted Project

Mar 7 2019

JonasToth added a comment to D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator.

@lebedev.ri @kallehuttunen what do you think of putting this into context of the proposal (i believe its being standardized with c++20) of operator==() = default and the spaceship-operator.
This check could serve as a basis to modernize the operator== to the default if appropriate and warn/diagnose in the other cases.
WDYT?

Mar 7 2019, 11:49 AM · Restricted Project, Restricted Project
JonasToth added a comment to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

IMHO the check is close to being finished. please address the notes and mark them as done if finished with it. So its clear to see whats outstanding.
In my opinion the user-facing documentation misses a "Limitations" sections that shows the artificial goto example, that would show that the used mechanism doesn't handle it.

Mar 7 2019, 4:16 AM · Restricted Project
JonasToth added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 7 2019, 4:10 AM · Restricted Project

Mar 5 2019

JonasToth added inline comments to rL354796: Update status page with papers/issues adopted in Kona.
Mar 5 2019, 2:56 AM

Mar 3 2019

JonasToth added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 3 2019, 11:19 AM · Restricted Project

Mar 2 2019

JonasToth added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 2 2019, 1:15 PM · Restricted Project
JonasToth added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 2 2019, 1:15 PM · Restricted Project

Mar 1 2019

JonasToth added inline comments to D58819: [clang-format] clang-format off/on not respected when using C Style comments.
Mar 1 2019, 12:43 PM · Restricted Project, Restricted Project, Restricted Project
JonasToth added inline comments to D58819: [clang-format] clang-format off/on not respected when using C Style comments.
Mar 1 2019, 10:22 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 1 2019, 10:22 AM · Restricted Project

Feb 28 2019

JonasToth accepted D57087: [clang-tidy] add OverrideMacro to modernize-use-override check.

LGTM

Feb 28 2019, 10:26 AM · Restricted Project, Restricted Project
JonasToth added a comment to D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.

@JonasToth I left a comment in the commit needed to fix the index.rst, which I don't think your later review fixes, sphinx complained about the rst file being an unreferenced octtree

https://reviews.llvm.org/rG5fbeff797a9dba504f08f14c4fa59b6f1076fe72#inline-2691

Feb 28 2019, 10:19 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth committed rGab10947b345e: [clang-tidy] fix documentation link in list of clang-tidy checks (authored by JonasToth).
[clang-tidy] fix documentation link in list of clang-tidy checks
Feb 28 2019, 9:54 AM
JonasToth committed rCTE355108: [clang-tidy] fix documentation link in list of clang-tidy checks.
[clang-tidy] fix documentation link in list of clang-tidy checks
Feb 28 2019, 9:54 AM
JonasToth committed rL355108: [clang-tidy] fix documentation link in list of clang-tidy checks.
[clang-tidy] fix documentation link in list of clang-tidy checks
Feb 28 2019, 9:54 AM
JonasToth added inline comments to rG5fbeff797a9d: [clang-tidy] redirection in list of checks adjusted.
Feb 28 2019, 9:54 AM
JonasToth committed rG5fbeff797a9d: [clang-tidy] redirection in list of checks adjusted (authored by JonasToth).
[clang-tidy] redirection in list of checks adjusted
Feb 28 2019, 7:57 AM
JonasToth committed rL355102: [clang-tidy] redirection in list of checks adjusted.
[clang-tidy] redirection in list of checks adjusted
Feb 28 2019, 7:57 AM
JonasToth committed rCTE355102: [clang-tidy] redirection in list of checks adjusted.
[clang-tidy] redirection in list of checks adjusted
Feb 28 2019, 7:57 AM
JonasToth added a comment to rL355097: [clang-tidy] tryfix documenation continued.

Hmm, yeah. The laptop i have here right now does not have the dependencies installed, so yeah (you can see from all the commits i needed to do get all errors that existed).
Most of the time it works though.

Feb 28 2019, 7:50 AM
JonasToth committed rGed571d77d2f0: [clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of… (authored by JonasToth).
[clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of…
Feb 28 2019, 7:47 AM
JonasToth committed rL355100: [clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of….
[clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of…
Feb 28 2019, 7:46 AM
JonasToth committed rCTE355100: [clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of….
[clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of…
Feb 28 2019, 7:46 AM
JonasToth committed rG3a24cb00ebcd: [clang-tidy] documentation fixing the actual correct file (authored by JonasToth).
[clang-tidy] documentation fixing the actual correct file
Feb 28 2019, 7:39 AM
JonasToth committed rL355098: [clang-tidy] documentation fixing the actual correct file.
[clang-tidy] documentation fixing the actual correct file
Feb 28 2019, 7:39 AM
JonasToth committed rCTE355098: [clang-tidy] documentation fixing the actual correct file.
[clang-tidy] documentation fixing the actual correct file
Feb 28 2019, 7:39 AM
JonasToth committed rGeae176f14276: [clang-tidy] tryfix documenation continued (authored by JonasToth).
[clang-tidy] tryfix documenation continued
Feb 28 2019, 7:28 AM
JonasToth committed rCTE355097: [clang-tidy] tryfix documenation continued.
[clang-tidy] tryfix documenation continued
Feb 28 2019, 7:28 AM
JonasToth committed rL355097: [clang-tidy] tryfix documenation continued.
[clang-tidy] tryfix documenation continued
Feb 28 2019, 7:27 AM
JonasToth added a comment to D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.

Thank you for the patch!

Feb 28 2019, 7:22 AM · Restricted Project, Restricted Project, Restricted Project
JonasToth committed rGdf5871997944: [clang-tidy] another issue in documentation, double empty line seemed to… (authored by JonasToth).
[clang-tidy] another issue in documentation, double empty line seemed to…
Feb 28 2019, 7:19 AM
JonasToth committed rCTE355095: [clang-tidy] another issue in documentation, double empty line seemed to….
[clang-tidy] another issue in documentation, double empty line seemed to…
Feb 28 2019, 7:18 AM
JonasToth committed rL355095: [clang-tidy] another issue in documentation, double empty line seemed to….
[clang-tidy] another issue in documentation, double empty line seemed to…
Feb 28 2019, 7:18 AM
JonasToth committed rG0023b130cf89: [clang-tidy] attempt to fix documentation build-error (authored by JonasToth).
[clang-tidy] attempt to fix documentation build-error
Feb 28 2019, 7:02 AM
JonasToth added a comment to rGc526e02668b3: [clang-tidy] Add the abseil-time-subtraction check.

This patch introduced a build-failure for the documentation builders (see http://lab.llvm.org:8011/builders/clang-tools-sphinx-docs/builds/38188/steps/docs-clang-tools-html/logs/stdio).
Please take a look at the buildbots after you committed something (http://lab.llvm.org:8011/console) to avoid such issues.

Feb 28 2019, 7:02 AM
JonasToth committed rL355094: [clang-tidy] attempt to fix documentation build-error.
[clang-tidy] attempt to fix documentation build-error
Feb 28 2019, 7:00 AM
JonasToth committed rCTE355094: [clang-tidy] attempt to fix documentation build-error.
[clang-tidy] attempt to fix documentation build-error
Feb 28 2019, 7:00 AM
JonasToth committed rGda666233fe7d: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions (authored by JonasToth).
[clang-tidy] added cppcoreguidelines-explicit-virtual-functions
Feb 28 2019, 6:55 AM
JonasToth committed rCTE355093: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.
[clang-tidy] added cppcoreguidelines-explicit-virtual-functions
Feb 28 2019, 6:55 AM
JonasToth committed rL355093: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.
[clang-tidy] added cppcoreguidelines-explicit-virtual-functions
Feb 28 2019, 6:55 AM