This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][NFC] Add cost model coverage for fp arithmetic instructions.
ClosedPublic

Authored by jacquesguan on Aug 24 2022, 12:58 AM.

Details

Summary

This patch adds cost model coverage for fp arithmetic instructions. Some is not exact, I am working on a revision to implement that.

Diff Detail

Event Timeline

jacquesguan created this revision.Aug 24 2022, 12:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2022, 12:58 AM
jacquesguan requested review of this revision.Aug 24 2022, 12:58 AM
reames accepted this revision.Aug 26 2022, 7:51 AM

LGTM. Duplicate testing noted, please remove before landing.

p.s. I'm working on intrinsic costing, you might find https://github.com/preames/riscv-llvm-cost-model-gen/ useful, and feel free to tag me on reviews. I'm motivated to see these fixed and landed.

llvm/test/Analysis/CostModel/RISCV/arith-fp.ll
487

sqrt already has test coverage - very recently added - in fp-sqrt-pow.ll. Please remove here.

567

Already covered in fp-min-max-abs.ll

This revision is now accepted and ready to land.Aug 26 2022, 7:51 AM

Remove duplicate test cases.

LGTM. Duplicate testing noted, please remove before landing.

p.s. I'm working on intrinsic costing, you might find https://github.com/preames/riscv-llvm-cost-model-gen/ useful, and feel free to tag me on reviews. I'm motivated to see these fixed and landed.

Thanks, it's wonderful.

This revision was landed with ongoing or failed builds.Aug 28 2022, 8:14 PM
This revision was automatically updated to reflect the committed changes.