This is an archive of the discontinued LLVM Phabricator instance.

[LoongArch] Port over minimal applyFixup from RISCV
ClosedPublic

Authored by xen0n on Aug 20 2022, 6:48 PM.

Details

Summary

Many DebugInfo tests now pass with native builds.

Diff Detail

Event Timeline

xen0n created this revision.Aug 20 2022, 6:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 20 2022, 6:48 PM
xen0n requested review of this revision.Aug 20 2022, 6:48 PM

Is this a WIP patch? Will you add some tests?

How about @wangleiat's opinion?

llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchAsmBackend.cpp
80–81

Can these 2 lines be moved before line-79?

xen0n updated this revision to Diff 454392.Aug 21 2022, 11:34 PM

address @SixWeining's review comments

xen0n marked an inline comment as done.Aug 21 2022, 11:36 PM

The patch is ready for review.

This may not need a dedicated test case, because before the change most if not all DebugInfo tests fail on native LoongArch builds, and this change (together with the parent change) fixes them.

llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchAsmBackend.cpp
80–81

fixed

This revision is now accepted and ready to land.Aug 24 2022, 1:25 AM
gonglingqin accepted this revision.Aug 24 2022, 1:28 AM
This revision was automatically updated to reflect the committed changes.
fhahn added a subscriber: fhahn.Aug 26 2022, 2:51 AM

Is it possible to add a unit tests for this?

Is it possible to add a unit tests for this?

Thanks for the reminder, test cases will be added in the subsequent complete implementation of applyFixup.