Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchAsmBackend.cpp | ||
---|---|---|
139–143 | This is placed here due to review comment on D132323, does the situation change enough to make this change appropriate? | |
llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMCCodeEmitter.cpp | ||
251 | Do we want to also handle BL here? Given it's the only other insn of the format. |
llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchAsmBackend.cpp | ||
---|---|---|
139–143 | Personal preference, just put the processing of Value together (Increases the readability of the code). Maybe it was put in the front at the time because of performance? If you think this is not good, I can modify it back. | |
llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMCCodeEmitter.cpp | ||
251 |
It is not needed. This is because BL are handled specifically in both the LowerCall phase and ASMParser. |
llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchAsmBackend.cpp | ||
---|---|---|
139–143 | Granted it's just a teensy bit of performance, but it's still @SixWeining's input after all, and after the change it's back to the same as RISCV, and effectively code churn for no objective reason. So I'd personally prefer the 2 lines be moved back. Thanks! | |
llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMCCodeEmitter.cpp | ||
251 | Okay, thanks for the explanation. I have no problem with that. |
Great! Will omit a lot of code, I will do that.
To avoid a lot of code removal, I'm going to make changes in the commits it depends on D132633
llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchAsmBackend.cpp | ||
---|---|---|
93 | % 4. The compiler can optimize it | |
100 | % 4 | |
llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMCCodeEmitter.cpp | ||
267 | break; | |
llvm/test/MC/LoongArch/Relocations/fixups-diagnostics.s | ||
2 | |& => 2>&1 | Some people's default shell (e.g. some macOS) don't support |& | |
4 | #@LINE @LINE is deprecated |
Thanks for all the comments, I will fix them. :)
llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchAsmBackend.cpp | ||
---|---|---|
93 |
| |
100 |
| |
llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMCCodeEmitter.cpp | ||
267 |
| |
llvm/test/MC/LoongArch/Relocations/fixups-diagnostics.s | ||
2 |
| |
4 |
|
% 4. The compiler can optimize it