Page MenuHomePhabricator

Use ISA versions instead of attributes to determine intrinsic legality.
AbandonedPublic

Authored by Leonc on Aug 16 2022, 2:28 AM.

Details

Summary

Subtarget attributes are not guaranteed to match those of the actual hardware. This can cause the compiler to crash in some circumstances.
Modify intrinsic lowering to be conditional on ISA version numbers instead of subtarget attributes.

Diff Detail

Event Timeline

Leonc created this revision.Aug 16 2022, 2:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2022, 2:28 AM
Leonc requested review of this revision.Aug 16 2022, 2:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2022, 2:28 AM
bcahoon added inline comments.Aug 16 2022, 6:45 AM
llvm/lib/Target/AMDGPU/SIISelLowering.cpp
7826

Why can't the compiler continue to use the attribute?

Leonc abandoned this revision.Aug 17 2022, 6:47 AM

Abandoning in favour of updating device-libs.