Page MenuHomePhabricator

Leonc (Leon Clark)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 12 2022, 11:16 PM (16 w, 5 d)

Recent Activity

Fri, Aug 5

Leonc added a comment to D123693: Transform illegal intrinsics to V_ILLEGAL.

We also probably should clean up the the encoding to rely on subtarget features instead of the generation check

Fri, Aug 5, 1:27 PM · Restricted Project, Restricted Project
Leonc added inline comments to D123693: Transform illegal intrinsics to V_ILLEGAL.
Fri, Aug 5, 1:12 PM · Restricted Project, Restricted Project
Leonc updated the diff for D123693: Transform illegal intrinsics to V_ILLEGAL.
  • Remove debug code.
Fri, Aug 5, 1:11 PM · Restricted Project, Restricted Project
Leonc updated the diff for D123693: Transform illegal intrinsics to V_ILLEGAL.
  • Address comments.
Fri, Aug 5, 10:25 AM · Restricted Project, Restricted Project
Leonc added inline comments to D123693: Transform illegal intrinsics to V_ILLEGAL.
Fri, Aug 5, 7:07 AM · Restricted Project, Restricted Project
Leonc added inline comments to D123693: Transform illegal intrinsics to V_ILLEGAL.
Fri, Aug 5, 6:58 AM · Restricted Project, Restricted Project
Leonc updated the diff for D123693: Transform illegal intrinsics to V_ILLEGAL.
  • Address comments.
Fri, Aug 5, 6:26 AM · Restricted Project, Restricted Project

Thu, Aug 4

Leonc updated the diff for D123693: Transform illegal intrinsics to V_ILLEGAL.
  • Address comments and fix tests.
Thu, Aug 4, 8:54 AM · Restricted Project, Restricted Project

Wed, Aug 3

Leonc added inline comments to D123693: Transform illegal intrinsics to V_ILLEGAL.
Wed, Aug 3, 11:13 AM · Restricted Project, Restricted Project
Leonc updated the diff for D123693: Transform illegal intrinsics to V_ILLEGAL.
  • Address comments.
Wed, Aug 3, 11:08 AM · Restricted Project, Restricted Project
Leonc added inline comments to D123693: Transform illegal intrinsics to V_ILLEGAL.
Wed, Aug 3, 7:12 AM · Restricted Project, Restricted Project
Leonc added inline comments to D123693: Transform illegal intrinsics to V_ILLEGAL.
Wed, Aug 3, 2:19 AM · Restricted Project, Restricted Project
Leonc updated the diff for D123693: Transform illegal intrinsics to V_ILLEGAL.
  • Add v_illegal assembly tests.
  • Update instruction definitions.
Wed, Aug 3, 2:15 AM · Restricted Project, Restricted Project

Mon, Aug 1

Leonc updated the diff for D123693: Transform illegal intrinsics to V_ILLEGAL.
  • Fix ternary args.
Mon, Aug 1, 8:01 AM · Restricted Project, Restricted Project
Leonc added inline comments to D123693: Transform illegal intrinsics to V_ILLEGAL.
Mon, Aug 1, 7:56 AM · Restricted Project, Restricted Project
Leonc added inline comments to D123693: Transform illegal intrinsics to V_ILLEGAL.
Mon, Aug 1, 7:43 AM · Restricted Project, Restricted Project
Leonc updated the diff for D123693: Transform illegal intrinsics to V_ILLEGAL.
  • Fix indentation, braces, and file mode.
Mon, Aug 1, 7:42 AM · Restricted Project, Restricted Project
Leonc updated the diff for D123693: Transform illegal intrinsics to V_ILLEGAL.
  • Add different versions of V_ILLEGAL for different targets.
Mon, Aug 1, 5:28 AM · Restricted Project, Restricted Project

Fri, Jul 29

Leonc updated the diff for D123693: Transform illegal intrinsics to V_ILLEGAL.
  • Handling for atomics plus tests.
Fri, Jul 29, 9:20 AM · Restricted Project, Restricted Project

Thu, Jul 28

Leonc added inline comments to D123693: Transform illegal intrinsics to V_ILLEGAL.
Thu, Jul 28, 4:34 AM · Restricted Project, Restricted Project
Leonc updated the diff for D123693: Transform illegal intrinsics to V_ILLEGAL.
  • Address comments.
Thu, Jul 28, 4:33 AM · Restricted Project, Restricted Project

Wed, Jul 27

Leonc updated the diff for D123693: Transform illegal intrinsics to V_ILLEGAL.
  • Revert changes to return values.
  • Refactor code.
  • Address comments.
Wed, Jul 27, 9:31 AM · Restricted Project, Restricted Project

Sun, Jul 24

Leonc updated the diff for D123693: Transform illegal intrinsics to V_ILLEGAL.
  • Fix existing test failures.
Sun, Jul 24, 7:21 PM · Restricted Project, Restricted Project

Jun 14 2022

Leonc added a comment to D123693: Transform illegal intrinsics to V_ILLEGAL.

The issue is our libraries contain code for all targets. We rely on dead code elimination to remove illegal intrinsics, but that doesn't happen on -O0.

Why can't you put the code for different subtargets in different functions, each with an appropriate "target-cpu"= attribute?

That's what I would do. I think there's some resistance to it though, and it would probably require a lot more work.

Well I am resistant to selecting intrinsics on subtargets that don't support them :)

How far are you planning to go with this approach? Do you expect to extend it to all AMDGPU intrinsics?

Jun 14 2022, 2:15 AM · Restricted Project, Restricted Project
Leonc added a comment to D123693: Transform illegal intrinsics to V_ILLEGAL.

The issue is our libraries contain code for all targets. We rely on dead code elimination to remove illegal intrinsics, but that doesn't happen on -O0.

Why can't you put the code for different subtargets in different functions, each with an appropriate "target-cpu"= attribute?

Jun 14 2022, 1:31 AM · Restricted Project, Restricted Project
Leonc added a comment to D123693: Transform illegal intrinsics to V_ILLEGAL.

Where's the rationale? Surely unsupported intrinsics should fail to select, and perhaps be diagnosed even earlier?

Jun 14 2022, 1:15 AM · Restricted Project, Restricted Project

Jun 13 2022

Leonc added inline comments to D123693: Transform illegal intrinsics to V_ILLEGAL.
Jun 13 2022, 9:23 PM · Restricted Project, Restricted Project

Jun 10 2022

Leonc added a comment to D123693: Transform illegal intrinsics to V_ILLEGAL.

Next steps:

Jun 10 2022, 10:34 PM · Restricted Project, Restricted Project
Leonc retitled D123693: Transform illegal intrinsics to V_ILLEGAL from Transform tex2D to legal intrinsic on gfx90a. to Transform illegal intrinsics to V_ILLEGAL.
Jun 10 2022, 10:24 PM · Restricted Project, Restricted Project
Leonc updated the diff for D123693: Transform illegal intrinsics to V_ILLEGAL.
  • Revert rebase error.
Jun 10 2022, 10:13 PM · Restricted Project, Restricted Project
Leonc updated the diff for D123693: Transform illegal intrinsics to V_ILLEGAL.
  • Updates toward catching and handling all illegal intrinsics.
Jun 10 2022, 10:08 PM · Restricted Project, Restricted Project

Apr 13 2022

Leonc updated the summary of D123693: Transform illegal intrinsics to V_ILLEGAL.
Apr 13 2022, 10:41 AM · Restricted Project, Restricted Project
Leonc requested review of D123693: Transform illegal intrinsics to V_ILLEGAL.
Apr 13 2022, 10:39 AM · Restricted Project, Restricted Project