This is an archive of the discontinued LLVM Phabricator instance.

[SelectionDAG] Restore calls to has_value (NFC)
ClosedPublic

Authored by kazu on Jul 10 2022, 1:27 PM.

Details

Summary

This patch restores calls to has_value to make it clear that we are
checking the presence of an optional value, not the underlying value.

This patch partially reverts d08f34b592ff06ccb1f36da88ec09aa926427a4d.

Diff Detail

Event Timeline

kazu created this revision.Jul 10 2022, 1:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2022, 1:27 PM
kazu requested review of this revision.Jul 10 2022, 1:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2022, 1:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 10 2022, 2:37 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.