Thanks for working on this! In general SGTM, but I would like to see the CI pass after rebasing.
Correct, but only on non-member functions. I don't see any conflicts, thanks for asking.
Not your change but please verify whether https://reviews.llvm.org/D129503#inline-1244548 is addressed otherwise please rebase and fix that before landing this patch.
Maybe not this patch but can we add a regex that when a member starts with __ it should end with _.
This will conflict with D129442, sorry I wasn't aware of this patch.
This prompted my regex question, since they weren't updated.
- Address comments
I'll try, but that might require a custom clang-tidy check. I think we should first work through the checks already available before adding custom ones for us. It might work with PublicMemberCase combined with PublicMemberIgnoredRegexp though. I'll try that after the easier ones.
I discovered the tautological compare while working on this patch, so I already expected a merge-conflict. It's small enough that I thought it wouldn't matter that much.
With this patch I'm only checking private members, since protected or public members could be required by the standard. I'm working on checking more, but it'll take some time to get most things checked.