Page MenuHomePhabricator

[libc++] Rename variables to use the snake case instead of camel case
ClosedPublic

Authored by huixie90 on Jul 11 2022, 10:29 AM.

Details

Summary

For some reason the pre-commit CI of https://reviews.llvm.org/D129233 was all green so I didn't spot this
https://reviews.llvm.org/B174525

Diff Detail

Event Timeline

huixie90 created this revision.Jul 11 2022, 10:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2022, 10:29 AM
huixie90 requested review of this revision.Jul 11 2022, 10:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2022, 10:29 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.Jul 11 2022, 10:31 AM

LGTM. I added the check in D129051. You probably just didn't rebase onto it.

This revision is now accepted and ready to land.Jul 11 2022, 10:31 AM
philnik retitled this revision from rename variables to use the snake case instead of camel case to [libc++] Rename variables to use the snake case instead of camel case.Jul 11 2022, 10:32 AM
Mordante accepted this revision.Jul 11 2022, 11:38 AM
Mordante added a subscriber: Mordante.

LGTM.

libcxx/include/__algorithm/set_intersection.h
29

These names look suspicious, the struct has underscores, the members not. Since this patch fixes a CI breakage I prefer to land this patch as is and improve this in a separate patch.

For your information __out is a name you can't use. It's used by Microsoft and will fail in the CI in our nasty-macro test.

@huixie90 since this fixes the breaking of the ToT I've landed this on your behalf.

Please have a look at the review comment I left earlier.