Page MenuHomePhabricator

[RISCV][Driver] Add libm linking to `RISCVToolchain` for C++
ClosedPublic

Authored by anton-afanasyev on Jul 4 2022, 2:47 AM.

Details

Summary

GCC automatically links math library by adding -lm to linker command
line, since C++ runtime libstdc++ requires libm, so add it to
RISCVToochain as well.

Diff Detail

Event Timeline

anton-afanasyev created this revision.Jul 4 2022, 2:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2022, 2:47 AM
anton-afanasyev requested review of this revision.Jul 4 2022, 2:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2022, 2:47 AM

Update summary

MaskRay accepted this revision.Jul 5 2022, 11:57 AM
This revision is now accepted and ready to land.Jul 5 2022, 11:57 AM

Commit subject/body should say C++ in it

anton-afanasyev retitled this revision from [RISCV][Driver] Add libm linking to `RISCVToolchain` to [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++.Jul 5 2022, 2:40 PM
anton-afanasyev edited the summary of this revision. (Show Details)

Commit subject/body should say C++ in it

Sure, updated.

This revision was landed with ongoing or failed builds.Jul 5 2022, 2:54 PM
This revision was automatically updated to reflect the committed changes.