[mlir][NFC] Fix various warnings generated by GCC 9

[unterumarmung]

Summary

Currently, there've been a lot of warnings while building MLIR.
This change fixes the warnings listed below.

.../SparseTensorUtils.cpp: In instantiation of ‘...::openSparseTensorCOO(...) [with ...]’:
.../SparseTensorUtils.cpp:1672:3:   required from here
.../SparseTensorUtils.cpp:87:21: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘PrimaryType’ [-Wformat=]

.../OptUtils.cpp:36:5: warning: this statement may fall through [-Wimplicit-fallthrough=]

.../AffineOps.cpp:1741:32: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]

[Mogball]

mlir/lib/ExecutionEngine/OptUtils.cpp

46

Should this be fall through?

[unterumarmung]

mlir/lib/ExecutionEngine/OptUtils.cpp

46

I'm not sure. @aeubanks is the author for this code, I think they know it better. If it should fall through, I'll change the code appropriately.
Currently, the only possible value of sizeLevel variable is 0. So at the current state of the codebase the change doesn't change behavior, but may affect it in the future.

[aeubanks]

mlir/lib/ExecutionEngine/OptUtils.cpp

46

yes the break should be there, we shouldn't be returning O3 when we have optLevel == 2

mlir/lib/Dialect/Affine/IR/AffineOps.cpp

void AffineForOp::getCanonicalizationPatterns(RewritePatternSet &results,
   results.add<AffineForEmptyLoopFolder>(context);
 }
 
 /// Return operands used when entering the region at 'index'. These operands
 /// correspond to the loop iterator operands, i.e., those excluding the
 /// induction variable. AffineForOp only has one region, so zero is the only
 /// valid value for `index`.
 OperandRange AffineForOp::getSuccessorEntryOperands(Optional<unsigned> index) {
-  assert(!index || *index == 0 && "invalid region index");
+  assert((!index || *index == 0) && "invalid region index");
 
   // The initial operands map to the loop arguments after the induction
   // variable or are forwarded to the results when the trip count is zero.
   return getIterOperands();
 }
 
 /// Given the region at `index`, or the parent operation if `index` is None,
 /// return the successor regions. These are the regions that may be selected

mlir/lib/ExecutionEngine/OptUtils.cpp

case 0:
       return OptimizationLevel::O2;
 
     case 1:
       return OptimizationLevel::Os;
 
     case 2:
       return OptimizationLevel::Oz;
     }
-
+    break;
   case 3:
     return OptimizationLevel::O3;
   }
   return None;
 }
 // Create and return a lambda that uses LLVM pass manager builder to set up
 // optimizations based on the given level.
 std::function<Error(Module *)>

mlir/lib/ExecutionEngine/SparseTensorUtils.cpp

openSparseTensorCOO(char *filename, uint64_t rank, const uint64_t *shape,
   // Check tensor element type against the value type in the input file.
   SparseTensorFile::ValueKind valueKind = stfile.getValueKind();
   bool tensorIsInteger =
       (valTp >= PrimaryType::kI64 && valTp <= PrimaryType::kI8);
   bool tensorIsReal = (valTp >= PrimaryType::kF64 && valTp <= PrimaryType::kI8);
   if ((valueKind == SparseTensorFile::ValueKind::kReal && tensorIsInteger) ||
       (valueKind == SparseTensorFile::ValueKind::kComplex && tensorIsReal)) {
     FATAL("Tensor element type %d not compatible with values in file %s\n",
-          valTp, filename);
+          static_cast<int>(valTp), filename);
   }
   stfile.assertMatchesShape(rank, shape);
   // Prepare sparse tensor object with per-dimension sizes
   // and the number of nonzeros as initial capacity.
   uint64_t nnz = stfile.getNNZ();
   auto *coo = SparseTensorCOO<V>::newSparseTensorCOO(rank, stfile.getDimSizes(),
                                                      perm, nnz);
   // Read all nonzero elements.