This is an archive of the discontinued LLVM Phabricator instance.

Differential D128686

[OpenMP][NFC] Reuse check lines for Clang/OpenMP tests
ClosedPublic

Authored by jdoerfert on Jun 27 2022, 4:07 PM.

Details

Reviewers
jhuber6
JonChesterfield
ABataev
RaviNarayanaswamy
ggeorgakoudis
tianshilei1992
Commits
rGb52d33e6de55: [OpenMP][NFC] Reuse check lines for Clang/OpenMP tests
Summary

I used a script to reuse existing check lines rather than creating new
ones. There are more opportunities to reduce the line count but the
"check generated functions" logic makes that somewhat tricky.

FWIW, we really should redo the update script with all these use cases
in mind...

Diff Detail

Event Timeline

jdoerfert created this revision.Jun 27 2022, 4:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2022, 4:07 PM
Herald added subscribers: mattd, asavonic, guansong and 2 others. · View Herald Transcript
jdoerfert requested review of this revision.Jun 27 2022, 4:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2022, 4:07 PM
Herald added subscribers: cfe-commits, sstefan1. · View Herald Transcript
jdoerfert added a comment.Jun 27 2022, 4:10 PM

I'm not so sure but phab things this is small, so no complaints:

jdoerfert added parent revisions: D128684: [UpdateTestChecks] Handle prefix reuse for appended check lines, D128685: [OpenMP][NFC] Remove unused check lines in Clang/OpenMP tests.Jun 27 2022, 4:11 PM
jdoerfert mentioned this in D128684: [UpdateTestChecks] Handle prefix reuse for appended check lines.Jun 27 2022, 4:15 PM
ABataev accepted this revision.Jun 27 2022, 4:23 PM

LG

This revision is now accepted and ready to land.Jun 27 2022, 4:23 PM
Harbormaster completed remote builds in B172348: Diff 440425.Jun 27 2022, 5:52 PM
jdoerfert mentioned this in rGb0ce93226cee: [UpdateTestChecks] Handle prefix reuse for appended check lines.Jun 28 2022, 3:19 PM
jhuber6 added a child revision: D128550: [OpenMP] Change OpenMP code generation for target region entries.Jun 28 2022, 6:45 PM
This revision was landed with ongoing or failed builds.Jul 1 2022, 7:35 PM
Closed by commit rGb52d33e6de55: [OpenMP][NFC] Reuse check lines for Clang/OpenMP tests (authored by jdoerfert). · Explain Why
This revision was automatically updated to reflect the committed changes.
jdoerfert added a commit: rGb52d33e6de55: [OpenMP][NFC] Reuse check lines for Clang/OpenMP tests.

Large Diff

This large diff affects 172 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
clang/
test/
OpenMP/
3828 lines
632 lines
6026 lines
1664 lines
1732 lines
12235 lines
2380 lines
9093 lines
2542 lines
4436 lines
1714 lines
465 lines
621 lines
15247 lines
3106 lines
7282 lines
3520 lines
6818 lines
2540 lines
614 lines
1308 lines
10094 lines
2368 lines
2668 lines
2212 lines
851 lines
595 lines
3762 lines
655 lines
491 lines
3917 lines
3633 lines
530 lines
679 lines
810 lines
345 lines
366 lines
80 lines
133 lines
397 lines
436 lines
449 lines
2472 lines
167 lines
124 lines
1536 lines
1200 lines
1040 lines
2852 lines
1015 lines
1390 lines
2663 lines
250 lines
322 lines
526 lines
249 lines
688 lines
354 lines
481 lines
928 lines
836 lines
902 lines
1236 lines
415 lines
1382 lines
472 lines
164 lines
514 lines
553 lines
1332 lines
391 lines
814 lines
518 lines
976 lines
484 lines
318 lines
1870 lines
840 lines
8463 lines
11156 lines
539 lines
15870 lines
4647 lines
3825 lines
485 lines
11250 lines
15129 lines
1157 lines
2553 lines
1827 lines
1749 lines
2134 lines
1709 lines
4137 lines
3909 lines
9282 lines
2609 lines
161 lines
2703 lines
465 lines
1391 lines
934 lines
13434 lines
3357 lines
2393 lines
5337 lines
6265 lines
7566 lines
3571 lines
5395 lines
614 lines
1677 lines
15872 lines
1204 lines
799 lines
16988 lines
1773 lines
3583 lines
2648 lines
2665 lines
2139 lines
1050 lines
3047 lines
3825 lines
3972 lines
1857 lines
673 lines
151 lines
74 lines
672 lines
803 lines
1956 lines
2094 lines
1141 lines
2499 lines
1831 lines
1714 lines
3184 lines
1677 lines
1023 lines
4089 lines
2458 lines
9373 lines
2524 lines
2292 lines
1688 lines
465 lines
1407 lines
939 lines
13274 lines
4552 lines
2361 lines
5289 lines
3320 lines
7462 lines
3494 lines
3513 lines
2658 lines
614 lines
1693 lines
15712 lines
1209 lines
815 lines
4987 lines
1757 lines
3529 lines
2656 lines
2638 lines
2144 lines
1066 lines
2511 lines
1342 lines

Diff 441854

clang/test/OpenMP/cancel_codegen.cpp

clang/test/OpenMP/cancellation_point_codegen.cpp

clang/test/OpenMP/distribute_codegen.cpp

clang/test/OpenMP/distribute_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_if_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_num_threads_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_private_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_proc_bind_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_reduction_task_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_if_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_num_threads_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_private_codegen.cpp

clang/test/OpenMP/distribute_parallel_for_simd_proc_bind_codegen.cpp

clang/test/OpenMP/distribute_private_codegen.cpp

clang/test/OpenMP/distribute_simd_codegen.cpp

clang/test/OpenMP/distribute_simd_firstprivate_codegen.cpp

clang/test/OpenMP/distribute_simd_lastprivate_codegen.cpp

clang/test/OpenMP/distribute_simd_private_codegen.cpp

clang/test/OpenMP/distribute_simd_reduction_codegen.cpp

clang/test/OpenMP/for_firstprivate_codegen.cpp

clang/test/OpenMP/for_lastprivate_codegen.cpp

clang/test/OpenMP/for_linear_codegen.cpp

clang/test/OpenMP/for_private_codegen.cpp

clang/test/OpenMP/for_reduction_codegen.cpp

clang/test/OpenMP/for_reduction_codegen_UDR.cpp

clang/test/OpenMP/for_reduction_task_codegen.cpp

clang/test/OpenMP/master_taskloop_in_reduction_codegen.cpp

clang/test/OpenMP/master_taskloop_simd_in_reduction_codegen.cpp

clang/test/OpenMP/nvptx_distribute_parallel_generic_mode_codegen.cpp

clang/test/OpenMP/nvptx_lambda_capturing.cpp

clang/test/OpenMP/nvptx_multi_target_parallel_codegen.cpp

clang/test/OpenMP/nvptx_nested_parallel_codegen.cpp

clang/test/OpenMP/nvptx_target_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_num_threads_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_reduction_codegen_tbaa_PR46146.cpp

clang/test/OpenMP/nvptx_target_teams_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_generic_mode_codegen.cpp

clang/test/OpenMP/nvptx_target_teams_distribute_parallel_for_simd_codegen.cpp

clang/test/OpenMP/ordered_codegen.cpp

clang/test/OpenMP/parallel_copyin_codegen.cpp

clang/test/OpenMP/parallel_firstprivate_codegen.cpp

clang/test/OpenMP/parallel_for_codegen.cpp

clang/test/OpenMP/parallel_for_lastprivate_conditional.cpp

clang/test/OpenMP/parallel_for_linear_codegen.cpp

clang/test/OpenMP/parallel_for_reduction_task_codegen.cpp

clang/test/OpenMP/parallel_for_simd_aligned_codegen.cpp

clang/test/OpenMP/parallel_if_codegen.cpp

clang/test/OpenMP/parallel_master_codegen.cpp

clang/test/OpenMP/parallel_master_reduction_task_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_lastprivate_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_simd_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_simd_lastprivate_codegen.cpp

clang/test/OpenMP/parallel_private_codegen.cpp

clang/test/OpenMP/parallel_reduction_codegen.cpp

clang/test/OpenMP/parallel_reduction_task_codegen.cpp

clang/test/OpenMP/parallel_sections_codegen.cpp

clang/test/OpenMP/parallel_sections_reduction_task_codegen.cpp

clang/test/OpenMP/sections_firstprivate_codegen.cpp

clang/test/OpenMP/sections_lastprivate_codegen.cpp

clang/test/OpenMP/sections_private_codegen.cpp

clang/test/OpenMP/sections_reduction_codegen.cpp

clang/test/OpenMP/sections_reduction_task_codegen.cpp

clang/test/OpenMP/single_codegen.cpp

clang/test/OpenMP/single_firstprivate_codegen.cpp

clang/test/OpenMP/single_private_codegen.cpp

clang/test/OpenMP/target_codegen_global_capture.cpp

clang/test/OpenMP/target_map_codegen_03.cpp

clang/test/OpenMP/target_parallel_codegen.cpp

clang/test/OpenMP/target_parallel_for_codegen.cpp

clang/test/OpenMP/target_parallel_for_reduction_task_codegen.cpp

clang/test/OpenMP/target_parallel_for_simd_codegen.cpp

clang/test/OpenMP/target_parallel_if_codegen.cpp

clang/test/OpenMP/target_parallel_num_threads_codegen.cpp

clang/test/OpenMP/target_parallel_reduction_task_codegen.cpp

clang/test/OpenMP/target_teams_codegen.cpp

clang/test/OpenMP/target_teams_distribute_codegen.cpp

clang/test/OpenMP/target_teams_distribute_collapse_codegen.cpp

clang/test/OpenMP/target_teams_distribute_dist_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_lastprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_collapse_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_dist_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_if_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_lastprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_order_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_proc_bind_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_reduction_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_reduction_task_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_collapse_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_dist_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_if_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_lastprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_proc_bind_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_reduction_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_reduction_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_collapse_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_dist_schedule_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_lastprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_reduction_codegen.cpp

clang/test/OpenMP/target_teams_map_codegen.cpp

clang/test/OpenMP/target_teams_num_teams_codegen.cpp

clang/test/OpenMP/target_teams_thread_limit_codegen.cpp

clang/test/OpenMP/task_if_codegen.cpp

clang/test/OpenMP/task_in_reduction_codegen.cpp

clang/test/OpenMP/task_member_call_codegen.cpp

clang/test/OpenMP/taskgroup_codegen.cpp

clang/test/OpenMP/taskloop_in_reduction_codegen.cpp

clang/test/OpenMP/taskloop_simd_in_reduction_codegen.cpp

clang/test/OpenMP/teams_codegen.cpp

clang/test/OpenMP/teams_distribute_codegen.cpp

clang/test/OpenMP/teams_distribute_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_dist_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_copyin_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_dist_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_if_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_num_threads_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_private_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_proc_bind_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_reduction_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_reduction_task_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_dist_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_if_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_num_threads_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_private_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_proc_bind_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_reduction_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_private_codegen.cpp

clang/test/OpenMP/teams_distribute_reduction_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_collapse_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_dist_schedule_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_lastprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_private_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_reduction_codegen.cpp

clang/test/OpenMP/teams_firstprivate_codegen.cpp

clang/test/OpenMP/teams_private_codegen.cpp