Page MenuHomePhabricator

[UpdateTestChecks] Handle prefix reuse for appended check lines
ClosedPublic

Authored by jdoerfert on Jun 27 2022, 4:04 PM.

Details

Summary

When we appended check lines at the end we could not share prefixes
before. This patch should make it possible and allow us to reduce
some check line counts (especially for Clang/OpenMP tests).

See also: https://reviews.llvm.org/D128686

Diff Detail

Event Timeline

jdoerfert created this revision.Jun 27 2022, 4:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2022, 4:04 PM
jdoerfert requested review of this revision.Jun 27 2022, 4:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2022, 4:04 PM
Herald added a subscriber: sstefan1. · View Herald Transcript

nit: in the commit message, there's a spurious 'the' before 'some check counts'

jdoerfert edited the summary of this revision. (Show Details)Jun 27 2022, 4:15 PM
jhuber6 accepted this revision.EditedJun 27 2022, 6:59 PM

LGTM, others may want to comment.

This revision is now accepted and ready to land.Jun 27 2022, 6:59 PM
This revision was landed with ongoing or failed builds.Jun 28 2022, 3:19 PM
This revision was automatically updated to reflect the committed changes.