This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][DWARF] Support mix mode DWARF
ClosedPublic

Authored by ayermolo on Jun 20 2022, 4:31 PM.

Details

Summary

Added support for mixing monolithic DWARF5 with legacy DWARF, and monolithic legacy and DWARF5 split dwarf.

Diff Detail

Event Timeline

ayermolo created this revision.Jun 20 2022, 4:31 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: hoy, modimo, wenlei. · View Herald Transcript
ayermolo requested review of this revision.Jun 20 2022, 4:31 PM
Herald added a project: Restricted Project. · View Herald Transcript
ayermolo updated this revision to Diff 438502.Jun 20 2022, 5:01 PM

Added check for .debug_line

ayermolo updated this revision to Diff 438539.Jun 20 2022, 8:45 PM

updated test, removed warning

ayermolo updated this revision to Diff 438847.Jun 21 2022, 3:01 PM

Added test for split dwarf.

ayermolo retitled this revision from [BOLT][DWARF] Support mix mode monolithic DWARF to [BOLT][DWARF] Support mix mode DWARF.Jun 21 2022, 3:02 PM
ayermolo edited the summary of this revision. (Show Details)
ayermolo updated this revision to Diff 438857.Jun 21 2022, 3:58 PM

seeing what's in line-str

ayermolo updated this revision to Diff 438863.Jun 21 2022, 4:15 PM

got order wrong

ayermolo updated this revision to Diff 438866.Jun 21 2022, 4:42 PM

changed debug-line checks not to include offsets

maksfb accepted this revision.Jun 28 2022, 6:00 PM
maksfb added inline comments.
bolt/test/X86/dwarf5-dwarf4-monolithic.test
9

nit

bolt/test/X86/dwarf5-split-dwarf4-monolithic.test
12 ↗(On Diff #438866)

nit

This revision is now accepted and ready to land.Jun 28 2022, 6:00 PM
ayermolo marked an inline comment as done.Jun 30 2022, 4:26 PM
ayermolo updated this revision to Diff 441550.Jun 30 2022, 4:30 PM

addressed nit

This revision was automatically updated to reflect the committed changes.