This is a follow up patch to support constrained FP in FP16 emulation.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| llvm/test/CodeGen/X86/fp-strict-scalar-cmp-fp16.ll | ||
|---|---|---|
| 8–47 | probably worth adding nounwind to #0 to stop the cfi noise | |
| llvm/lib/Target/X86/X86ISelLowering.cpp | ||
|---|---|---|
| 660 | worth keeping the f32/f64 setOperationAction calls separate? | |
Comment Actions
Address review comments. Thanks Simon!
| llvm/lib/Target/X86/X86ISelLowering.cpp | ||
|---|---|---|
| 660 | Good point! | |
Comment Actions
Ping. I hold for a while in case blocking the base patch been reverted. I think it's stable to go now.
worth keeping the f32/f64 setOperationAction calls separate?