Page MenuHomePhabricator

[analyzer][NFC] Remove dead code and modernize surroundings
ClosedPublic

Authored by steakhal on Jun 15 2022, 2:12 AM.

Details

Summary

Thanks @kazu for helping me clean these parts in D127799.

I'm leaving the dump methods, along with the unused visitor handlers and
the forwarding methods.

The dead parts actually helped to uncover two bugs, to which I'm going
to post separate patches.

Diff Detail

Event Timeline

steakhal created this revision.Jun 15 2022, 2:12 AM
Herald added a project: Restricted Project. · View Herald Transcript
steakhal requested review of this revision.Jun 15 2022, 2:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2022, 2:12 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
martong added inline comments.Jun 15 2022, 4:34 AM
clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
929–930

Why should we keep this?

steakhal updated this revision to Diff 437120.Jun 15 2022, 5:42 AM

remove dead code from MallocChecker

clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
929–930

Accident xD

steakhal marked an inline comment as done.Jun 15 2022, 5:42 AM
martong accepted this revision.Jun 15 2022, 7:01 AM

LGTM

This revision is now accepted and ready to land.Jun 15 2022, 7:01 AM
This revision was landed with ongoing or failed builds.Jun 15 2022, 7:50 AM
This revision was automatically updated to reflect the committed changes.