Depends on D127664
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| llvm/include/llvm/IR/IntrinsicsAMDGPU.td | ||
|---|---|---|
| 1478 | Are you going to submit these builtins separately? | |
| llvm/include/llvm/IR/IntrinsicsAMDGPU.td | ||
|---|---|---|
| 1478 | The __int_* prefix doesn't make much sense. I would suggest either using the tablegen name (int_amdgcn_interp_inreg_p10) or preferably the LLVM IR name (llvm.amdgcn.interp.inreg.p10). | |
| llvm/include/llvm/IR/IntrinsicsAMDGPU.td | ||
|---|---|---|
| 1478 |
I will remove the builtin and it can be added later if needed. | |
| 1478 | Done, see | |
| llvm/include/llvm/IR/IntrinsicsAMDGPU.td | ||
|---|---|---|
| 1494 | Wouldn't it be more natural to declare p and p0 to be llvm_v2f16_ty? | |
| llvm/include/llvm/IR/IntrinsicsAMDGPU.td | ||
|---|---|---|
| 1494 | Yes, I think so, but it would require coordinated changes in Mesa and LLPC, and we should probably also provide a v2f16 version of llvm.amdgcn.lds.param.load which currently always returns a float. | |
Are you going to submit these builtins separately?