Page MenuHomePhabricator

[libc++] Remove mention of official support for FreeBSD
AbandonedPublic

Authored by ldionne on Jun 13 2022, 8:34 AM.

Details

Reviewers
dim
Group Reviewers
Restricted Project
Summary

Libc++'s policy is that we only officially support configurations that
we have CI for. This has been instrumental in providing an implementation
of quality while ensuring low friction for contributors.

We've been making an exception for FreeBSD because it has been supported
for a long time and it's an important platform. However, after requesting
FreeBSD CI for more than a year, it is time to stop making an exception
and hold all platforms to the same standards.

This will be committed after branching for LLVM 15 unless FreeBSD CI is
added before then.

Diff Detail

Event Timeline

ldionne created this revision.Jun 13 2022, 8:34 AM
ldionne requested review of this revision.Jun 13 2022, 8:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 8:34 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne added a subscriber: Restricted Project.Jun 13 2022, 8:37 AM

This discussion came up on Discord, and several contributors (including myself) agreed that we needed to treat all platforms fairly with respect to our CI requirement. I actually hope that I'll never commit this change -- this is basically just a way to officially say "let's now prioritize adding CI for FreeBSD". Doing so is really easy and we will be happy to help out (reaching out on Discord is probably easiest).

This discussion came up on Discord, and several contributors (including myself) agreed that we needed to treat all platforms fairly with respect to our CI requirement. I actually hope that I'll never commit this change -- this is basically just a way to officially say "let's now prioritize adding CI for FreeBSD". Doing so is really easy and we will be happy to help out (reaching out on Discord is probably easiest).

+1
It would be really great to have a FreeBSD tested in our CI!

EricWF added a subscriber: EricWF.Jun 13 2022, 9:49 AM

It's worth noting that buildkite supports FreeBSD, so there shouldn't be any fundamental issues trying to add a builder once we have hardware.

It’s also worth pointing out that being off this list doesn’t mean that code for the platforms is ripped out - there’s many platforms that are supported on a best effort basis.

I actually hope that I'll never commit this change

Thank you - this issue is my fault, I promised but have not yet succeeded in providing a FreeBSD CI instance. I'll prioritize getting this done.

I actually hope that I'll never commit this change

Thank you - this issue is my fault, I promised but have not yet succeeded in providing a FreeBSD CI instance. I'll prioritize getting this done.

Awesome, thanks! Reach out via discord or e-mail and I'll give you a BuildKite token. You can see the documentation for adding a new CI job here: https://libcxx.llvm.org/AddingNewCIJobs.html#addingnewcijobs

ldionne abandoned this revision.Jun 23 2022, 12:13 PM

Abandoning because of D128084. @emaste , can you please still work on providing us with an official FreeBSD builder?