This is an archive of the discontinued LLVM Phabricator instance.

[VPlan] Remove dead recipes across whole plan.
ClosedPublic

Authored by fhahn on Jun 11 2022, 3:51 PM.

Details

Summary

This extends removeDeadRecipe to remove recipes across the whole plan.

Diff Detail

Event Timeline

fhahn created this revision.Jun 11 2022, 3:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2022, 3:51 PM
fhahn requested review of this revision.Jun 11 2022, 3:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2022, 3:51 PM
Herald added a subscriber: vkmr. · View Herald Transcript
Ayal accepted this revision.Jun 13 2022, 8:24 AM

Looks good to me!

llvm/lib/Transforms/Vectorize/VPlan.cpp
593

Hmm, bug fix? Is there a test that checks it?

llvm/lib/Transforms/Vectorize/VPlanTransforms.h
52–53

nit: comment seems redundant, remove or extend?

This revision is now accepted and ready to land.Jun 13 2022, 8:24 AM
fhahn updated this revision to Diff 439273.Jun 23 2022, 1:42 AM

Rebase before landing.

fhahn marked 2 inline comments as done.Jun 23 2022, 4:36 AM
fhahn added inline comments.
llvm/lib/Transforms/Vectorize/VPlan.cpp
593

Yes, it is covered by the existing tests. Without it, removeDeadRecipes would now remove branchonmask, which would cause issues.

llvm/lib/Transforms/Vectorize/VPlanTransforms.h
52–53

Removed!

This revision was landed with ongoing or failed builds.Jun 23 2022, 4:36 AM
This revision was automatically updated to reflect the committed changes.
fhahn marked 2 inline comments as done.