This is an archive of the discontinued LLVM Phabricator instance.

Differential D126875

llvm-debuginfo-analyzer - Debug Information Visual Analizer
Needs ReviewPublic

Authored by CarlosAlbertoEnciso on Jun 2 2022, 5:00 AM.

Details

Reviewers
jdoerfert
Summary
NOTE: The purpose of this revision is to provide the LLVM community with a single patch, so llvm-debuginfo-analyzer can be built and try out right away, rather than apply the individual patches that have been uploaded for review.

See https://discourse.llvm.org/t/llvm-dev-rfc-llvm-dva-debug-information-visual-analyzer/62570 for more information.

SN Systems (Sony Interactive Entertainment) GitHub repository: https://github.com/SNSystems/llvm-debuginfo-analyzer

Diff Detail

Unit TestsFailed

TimeTest
20 msx64 debian > LLVM-Unit.DebugInfo/LogicalView/_/DebugInfoLogicalViewTests/0::16
10 msx64 debian > LLVM-Unit.DebugInfo/LogicalView/_/DebugInfoLogicalViewTests/15::16
10 msx64 debian > LLVM-Unit.DebugInfo/LogicalView/_/DebugInfoLogicalViewTests/2::16
130 msx64 debian > LLVM.tools/llvm-debuginfo-analyzer/COFF::01-coff-compare-logical-elements.test
130 msx64 debian > LLVM.tools/llvm-debuginfo-analyzer/COFF::01-coff-print-basic-details.test
View Full Test Results (21 Failed)

Event Timeline

CarlosAlbertoEnciso created this revision.Jun 2 2022, 5:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2022, 5:00 AM
Herald added subscribers: mstorsjo, arphaman, mgrang and 2 others. · View Herald Transcript
CarlosAlbertoEnciso requested review of this revision.Jun 2 2022, 5:00 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJun 2 2022, 5:00 AM
Herald added subscribers: llvm-commits, sstefan1. · View Herald Transcript
CarlosAlbertoEnciso edited the summary of this revision. (Show Details)Jun 2 2022, 5:05 AM
Harbormaster completed remote builds in B167492: Diff 433713.Jun 2 2022, 5:46 AM
psamolysov added a subscriber: psamolysov.Jun 2 2022, 8:04 AM
CarlosAlbertoEnciso retitled this revision from llvm-dva - Debug Information Visual Analizer to llvm-debuginfo-analyzer - Debug Information Visual Analizer.Aug 9 2022, 11:06 PM
CarlosAlbertoEnciso edited the summary of this revision. (Show Details)
Herald added subscribers: manas, ASDenysPetrov, dkrupp and 4 others. · View Herald TranscriptAug 9 2022, 11:06 PM
CarlosAlbertoEnciso updated this revision to Diff 451357.Aug 9 2022, 11:12 PM

Uploaded a new single patch that:

  • Addressed the reviewer’s feedback.
  • Tool renamed as: llvm-debuginfo-analyzer.
Harbormaster completed remote builds in B180314: Diff 451357.Aug 9 2022, 11:46 PM
CarlosAlbertoEnciso updated this revision to Diff 454471.Aug 22 2022, 5:48 AM

This updated patch solves the issues described in https://github.com/llvm/llvm-project/issues/57040

  • Incorrect function comparision.
  • Missing parameter line information.
Herald added a subscriber: ormris. · View Herald TranscriptAug 22 2022, 5:48 AM
Harbormaster completed remote builds in B182571: Diff 454471.Aug 22 2022, 7:25 AM
CarlosAlbertoEnciso edited the summary of this revision. (Show Details)Aug 24 2022, 10:33 PM
chrisjackson added a subscriber: chrisjackson.Oct 27 2022, 7:51 AM

Large Diff

This large diff affects 118 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
llvm/
docs/
CommandGuide/
1 line
1962 lines
12 lines
include/
llvm/
ADT/
685 lines
DebugInfo/
DWARF/
5 lines
5 lines
12 lines
LogicalView/
Core/
91 lines
369 lines
163 lines
202 lines
358 lines
655 lines
102 lines
234 lines
827 lines
51 lines
101 lines
289 lines
195 lines
289 lines
105 lines
Readers/
208 lines
238 lines
481 lines
159 lines
lib/
DebugInfo/
1 line
DWARF/
16 lines
2 lines
15 lines
LogicalView/
52 lines
Core/
422 lines
568 lines
201 lines
674 lines
169 lines
576 lines
150 lines
303 lines
2121 lines
113 lines
166 lines
448 lines
528 lines
21 lines
324 lines
Readers/
895 lines
1233 lines
3530 lines
1231 lines
PDB/
Native/
4 lines
test/
1 line
1 line
tools/
llvm-debuginfo-analyzer/
COFF/
101 lines
63 lines
68 lines
54 lines
105 lines
135 lines
95 lines
97 lines
Inputs/
DWARF/
101 lines
67 lines
71 lines
63 lines
124 lines
124 lines
108 lines
105 lines
Inputs/
65 lines
142 lines
221 lines
tools/
llvm-debuginfo-analyzer/
19 lines
21 lines
81 lines
501 lines
141 lines
unittests/
ADT/
1 line
1530 lines
DebugInfo/
1 line
LogicalView/
21 lines
475 lines
276 lines
450 lines
342 lines
Inputs/
345 lines
342 lines
399 lines
60 lines
558 lines

Diff 454471

llvm/docs/CommandGuide/index.rst

llvm/docs/CommandGuide/llvm-debuginfo-analyzer.rst

llvm/docs/ProgrammersManual.rst

llvm/include/llvm/ADT/IntervalTree.h

llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLine.h

llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h

llvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h

llvm/include/llvm/DebugInfo/LogicalView/Core/LVCompare.h

llvm/include/llvm/DebugInfo/LogicalView/Core/LVElement.h

llvm/include/llvm/DebugInfo/LogicalView/Core/LVLine.h

llvm/include/llvm/DebugInfo/LogicalView/Core/LVLocation.h

llvm/include/llvm/DebugInfo/LogicalView/Core/LVObject.h

llvm/include/llvm/DebugInfo/LogicalView/Core/LVOptions.h

llvm/include/llvm/DebugInfo/LogicalView/Core/LVRange.h

llvm/include/llvm/DebugInfo/LogicalView/Core/LVReader.h

llvm/include/llvm/DebugInfo/LogicalView/Core/LVScope.h

llvm/include/llvm/DebugInfo/LogicalView/Core/LVSort.h

llvm/include/llvm/DebugInfo/LogicalView/Core/LVStringPool.h

llvm/include/llvm/DebugInfo/LogicalView/Core/LVSupport.h

llvm/include/llvm/DebugInfo/LogicalView/Core/LVSymbol.h

llvm/include/llvm/DebugInfo/LogicalView/Core/LVType.h

llvm/include/llvm/DebugInfo/LogicalView/LVReaderHandler.h

llvm/include/llvm/DebugInfo/LogicalView/Readers/LVBinaryReader.h

llvm/include/llvm/DebugInfo/LogicalView/Readers/LVCodeViewReader.h

llvm/include/llvm/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.h

llvm/include/llvm/DebugInfo/LogicalView/Readers/LVELFReader.h

llvm/lib/DebugInfo/CMakeLists.txt

llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp

llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp

llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp

llvm/lib/DebugInfo/LogicalView/CMakeLists.txt

llvm/lib/DebugInfo/LogicalView/Core/LVCompare.cpp

llvm/lib/DebugInfo/LogicalView/Core/LVElement.cpp

llvm/lib/DebugInfo/LogicalView/Core/LVLine.cpp

llvm/lib/DebugInfo/LogicalView/Core/LVLocation.cpp

llvm/lib/DebugInfo/LogicalView/Core/LVObject.cpp

llvm/lib/DebugInfo/LogicalView/Core/LVOptions.cpp

llvm/lib/DebugInfo/LogicalView/Core/LVRange.cpp

llvm/lib/DebugInfo/LogicalView/Core/LVReader.cpp

llvm/lib/DebugInfo/LogicalView/Core/LVScope.cpp

llvm/lib/DebugInfo/LogicalView/Core/LVSort.cpp

llvm/lib/DebugInfo/LogicalView/Core/LVSupport.cpp

llvm/lib/DebugInfo/LogicalView/Core/LVSymbol.cpp

llvm/lib/DebugInfo/LogicalView/Core/LVType.cpp

llvm/lib/DebugInfo/LogicalView/LLVMBuild.txt

llvm/lib/DebugInfo/LogicalView/LVReaderHandler.cpp

llvm/lib/DebugInfo/LogicalView/Readers/LVBinaryReader.cpp

llvm/lib/DebugInfo/LogicalView/Readers/LVCodeViewReader.cpp

llvm/lib/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.cpp

llvm/lib/DebugInfo/LogicalView/Readers/LVELFReader.cpp

llvm/lib/DebugInfo/PDB/Native/DbiModuleList.cpp

llvm/test/CMakeLists.txt

llvm/test/lit.cfg.py

llvm/test/tools/llvm-debuginfo-analyzer/COFF/01-coff-compare-logical-elements.test

llvm/test/tools/llvm-debuginfo-analyzer/COFF/01-coff-print-basic-details.test

llvm/test/tools/llvm-debuginfo-analyzer/COFF/01-coff-select-logical-elements.test

llvm/test/tools/llvm-debuginfo-analyzer/COFF/02-coff-logical-lines.test

llvm/test/tools/llvm-debuginfo-analyzer/COFF/03-coff-incorrect-lexical-scope-typedef.test

llvm/test/tools/llvm-debuginfo-analyzer/COFF/04-coff-missing-nested-enumerators.test

llvm/test/tools/llvm-debuginfo-analyzer/COFF/05-coff-incorrect-lexical-scope-variable.test

llvm/test/tools/llvm-debuginfo-analyzer/COFF/06-coff-full-logical-view.test

llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/hello-world-codeview-clang.o

llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/hello-world-codeview-msvc.o

llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/pr-43860-codeview-clang.o

llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/pr-43860-codeview-msvc.o

llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/pr-44884-codeview-clang.o

llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/pr-44884-codeview-msvc.o

llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/pr-46466-codeview-clang.o

llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/pr-46466-codeview-msvc.o

llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/test-codeview-clang.o

llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/test-codeview-msvc.o

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/01-dwarf-compare-logical-elements.test

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/01-dwarf-print-basic-details.test

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/01-dwarf-select-logical-elements.test

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/02-dwarf-logical-lines.test

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/03-dwarf-incorrect-lexical-scope-typedef.test

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/04-dwarf-missing-nested-enumerators.test

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/05-dwarf-incorrect-lexical-scope-variable.test

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/06-dwarf-full-logical-view.test

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/Inputs/hello-world-dwarf-clang.o

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/Inputs/hello-world-dwarf-gcc.o

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/Inputs/pr-43860-dwarf-clang.o

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/Inputs/pr-43860-dwarf-gcc.o

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/Inputs/pr-44884-dwarf-clang.o

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/Inputs/pr-44884-dwarf-gcc.o

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/Inputs/pr-46466-dwarf-clang.o

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/Inputs/pr-46466-dwarf-gcc.o

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/Inputs/pr-57040-test-dwarf-clang.o

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/Inputs/pr-57040-test-dwarf-gcc.o

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/Inputs/test-dwarf-clang.o

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/Inputs/test-dwarf-gcc.o

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/pr-57040-ignored-DW_FORM_implicit_const.test

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/pr-57040-incorrect-function-compare.test

llvm/test/tools/llvm-debuginfo-analyzer/cmdline.test

llvm/tools/llvm-debuginfo-analyzer/CMakeLists.txt

llvm/tools/llvm-debuginfo-analyzer/LLVMBuild.txt

llvm/tools/llvm-debuginfo-analyzer/Options.h

llvm/tools/llvm-debuginfo-analyzer/Options.cpp

llvm/tools/llvm-debuginfo-analyzer/llvm-debuginfo-analyzer.cpp

llvm/unittests/ADT/CMakeLists.txt

llvm/unittests/ADT/IntervalTreeTest.cpp

llvm/unittests/DebugInfo/CMakeLists.txt

llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt

llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp

llvm/unittests/DebugInfo/LogicalView/CommandLineOptionsTest.cpp

llvm/unittests/DebugInfo/LogicalView/CompareElementsTest.cpp

llvm/unittests/DebugInfo/LogicalView/ELFReaderTest.cpp

llvm/unittests/DebugInfo/LogicalView/Inputs/test-codeview-clang.o

llvm/unittests/DebugInfo/LogicalView/Inputs/test-codeview-msvc.o

llvm/unittests/DebugInfo/LogicalView/Inputs/test-codeview-pdb-msvc-.pdb

llvm/unittests/DebugInfo/LogicalView/Inputs/test-codeview-pdb-msvc.o

llvm/unittests/DebugInfo/LogicalView/Inputs/test-dwarf-clang.o

llvm/unittests/DebugInfo/LogicalView/Inputs/test-dwarf-gcc.o

llvm/unittests/DebugInfo/LogicalView/LocationRangesTest.cpp

llvm/unittests/DebugInfo/LogicalView/LogicalElementsTest.cpp

llvm/unittests/DebugInfo/LogicalView/SelectElementsTest.cpp

llvm/unittests/DebugInfo/LogicalView/StringPoolTest.cpp

llvm/unittests/DebugInfo/LogicalView/WarningInternalTest.cpp