This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Return an invalid cost for memory ops with unsupported types
AbandonedPublic

Authored by Miss_Grape on May 25 2022, 8:05 PM.

Diff Detail

Event Timeline

Miss_Grape created this revision.May 25 2022, 8:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2022, 8:05 PM
Miss_Grape requested review of this revision.May 25 2022, 8:05 PM

Maybe we can not return invalid costs. Just reference D123799.

With no knowledge of how this side of things works, you at least need tests

reames requested changes to this revision.Aug 18 2022, 10:53 AM
reames added a subscriber: reames.

This patch does not meet basic standards.

  • It has no explanation of intent.
  • It has no tests.
  • The code change itself seems nonsensical.

Phabricator doesn't give a way to hard reject, so marking as Request Changes and removing myself as reviewer.

This revision now requires changes to proceed.Aug 18 2022, 10:53 AM
reames resigned from this revision.Aug 18 2022, 10:53 AM
This revision now requires review to proceed.Aug 18 2022, 10:53 AM
Miss_Grape abandoned this revision.Jan 4 2023, 6:15 PM