This is to avoid err_target_unknown_abi which is caused by use default TargetTriple instead of shader model target triple.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/lib/Driver/ToolChains/HLSL.h | ||
---|---|---|
32–33 | I don't like using an empty string as a sentinel for an error. Since this is no longer overriding an existing method, we should change it. Probably the easiest change is to llvm::Optional. Then you can return None in the failure cases. |
clang/lib/Driver/Driver.cpp | ||
---|---|---|
1242 | The -T flag is required for DXCMode, so the else of this should emit an error. That also means the code above that explicitly sets the OS to ShaderModel can be removed too. |