Page MenuHomePhabricator

python3kgae (Xiang Li)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 4 2021, 7:05 PM (76 w, 5 d)

Recent Activity

Yesterday

python3kgae requested review of D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments.
Sat, Mar 25, 10:31 PM · Restricted Project, Restricted Project

Fri, Mar 10

python3kgae updated the diff for D144659: [DirectX backend] remove hlsl.* FnAttr after use..

Avoid send EntryAttr as input parameter for EntryProps constructor.

Fri, Mar 10, 12:53 PM · Restricted Project, Restricted Project

Mon, Mar 6

python3kgae added inline comments to D144659: [DirectX backend] remove hlsl.* FnAttr after use..
Mon, Mar 6, 1:58 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D144659: [DirectX backend] remove hlsl.* FnAttr after use..

Remove hlsl attr in DXILTranslateMetadata.

Mon, Mar 6, 8:04 AM · Restricted Project, Restricted Project

Thu, Mar 2

python3kgae accepted D144309: [HLSL] add max/min library functions.
Thu, Mar 2, 4:05 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D144309: [HLSL] add max/min library functions.
Thu, Mar 2, 1:41 PM · Restricted Project, Restricted Project
python3kgae added a comment to D144309: [HLSL] add max/min library functions.
  • ushort is now unsigned
Thu, Mar 2, 11:45 AM · Restricted Project, Restricted Project

Mon, Feb 27

python3kgae added a comment to D144309: [HLSL] add max/min library functions.

add int support for max/min.

Mon, Feb 27, 3:52 PM · Restricted Project, Restricted Project
python3kgae added a comment to D144309: [HLSL] add max/min library functions.

max/min does work on integers in HLSL.
And __builtin_elementwise_max/min support both integers and floats.

Mon, Feb 27, 12:23 PM · Restricted Project, Restricted Project

Sun, Feb 26

python3kgae added inline comments to D144802: clang: Add __builtin_elementwise_round.
Sun, Feb 26, 8:23 PM · Restricted Project

Feb 23 2023

python3kgae updated the diff for D144659: [DirectX backend] remove hlsl.* FnAttr after use..

Fix format.

Feb 23 2023, 12:24 PM · Restricted Project, Restricted Project
python3kgae requested review of D144659: [DirectX backend] remove hlsl.* FnAttr after use..
Feb 23 2023, 11:04 AM · Restricted Project, Restricted Project

Feb 15 2023

python3kgae accepted D144120: [HLSL] add log library functions.

LGTM.
Just fix the newline at end of file for the tests.

Feb 15 2023, 6:48 PM · Restricted Project, Restricted Project

Feb 13 2023

python3kgae added inline comments to D143854: [DirectX backend] remove string function attribute and unused module flags.
Feb 13 2023, 9:52 AM · Restricted Project, Restricted Project
python3kgae updated the diff for D143854: [DirectX backend] remove string function attribute and unused module flags.

Only keep debug related module flags which are used by DXIL.
Also let DXILPrepare pass preserve DXILResourceWrapper which is used in asm dump pass for test.

Feb 13 2023, 9:51 AM · Restricted Project, Restricted Project
python3kgae committed rGcc4fb5837647: [mlir] support complex type in DenseElementsAttr::get. (authored by python3kgae).
[mlir] support complex type in DenseElementsAttr::get.
Feb 13 2023, 6:41 AM · Restricted Project, Restricted Project
python3kgae closed D143848: [mlir] support complex type in DenseElementsAttr::get..
Feb 13 2023, 6:41 AM · Restricted Project, Restricted Project

Feb 12 2023

python3kgae updated the diff for D143848: [mlir] support complex type in DenseElementsAttr::get..

Update to fix issues mentioned in comments.

Feb 12 2023, 4:12 PM · Restricted Project, Restricted Project
python3kgae requested review of D143854: [DirectX backend] remove string function attribute and unused module flags.
Feb 12 2023, 12:16 PM · Restricted Project, Restricted Project
python3kgae requested review of D143848: [mlir] support complex type in DenseElementsAttr::get..
Feb 12 2023, 9:20 AM · Restricted Project, Restricted Project

Feb 8 2023

python3kgae abandoned D143518: [DirectX backend] add pass to collect Resource information from dxil metadata..
 void getAnalysisUsage(AnalysisUsage &AU) const override {
  AU.addPreserved<DXILResourceWrapper>();
}

to DXILPrepareModule resolved the issue.

Feb 8 2023, 6:47 AM · Restricted Project, Restricted Project

Feb 7 2023

python3kgae requested review of D143518: [DirectX backend] add pass to collect Resource information from dxil metadata..
Feb 7 2023, 10:12 AM · Restricted Project, Restricted Project

Feb 3 2023

python3kgae accepted D143239: [mlir] remove StringMap to make -view-op-graph attr order deterministic.
Feb 3 2023, 4:50 AM · Restricted Project, Restricted Project

Feb 2 2023

python3kgae added inline comments to D143239: [mlir] remove StringMap to make -view-op-graph attr order deterministic.
Feb 2 2023, 7:51 PM · Restricted Project, Restricted Project
python3kgae added a comment to D143207: Add codegen for llvm log2/log10 elementwise builtins.

Add log2 together?
They're in same category.

Feb 2 2023, 4:43 PM · Restricted Project, Restricted Project
python3kgae committed rG09ba3248aedd: [NFC] [mlir] fix file header for SCFToControlFlow.h (authored by python3kgae).
[NFC] [mlir] fix file header for SCFToControlFlow.h
Feb 2 2023, 7:14 AM · Restricted Project, Restricted Project

Feb 1 2023

python3kgae accepted D143130: [DX] Add support for PSV resource bindings.
Feb 1 2023, 7:59 PM · Restricted Project, Restricted Project
python3kgae committed rGd5a7439e220c: [HLSL] [Dirver] add dxv as a VerifyDebug Job (authored by python3kgae).
[HLSL] [Dirver] add dxv as a VerifyDebug Job
Feb 1 2023, 5:23 PM · Restricted Project, Restricted Project
python3kgae closed D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.
Feb 1 2023, 5:23 PM · Restricted Project, Restricted Project
python3kgae accepted D141649: [DX] Begin adding support for pipeline state.

LGTM.
Will next PR add resource support?

Feb 1 2023, 4:35 PM · Restricted Project, Restricted Project

Jan 31 2023

python3kgae committed rGe1af75572d3a: [mlir] return nullopt for getNeutralElement (authored by python3kgae).
[mlir] return nullopt for getNeutralElement
Jan 31 2023, 10:47 PM · Restricted Project, Restricted Project
python3kgae closed D142945: [mlir] return nullopt for getNeutralElement.
Jan 31 2023, 10:47 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D142945: [mlir] return nullopt for getNeutralElement.

rebase.

Jan 31 2023, 10:11 PM · Restricted Project, Restricted Project

Jan 30 2023

python3kgae requested review of D142945: [mlir] return nullopt for getNeutralElement.
Jan 30 2023, 5:41 PM · Restricted Project, Restricted Project
python3kgae committed rG7b182d788e7b: [mlir] use getNumDimAndSymbolVars when iterate dims/symbols of… (authored by python3kgae).
[mlir] use getNumDimAndSymbolVars when iterate dims/symbols of…
Jan 30 2023, 6:16 AM · Restricted Project, Restricted Project
python3kgae closed D142851: [mlir] use getNumDimAndSymbolVars when iterate dims/symbols of FlatAffineValueConstraints.
Jan 30 2023, 6:16 AM · Restricted Project, Restricted Project
python3kgae updated the diff for D142851: [mlir] use getNumDimAndSymbolVars when iterate dims/symbols of FlatAffineValueConstraints.

Move test to correct place.

Jan 30 2023, 6:04 AM · Restricted Project, Restricted Project

Jan 29 2023

python3kgae committed rG28f9bfe466b0: [mlir] skip 0-D vector in BubbleUpBitCastForStridedSliceInsert (authored by python3kgae).
[mlir] skip 0-D vector in BubbleUpBitCastForStridedSliceInsert
Jan 29 2023, 8:21 PM · Restricted Project, Restricted Project
python3kgae closed D142319: [mlir] skip 0-D vector in BubbleUpBitCastForStridedSliceInsert.
Jan 29 2023, 8:21 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D142319: [mlir] skip 0-D vector in BubbleUpBitCastForStridedSliceInsert.
Jan 29 2023, 5:59 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D142319: [mlir] skip 0-D vector in BubbleUpBitCastForStridedSliceInsert.

Fix wrong history.

Jan 29 2023, 5:57 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D142319: [mlir] skip 0-D vector in BubbleUpBitCastForStridedSliceInsert.

Move test to vector-transforms.mlir

Jan 29 2023, 5:43 PM · Restricted Project, Restricted Project
python3kgae added a comment to D142319: [mlir] skip 0-D vector in BubbleUpBitCastForStridedSliceInsert.

ping.

Jan 29 2023, 3:18 PM · Restricted Project, Restricted Project
python3kgae requested review of D142851: [mlir] use getNumDimAndSymbolVars when iterate dims/symbols of FlatAffineValueConstraints.
Jan 29 2023, 3:15 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.
Jan 29 2023, 2:13 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.

add space for warning message.

Jan 29 2023, 2:12 PM · Restricted Project, Restricted Project

Jan 27 2023

python3kgae added inline comments to D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.
Jan 27 2023, 4:04 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.

Fix windows test fail.

Jan 27 2023, 4:03 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.
Jan 27 2023, 3:48 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.

rename to requiresValidation.

Jan 27 2023, 3:46 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.
Jan 27 2023, 3:28 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.
Jan 27 2023, 3:03 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.

switch to getDefaultToolChain.

Jan 27 2023, 3:02 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.

cast ToolChain to HLSLToolChain.

Jan 27 2023, 1:31 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.
Jan 27 2023, 1:30 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.
Jan 27 2023, 12:57 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.
Jan 27 2023, 12:12 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.

add DX_CONTAINER Driver type.
Code cleanup.

Jan 27 2023, 12:10 PM · Restricted Project, Restricted Project

Jan 26 2023

python3kgae added reviewers for D141705: [HLSL] [Dirver] add dxv as a Driver Action Job: MaskRay, jansvoboda11.
Jan 26 2023, 1:58 PM · Restricted Project, Restricted Project
python3kgae added a comment to D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.

I'm not overly familiar with HLSL or DirectX here. Most of the changes are purely mechanical, but I don't see anywhere we create the tool. Does that come later? Normally you'd test these with -ccc-print-bindings, -ccc-print-bindings, and -###.

Jan 26 2023, 1:57 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.

Only create dxv job when 'dxv' exist.
Test ccc-print-bindings.
Code cleanup.

Jan 26 2023, 1:55 PM · Restricted Project, Restricted Project
python3kgae added reviewers for D141705: [HLSL] [Dirver] add dxv as a Driver Action Job: jdoerfert, gregrodgers, JonChesterfield, ronlieb, jhuber6.
Jan 26 2023, 7:32 AM · Restricted Project, Restricted Project

Jan 25 2023

python3kgae committed rG4ef085c57210: [mlir] fix crash when call a function decl (authored by python3kgae).
[mlir] fix crash when call a function decl
Jan 25 2023, 8:08 AM · Restricted Project, Restricted Project
python3kgae closed D142544: [mlir] fix crash when call a function decl.
Jan 25 2023, 8:08 AM · Restricted Project, Restricted Project
python3kgae requested review of D142544: [mlir] fix crash when call a function decl.
Jan 25 2023, 7:28 AM · Restricted Project, Restricted Project
python3kgae committed rG2ecf2c0df7cb: [mlir][doc] Fix syntax for affine.dam_wait (authored by python3kgae).
[mlir][doc] Fix syntax for affine.dam_wait
Jan 25 2023, 6:15 AM · Restricted Project, Restricted Project
python3kgae closed D141887: [mlir][doc] Fix syntax for affine.dam_wait.
Jan 25 2023, 6:15 AM · Restricted Project, Restricted Project
python3kgae added a comment to D141887: [mlir][doc] Fix syntax for affine.dam_wait.

ping

Jan 25 2023, 6:01 AM · Restricted Project, Restricted Project

Jan 23 2023

python3kgae added inline comments to D142324: [mlir] allow empty region in transform::SequenceOp::getEffects.
Jan 23 2023, 9:27 PM · Restricted Project, Restricted Project
python3kgae committed rGc3728d28821e: [mlir] support !shape.value_shape when replace WithOp in… (authored by python3kgae).
[mlir] support !shape.value_shape when replace WithOp in…
Jan 23 2023, 7:36 PM · Restricted Project, Restricted Project
python3kgae closed D142275: [mlir] support !shape.value_shape when replace WithOp in OutlineShapeComputationPass..
Jan 23 2023, 7:36 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D142275: [mlir] support !shape.value_shape when replace WithOp in OutlineShapeComputationPass..

Fix clang-format missed by arc lint

Jan 23 2023, 7:14 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D142295: [mlir] support unsigned int in mlir::spirv::ConstantOp::getAsmResultNames.
Jan 23 2023, 7:00 PM · Restricted Project, Restricted Project
python3kgae committed rG365ce62df222: [mlir] support unsigned int in mlir::spirv::ConstantOp::getAsmResultNames (authored by python3kgae).
[mlir] support unsigned int in mlir::spirv::ConstantOp::getAsmResultNames
Jan 23 2023, 9:07 AM · Restricted Project, Restricted Project
python3kgae closed D142295: [mlir] support unsigned int in mlir::spirv::ConstantOp::getAsmResultNames.
Jan 23 2023, 9:07 AM · Restricted Project, Restricted Project
python3kgae committed rG9451572ade3c: [mlir] add RemoveConstantIfCondition to populateOpenACCToSCFConversionPatterns (authored by python3kgae).
[mlir] add RemoveConstantIfCondition to populateOpenACCToSCFConversionPatterns
Jan 23 2023, 7:12 AM · Restricted Project, Restricted Project
python3kgae closed D142286: [mlir] add RemoveConstantIfCondition to populateOpenACCToSCFConversionPatterns.
Jan 23 2023, 7:12 AM · Restricted Project, Restricted Project

Jan 22 2023

python3kgae requested review of D142324: [mlir] allow empty region in transform::SequenceOp::getEffects.
Jan 22 2023, 8:31 PM · Restricted Project, Restricted Project
python3kgae requested review of D142319: [mlir] skip 0-D vector in BubbleUpBitCastForStridedSliceInsert.
Jan 22 2023, 3:14 PM · Restricted Project, Restricted Project

Jan 21 2023

python3kgae requested review of D142295: [mlir] support unsigned int in mlir::spirv::ConstantOp::getAsmResultNames.
Jan 21 2023, 7:27 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D142286: [mlir] add RemoveConstantIfCondition to populateOpenACCToSCFConversionPatterns.

Do RemoveConstantIfCondition in ExpandIfCondition for constant if cond.

Jan 21 2023, 1:39 PM · Restricted Project, Restricted Project
python3kgae added a comment to D142286: [mlir] add RemoveConstantIfCondition to populateOpenACCToSCFConversionPatterns.

Could just inverse the condition and return failure()?

Not sure which path you're talking about :(

change assert(op.getIfCond() && "expected Op with IfCond"); to

if (!op.getIfCond())
  return failure();

or
add back the check ifCond as constant like
if (op.getIfCond().template getDefiningOp<arith::ConstantOp>())

return failure();

Or both?

Jan 21 2023, 1:06 PM · Restricted Project, Restricted Project
python3kgae added a comment to D142286: [mlir] add RemoveConstantIfCondition to populateOpenACCToSCFConversionPatterns.

Could just inverse the condition and return failure()?

Jan 21 2023, 12:47 PM · Restricted Project, Restricted Project
python3kgae added a comment to D142286: [mlir] add RemoveConstantIfCondition to populateOpenACCToSCFConversionPatterns.

Why creating an op if we know we don't need it?

Jan 21 2023, 11:19 AM · Restricted Project, Restricted Project
python3kgae requested review of D142286: [mlir] add RemoveConstantIfCondition to populateOpenACCToSCFConversionPatterns.
Jan 21 2023, 8:38 AM · Restricted Project, Restricted Project
python3kgae added inline comments to D142275: [mlir] support !shape.value_shape when replace WithOp in OutlineShapeComputationPass..
Jan 21 2023, 7:02 AM · Restricted Project, Restricted Project
python3kgae updated the diff for D142275: [mlir] support !shape.value_shape when replace WithOp in OutlineShapeComputationPass..

add comments about the transform.

Jan 21 2023, 7:01 AM · Restricted Project, Restricted Project

Jan 20 2023

python3kgae requested review of D142275: [mlir] support !shape.value_shape when replace WithOp in OutlineShapeComputationPass..
Jan 20 2023, 10:52 PM · Restricted Project, Restricted Project
python3kgae committed rG16f8d17f7bd8: [mlir] Add "memref::MemRefDialect" as dependentDialects for… (authored by python3kgae).
[mlir] Add "memref::MemRefDialect" as dependentDialects for…
Jan 20 2023, 11:20 AM · Restricted Project, Restricted Project
python3kgae closed D141987: [mlir] Add "memref::MemRefDialect" as dependentDialects for GpuToLLVMConversionPass.
Jan 20 2023, 11:20 AM · Restricted Project, Restricted Project
python3kgae updated the diff for D141987: [mlir] Add "memref::MemRefDialect" as dependentDialects for GpuToLLVMConversionPass.

rebase to get stable_sort fix

Jan 20 2023, 8:37 AM · Restricted Project, Restricted Project
python3kgae committed rGee3c6de722e7: [mlir] use stable_sort for OperationLegalizer::computeOpLegalizationDepth (authored by python3kgae).
[mlir] use stable_sort for OperationLegalizer::computeOpLegalizationDepth
Jan 20 2023, 8:33 AM · Restricted Project, Restricted Project
python3kgae closed D142110: [mlir] use stable_sort for OperationLegalizer::computeOpLegalizationDepth.
Jan 20 2023, 8:33 AM · Restricted Project, Restricted Project

Jan 19 2023

python3kgae added a comment to D141987: [mlir] Add "memref::MemRefDialect" as dependentDialects for GpuToLLVMConversionPass.

Create https://reviews.llvm.org/D142110 for the non-determinism between windows and linux.

Jan 19 2023, 6:24 AM · Restricted Project, Restricted Project
python3kgae requested review of D142110: [mlir] use stable_sort for OperationLegalizer::computeOpLegalizationDepth.
Jan 19 2023, 6:23 AM · Restricted Project, Restricted Project
python3kgae added a comment to D141987: [mlir] Add "memref::MemRefDialect" as dependentDialects for GpuToLLVMConversionPass.

Does one of the patterns actually has a higher benefit value? Or do they have the default value and one just happens to be selected instead of the other? In the latter case, it sounds like there is some non-determinism involved (e.g., something stored in a hashmap) that is exposed by platform differences.

Jan 19 2023, 5:47 AM · Restricted Project, Restricted Project

Jan 18 2023

python3kgae added a comment to D141987: [mlir] Add "memref::MemRefDialect" as dependentDialects for GpuToLLVMConversionPass.

Both VectorStoreToMemrefStoreLowering and VectorLoadStoreConversion<mlir::vector::StoreOp, mlir::vector::StoreOpAdaptor> are added to legalize vector.store.
On windows, VectorLoadStoreConversion has higher benefit, so it does not crash.
And on linux, VectorStoreToMemrefStoreLowering has higher benefit, and memref.store is not resisted, so it will crash.

Jan 18 2023, 9:48 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D136913: [HLSL] support RWByteAddressBuffer..

Rebase and update test.

Jan 18 2023, 1:04 PM · Restricted Project, Restricted Project
python3kgae retitled D141705: [HLSL] [Dirver] add dxv as a Driver Action Job from [HLSL] [Dirver] add dxv as a VerifyDebug Job to [HLSL] [Dirver] add dxv as a Driver Action Job.
Jan 18 2023, 12:27 PM · Restricted Project, Restricted Project
python3kgae added a comment to D136031: [DirectX backend] support ConstantBuffer to DXILResource.h.

@python3kgae, this change introduced a bunch of warning spew because it is using an API that was deprecated shortly before the change merged. Can you please address this?

Jan 18 2023, 10:07 AM · Restricted Project, Restricted Project, Restricted Project