Page MenuHomePhabricator

python3kgae (Xiang Li)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 4 2021, 7:05 PM (37 w, 6 d)

Recent Activity

Yesterday

python3kgae added inline comments to D128569: Start support for HLSL `RWBuffer`.
Sat, Jun 25, 5:38 AM · Restricted Project, Restricted Project

Thu, Jun 23

python3kgae requested review of D128462: [HLSL] add -I option for dxc mode..
Thu, Jun 23, 2:07 PM · Restricted Project, Restricted Project
python3kgae committed rG77f72ac15bca: [HLSL] Enable half type for hlsl. (authored by python3kgae).
[HLSL] Enable half type for hlsl.
Thu, Jun 23, 12:56 PM · Restricted Project, Restricted Project
python3kgae closed D124790: [HLSL] Enable half type for hlsl..
Thu, Jun 23, 12:56 PM · Restricted Project, Restricted Project
python3kgae added a comment to D124790: [HLSL] Enable half type for hlsl..

Thanks for the review.
Updated the comments.

Thu, Jun 23, 10:52 AM · Restricted Project, Restricted Project
python3kgae updated the diff for D124790: [HLSL] Enable half type for hlsl..

Cleanup comments.

Thu, Jun 23, 10:52 AM · Restricted Project, Restricted Project

Wed, Jun 22

python3kgae committed rG73ebb05e4423: [DirectX] Support opaque ptr for ValueAsMetadata in DXILBitcodeWriter (authored by python3kgae).
[DirectX] Support opaque ptr for ValueAsMetadata in DXILBitcodeWriter
Wed, Jun 22, 9:11 AM · Restricted Project, Restricted Project
python3kgae closed D127705: [DirectX] Support opaque ptr for ValueAsMetadata in DXILBitcodeWriter.
Wed, Jun 22, 9:10 AM · Restricted Project, Restricted Project
python3kgae added inline comments to D127705: [DirectX] Support opaque ptr for ValueAsMetadata in DXILBitcodeWriter.
Wed, Jun 22, 6:26 AM · Restricted Project, Restricted Project
python3kgae updated the diff for D127705: [DirectX] Support opaque ptr for ValueAsMetadata in DXILBitcodeWriter.

Update regex to cover more cases.

Wed, Jun 22, 6:24 AM · Restricted Project, Restricted Project

Sun, Jun 19

python3kgae updated the summary of D124790: [HLSL] Enable half type for hlsl..
Sun, Jun 19, 3:43 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D124790: [HLSL] Enable half type for hlsl..

Change CXXABI to Microsoft to match dxc behavior.
The mangle name for half is "$f16@" when half is treat as native half type and "$halff@" when treat as float.

Sun, Jun 19, 3:40 PM · Restricted Project, Restricted Project

Fri, Jun 17

python3kgae accepted D127166: [DirectX] Add DirectX target object writer.
Fri, Jun 17, 11:28 AM · Restricted Project, Restricted Project
python3kgae added inline comments to D127166: [DirectX] Add DirectX target object writer.
Fri, Jun 17, 10:53 AM · Restricted Project, Restricted Project
python3kgae added inline comments to D127166: [DirectX] Add DirectX target object writer.
Fri, Jun 17, 9:02 AM · Restricted Project, Restricted Project
python3kgae added inline comments to D127166: [DirectX] Add DirectX target object writer.
Fri, Jun 17, 8:59 AM · Restricted Project, Restricted Project

Thu, Jun 16

python3kgae committed rG0d2dde20be14: [TableGen][DirectX] generate DXIL operation table with TableGen. (authored by python3kgae).
[TableGen][DirectX] generate DXIL operation table with TableGen.
Thu, Jun 16, 11:26 PM · Restricted Project, Restricted Project
python3kgae closed D125520: [TableGen][DirectX] generate DXIL operation table with TableGen..
Thu, Jun 16, 11:26 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D125520: [TableGen][DirectX] generate DXIL operation table with TableGen..

Update to make arc happy to land.

Thu, Jun 16, 11:25 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D125520: [TableGen][DirectX] generate DXIL operation table with TableGen..

Fix warning.

Thu, Jun 16, 3:46 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D128012: [HLSL] Add ExternalSemaSource & vector alias.
Thu, Jun 16, 3:20 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D124790: [HLSL] Enable half type for hlsl..
Thu, Jun 16, 2:46 PM · Restricted Project, Restricted Project
python3kgae reopened D125520: [TableGen][DirectX] generate DXIL operation table with TableGen..
Thu, Jun 16, 2:39 PM · Restricted Project, Restricted Project
python3kgae committed rG46fcdf23640e: [TableGen][DirectX] generate DXIL operation table with TableGen. (authored by python3kgae).
[TableGen][DirectX] generate DXIL operation table with TableGen.
Thu, Jun 16, 1:39 PM · Restricted Project, Restricted Project
python3kgae closed D125520: [TableGen][DirectX] generate DXIL operation table with TableGen..
Thu, Jun 16, 1:39 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D127990: [DirectX] add thread/group id DXIL operations..

Fix test.

Thu, Jun 16, 12:38 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D125520: [TableGen][DirectX] generate DXIL operation table with TableGen..

Add assert to make sure found the opcode.

Thu, Jun 16, 12:14 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D127990: [DirectX] add thread/group id DXIL operations..
Thu, Jun 16, 11:53 AM · Restricted Project, Restricted Project
python3kgae updated the diff for D127990: [DirectX] add thread/group id DXIL operations..

Use _ for the whole name.

Thu, Jun 16, 11:51 AM · Restricted Project, Restricted Project
python3kgae added inline comments to D127990: [DirectX] add thread/group id DXIL operations..
Thu, Jun 16, 11:12 AM · Restricted Project, Restricted Project
python3kgae updated the diff for D127990: [DirectX] add thread/group id DXIL operations..

Change intrinsic start with lower case.

Thu, Jun 16, 11:11 AM · Restricted Project, Restricted Project
python3kgae requested review of D127990: [DirectX] add thread/group id DXIL operations..
Thu, Jun 16, 10:52 AM · Restricted Project, Restricted Project
python3kgae retitled D125520: [TableGen][DirectX] generate DXIL operation table with TableGen. from [TableGen][DirectX] Add tableGen backend to generate DXIL operation table. to [TableGen][DirectX] generate DXIL operation table with TableGen..
Thu, Jun 16, 9:28 AM · Restricted Project, Restricted Project
python3kgae updated the diff for D125520: [TableGen][DirectX] generate DXIL operation table with TableGen..

Move EmitDXILOperationTable gen-dxil-operation

Thu, Jun 16, 7:59 AM · Restricted Project, Restricted Project
python3kgae updated the summary of D125520: [TableGen][DirectX] generate DXIL operation table with TableGen..
Thu, Jun 16, 7:58 AM · Restricted Project, Restricted Project

Wed, Jun 15

python3kgae committed rG264c09b732ab: [TableGen][DirectX] Add tableGen backend to generate map from llvm intrinsic to… (authored by python3kgae).
[TableGen][DirectX] Add tableGen backend to generate map from llvm intrinsic to…
Wed, Jun 15, 7:41 PM · Restricted Project, Restricted Project
python3kgae closed D125519: [TableGen][DirectX] Add tableGen backend to generate map from llvm intrinsic to DXIL operation..
Wed, Jun 15, 7:41 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D125519: [TableGen][DirectX] Add tableGen backend to generate map from llvm intrinsic to DXIL operation..
Wed, Jun 15, 5:24 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D125519: [TableGen][DirectX] Add tableGen backend to generate map from llvm intrinsic to DXIL operation..

Update to match the comments.

Wed, Jun 15, 5:22 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D125519: [TableGen][DirectX] Add tableGen backend to generate map from llvm intrinsic to DXIL operation..

Add static for internal function.

Wed, Jun 15, 3:43 PM · Restricted Project, Restricted Project

Tue, Jun 14

python3kgae updated the diff for D125519: [TableGen][DirectX] Add tableGen backend to generate map from llvm intrinsic to DXIL operation..

Move EmitDXILIntrinsicMap into EmitDXILOperation.

Tue, Jun 14, 8:49 PM · Restricted Project, Restricted Project
python3kgae committed rG435897b41d60: [TableGen][DirectX] Add tableGen backend to generate DXIL operation for DirectX… (authored by python3kgae).
[TableGen][DirectX] Add tableGen backend to generate DXIL operation for DirectX…
Tue, Jun 14, 5:32 PM · Restricted Project, Restricted Project
python3kgae closed D125435: [TableGen][DirectX] Add tableGen backend to generate DXIL operation for DirectX backend..
Tue, Jun 14, 5:32 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D127802: [HLSL] Support HLSL vector initializers.
Tue, Jun 14, 3:04 PM · Restricted Project, Restricted Project
python3kgae added a comment to D125435: [TableGen][DirectX] Add tableGen backend to generate DXIL operation for DirectX backend..

Updated the comments and test.
Thanks for the review.

Tue, Jun 14, 2:03 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D125435: [TableGen][DirectX] Add tableGen backend to generate DXIL operation for DirectX backend..

Clean comments and test.

Tue, Jun 14, 2:01 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D124753: [HLSL] Set main as default entry..
Tue, Jun 14, 12:50 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D124753: [HLSL] Set main as default entry..

Fix typo in test.

Tue, Jun 14, 12:48 PM · Restricted Project, Restricted Project
python3kgae added a reviewer for D127705: [DirectX] Support opaque ptr for ValueAsMetadata in DXILBitcodeWriter: beanz.
Tue, Jun 14, 6:45 AM · Restricted Project, Restricted Project

Mon, Jun 13

python3kgae added inline comments to D127705: [DirectX] Support opaque ptr for ValueAsMetadata in DXILBitcodeWriter.
Mon, Jun 13, 7:28 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D127705: [DirectX] Support opaque ptr for ValueAsMetadata in DXILBitcodeWriter.

Save addresspace for Function.

Mon, Jun 13, 7:27 PM · Restricted Project, Restricted Project
python3kgae requested review of D127705: [DirectX] Support opaque ptr for ValueAsMetadata in DXILBitcodeWriter.
Mon, Jun 13, 5:16 PM · Restricted Project, Restricted Project
python3kgae added a comment to D125435: [TableGen][DirectX] Add tableGen backend to generate DXIL operation for DirectX backend..

Gentle Ping.

Mon, Jun 13, 9:38 AM · Restricted Project, Restricted Project
python3kgae added a comment to D124751: [HLSL] Support -E option for HLSL..

Gentle Ping.

Mon, Jun 13, 9:33 AM · Restricted Project, Restricted Project
python3kgae added a comment to D127640: [docs] Adding DirectX target usage doc.

Should we add an example command line to compile .ll to a DXContainer?

Mon, Jun 13, 9:28 AM · Restricted Project, Restricted Project

Tue, Jun 7

python3kgae committed rG12ca031b0d1b: [DirectX][Fail crash in DXILPrepareModule pass when input has typed ptr. (authored by python3kgae).
[DirectX][Fail crash in DXILPrepareModule pass when input has typed ptr.
Tue, Jun 7, 9:11 PM · Restricted Project, Restricted Project
python3kgae closed D127268: [DirectX][Fail crash in DXILPrepareModule pass when input has typed ptr..
Tue, Jun 7, 9:11 PM · Restricted Project, Restricted Project
python3kgae requested review of D127268: [DirectX][Fail crash in DXILPrepareModule pass when input has typed ptr..
Tue, Jun 7, 7:10 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D125435: [TableGen][DirectX] Add tableGen backend to generate DXIL operation for DirectX backend..

Rename to prepare for make all tableGen work for DXIL operation in one tableGen backend.

Tue, Jun 7, 1:21 AM · Restricted Project, Restricted Project

Mon, Jun 6

python3kgae updated the diff for D124751: [HLSL] Support -E option for HLSL..

Fix test fail after rebased on llvm/main.

Mon, Jun 6, 2:30 PM · Restricted Project, Restricted Project
python3kgae added a comment to D127147: [DirectX] Add MC Register and Frame stubs.

Do we need any test for this change?

Mon, Jun 6, 2:16 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D127147: [DirectX] Add MC Register and Frame stubs.
Mon, Jun 6, 2:08 PM · Restricted Project, Restricted Project

Fri, Jun 3

python3kgae committed rG436fef21efe3: [NFC] Fix issue on CMake Xcode build configuration. (authored by python3kgae).
[NFC] Fix issue on CMake Xcode build configuration.
Fri, Jun 3, 11:03 AM · Restricted Project, Restricted Project
python3kgae closed D126892: [NFC] Fix issue on CMake Xcode build configuration..
Fri, Jun 3, 11:03 AM · Restricted Project, Restricted Project

Thu, Jun 2

python3kgae committed rG6bea9ff91378: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL (authored by python3kgae).
[HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL
Thu, Jun 2, 1:06 PM · Restricted Project, Restricted Project
python3kgae closed D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL.
Thu, Jun 2, 1:06 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL.
Thu, Jun 2, 12:37 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL.

Simplify test.

Thu, Jun 2, 12:33 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL.
Thu, Jun 2, 12:10 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL.

Change to verify test.

Thu, Jun 2, 12:10 PM · Restricted Project, Restricted Project
python3kgae added a comment to D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL.

ok, so the reason you are adding this to clang is that it needs to be mapped into a target intrinsic?

Thu, Jun 2, 11:49 AM · Restricted Project, Restricted Project
python3kgae requested review of D126892: [NFC] Fix issue on CMake Xcode build configuration..
Thu, Jun 2, 9:39 AM · Restricted Project, Restricted Project
python3kgae requested review of D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL.
Thu, Jun 2, 12:28 AM · Restricted Project, Restricted Project

Wed, Jun 1

python3kgae added a comment to D124753: [HLSL] Set main as default entry..

From the current change it seems to me that what you need to be testing is a just that the frontend options are being passed correctly? This should then be a driver test with -### checking for the options to be set for the frontend invocation...

There's already a driver test with '-###' in https://reviews.llvm.org/D124751#change-af6Z62NjlfGb

This test doesn't seem to correspond to the change being added as you are changing the command-line flags. You don't actually add/generate any attributes in this patch.

Wed, Jun 1, 10:15 AM · Restricted Project, Restricted Project
python3kgae updated the diff for D124753: [HLSL] Set main as default entry..

Cleanup test.

Wed, Jun 1, 12:18 AM · Restricted Project, Restricted Project

Tue, May 31

python3kgae committed rGd3e4727907e5: [HLSL] add -D option for dxc mode. (authored by python3kgae).
[HLSL] add -D option for dxc mode.
Tue, May 31, 5:51 PM · Restricted Project, Restricted Project
python3kgae closed D125338: [HLSL] add -D option for dxc mode..
Tue, May 31, 5:50 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D125338: [HLSL] add -D option for dxc mode..

Recover after fixed Mac/arm test fail.

Tue, May 31, 4:33 PM · Restricted Project, Restricted Project
python3kgae reopened D125338: [HLSL] add -D option for dxc mode..

Reopen to recover the change after fix Mac/arm test fail.

Tue, May 31, 1:58 PM · Restricted Project, Restricted Project
python3kgae committed rG13e1a653278b: [HLSL] Enable vector types for hlsl. (authored by python3kgae).
[HLSL] Enable vector types for hlsl.
Tue, May 31, 1:54 PM · Restricted Project, Restricted Project
python3kgae closed D125052: [HLSL] Enable vector types for hlsl..
Tue, May 31, 1:54 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D125052: [HLSL] Enable vector types for hlsl..

Recover after fix Mac/arm test issue.

Tue, May 31, 1:53 PM · Restricted Project, Restricted Project
python3kgae reopened D125052: [HLSL] Enable vector types for hlsl..

Reopen for the Mac/arm test fail.

Tue, May 31, 1:53 PM · Restricted Project, Restricted Project
python3kgae committed rGfde240c9c328: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple. (authored by python3kgae).
[HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple.
Tue, May 31, 1:23 PM · Restricted Project, Restricted Project
python3kgae closed D125585: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple..
Tue, May 31, 1:23 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D125585: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple..

Add check for no -T option.

Tue, May 31, 11:10 AM · Restricted Project, Restricted Project

Mon, May 30

python3kgae updated the diff for D124753: [HLSL] Set main as default entry..

Add new line at end of file.

Mon, May 30, 7:17 PM · Restricted Project, Restricted Project
python3kgae added a comment to D124753: [HLSL] Set main as default entry..

From the current change it seems to me that what you need to be testing is a just that the frontend options are being passed correctly? This should then be a driver test with -### checking for the options to be set for the frontend invocation...

Mon, May 30, 7:15 PM · Restricted Project, Restricted Project
python3kgae added a comment to D125052: [HLSL] Enable vector types for hlsl..
Mon, May 30, 12:28 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D124752: [HLSL] clang codeGen for HLSLShaderAttr..

Code cleanup to match comments.

Mon, May 30, 9:18 AM · Restricted Project, Restricted Project
python3kgae committed rGe576280380d3: [HLSL] Enable vector types for hlsl. (authored by python3kgae).
[HLSL] Enable vector types for hlsl.
Mon, May 30, 9:05 AM · Restricted Project, Restricted Project
python3kgae closed D125052: [HLSL] Enable vector types for hlsl..
Mon, May 30, 9:05 AM · Restricted Project, Restricted Project

May 27 2022

python3kgae updated the diff for D124753: [HLSL] Set main as default entry..

Use default value of MarshallingInfoString.

May 27 2022, 11:30 AM · Restricted Project, Restricted Project
python3kgae updated the diff for D125052: [HLSL] Enable vector types for hlsl..

Add newline at end of file

May 27 2022, 8:45 AM · Restricted Project, Restricted Project
python3kgae added inline comments to D124751: [HLSL] Support -E option for HLSL..
May 27 2022, 8:00 AM · Restricted Project, Restricted Project
python3kgae updated the diff for D124751: [HLSL] Support -E option for HLSL..

Add hlsl-entry for cc1 option.

May 27 2022, 7:58 AM · Restricted Project, Restricted Project

May 26 2022

python3kgae updated the diff for D124753: [HLSL] Set main as default entry..

Add test for main is not entry.

May 26 2022, 5:32 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D124752: [HLSL] clang codeGen for HLSLShaderAttr..

Move addHLSLFunctionAttributes to ConstructAttributeList.

May 26 2022, 2:50 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D124752: [HLSL] clang codeGen for HLSLShaderAttr..
May 26 2022, 2:49 PM · Restricted Project, Restricted Project
python3kgae committed rG628b2bfad828: [DirectX] Update test for dxil-dis. (authored by python3kgae).
[DirectX] Update test for dxil-dis.
May 26 2022, 12:33 PM · Restricted Project, Restricted Project