Page MenuHomePhabricator

pow2clk (Greg Roth)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2019, 3:21 PM (182 w, 2 d)

Recent Activity

Aug 26 2022

pow2clk added a comment to D132711: [HLSL] add sqrt library function.

A very minor suggestion. This looks pretty straightforward.

Aug 26 2022, 3:17 PM · Restricted Project, Restricted Project

Jul 11 2022

pow2clk added a comment to D124751: [HLSL] Support -E option for HLSL..

Looks to me that all the comments were responded to. I see nothing else worth commenting on.

Jul 11 2022, 11:44 PM · Restricted Project, Restricted Project
pow2clk added a comment to D125655: [HLSL] add -P option for dxc mode..

Mostly just some comments on user output

Jul 11 2022, 11:30 PM · Restricted Project, Restricted Project
pow2clk added a comment to D128462: [HLSL] add -I option for dxc mode..

I'm confused by the ways this option is allowed to be specified

Jul 11 2022, 11:11 PM · Restricted Project, Restricted Project, Restricted Project
pow2clk added a comment to D128845: [HLSL]Add -O and -Od option for dxc mode..

Looks good apart from my uncertainty as to what -fcgl should or shouldn't imply

Jul 11 2022, 10:59 PM · Restricted Project, Restricted Project

Mar 28 2022

pow2clk added a comment to D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads.

Looks good. I made a comment about the CS 4.0 thing, but that can be addressed when more thorough examination of the requested shader models comes around.

Mar 28 2022, 7:24 PM · Restricted Project, Restricted Project