Widen and split vp.setcc the same way as setcc.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
I think @simoll should be included in VP reviews.
| llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp | ||
|---|---|---|
| 5256 | What if we hit this case? It looks like it might silently just work and generate non-VP code. It's not the end of the world but might be unexpected. Can we test this particular path with RISC-V? I'm not sure we can.. My first thought is that maybe we should add support for splitting VP_SETCC first so we know this function works in principle, then come back to widening afterwards. | |
| 5283 | Unnecessary parens () | |
| llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp | ||
|---|---|---|
| 5256 | I add SplitVecOp_VSETCC and SplitVecRes_SETCC for vp.setcc | |
| llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp | ||
|---|---|---|
| 5281 | You can drop the else. The if returned | |
| llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp | ||
|---|---|---|
| 5281 | Drop the else and returned in if | |
| llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp | ||
|---|---|---|
| 3514 | I suppose this is a non-VP extend? Could this be a TODO to use a VP extend? | |
This assert provides no value. It's the oppose of the if you wrote above.