Based on D123467.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Can you provide a little detail as to the value of this change. I find it common to grep for setOperationAction(ISD::blah to identify the legalisation strategy. After this change that becomes impossible. I'm not saying I'm against this change but it would be nice to know what we get back in return for loosing this flexibility.
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp | ||
---|---|---|
378 | I can definitely some benefit here in terms of removing duplication, but in other places (I've left comments in a couple of examples) it's not obvious what the benefit is. | |
881 | This change looks more cosmetic than functional - we're not really reducing lines of code here. | |
968 | Again, not sure of the benefit of changes like this - we've not removed duplication, but it has made it harder to grep for operation actions. |
I can definitely some benefit here in terms of removing duplication, but in other places (I've left comments in a couple of examples) it's not obvious what the benefit is.