Page MenuHomePhabricator

nigelp-xmos (Nigel Perks)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 24 2020, 8:40 AM (55 w, 4 d)

Recent Activity

Yesterday

nigelp-xmos committed rG23f8993f32d7: Restore lit feature object-emission. Omit DebugInfo/Generic on XCore. (authored by nigelp-xmos).
Restore lit feature object-emission. Omit DebugInfo/Generic on XCore.
Fri, Apr 16, 5:06 AM
nigelp-xmos closed D98508: Restore lit feature object-emission.
Fri, Apr 16, 5:05 AM · Restricted Project
nigelp-xmos added a comment to D98508: Restore lit feature object-emission.

Thank you for the reviews, I appreciate people taking time on something that is only for this target.

Fri, Apr 16, 12:03 AM · Restricted Project

Thu, Apr 15

nigelp-xmos added a reviewer for D98508: Restore lit feature object-emission: echristo.

Invite debug info code owner to review.

Thu, Apr 15, 1:57 AM · Restricted Project

Mon, Apr 12

nigelp-xmos added a comment to D98508: Restore lit feature object-emission.

As suggested, excluded xcore from DebugInfo/Generic rather than patching each file.

Mon, Apr 12, 1:29 AM · Restricted Project

Thu, Apr 1

nigelp-xmos updated the diff for D98508: Restore lit feature object-emission.

Tidy up.

Thu, Apr 1, 6:21 AM · Restricted Project
nigelp-xmos updated the diff for D98508: Restore lit feature object-emission.

Restore lit feature object-emission. Omit DebugInfo/Generic on XCore.

Thu, Apr 1, 5:53 AM · Restricted Project

Wed, Mar 31

nigelp-xmos added a comment to D98508: Restore lit feature object-emission.

Thanks, I see what you mean about churn and maintenance. The integrated assembler is planned. I will rework the patch.

Wed, Mar 31, 12:59 PM · Restricted Project
nigelp-xmos added a comment to D98508: Restore lit feature object-emission.

DebugInfo/Generic can be handled by two lines in lit.local.cfg:

Wed, Mar 31, 9:14 AM · Restricted Project
nigelp-xmos added a comment to D98508: Restore lit feature object-emission.

@MaskRay Thanks for the comment. I will look at that. But DebugInfo/Generic has 78 files requiring object-emission and 60 not requiring it - isn't it worth still running the 60? (I looked at some to see what they were doing: running llvm-as, llvm-dis, and checking assembly output.)

Wed, Mar 31, 7:56 AM · Restricted Project

Tue, Mar 30

nigelp-xmos added a reviewer for D98949: [XCore][Test] llvm-mc integrated assembler is unsupported.: mehdi_amini.

Invite reviewers around llvm-mc tool tests.

Tue, Mar 30, 2:41 AM · Restricted Project
nigelp-xmos added reviewers for D98949: [XCore][Test] llvm-mc integrated assembler is unsupported.: bogner, davide.

Invite reviewers around llvm-mc tool tests.

Tue, Mar 30, 2:37 AM · Restricted Project
nigelp-xmos added reviewers for D98508: Restore lit feature object-emission: jverma, chapuni, djtodoro, MaskRay, mtrofin.

Invite reviewers around lit.cfg.py changes.

Tue, Mar 30, 2:10 AM · Restricted Project

Wed, Mar 24

nigelp-xmos committed rGc1fa0ba1f057: [XCore][Test] XFAIL tests requiring 8-byte stack alignment. (authored by nigelp-xmos).
[XCore][Test] XFAIL tests requiring 8-byte stack alignment.
Wed, Mar 24, 2:14 AM
nigelp-xmos closed D99092: [XCore][Test] XFAIL tests requiring 8-byte stack alignment..
Wed, Mar 24, 2:14 AM · Restricted Project

Tue, Mar 23

nigelp-xmos added reviewers for D99157: [XCore][Test] inline asm memory constraint not supported.: dylanmckay, dsanders, majnemer.
Tue, Mar 23, 2:14 AM · Restricted Project
nigelp-xmos requested review of D99157: [XCore][Test] inline asm memory constraint not supported..
Tue, Mar 23, 2:08 AM · Restricted Project

Mon, Mar 22

nigelp-xmos added reviewers for D99092: [XCore][Test] XFAIL tests requiring 8-byte stack alignment.: dblaikie, dylanmckay, aprantl.
Mon, Mar 22, 10:28 AM · Restricted Project
nigelp-xmos requested review of D99092: [XCore][Test] XFAIL tests requiring 8-byte stack alignment..
Mon, Mar 22, 10:26 AM · Restricted Project

Fri, Mar 19

nigelp-xmos added reviewers for D98949: [XCore][Test] llvm-mc integrated assembler is unsupported.: colinl, grosbach.
Fri, Mar 19, 7:16 AM · Restricted Project
nigelp-xmos requested review of D98949: [XCore][Test] llvm-mc integrated assembler is unsupported..
Fri, Mar 19, 7:11 AM · Restricted Project

Mar 18 2021

nigelp-xmos committed rG1a6ab32f3365: [XCore] Remove XFAIL: xcore from passing test. (authored by nigelp-xmos).
[XCore] Remove XFAIL: xcore from passing test.
Mar 18 2021, 8:48 AM
nigelp-xmos closed D98352: [XCore] Remove XFAIL: xcore from passing test..
Mar 18 2021, 8:47 AM · Restricted Project
nigelp-xmos added reviewers for D98352: [XCore] Remove XFAIL: xcore from passing test.: dylanmckay, arsenm.

Add reviewer suggestions from CodeGen/Generic history.

Mar 18 2021, 7:31 AM · Restricted Project
nigelp-xmos committed rG251fe986afd3: [Test][DebugInfo] Check for backend object emission support. (authored by nigelp-xmos).
[Test][DebugInfo] Check for backend object emission support.
Mar 18 2021, 2:52 AM
nigelp-xmos closed D98400: [Test][DebugInfo] Check for backend object emission support..
Mar 18 2021, 2:52 AM · Restricted Project
nigelp-xmos added inline comments to D98400: [Test][DebugInfo] Check for backend object emission support..
Mar 18 2021, 2:33 AM · Restricted Project

Mar 13 2021

nigelp-xmos added a comment to D97943: [XCore] Build fewer components. Run 4 parallel jobs..

Thanks, Galina.

Mar 13 2021, 2:36 AM
nigelp-xmos committed rZORG258da7a6e288: [XCore] Build fewer components. Run 4 parallel jobs. (authored by nigelp-xmos).
[XCore] Build fewer components. Run 4 parallel jobs.
Mar 13 2021, 2:35 AM
nigelp-xmos closed D97943: [XCore] Build fewer components. Run 4 parallel jobs..
Mar 13 2021, 2:35 AM

Mar 12 2021

nigelp-xmos added reviewers for D98508: Restore lit feature object-emission: ted, JDevlieghere, probinson.
Mar 12 2021, 7:23 AM · Restricted Project
nigelp-xmos requested review of D98508: Restore lit feature object-emission.
Mar 12 2021, 7:15 AM · Restricted Project

Mar 11 2021

nigelp-xmos added a comment to D98400: [Test][DebugInfo] Check for backend object emission support..

Thanks @clayborg

Mar 11 2021, 10:54 PM · Restricted Project
nigelp-xmos updated the diff for D98400: [Test][DebugInfo] Check for backend object emission support..
  • Incorporate isConfigurationSupported in isObjectEmissionSupported
Mar 11 2021, 4:29 AM · Restricted Project
nigelp-xmos added a comment to D98400: [Test][DebugInfo] Check for backend object emission support..

@labath Thanks for the quick response. That looks like a good idea. I will try that.

Mar 11 2021, 2:23 AM · Restricted Project
nigelp-xmos added reviewers for D98400: [Test][DebugInfo] Check for backend object emission support.: clayborg, grimar, labath.
Mar 11 2021, 2:10 AM · Restricted Project
nigelp-xmos updated the diff for D98400: [Test][DebugInfo] Check for backend object emission support..

Run clang-format

Mar 11 2021, 2:05 AM · Restricted Project
nigelp-xmos requested review of D98400: [Test][DebugInfo] Check for backend object emission support..
Mar 11 2021, 2:01 AM · Restricted Project

Mar 10 2021

nigelp-xmos added reviewers for D98352: [XCore] Remove XFAIL: xcore from passing test.: dblaikie, ributzka.
Mar 10 2021, 7:38 AM · Restricted Project
nigelp-xmos requested review of D98352: [XCore] Remove XFAIL: xcore from passing test..
Mar 10 2021, 7:35 AM · Restricted Project

Mar 8 2021

nigelp-xmos updated the diff for D97943: [XCore] Build fewer components. Run 4 parallel jobs..

arc --update with all changes.

Mar 8 2021, 9:06 PM
nigelp-xmos updated the diff for D97943: [XCore] Build fewer components. Run 4 parallel jobs..

[XCore] Do not override LLVM_LIT_ARGS: use -j from the factory.

Mar 8 2021, 9:02 PM

Mar 4 2021

nigelp-xmos requested review of D97943: [XCore] Build fewer components. Run 4 parallel jobs..
Mar 4 2021, 6:04 AM

Mar 3 2021

nigelp-xmos closed D97270: Add buildbot for Clang for XCore target on Ubuntu host..

https://github.com/llvm/llvm-zorg/commit/f128ee547d9f4d1fc9480b9e95b6c119d9a08392

Mar 3 2021, 2:55 AM
nigelp-xmos committed rZORGf128ee547d9f: Add builder and worker for XCore as default target. (authored by nigelp-xmos).
Add builder and worker for XCore as default target.
Mar 3 2021, 2:53 AM
nigelp-xmos updated the diff for D97270: Add buildbot for Clang for XCore target on Ubuntu host..

Revise as per review comments.

Mar 3 2021, 2:41 AM
nigelp-xmos abandoned D97844: Revise as per review comments..

Created by mistake.

Mar 3 2021, 2:35 AM
nigelp-xmos requested review of D97844: Revise as per review comments..
Mar 3 2021, 2:34 AM

Feb 23 2021

nigelp-xmos requested review of D97270: Add buildbot for Clang for XCore target on Ubuntu host..
Feb 23 2021, 4:12 AM

Jan 14 2021

nigelp-xmos committed rG19297a417117: Change XCore code owner. (authored by nigelp-xmos).
Change XCore code owner.
Jan 14 2021, 4:15 AM

Jan 9 2021

nigelp-xmos added a comment to D93625: [NFC] [TEST] Fix the threads.ll for Windows.

I think this patch can be cancelled, because the issue is already fixed in the main branch. But please say if I have missed something.

Jan 9 2021, 2:58 AM · Restricted Project

Jan 5 2021

nigelp-xmos added a comment to D93625: [NFC] [TEST] Fix the threads.ll for Windows.

I've reproduced the failure. The test passes when I change -march=xcore to -mtriple=xcore-unknown-unknown, as in main branch commit https://github.com/llvm/llvm-project/commit/15ca54525d6c2927b2a51b871a9e343c7ce1c2ea. Does that commit solve this problem and unblock D91556 ? (I will continue to investigate to understand the reason for the register swap.)

Jan 5 2021, 6:15 AM · Restricted Project

Jan 4 2021

nigelp-xmos added a comment to D93625: [NFC] [TEST] Fix the threads.ll for Windows.

The specified XCore backend code owner has moved on from XMOS and from working on XCore. I will have a look at this patch.

Jan 4 2021, 4:44 AM · Restricted Project

Dec 8 2020

nigelp-xmos added a comment to D92108: Fix inconsistent availability attribute message string literal check..

Many thanks for review and approval. Please could it be committed as I do not have commit access? (I will request.)

Dec 8 2020, 3:12 AM · Restricted Project
nigelp-xmos added a comment to D92019: [XCore][docs] Fix XCore compiler writer documentation links..

Added reviewer suggestions from git history. If someone familiar with updating the documentation could commit for me, I would be grateful, as I do not have commit access.

Dec 8 2020, 3:07 AM · Restricted Project
nigelp-xmos added reviewers for D92019: [XCore][docs] Fix XCore compiler writer documentation links.: jryans, sdardis, craig.topper.
Dec 8 2020, 3:07 AM · Restricted Project

Nov 25 2020

nigelp-xmos updated the diff for D92108: Fix inconsistent availability attribute message string literal check..

Run clang-format

Nov 25 2020, 9:31 AM · Restricted Project
nigelp-xmos updated the diff for D92108: Fix inconsistent availability attribute message string literal check..

Run clang-format

Nov 25 2020, 9:27 AM · Restricted Project
nigelp-xmos added reviewers for D92108: Fix inconsistent availability attribute message string literal check.: doug.gregor, bkramer, majnemer.
Nov 25 2020, 8:51 AM · Restricted Project
nigelp-xmos added a comment to D92108: Fix inconsistent availability attribute message string literal check..

Alternatively, if all 1-byte-character strings are acceptable, should I remove the check that the first token is a string literal, and omit the failing test case on XCore?

Nov 25 2020, 8:48 AM · Restricted Project
nigelp-xmos requested review of D92108: Fix inconsistent availability attribute message string literal check..
Nov 25 2020, 8:44 AM · Restricted Project

Nov 24 2020

nigelp-xmos added reviewers for D92019: [XCore][docs] Fix XCore compiler writer documentation links.: zixuan-wu, jsji, atanasyan, efriedma.
Nov 24 2020, 3:28 AM · Restricted Project
nigelp-xmos requested review of D92019: [XCore][docs] Fix XCore compiler writer documentation links..
Nov 24 2020, 3:24 AM · Restricted Project

Jun 24 2020

nigelp-xmos added a comment to D77068: Fix crash on XCore on unused inline in EmitTargetMetadata.

I do not have commit access, so if this is approved, please could it be committed against author "Nigel Perks" nigelp@xmos.com ?

Jun 24 2020, 11:21 AM · Restricted Project
nigelp-xmos updated the diff for D77068: Fix crash on XCore on unused inline in EmitTargetMetadata.

Added explanatory comment and CHECK lines to test case, as per review comment.

Jun 24 2020, 10:51 AM · Restricted Project

Jun 22 2020

nigelp-xmos added inline comments to D77068: Fix crash on XCore on unused inline in EmitTargetMetadata.
Jun 22 2020, 9:07 AM · Restricted Project
nigelp-xmos added a comment to D77068: Fix crash on XCore on unused inline in EmitTargetMetadata.

Ping. I made the change suggested by @erichkeane .

Jun 22 2020, 8:35 AM · Restricted Project

May 28 2020

nigelp-xmos added inline comments to D80368: Remove GlobalValue::getAlignment()..
May 28 2020, 2:08 AM · Restricted Project

May 19 2020

nigelp-xmos updated the summary of D77068: Fix crash on XCore on unused inline in EmitTargetMetadata.
May 19 2020, 2:40 AM · Restricted Project
nigelp-xmos updated the diff for D77068: Fix crash on XCore on unused inline in EmitTargetMetadata.

As suggested by FIXME comment in code, and review comment, moved the EmitTargetMetadata loop into XCore target.

May 19 2020, 2:40 AM · Restricted Project

May 12 2020

nigelp-xmos added a comment to D77068: Fix crash on XCore on unused inline in EmitTargetMetadata.

Thanks for the comment, I will look into that.

May 12 2020, 8:34 AM · Restricted Project
nigelp-xmos added reviewers for D77068: Fix crash on XCore on unused inline in EmitTargetMetadata: jasonliu, erichkeane, RKSimon, jhibbits, ctetreau, george.burgess.iv, efriedma.

Adding code reviewer suggestions from git history. I would be grateful for review and/or reviewer suggestions. Many thanks.

May 12 2020, 7:29 AM · Restricted Project

Apr 27 2020

nigelp-xmos added a comment to D77068: Fix crash on XCore on unused inline in EmitTargetMetadata.

This patches fixes two Clang tests which are failing for XCore target on 2020-04-27 with "unexpected null value" assert failures:

Apr 27 2020, 8:02 AM · Restricted Project

Apr 15 2020

nigelp-xmos added a comment to D77068: Fix crash on XCore on unused inline in EmitTargetMetadata.

Just a polite ping to keep it alive. I hope that's all right. Not urgent at all.

Apr 15 2020, 7:05 AM · Restricted Project

Mar 30 2020

nigelp-xmos created D77068: Fix crash on XCore on unused inline in EmitTargetMetadata.
Mar 30 2020, 9:10 AM · Restricted Project