Page MenuHomePhabricator

nigelp-xmos (Nigel Perks)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 24 2020, 8:40 AM (112 w, 6 d)

Recent Activity

Mon, May 16

nigelp-xmos added a comment to D123661: [XCORE][CodeGen][NFC] Use ArrayRef in TargetLowering functions.

I am inclined to revert this change, in line with readability and the other targets. I commented above that I found the original structure clearer. Others said similarly in the changes for other targets. I was happy to bring XCore in line with other targets, but they have not gone for multiple operations on one line. So I would prefer to revert, but welcome comments.

Mon, May 16, 2:27 AM · Restricted Project, Restricted Project

Wed, May 4

nigelp-xmos added a comment to D122251: [lit] Use sharding for GoogleTest format.

Are you blocked in some way due to the mismatch?

Wed, May 4, 12:29 PM · Restricted Project, Restricted Project
nigelp-xmos added a comment to D122251: [lit] Use sharding for GoogleTest format.

This has changed test totals reported on the buildbot dashboard, so I would be interested in a comment on that.

Wed, May 4, 2:16 AM · Restricted Project, Restricted Project

Thu, Apr 28

nigelp-xmos added a comment to D120094: [CallingConv] Generate isCCArgumentReg() predicate via tablegen.

XCore OK.

Thu, Apr 28, 3:45 AM · Restricted Project, Restricted Project

Mon, Apr 25

nigelp-xmos accepted D123661: [XCORE][CodeGen][NFC] Use ArrayRef in TargetLowering functions.

I see D123467 is the cross-target patch for this, and was accepted, so LGTM.

Mon, Apr 25, 8:42 AM · Restricted Project, Restricted Project
nigelp-xmos added a comment to D123661: [XCORE][CodeGen][NFC] Use ArrayRef in TargetLowering functions.

If D123656 gets consensus then this looks right to bring XCore in line with it. But personally I think the original structure is clearer: one operation per line, with the MVT and action right next to it. What is the motive for the change?

Mon, Apr 25, 8:36 AM · Restricted Project, Restricted Project
nigelp-xmos added a reviewer for D123661: [XCORE][CodeGen][NFC] Use ArrayRef in TargetLowering functions: nigelp-xmos.
Mon, Apr 25, 8:31 AM · Restricted Project, Restricted Project

Mar 19 2022

nigelp-xmos accepted D121982: [Xcore] Set Int_MemBarrier as a meta-instruction.

LGTM thanks

Mar 19 2022, 2:21 AM · Restricted Project, Restricted Project

Mar 18 2022

nigelp-xmos added a comment to D121994: [tests] Make 'object-emission' imply 'default_triple'.

LGTM.

Mar 18 2022, 8:10 AM · Restricted Project, Restricted Project
nigelp-xmos added a comment to D121996: [NVPTX][tests] Do not run tests that require direct object generation.

LGTM but I would prefer to hear from other reviewers who commented on object-emission before.

Mar 18 2022, 8:01 AM · Restricted Project, Restricted Project
nigelp-xmos added a comment to D121996: [NVPTX][tests] Do not run tests that require direct object generation.

The code LGTM. When object-emission was reintroduced in D98508, there was some discussion on whether XCore ought to use this feature, or provide an integrated assembler instead. Sorry I don't know NVPTX: is NVPTX different because it generates assembly as its natural output, and binary does not make sense? Or could it have an integrated assembler at some point?

Mar 18 2022, 6:42 AM · Restricted Project, Restricted Project
nigelp-xmos added a comment to D121982: [Xcore] Set Int_MemBarrier as a meta-instruction.

As the test is specifying targets, I think it needs to be in both X86 and XCore areas. Otherwise compilers not supporting those targets will attempt the test.

Mar 18 2022, 6:09 AM · Restricted Project, Restricted Project

Mar 17 2022

nigelp-xmos added a comment to D121600: [Codegen][tablgen][NFC] Allow meta instruction to be target dependent.

LGTM

Mar 17 2022, 5:55 AM · Restricted Project, Restricted Project

Jan 17 2022

nigelp-xmos added a comment to D117298: [CodeGen] Remove unneeded regex escaping in FileCheck patterns. NFC..

XCore files LGTM. Nice improvement.

Jan 17 2022, 6:35 AM · Restricted Project

Sep 14 2021

nigelp-xmos committed rZORG0cee063195ed: Add SKIPPED to known result names. (authored by nigelp-xmos).
Add SKIPPED to known result names.
Sep 14 2021, 2:59 AM
nigelp-xmos closed D104518: Add SKIPPED to known result names..
Sep 14 2021, 2:58 AM
nigelp-xmos updated the diff for D104518: Add SKIPPED to known result names..

Remove "unit" from description as recommended in review.

Sep 14 2021, 2:51 AM

Sep 13 2021

nigelp-xmos added a comment to D104518: Add SKIPPED to known result names..

Thanks @gkistanova . Yes, I will remove "unit" as suggested.

Sep 13 2021, 9:10 AM
nigelp-xmos added a comment to D104518: Add SKIPPED to known result names..

@ikudrin Thanks for the comment and the buildbot links. Yes, I won't check in till approved by buildbot maintainers.

Sep 13 2021, 5:34 AM
nigelp-xmos updated the summary of D104518: Add SKIPPED to known result names..
Sep 13 2021, 1:47 AM

Jul 1 2021

nigelp-xmos abandoned D98949: [XCore][Test] llvm-mc integrated assembler is unsupported..
Jul 1 2021, 12:12 AM · Restricted Project

Jun 24 2021

nigelp-xmos added a comment to D104518: Add SKIPPED to known result names..

The clang-xcore build status changed from "Unexpected test result output SKIPPED" in https://lab.llvm.org/staging/#/builders/145/builds/1340, to "X skipped unit tests" in https://lab.llvm.org/staging/#/builders/145/builds/1342. If that was when the patch was staged, it has worked on the display of results.

Jun 24 2021, 2:02 AM

Jun 18 2021

nigelp-xmos added reviewers for D104518: Add SKIPPED to known result names.: stevanradakovic, andreil99.
Jun 18 2021, 3:55 AM
nigelp-xmos requested review of D104518: Add SKIPPED to known result names..
Jun 18 2021, 3:53 AM

Jun 16 2021

nigelp-xmos added a comment to D92842: [SelectionDAG] Add Target-Independent Compiler Barrier.

llvm/include/llvm/Target/TargetSelectionDAG.td defines SDTMemBarrier. This seems to have been introduced in 9b254eed32028 for ISD::MEMBARRIER, which was removed some time ago. I can't find a use of it and I can build without it. Could SDTMemBarrier be removed and would it belong in this patch?

Jun 16 2021, 2:00 AM · Restricted Project, Restricted Project
nigelp-xmos added a comment to D92842: [SelectionDAG] Add Target-Independent Compiler Barrier.

XCore change LGTM. (Commenting on XCore only.)

Jun 16 2021, 1:52 AM · Restricted Project, Restricted Project

Jun 14 2021

nigelp-xmos added a comment to D92842: [SelectionDAG] Add Target-Independent Compiler Barrier.

Yes, I will look at this for the XCore target.

Jun 14 2021, 2:59 AM · Restricted Project, Restricted Project

Apr 29 2021

nigelp-xmos updated subscribers of D99157: [XCore][Test] inline asm memory constraint not supported..

Currently the only memory operands that XCore inline asm supports are indirect (*m) and they have to be globals. It doesn’t handle locals as operands, or plain “m”. (It doesn’t handle FrameIndex.) So in that sense these tests are expected to fail. As an alternative to XFAIL, I’ve started looking at handling these other cases, or at least finding out what is difficult about them. I suspect there is some difficulty, otherwise the original developer would have done it, but I can’t say what it is yet.

Apr 29 2021, 6:04 AM · Restricted Project

Apr 28 2021

nigelp-xmos planned changes to D99157: [XCore][Test] inline asm memory constraint not supported..

I'm looking at extending XCore inline asm, or at least understanding why it's a problem to handle these cases, to provide more context for any XFAIL.

Apr 28 2021, 1:01 AM · Restricted Project

Apr 26 2021

nigelp-xmos committed rGe7b6c0f398ee: [clang][XCore] Define __xcore__ for XCore target. (authored by nigelp-xmos).
[clang][XCore] Define __xcore__ for XCore target.
Apr 26 2021, 7:07 AM

Apr 21 2021

nigelp-xmos added a comment to D99157: [XCore][Test] inline asm memory constraint not supported..

@echristo Thanks for the comment, Eric. I'm happy to do what is expected. Do you mean that it's a bug not to accept these cases, and we should fix it rather than XFAIL? So the build should not be green from XFAIL but only from a fix in this case?

Apr 21 2021, 7:58 AM · Restricted Project

Apr 20 2021

nigelp-xmos added a comment to rG701d70d4c25c: String Literal and Wide String Literal Encoding from the Preprocessor.

In a quick test, I used else if (TI.getTypeWidth(TI.getWCharType()) == 8) but did you want to avoid that?

Apr 20 2021, 12:35 PM
nigelp-xmos added a comment to rG701d70d4c25c: String Literal and Wide String Literal Encoding from the Preprocessor.

At the moment Clang defines __XS1B__ for XCore, but really that's one subtarget, I need to patch to define __xcore__ . It's an embedded processor, usually bare metal, so wouldn't have an OS character set. I just saw this change and thought I'd mention it's only 8 bits wide - I don't know what the best approach is. I'll discuss with others. Thanks for the quick reply.

Apr 20 2021, 12:34 PM
nigelp-xmos added a comment to rG701d70d4c25c: String Literal and Wide String Literal Encoding from the Preprocessor.

The XCore target has 8-bit wchar_t (unsigned char). Should there be a test for width == 8 and set to "UTF-8", or at least not "UTF-16"?

Apr 20 2021, 12:08 PM
nigelp-xmos updated the summary of D98949: [XCore][Test] llvm-mc integrated assembler is unsupported..
Apr 20 2021, 3:00 AM · Restricted Project
nigelp-xmos updated the diff for D98949: [XCore][Test] llvm-mc integrated assembler is unsupported..

Use XFAIL

Apr 20 2021, 2:59 AM · Restricted Project
nigelp-xmos added a reviewer for D99157: [XCore][Test] inline asm memory constraint not supported.: echristo.

Invite inline assembly code owner to review.

Apr 20 2021, 1:28 AM · Restricted Project

Apr 19 2021

nigelp-xmos updated the summary of D99157: [XCore][Test] inline asm memory constraint not supported..
Apr 19 2021, 12:40 PM · Restricted Project
nigelp-xmos updated the diff for D99157: [XCore][Test] inline asm memory constraint not supported..

Tidy up.

Apr 19 2021, 12:39 PM · Restricted Project

Apr 16 2021

nigelp-xmos committed rG23f8993f32d7: Restore lit feature object-emission. Omit DebugInfo/Generic on XCore. (authored by nigelp-xmos).
Restore lit feature object-emission. Omit DebugInfo/Generic on XCore.
Apr 16 2021, 5:06 AM
nigelp-xmos closed D98508: Restore lit feature object-emission.
Apr 16 2021, 5:05 AM · Restricted Project
nigelp-xmos added a comment to D98508: Restore lit feature object-emission.

Thank you for the reviews, I appreciate people taking time on something that is only for this target.

Apr 16 2021, 12:03 AM · Restricted Project

Apr 15 2021

nigelp-xmos added a reviewer for D98508: Restore lit feature object-emission: echristo.

Invite debug info code owner to review.

Apr 15 2021, 1:57 AM · Restricted Project

Apr 12 2021

nigelp-xmos added a comment to D98508: Restore lit feature object-emission.

As suggested, excluded xcore from DebugInfo/Generic rather than patching each file.

Apr 12 2021, 1:29 AM · Restricted Project

Apr 1 2021

nigelp-xmos updated the diff for D98508: Restore lit feature object-emission.

Tidy up.

Apr 1 2021, 6:21 AM · Restricted Project
nigelp-xmos updated the diff for D98508: Restore lit feature object-emission.

Omit DebugInfo/Generic on XCore to avoid annotating 70 separate files.

Apr 1 2021, 5:53 AM · Restricted Project

Mar 31 2021

nigelp-xmos added a comment to D98508: Restore lit feature object-emission.

Thanks, I see what you mean about churn and maintenance. The integrated assembler is planned. I will rework the patch.

Mar 31 2021, 12:59 PM · Restricted Project
nigelp-xmos added a comment to D98508: Restore lit feature object-emission.

DebugInfo/Generic can be handled by two lines in lit.local.cfg:

Mar 31 2021, 9:14 AM · Restricted Project
nigelp-xmos added a comment to D98508: Restore lit feature object-emission.

@MaskRay Thanks for the comment. I will look at that. But DebugInfo/Generic has 78 files requiring object-emission and 60 not requiring it - isn't it worth still running the 60? (I looked at some to see what they were doing: running llvm-as, llvm-dis, and checking assembly output.)

Mar 31 2021, 7:56 AM · Restricted Project

Mar 30 2021

nigelp-xmos added a reviewer for D98949: [XCore][Test] llvm-mc integrated assembler is unsupported.: mehdi_amini.

Invite reviewers around llvm-mc tool tests.

Mar 30 2021, 2:41 AM · Restricted Project
nigelp-xmos added reviewers for D98949: [XCore][Test] llvm-mc integrated assembler is unsupported.: bogner, davide.

Invite reviewers around llvm-mc tool tests.

Mar 30 2021, 2:37 AM · Restricted Project
nigelp-xmos added reviewers for D98508: Restore lit feature object-emission: jverma, chapuni, djtodoro, MaskRay, mtrofin.

Invite reviewers around lit.cfg.py changes.

Mar 30 2021, 2:10 AM · Restricted Project

Mar 24 2021

nigelp-xmos committed rGc1fa0ba1f057: [XCore][Test] XFAIL tests requiring 8-byte stack alignment. (authored by nigelp-xmos).
[XCore][Test] XFAIL tests requiring 8-byte stack alignment.
Mar 24 2021, 2:14 AM
nigelp-xmos closed D99092: [XCore][Test] XFAIL tests requiring 8-byte stack alignment..
Mar 24 2021, 2:14 AM · Restricted Project

Mar 23 2021

nigelp-xmos added reviewers for D99157: [XCore][Test] inline asm memory constraint not supported.: dylanmckay, dsanders, majnemer.
Mar 23 2021, 2:14 AM · Restricted Project
nigelp-xmos requested review of D99157: [XCore][Test] inline asm memory constraint not supported..
Mar 23 2021, 2:08 AM · Restricted Project

Mar 22 2021

nigelp-xmos added reviewers for D99092: [XCore][Test] XFAIL tests requiring 8-byte stack alignment.: dblaikie, dylanmckay, aprantl.
Mar 22 2021, 10:28 AM · Restricted Project
nigelp-xmos requested review of D99092: [XCore][Test] XFAIL tests requiring 8-byte stack alignment..
Mar 22 2021, 10:26 AM · Restricted Project

Mar 19 2021

nigelp-xmos added reviewers for D98949: [XCore][Test] llvm-mc integrated assembler is unsupported.: colinl, grosbach.
Mar 19 2021, 7:16 AM · Restricted Project
nigelp-xmos requested review of D98949: [XCore][Test] llvm-mc integrated assembler is unsupported..
Mar 19 2021, 7:11 AM · Restricted Project

Mar 18 2021

nigelp-xmos committed rG1a6ab32f3365: [XCore] Remove XFAIL: xcore from passing test. (authored by nigelp-xmos).
[XCore] Remove XFAIL: xcore from passing test.
Mar 18 2021, 8:48 AM
nigelp-xmos closed D98352: [XCore] Remove XFAIL: xcore from passing test..
Mar 18 2021, 8:47 AM · Restricted Project
nigelp-xmos added reviewers for D98352: [XCore] Remove XFAIL: xcore from passing test.: dylanmckay, arsenm.

Add reviewer suggestions from CodeGen/Generic history.

Mar 18 2021, 7:31 AM · Restricted Project
nigelp-xmos committed rG251fe986afd3: [Test][DebugInfo] Check for backend object emission support. (authored by nigelp-xmos).
[Test][DebugInfo] Check for backend object emission support.
Mar 18 2021, 2:52 AM
nigelp-xmos closed D98400: [Test][DebugInfo] Check for backend object emission support..
Mar 18 2021, 2:52 AM · Restricted Project
nigelp-xmos added inline comments to D98400: [Test][DebugInfo] Check for backend object emission support..
Mar 18 2021, 2:33 AM · Restricted Project

Mar 13 2021

nigelp-xmos added a comment to D97943: [XCore] Build fewer components. Run 4 parallel jobs..

Thanks, Galina.

Mar 13 2021, 2:36 AM
nigelp-xmos committed rZORG258da7a6e288: [XCore] Build fewer components. Run 4 parallel jobs. (authored by nigelp-xmos).
[XCore] Build fewer components. Run 4 parallel jobs.
Mar 13 2021, 2:35 AM
nigelp-xmos closed D97943: [XCore] Build fewer components. Run 4 parallel jobs..
Mar 13 2021, 2:35 AM

Mar 12 2021

nigelp-xmos added reviewers for D98508: Restore lit feature object-emission: ted, JDevlieghere, probinson.
Mar 12 2021, 7:23 AM · Restricted Project
nigelp-xmos requested review of D98508: Restore lit feature object-emission.
Mar 12 2021, 7:15 AM · Restricted Project

Mar 11 2021

nigelp-xmos added a comment to D98400: [Test][DebugInfo] Check for backend object emission support..

Thanks @clayborg

Mar 11 2021, 10:54 PM · Restricted Project
nigelp-xmos updated the diff for D98400: [Test][DebugInfo] Check for backend object emission support..
  • Incorporate isConfigurationSupported in isObjectEmissionSupported
Mar 11 2021, 4:29 AM · Restricted Project
nigelp-xmos added a comment to D98400: [Test][DebugInfo] Check for backend object emission support..

@labath Thanks for the quick response. That looks like a good idea. I will try that.

Mar 11 2021, 2:23 AM · Restricted Project
nigelp-xmos added reviewers for D98400: [Test][DebugInfo] Check for backend object emission support.: clayborg, grimar, labath.
Mar 11 2021, 2:10 AM · Restricted Project
nigelp-xmos updated the diff for D98400: [Test][DebugInfo] Check for backend object emission support..

Run clang-format

Mar 11 2021, 2:05 AM · Restricted Project
nigelp-xmos requested review of D98400: [Test][DebugInfo] Check for backend object emission support..
Mar 11 2021, 2:01 AM · Restricted Project

Mar 10 2021

nigelp-xmos added reviewers for D98352: [XCore] Remove XFAIL: xcore from passing test.: dblaikie, ributzka.
Mar 10 2021, 7:38 AM · Restricted Project
nigelp-xmos requested review of D98352: [XCore] Remove XFAIL: xcore from passing test..
Mar 10 2021, 7:35 AM · Restricted Project

Mar 8 2021

nigelp-xmos updated the diff for D97943: [XCore] Build fewer components. Run 4 parallel jobs..

arc --update with all changes.

Mar 8 2021, 9:06 PM
nigelp-xmos updated the diff for D97943: [XCore] Build fewer components. Run 4 parallel jobs..

[XCore] Do not override LLVM_LIT_ARGS: use -j from the factory.

Mar 8 2021, 9:02 PM

Mar 4 2021

nigelp-xmos requested review of D97943: [XCore] Build fewer components. Run 4 parallel jobs..
Mar 4 2021, 6:04 AM

Mar 3 2021

nigelp-xmos closed D97270: Add buildbot for Clang for XCore target on Ubuntu host..

https://github.com/llvm/llvm-zorg/commit/f128ee547d9f4d1fc9480b9e95b6c119d9a08392

Mar 3 2021, 2:55 AM
nigelp-xmos committed rZORGf128ee547d9f: Add builder and worker for XCore as default target. (authored by nigelp-xmos).
Add builder and worker for XCore as default target.
Mar 3 2021, 2:53 AM
nigelp-xmos updated the diff for D97270: Add buildbot for Clang for XCore target on Ubuntu host..

Revise as per review comments.

Mar 3 2021, 2:41 AM
nigelp-xmos abandoned D97844: Revise as per review comments..

Created by mistake.

Mar 3 2021, 2:35 AM
nigelp-xmos requested review of D97844: Revise as per review comments..
Mar 3 2021, 2:34 AM

Feb 23 2021

nigelp-xmos requested review of D97270: Add buildbot for Clang for XCore target on Ubuntu host..
Feb 23 2021, 4:12 AM

Jan 14 2021

nigelp-xmos committed rG19297a417117: Change XCore code owner. (authored by nigelp-xmos).
Change XCore code owner.
Jan 14 2021, 4:15 AM

Jan 9 2021

nigelp-xmos added a comment to D93625: [NFC] [TEST] Fix the threads.ll for Windows.

I think this patch can be cancelled, because the issue is already fixed in the main branch. But please say if I have missed something.

Jan 9 2021, 2:58 AM · Restricted Project

Jan 5 2021

nigelp-xmos added a comment to D93625: [NFC] [TEST] Fix the threads.ll for Windows.

I've reproduced the failure. The test passes when I change -march=xcore to -mtriple=xcore-unknown-unknown, as in main branch commit https://github.com/llvm/llvm-project/commit/15ca54525d6c2927b2a51b871a9e343c7ce1c2ea. Does that commit solve this problem and unblock D91556 ? (I will continue to investigate to understand the reason for the register swap.)

Jan 5 2021, 6:15 AM · Restricted Project

Jan 4 2021

nigelp-xmos added a comment to D93625: [NFC] [TEST] Fix the threads.ll for Windows.

The specified XCore backend code owner has moved on from XMOS and from working on XCore. I will have a look at this patch.

Jan 4 2021, 4:44 AM · Restricted Project

Dec 8 2020

nigelp-xmos added a comment to D92108: Fix inconsistent availability attribute message string literal check..

Many thanks for review and approval. Please could it be committed as I do not have commit access? (I will request.)

Dec 8 2020, 3:12 AM · Restricted Project
nigelp-xmos added a comment to D92019: [XCore][docs] Fix XCore compiler writer documentation links..

Added reviewer suggestions from git history. If someone familiar with updating the documentation could commit for me, I would be grateful, as I do not have commit access.

Dec 8 2020, 3:07 AM · Restricted Project
nigelp-xmos added reviewers for D92019: [XCore][docs] Fix XCore compiler writer documentation links.: jryans, sdardis, craig.topper.
Dec 8 2020, 3:07 AM · Restricted Project

Nov 25 2020

nigelp-xmos updated the diff for D92108: Fix inconsistent availability attribute message string literal check..

Run clang-format

Nov 25 2020, 9:31 AM · Restricted Project
nigelp-xmos updated the diff for D92108: Fix inconsistent availability attribute message string literal check..

Run clang-format

Nov 25 2020, 9:27 AM · Restricted Project
nigelp-xmos added reviewers for D92108: Fix inconsistent availability attribute message string literal check.: doug.gregor, bkramer, majnemer.
Nov 25 2020, 8:51 AM · Restricted Project
nigelp-xmos added a comment to D92108: Fix inconsistent availability attribute message string literal check..

Alternatively, if all 1-byte-character strings are acceptable, should I remove the check that the first token is a string literal, and omit the failing test case on XCore?

Nov 25 2020, 8:48 AM · Restricted Project
nigelp-xmos requested review of D92108: Fix inconsistent availability attribute message string literal check..
Nov 25 2020, 8:44 AM · Restricted Project