This is an archive of the discontinued LLVM Phabricator instance.

Differential D124428

[RISCV] Add RV64Zbs invalid tests
ClosedPublic

Authored by Pretty-box on Apr 25 2022, 7:06 PM.

Details

Reviewers
benshi001
craig.topper
frasercrmck
asb
Commits
rGc15ae0a37dda: [RISCV][NFC] Add RV64Zbs invalid tests
Summary

The reason why this test file is added is because rv32zbs-invalid.s file already exists, but rv64zbs-invalid.s file is missing.

Diff Detail

Event Timeline

Pretty-box created this revision.Apr 25 2022, 7:06 PM
Herald added subscribers: sunshaoce, VincentWu, luke957 and 27 others. · View Herald TranscriptApr 25 2022, 7:06 PM
Pretty-box requested review of this revision.Apr 25 2022, 7:06 PM
Herald added subscribers: llvm-commits, • pcwang-thead, eopXD, MaskRay. · View Herald TranscriptApr 25 2022, 7:06 PM
craig.topper added inline comments.Apr 25 2022, 7:22 PM
llvm/test/MC/RISCV/rv64zbs-invalid.s
2

Can you test with riscv32 as well? The immediate ranges are different.

Pretty-box added inline comments.Apr 25 2022, 7:28 PM
llvm/test/MC/RISCV/rv64zbs-invalid.s
2

rv32zbs-invalid.s file already exists, but rv64zbs-invalid.s file is missing

Harbormaster completed remote builds in B161311: Diff 425103.Apr 25 2022, 8:45 PM
craig.topper accepted this revision.Apr 26 2022, 8:26 AM

LGTM

llvm/test/MC/RISCV/rv64zbs-invalid.s
2

Thanks. That would have been good information to put in the patch description.

This revision is now accepted and ready to land.Apr 26 2022, 8:26 AM
asb accepted this revision.Apr 26 2022, 8:29 AM
Pretty-box edited the summary of this revision. (Show Details)Apr 26 2022, 6:33 PM
This revision was landed with ongoing or failed builds.Apr 26 2022, 6:42 PM
Closed by commit rGc15ae0a37dda: [RISCV][NFC] Add RV64Zbs invalid tests (authored by Pretty-box, committed by benshi001). · Explain Why
This revision was automatically updated to reflect the committed changes.
benshi001 added a commit: rGc15ae0a37dda: [RISCV][NFC] Add RV64Zbs invalid tests.

Revision Contents

PathSize
llvm/
test/
MC/
RISCV/
30 lines

Diff 425389

llvm/test/MC/RISCV/rv64zbs-invalid.s

  • This file was added.
# RUN: not llvm-mc -triple riscv64 -mattr=+zbs < %s 2>&1 | FileCheck %s
craig.topperUnsubmitted
Not Done
ReplyInline Actions

Can you test with riscv32 as well? The immediate ranges are different.

craig.topper: Can you test with riscv32 as well? The immediate ranges are different.
Pretty-boxAuthorUnsubmitted
Done
ReplyInline Actions

rv32zbs-invalid.s file already exists, but rv64zbs-invalid.s file is missing

Pretty-box: rv32zbs-invalid.s file already exists, but rv64zbs-invalid.s file is missing
craig.topperUnsubmitted
Not Done
ReplyInline Actions

Thanks. That would have been good information to put in the patch description.

craig.topper: Thanks. That would have been good information to put in the patch description.
# Too few operands
bclr t0, t1 # CHECK: :[[@LINE]]:1: error: too few operands for instruction
# Too few operands
bset t0, t1 # CHECK: :[[@LINE]]:1: error: too few operands for instruction
# Too few operands
binv t0, t1 # CHECK: :[[@LINE]]:1: error: too few operands for instruction
# Too few operands
bext t0, t1 # CHECK: :[[@LINE]]:1: error: too few operands for instruction
# Too few operands
bclri t0, t1 # CHECK: :[[@LINE]]:1: error: too few operands for instruction
# Immediate operand out of range
bclri t0, t1, 64 # CHECK: :[[@LINE]]:15: error: immediate must be an integer in the range [0, 63]
bclri t0, t1, -1 # CHECK: :[[@LINE]]:15: error: immediate must be an integer in the range [0, 63]
# Too few operands
bseti t0, t1 # CHECK: :[[@LINE]]:1: error: too few operands for instruction
# Immediate operand out of range
bseti t0, t1, 64 # CHECK: :[[@LINE]]:15: error: immediate must be an integer in the range [0, 63]
bseti t0, t1, -1 # CHECK: :[[@LINE]]:15: error: immediate must be an integer in the range [0, 63]
# Too few operands
binvi t0, t1 # CHECK: :[[@LINE]]:1: error: too few operands for instruction
# Immediate operand out of range
binvi t0, t1, 64 # CHECK: :[[@LINE]]:15: error: immediate must be an integer in the range [0, 63]
binvi t0, t1, -1 # CHECK: :[[@LINE]]:15: error: immediate must be an integer in the range [0, 63]
# Too few operands
bexti t0, t1 # CHECK: :[[@LINE]]:1: error: too few operands for instruction
# Immediate operand out of range
bexti t0, t1, 64 # CHECK: :[[@LINE]]:15: error: immediate must be an integer in the range [0, 63]
bexti t0, t1, -1 # CHECK: :[[@LINE]]:15: error: immediate must be an integer in the range [0, 63]