This is an archive of the discontinued LLVM Phabricator instance.

[CUDA][HIP] Fix delete operator for -fopenmp
ClosedPublic

Authored by yaxunl on Apr 18 2022, 8:20 PM.

Details

Summary

When new operator is called in OpenMP parallel region,
delete operator is resolved and checked. Due to similar
issue fixed by https://reviews.llvm.org/D121765,
when resolving delete operator, the caller was not
determined correctly, which results in error as
shown in https://godbolt.org/z/jKhd8qKos.

This patch fixes the issue in a similar way as
https://reviews.llvm.org/D121765

Diff Detail

Event Timeline

yaxunl created this revision.Apr 18 2022, 8:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2022, 8:20 PM
yaxunl requested review of this revision.Apr 18 2022, 8:20 PM
yaxunl updated this revision to Diff 423515.Apr 18 2022, 8:33 PM

remove redundant casts.

tra accepted this revision.Apr 19 2022, 10:20 AM
This revision is now accepted and ready to land.Apr 19 2022, 10:20 AM
This revision was landed with ongoing or failed builds.Apr 19 2022, 11:47 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2022, 11:47 AM