Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Paths

Table of Contentst

Differential D123971

[clang][PS4] Enable SplitLTOUnits by default
ClosedPublic
Actions

Authored by ormris on Apr 18 2022, 5:45 PM.

Tags

Subscribers

Details

Reviewers

tejohnson
pcc
mehdi_amini
probinson

Commits

rG392b30680752: [clang][PS4] Enable SplitLTOUnits and Unified LTO by default

Summary

This patch contains the parts of the unified LTO pipeline specific to PS4/5. See this conversation: https://discourse.llvm.org/t/rfc-a-unified-lto-bitcode-frontend/61774/15

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

ormris created this revision.Apr 18 2022, 5:45 PM

Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2022, 5:45 PM

Herald added a subscriber: inglorion. · View Herald Transcript

ormris requested review of this revision.Apr 18 2022, 5:45 PM

Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2022, 5:45 PM

Herald added subscribers: llvm-commits, MaskRay. · View Herald Transcript

Harbormaster completed remote builds in B160138: Diff 423498.Apr 18 2022, 5:45 PM

ormris added a parent revision: D123803: [WIP][llvm] A Unified LTO Bitcode Frontend.Apr 18 2022, 5:45 PM

ormris added a reviewer: probinson.Apr 19 2022, 4:19 PM

If a vendor wants to change some driver default, that's fine, especially when on/off already has a condition. But please include full context per https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface and add a clang/test/Driver/ test.
Also, "SIE" isn't a clear abbreviation. PS4 seems more understandable by other contributors.

Add context.

Harbormaster completed remote builds in B161191: Diff 424943.Apr 25 2022, 9:39 AM

Changelog:

Rebased
Add tests

Herald added subscribers: steven_wu, hiraditya. · View Herald TranscriptMay 17 2023, 4:16 PM

Harbormaster completed remote builds in B232735: Diff 523213.May 17 2023, 4:17 PM

ormris edited parent revisions, added: D123804: [clang] A Unified LTO Bitcode Frontend; removed: D123803: [WIP][llvm] A Unified LTO Bitcode Frontend.May 18 2023, 11:54 AM

Attempt to fix pre-merge checks

Harbormaster completed remote builds in B233307: Diff 523950.May 19 2023, 6:05 PM

clang-format

Harbormaster completed remote builds in B234952: Diff 526179.May 26 2023, 1:17 PM

probinson added inline comments.Jun 8 2023, 12:54 PM

clang/test/Driver/split-lto-unit.c
2	This all shows that `-funified-lto` has the desired effect, but not what the defaults are (yes for PS4, no for e.g. linux).

Unified LTO default for all PlayStation targets
Add default case to tests
SplitLTOUnit not default for PS4

clang/test/Driver/split-lto-unit.c
2	Should be fixed.

Harbormaster completed remote builds in B237888: Diff 530117.Jun 9 2023, 5:00 PM

LGTM

This revision is now accepted and ready to land.Jun 29 2023, 10:57 AM

This revision was landed with ongoing or failed builds.Jul 11 2023, 4:25 PM

Closed by commit rG392b30680752: [clang][PS4] Enable SplitLTOUnits and Unified LTO by default (authored by ormris). · Explain Why

This revision was automatically updated to reflect the committed changes.

ormris added a commit: rG392b30680752: [clang][PS4] Enable SplitLTOUnits and Unified LTO by default.

Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2023, 4:25 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Thanks!

Revision Contents
Changeset List

Path

Size

clang/

lib/

Driver/

ToolChains/

5 lines

test/

CodeGen/

split-lto-unit.c

6 lines

CodeGenCXX/

unified-cfi-lto.cpp

2 lines

Driver/

5 lines

split-lto-unit.c

4 lines

Diff 539331

clang/lib/Driver/ToolChains/Clang.cpp

Loading...

clang/test/CodeGen/split-lto-unit.c

Loading...

clang/test/CodeGenCXX/unified-cfi-lto.cpp

Loading...

clang/test/Driver/lto-unit.c

Loading...

clang/test/Driver/split-lto-unit.c

Loading...