Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
llvm/test/CodeGen/RISCV/rvv/ctlz-sdnode.ll | ||
---|---|---|
2–5 | I still see common checks shared by all four test lines, so can we get more reduction by setting the prefixes of line4 and line5 to --check-prefixes=CHECK,CHECK-D,RV32,RV32D ? | |
llvm/test/CodeGen/RISCV/rvv/cttz-sdnode.ll | ||
3 | The same suggestion as abive, --check-prefixes=CHECK,CHECK-D,RV32,RV32D | |
llvm/test/CodeGen/RISCV/ssub_sat.ll | ||
2–5 | just simplify CHECK-RV32 to RV32 and CHECK-RV64 to RV64 | |
llvm/test/CodeGen/RISCV/ssub_sat_plus.ll | ||
5 | The save as above CHECK-RV32 -> RV32 and CHECK-RV64 -> RV64 | |
llvm/test/CodeGen/RISCV/unfold-masked-merge-scalar-variablemask.ll | ||
9 | still, we should keep CHECK if there are common lines shared by all, and add a CHECK-ZBB for the lines shared only by the last two tests. |
Retitle to [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines .
llvm/test/CodeGen/RISCV/ssub_sat.ll | ||
---|---|---|
4 | Need to remove unused prefix RV32IZbbNOZbt and probably others. This should be reproduceable running locally. |
llvm/test/CodeGen/RISCV/unfold-masked-merge-scalar-variablemask.ll | ||
---|---|---|
3 | CHECK-RV -> CHECK-I |
llvm/test/CodeGen/RISCV/ssub_sat.ll | ||
---|---|---|
2–5 | The RV32 prefix is confusing because zbt command lines don't use it. So it's really RV32NoZbt? |
llvm/test/CodeGen/RISCV/ssub_sat.ll | ||
---|---|---|
2–5 | yes, I agree with you. |
I still see common checks shared by all four test lines, so can we get more reduction by setting the prefixes of line4 and line5 to --check-prefixes=CHECK,CHECK-D,RV32,RV32D ?