This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines
ClosedPublic

Authored by Pretty-box on Apr 5 2022, 8:24 PM.

Diff Detail

Event Timeline

Pretty-box created this revision.Apr 5 2022, 8:24 PM
Pretty-box requested review of this revision.Apr 5 2022, 8:24 PM
benshi001 added inline comments.Apr 5 2022, 11:54 PM
llvm/test/CodeGen/RISCV/rvv/ctlz-sdnode.ll
2–5

I still see common checks shared by all four test lines, so can we get more reduction by setting the prefixes of line4 and line5 to --check-prefixes=CHECK,CHECK-D,RV32,RV32D ?

llvm/test/CodeGen/RISCV/rvv/cttz-sdnode.ll
3

The same suggestion as abive, --check-prefixes=CHECK,CHECK-D,RV32,RV32D

llvm/test/CodeGen/RISCV/ssub_sat.ll
2–5

just simplify CHECK-RV32 to RV32 and CHECK-RV64 to RV64

llvm/test/CodeGen/RISCV/ssub_sat_plus.ll
5

The save as above CHECK-RV32 -> RV32 and CHECK-RV64 -> RV64

llvm/test/CodeGen/RISCV/unfold-masked-merge-scalar-variablemask.ll
9

still, we should keep CHECK if there are common lines shared by all, and add a CHECK-ZBB for the lines shared only by the last two tests.

Retitle to [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines .

Pretty-box updated this revision to Diff 420737.Apr 6 2022, 1:37 AM
Pretty-box retitled this revision from [RISCV][NFC]Add some check prefixes to remove redundant checks in some IR tests to [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines.
frasercrmck added inline comments.Apr 6 2022, 4:06 AM
llvm/test/CodeGen/RISCV/ssub_sat.ll
4

Need to remove unused prefix RV32IZbbNOZbt and probably others. This should be reproduceable running locally.

Pretty-box updated this revision to Diff 421064.Apr 6 2022, 6:58 PM
Pretty-box marked 5 inline comments as done.
Pretty-box marked an inline comment as done.

address comments

benshi001 added inline comments.Apr 6 2022, 8:19 PM
llvm/test/CodeGen/RISCV/unfold-masked-merge-scalar-variablemask.ll
3

CHECK-RV -> CHECK-I

Pretty-box updated this revision to Diff 421075.Apr 6 2022, 8:42 PM
Pretty-box marked an inline comment as done.
benshi001 accepted this revision.Apr 6 2022, 8:50 PM
This revision is now accepted and ready to land.Apr 6 2022, 8:50 PM

Any thoughts on this change? Can I help Pretty-box commit it ?

craig.topper added inline comments.Apr 11 2022, 7:16 PM
llvm/test/CodeGen/RISCV/ssub_sat.ll
2–5

The RV32 prefix is confusing because zbt command lines don't use it. So it's really RV32NoZbt?

Pretty-box added inline comments.Apr 11 2022, 7:26 PM
llvm/test/CodeGen/RISCV/ssub_sat.ll
2–5

yes, I agree with you.

Pretty-box marked an inline comment as done.

Patch application failed, apparently. Maybe you need to rebase?

Patch application failed, apparently. Maybe you need to rebase?

done

frasercrmck accepted this revision.Apr 13 2022, 2:29 AM

LGTM, thanks

This revision was landed with ongoing or failed builds.Apr 13 2022, 3:01 AM
This revision was automatically updated to reflect the committed changes.