This is an archive of the discontinued LLVM Phabricator instance.

BuildLibCalls: infer allockind attributes on relevant functions
ClosedPublic

Authored by durin42 on Apr 4 2022, 3:17 PM.

Diff Detail

Event Timeline

durin42 created this revision.Apr 4 2022, 3:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 3:17 PM
durin42 requested review of this revision.Apr 4 2022, 3:17 PM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
durin42 updated this revision to Diff 420858.Apr 6 2022, 7:41 AM
durin42 edited the summary of this revision. (Show Details)
durin42 updated this revision to Diff 420919.Apr 6 2022, 9:10 AM
durin42 updated this revision to Diff 421211.Apr 7 2022, 7:36 AM
durin42 updated this revision to Diff 422246.Apr 12 2022, 8:33 AM
durin42 updated this revision to Diff 424972.Apr 25 2022, 10:55 AM
durin42 updated this revision to Diff 425071.Apr 25 2022, 5:15 PM
durin42 updated this revision to Diff 425365.Apr 26 2022, 5:35 PM
durin42 updated this revision to Diff 425497.Apr 27 2022, 6:05 AM
durin42 updated this revision to Diff 425840.Apr 28 2022, 10:34 AM
durin42 updated this revision to Diff 426088.Apr 29 2022, 9:29 AM
durin42 updated this revision to Diff 426096.Apr 29 2022, 9:34 AM
durin42 updated this revision to Diff 426408.May 2 2022, 7:04 AM
durin42 updated this revision to Diff 426733.May 3 2022, 8:47 AM
durin42 updated this revision to Diff 426775.May 3 2022, 10:45 AM
durin42 updated this revision to Diff 427089.May 4 2022, 11:36 AM
nikic added inline comments.May 4 2022, 1:16 PM
llvm/test/Transforms/InferFunctionAttrs/annotate.ll
223

What do these ALLOCKIND18 etc names stand for? Is that the integral value of the flags?

durin42 marked an inline comment as done.May 6 2022, 2:39 PM
durin42 added inline comments.
llvm/test/Transforms/InferFunctionAttrs/annotate.ll
223

Yeah, in a past version of this I hadn't come up with the hack to parse a string in the text IR, so they were integers. I've updated the values to have more meaningful names, even if they're verbose.

durin42 updated this revision to Diff 427754.May 6 2022, 2:40 PM
durin42 marked an inline comment as done.
nikic added inline comments.May 13 2022, 3:15 PM
llvm/lib/Transforms/Utils/BuildLibCalls.cpp
460

Missing Aligned for the aligned_alloc fallthrough?

durin42 updated this revision to Diff 430160.May 17 2022, 12:28 PM
durin42 marked an inline comment as done.May 17 2022, 12:28 PM
durin42 added inline comments.
llvm/lib/Transforms/Utils/BuildLibCalls.cpp
460

Very good catch, thank you! Fixed.

nikic accepted this revision.May 18 2022, 6:50 AM

LGTM

This revision is now accepted and ready to land.May 18 2022, 6:50 AM
This revision was landed with ongoing or failed builds.May 31 2022, 7:19 AM
This revision was automatically updated to reflect the committed changes.