- User Since
- Sep 30 2021, 10:00 AM (16 w, 5 h)
You've convinced me that we can at least combine the if statement and use an assert, though I'm weirded out by the test failures if I assert Family right after assigning it.
Tue, Jan 18
I'll poke the enum later today or first thing tomorrow. I got stuck in a tarpit of being sad about the arc command line tool today.
Fri, Jan 14
Split out vec_* functions and updated MSVC ::operator::new/delete to use the _actual_ mangled form.
Fixed new-delete-itanium.ll failure. Several comments in the free function list were incorrect and it didn't matter until now. Fixed that while I'm here.
After splitting the ::operator::new flavors into their own families, I'm getting a weird failure from new-delete-itanium.ll. test8 in that file should optimize to just ret void but instead a few calls are surviving:
Split up C++ new families per @jyknight
Fix table formatting goofs.
Fixed typo s/off/on/ in a clang-format directive. Sigh.
Reformatted table in anticipation of my next patch, which will embiggen the table enough that clang-format makes a mess of it.
Done. I don't have commit access, so if someone can push this I'd appreciate it. :)
(My next patch isn't actually done yet, but I figured I'd get this out for review early since it doesn't seem harmful on its own and I felt like was a nice cleanup of the function.)
Dec 10 2021
I don't have commit access, so could someone push this for me?
Dec 8 2021
No worries on the break, it happens. I'm not familiar enough with how the validation works to know if there's a way to have C++-specific validations.