Page MenuHomePhabricator

durin42 (Augie Fackler)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2021, 10:00 AM (16 w, 5 h)

Recent Activity

Today

durin42 requested review of D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.
Thu, Jan 20, 8:04 AM · Restricted Project
durin42 added a comment to D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.

You've convinced me that we can at least combine the if statement and use an assert, though I'm weirded out by the test failures if I assert Family right after assigning it.

Thu, Jan 20, 8:03 AM · Restricted Project

Tue, Jan 18

durin42 added a comment to D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.

PTAL

Tue, Jan 18, 4:52 PM · Restricted Project
durin42 updated the diff for D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.
Tue, Jan 18, 4:51 PM · Restricted Project
durin42 added a reviewer for D117624: [NFC] MemoryBuiltins: tease out a getFreeFunctionDataForFunction helper: reames.
Tue, Jan 18, 4:18 PM · Restricted Project
durin42 added a comment to D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.

I'll poke the enum later today or first thing tomorrow. I got stuck in a tarpit of being sad about the arc command line tool today.

Tue, Jan 18, 4:17 PM · Restricted Project
durin42 updated the diff for D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.
Tue, Jan 18, 4:11 PM · Restricted Project
durin42 requested review of D117624: [NFC] MemoryBuiltins: tease out a getFreeFunctionDataForFunction helper.
Tue, Jan 18, 4:11 PM · Restricted Project
durin42 updated the diff for D117350: MemoryBuiltins: simplify isLibFreeFunction.
Tue, Jan 18, 4:11 PM · Restricted Project

Fri, Jan 14

durin42 added a comment to D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.

Ah, @jyknight bailed me out. That's https://github.com/llvm/llvm-project/issues/40384 which looks related, yes. I suspect that would be resolved by this patch.

Fri, Jan 14, 3:13 PM · Restricted Project
durin42 added a comment to D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.

Is the issue being addressed similar to PR41039?

Fri, Jan 14, 3:10 PM · Restricted Project
durin42 updated the diff for D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.
Fri, Jan 14, 3:02 PM · Restricted Project
durin42 added a comment to D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.

Updated.

Fri, Jan 14, 3:01 PM · Restricted Project
durin42 updated the diff for D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.

Split out vec_* functions and updated MSVC ::operator::new/delete to use the _actual_ mangled form.

Fri, Jan 14, 3:01 PM · Restricted Project
durin42 updated the diff for D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.

Fixed new-delete-itanium.ll failure. Several comments in the free function list were incorrect and it didn't matter until now. Fixed that while I'm here.

Fri, Jan 14, 2:34 PM · Restricted Project
durin42 added a comment to D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.

After splitting the ::operator::new flavors into their own families, I'm getting a weird failure from new-delete-itanium.ll. test8 in that file should optimize to just ret void but instead a few calls are surviving:

Fri, Jan 14, 2:22 PM · Restricted Project
durin42 updated the diff for D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.
Fri, Jan 14, 2:10 PM · Restricted Project
durin42 updated the diff for D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.

Split up C++ new families per @jyknight

Fri, Jan 14, 1:44 PM · Restricted Project
durin42 updated the diff for D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.

Fix table formatting goofs.

Fri, Jan 14, 1:21 PM · Restricted Project
durin42 requested review of D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.
Fri, Jan 14, 1:18 PM · Restricted Project
durin42 added inline comments to D117350: MemoryBuiltins: simplify isLibFreeFunction.
Fri, Jan 14, 1:05 PM · Restricted Project
durin42 updated the diff for D117350: MemoryBuiltins: simplify isLibFreeFunction.

Fixed typo s/off/on/ in a clang-format directive. Sigh.

Fri, Jan 14, 1:05 PM · Restricted Project
durin42 updated the diff for D117350: MemoryBuiltins: simplify isLibFreeFunction.

Reformatted table in anticipation of my next patch, which will embiggen the table enough that clang-format makes a mess of it.

Fri, Jan 14, 1:03 PM · Restricted Project
durin42 added a comment to D117350: MemoryBuiltins: simplify isLibFreeFunction.

Done. I don't have commit access, so if someone can push this I'd appreciate it. :)

Fri, Jan 14, 12:26 PM · Restricted Project
durin42 retitled D117350: MemoryBuiltins: simplify isLibFreeFunction from MemoryBuiltins: simplify isLibFreeFunction to [NFC] MemoryBuiltins: simplify isLibFreeFunction.
Fri, Jan 14, 12:26 PM · Restricted Project
durin42 added a comment to D117350: MemoryBuiltins: simplify isLibFreeFunction.

(My next patch isn't actually done yet, but I figured I'd get this out for review early since it doesn't seem harmful on its own and I felt like was a nice cleanup of the function.)

Fri, Jan 14, 11:46 AM · Restricted Project
durin42 requested review of D117350: MemoryBuiltins: simplify isLibFreeFunction.
Fri, Jan 14, 11:45 AM · Restricted Project

Dec 10 2021

durin42 added a comment to D115353: Verifier: accept enums as scopes.

I don't have commit access, so could someone push this for me?

Dec 10 2021, 8:57 AM · Restricted Project

Dec 8 2021

durin42 added a comment to D115353: Verifier: accept enums as scopes.

No worries on the break, it happens. I'm not familiar enough with how the validation works to know if there's a way to have C++-specific validations.

Dec 8 2021, 10:30 AM · Restricted Project
durin42 requested review of D115353: Verifier: accept enums as scopes.
Dec 8 2021, 8:16 AM · Restricted Project