[AIX][XCOFF] print unsupported message for llvm-ar big archive write operation

[DiggerLin]

Summary

when run "llvm-ar cr" on AIX OS , it created a gnu archive, it is not desirable in aix OS.
instead of creating a gnu archive, the patch will print a unsupport message for llvm-ar big archive write operation in AIX OS.

after implement the big archive operation, I will revert the XFAIL: AIX " and "--format=gnu" test cases.

[jhenderson]

llvm/test/tools/llvm-ar/default-xcoff.test

2

I'm confused why this is system-aix but the XFAILed tests are just aix. I supsect they all want to be system-aix?

3

Let's use the term "Big" with upper-case 'B' to distinguish it from just a large archive.

12

Nit: too many blank lines at EOF.

llvm/test/tools/llvm-link/archivell.ll

1 ↗

(On Diff #419224)

What's the motivation for using --format=gnu in this and other test cases rather than the XFAIL option?

llvm/tools/llvm-ar/llvm-ar.cpp

948

llvm_unreachable is for use only when the program should never be able to reach this code. Clearly, here it can reach it (or you wouldn't need all those XFAILs in the tests). Instead, use fail like in the case BSD: case a few lines below.

Also, error messages should start with lower-case letter, as per the LLVM style guide.

1280

Undo this change. It's not relevant to the patch.

[DiggerLin]

llvm/test/tools/llvm-link/archivell.ll

1 ↗

(On Diff #419224)

Those test case do not test functionality of llvm-ar (archive), it test the llvm-link, llvm-readobj, or llvm-nm , I just want the test case go through in the AIX. the format is do not matter.

I will revert those test cases when I implement the writing operation of big archive.

[DiggerLin]

address James comment

[jhenderson]

LGTM.

[jsji]

LGTM. Thanks @DiggerLin !

llvm/tools/llvm-ar/llvm-ar.cpp

948

nit: Can we update the message to be more verbose? eg: big archive writer operation on AIX not yet supported?

llvm/test/tools/llvm-ar/Inputs/xcoff.yaml

+--- !XCOFF
+FileHeader:
+  MagicNumber:          0x1DF

llvm/test/tools/llvm-ar/default-xcoff.test

+; REQUIRES: system-aix 
+;; Test llvm-ar do not big AIX archive write operation.
+
+; RUN: yaml2obj %S/Inputs/xcoff.yaml -o %t.obj
+; RUN: rm -f %t.ar
+; RUN: not --crash llvm-ar cr %t.ar %t.obj 2>&1 | FileCheck %s 
+; RUN: echo "test big archive" > %t.txt
+; RUN: not --crash llvm-ar cr %t.ar %t.txt 2>&1 | FileCheck %s
+
+; CHECK: Unsupported big AIX write operation   
+

llvm/tools/llvm-ar/llvm-ar.cpp

 #include "llvm/BinaryFormat/Magic.h"
 #include "llvm/IR/LLVMContext.h"
 #include "llvm/Object/Archive.h"
 #include "llvm/Object/ArchiveWriter.h"
 #include "llvm/Object/IRObjectFile.h"
 #include "llvm/Object/MachO.h"
 #include "llvm/Object/ObjectFile.h"
 #include "llvm/Object/SymbolicFile.h"
+#include "llvm/Object/XCOFFObjectFile.h"
 #include "llvm/Support/Chrono.h"
 #include "llvm/Support/CommandLine.h"
 #include "llvm/Support/ConvertUTF.h"
 #include "llvm/Support/Errc.h"
 #include "llvm/Support/FileSystem.h"
 #include "llvm/Support/Format.h"
 #include "llvm/Support/FormatVariadic.h"
 #include "llvm/Support/Host.h"
computeNewArchiveMembers(ArchiveOperation Operation,
   Ret.reserve(Ret.size() + NewMembers.size());
   std::move(NewMembers.begin(), NewMembers.end(),
             std::inserter(Ret, std::next(Ret.begin(), InsertPos)));
 
   return Ret;
 }
 
 static object::Archive::Kind getDefaultForHost() {
-  return Triple(sys::getProcessTriple()).isOSDarwin()
+  Triple HostTriple(sys::getProcessTriple());
+  return HostTriple.isOSDarwin()
              ? object::Archive::K_DARWIN
-             : object::Archive::K_GNU;
+             : (HostTriple.isOSAIX() ? object::Archive::K_AIXBIG
+                                     : object::Archive::K_GNU);
 }
 
 static object::Archive::Kind getKindFromMember(const NewArchiveMember &Member) {
   auto MemBufferRef = Member.Buf->getMemBufferRef();
   Expected<std::unique_ptr<object::ObjectFile>> OptionalObject =
       object::ObjectFile::createObjectFile(MemBufferRef);
 
   if (OptionalObject)
     return isa<object::MachOObjectFile>(**OptionalObject)
                ? object::Archive::K_DARWIN
-               : object::Archive::K_GNU;
+               : (isa<object::XCOFFObjectFile>(**OptionalObject)
+                      ? object::Archive::K_AIXBIG
+                      : object::Archive::K_GNU);
 
   // squelch the error in case we had a non-object file
   consumeError(OptionalObject.takeError());
 
   // If we're adding a bitcode file to the archive, detect the Archive kind
   // based on the target triple.
   LLVMContext Context;
   if (identify_magic(MemBufferRef.getBuffer()) == file_magic::bitcode) {
case Default:
     else if (OldArchive)
       Kind = OldArchive->kind();
     else if (NewMembersP)
       Kind = !NewMembersP->empty() ? getKindFromMember(NewMembersP->front())
                                    : getDefaultForHost();
     else
       Kind = !NewMembers.empty() ? getKindFromMember(NewMembers.front())
                                  : getDefaultForHost();
+    if (Kind == object::Archive::K_AIXBIG)
+      llvm_unreachable("Unsupported big AIX write operation");
     break;
   case GNU:
     Kind = object::Archive::K_GNU;
     break;
   case BSD:
     if (Thin)
       fail("only the gnu format has a thin mode");
     Kind = object::Archive::K_BSD;
if (handleGenericOption(arg)) {
           return 0;
         } else {
           // TODO: GNU ranlib also supports a -t flag
           fail("Invalid option: '-" + arg + "'");
         }
         arg = arg.drop_front(1);
       }
     } else {
-      if (ArchiveSpecified)
         fail("exactly one archive should be specified");
+        if (ArchiveSpecified)
           ArchiveSpecified = true;
         ArchiveName = arg.str();
     }
   }
   if (!ArchiveSpecified) {
     badUsage("an archive name must be specified");
   }
   return performOperation(CreateSymTab, nullptr);
 }