This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] [NFC] Add Immediate tests for the cmov instruction
ClosedPublic

Authored by Miss_Grape on Mar 30 2022, 4:52 AM.

Diff Detail

Event Timeline

Miss_Grape created this revision.Mar 30 2022, 4:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 4:52 AM
Miss_Grape requested review of this revision.Mar 30 2022, 4:52 AM
Miss_Grape retitled this revision from WIP [RISCV] [NFC] Add tests for cmov to [RISCV] [NFC] Add Immediate tests for the cmov instruction.
craig.topper added inline comments.Mar 30 2022, 9:30 AM
llvm/test/CodeGen/RISCV/i32-icmp.ll
211 ↗(On Diff #419123)

Why are you changing unsigned constants to signed? Wasn't unsigned requested in the previous review?

Why are you changing unsigned constants to signed? Wasn't unsigned requested in the previous review?

Fixed

This revision is now accepted and ready to land.Apr 5 2022, 7:23 PM
This revision was landed with ongoing or failed builds.Apr 5 2022, 8:09 PM
This revision was automatically updated to reflect the committed changes.