[X86][NFC] Generate mnemonic tables

[Amir]

Summary

Produce mnemonic tables, adding the functions to llvm::X86 namespace.

[RKSimon]

llvm/lib/Target/X86/CMakeLists.txt

12

(sorting)

[Amir]

Sort

[skan]

LGTM

[uabelho]

Hello,

I noticed that if compilng with ubsan
-DLLVM_USE_SANITIZER='Undefined'
you get the following error when compiling llc with this patch:

FAILED: lib/Target/X86/X86GenMnemonicTables.inc
cd /repo/uabelho/master-github/llvm/build-all-bbisdk-ubsan && /repo/uabelho/master-github/llvm/build-all-bbisdk-ubsan/bin/llvm-tblgen -gen-x86-mnemonic-tables -asmwriternum=1 -I /repo/uabelho/master-github/llvm/lib/Target/X86 -I/repo/uabelho/master-github/llvm/build-all-bbisdk-ubsan/include -I/repo/uabelho/master-github/llvm/include -I /repo/uabelho/master-github/llvm/lib/Target /repo/uabelho/master-github/llvm/lib/Target/X86/X86.td --write-if-changed -o lib/Target/X86/X86GenMnemonicTables.inc -d lib/Target/X86/X86GenMnemonicTables.inc.d
../utils/TableGen/X86MnemonicTables.cpp:52:29: runtime error: load of value 170, which is not a valid value for type 'bool'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../utils/TableGen/X86MnemonicTables.cpp:52:29 in

[Amir]

In D121572#3396218, @uabelho wrote:

Hello,

I noticed that if compilng with ubsan
-DLLVM_USE_SANITIZER='Undefined'
you get the following error when compiling llc with this patch:

FAILED: lib/Target/X86/X86GenMnemonicTables.inc
cd /repo/uabelho/master-github/llvm/build-all-bbisdk-ubsan && /repo/uabelho/master-github/llvm/build-all-bbisdk-ubsan/bin/llvm-tblgen -gen-x86-mnemonic-tables -asmwriternum=1 -I /repo/uabelho/master-github/llvm/lib/Target/X86 -I/repo/uabelho/master-github/llvm/build-all-bbisdk-ubsan/include -I/repo/uabelho/master-github/llvm/include -I /repo/uabelho/master-github/llvm/lib/Target /repo/uabelho/master-github/llvm/lib/Target/X86/X86.td --write-if-changed -o lib/Target/X86/X86GenMnemonicTables.inc -d lib/Target/X86/X86GenMnemonicTables.inc.d
../utils/TableGen/X86MnemonicTables.cpp:52:29: runtime error: load of value 170, which is not a valid value for type 'bool'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../utils/TableGen/X86MnemonicTables.cpp:52:29 in

Hello and thanks for reporting! Working on it. Note there's an earlier report here: https://reviews.llvm.org/D121571#3396209

[uabelho]

In D121572#3396262, @Amir wrote:

In D121572#3396218, @uabelho wrote:

Hello,

I noticed that if compilng with ubsan
-DLLVM_USE_SANITIZER='Undefined'
you get the following error when compiling llc with this patch:

FAILED: lib/Target/X86/X86GenMnemonicTables.inc
cd /repo/uabelho/master-github/llvm/build-all-bbisdk-ubsan && /repo/uabelho/master-github/llvm/build-all-bbisdk-ubsan/bin/llvm-tblgen -gen-x86-mnemonic-tables -asmwriternum=1 -I /repo/uabelho/master-github/llvm/lib/Target/X86 -I/repo/uabelho/master-github/llvm/build-all-bbisdk-ubsan/include -I/repo/uabelho/master-github/llvm/include -I /repo/uabelho/master-github/llvm/lib/Target /repo/uabelho/master-github/llvm/lib/Target/X86/X86.td --write-if-changed -o lib/Target/X86/X86GenMnemonicTables.inc -d lib/Target/X86/X86GenMnemonicTables.inc.d
../utils/TableGen/X86MnemonicTables.cpp:52:29: runtime error: load of value 170, which is not a valid value for type 'bool'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../utils/TableGen/X86MnemonicTables.cpp:52:29 in

Hello and thanks for reporting! Working on it. Note there's an earlier report here: https://reviews.llvm.org/D121571#3396209

Great! Thanks!

[Amir]

D122140

llvm/lib/Target/X86/CMakeLists.txt

 add_llvm_component_group(X86 HAS_JIT)
 
 set(LLVM_TARGET_DEFINITIONS X86.td)
 
 tablegen(LLVM X86GenAsmMatcher.inc -gen-asm-matcher)
 tablegen(LLVM X86GenAsmWriter.inc -gen-asm-writer)
 tablegen(LLVM X86GenAsmWriter1.inc -gen-asm-writer -asmwriternum=1)
 tablegen(LLVM X86GenCallingConv.inc -gen-callingconv)
 tablegen(LLVM X86GenDAGISel.inc -gen-dag-isel)
 tablegen(LLVM X86GenDisassemblerTables.inc -gen-disassembler)
 tablegen(LLVM X86GenEVEX2VEXTables.inc -gen-x86-EVEX2VEX-tables)
 tablegen(LLVM X86GenExegesis.inc -gen-exegesis)
 tablegen(LLVM X86GenFastISel.inc -gen-fast-isel)
 tablegen(LLVM X86GenGlobalISel.inc -gen-global-isel)
 tablegen(LLVM X86GenInstrInfo.inc -gen-instr-info)
+tablegen(LLVM X86GenMnemonicTables.inc -gen-x86-mnemonic-tables -asmwriternum=1)
 tablegen(LLVM X86GenRegisterBank.inc -gen-register-bank)
 tablegen(LLVM X86GenRegisterInfo.inc -gen-register-info)
 tablegen(LLVM X86GenSubtargetInfo.inc -gen-subtarget)
 
 if (X86_GEN_FOLD_TABLES)
   tablegen(LLVM X86GenFoldTables.inc -gen-x86-fold-tables)
 endif()
 

llvm/lib/Target/X86/MCTargetDesc/CMakeLists.txt

 add_llvm_component_library(LLVMX86Desc
   X86ATTInstPrinter.cpp
   X86IntelInstPrinter.cpp
   X86InstComments.cpp
   X86InstPrinterCommon.cpp
   X86InstrRelaxTables.cpp
   X86ShuffleDecode.cpp
   X86AsmBackend.cpp
   X86MCTargetDesc.cpp
   X86MCAsmInfo.cpp
   X86MCCodeEmitter.cpp
   X86MachObjectWriter.cpp
+  X86MnemonicTables.cpp
   X86ELFObjectWriter.cpp
   X86WinCOFFObjectWriter.cpp
   X86WinCOFFStreamer.cpp
   X86WinCOFFTargetStreamer.cpp
 
   LINK_COMPONENTS
   MC
   MCDisassembler
   Support
   X86Info
   BinaryFormat
 
   ADD_TO_COMPONENT
   X86
   )

llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.h

 //
 #define GET_INSTRINFO_ENUM
 #define GET_INSTRINFO_MC_HELPER_DECLS
 #include "X86GenInstrInfo.inc"
 
 #define GET_SUBTARGETINFO_ENUM
 #include "X86GenSubtargetInfo.inc"
 
+#define GET_X86_MNEMONIC_TABLES_H
+#include "X86GenMnemonicTables.inc"
+
 #endif

llvm/lib/Target/X86/MCTargetDesc/X86MnemonicTables.cpp

+//===-- X86MnemonicTables.cpp - X86 Mnemonic Tables -------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+//
+// This file provides X86 mnemonic tables.
+//
+//===----------------------------------------------------------------------===//
+
+#include "X86InstrInfo.h"
+
+#define GET_X86_MNEMONIC_TABLES_CPP
+#include "X86GenMnemonicTables.inc"