This is an archive of the discontinued LLVM Phabricator instance.

Differential D121562

Move the IR and Interfaces library to a new mlir/core subdirectory (NFC)
AcceptedPublic

Authored by mehdi_amini on Mar 13 2022, 5:57 PM.

Details

Reviewers
rriddle
stellaraccident
antiagainst
aartbik
aaron.ballman
Summary

This is a first step in the repo restructuring, see:

https://discourse.llvm.org/t/rfc-restructuring-of-the-mlir-repo/4927

Diff Detail

Event Timeline

mehdi_amini created this revision.Mar 13 2022, 5:57 PM
Herald added a reviewer: antiagainst. · View Herald TranscriptMar 13 2022, 5:57 PM
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: aaron.ballman. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 22 others. · View Herald Transcript
mehdi_amini requested review of this revision.Mar 13 2022, 5:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2022, 5:57 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rriddle added a comment.Mar 13 2022, 6:01 PM

Can you refresh on what all is intended to go into this core/ directory?

mehdi_amini added a comment.Mar 13 2022, 6:05 PM

The original proposal had:

        Parser/
        Pass/
        PDL/
        Rewrite/
        Support/
        TableGen/
``

But I haven't checked if there has been new directories recently, I was planning to send reviews one directory at a time
Harbormaster completed remote builds in B154015: Diff 414969.Mar 13 2022, 6:13 PM
stellaraccident added a comment.Mar 13 2022, 6:24 PM

We need some coordination on the CMake include changes. Left some comments but also open to patching what you have and poking at it.

mlir/CMakeLists.txt
144

Why wouldn't it be practical? I think if you add the generated binary include dir at the library level similar to how adding the source include, it should work (or it will once the AddLLVM.cmake changes in https://reviews.llvm.org/D120788 go in).

mlir/core/include/CMakeLists.txt
2

What is your expectation that these include_directories are doing?

mlir/core/lib/IR/CMakeLists.txt
60

This isn't quite sufficient.

We will also at least need the changes to llvm_add_library from https://reviews.llvm.org/D120788 (sorry meant to triage the build issues and land this ahead of you).

If we're going this way for the whole tree, then I think I should back out the $<BUILD_INTERFACE:${MLIR_SOURCE_DIR}/include> from the above patch (i.e. only auto-add the the generated files include dir in add_mlir_library). Thoughts?

61

This should be:

$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../include>
mlir/core/lib/Interfaces/CMakeLists.txt
16

I think you need to set target_include_directories here and below as well.

stellaraccident added inline comments.Mar 13 2022, 6:34 PM
mlir/CMakeLists.txt
144

I think it is actually pretty important that we fix this before submission so that these include_directories are not required for the new core directories. If they are excluded, then the in-tree includes will be a good mirror/test as for out of tree usage. As written, every out of tree may need to specify these manually in some way if something is gotten wrong.

If it fails in-tree with these removed, that is an indication that we just broke everyone else :)

mehdi_amini added inline comments.Mar 13 2022, 6:40 PM
mlir/CMakeLists.txt
144

The problem I see is every single call to mlir_tablegen need to express a dependency on some target in core to get the include path somehow to resolve things like mlir/IR/OpBase.td.

mlir/core/include/CMakeLists.txt
2

Oh this is some leftover test I was doing, this is not doing anything useful.

mlir/core/lib/IR/CMakeLists.txt
60

I think both target_include_directories path in your patch becomes obsolete then, the generated binary files are also in a different paths?

I'm don't really understand the CMake model of how this all interacts with out-of-tree users unfortunately.

61

Oh right!

mlir/core/lib/Interfaces/CMakeLists.txt
16

Right.
It works now because there is a dependency here on MLIRIR which already provides the include path.

jpienaar added a subscriber: jpienaar.Mar 13 2022, 6:52 PM

Could the RFC be updated with the final state planned here, intermediate steps that will be followed etc? Currently it is unclear from the RFC what state is (e.g., RFC seems unfinished/conversation just ended 27 days ago seemingly open ended), the end state unclear (as seen from review comments) and steps to get there unknown (e.g., is this just breaking changes in a row?). Judging each individually is convenient thanks. Test file locations is still a bit unclear too: seems like this is changing dir hierarchy but not affecting tests which is curious as I thought a goal was to have the association be easier, and for out of tree to be able to follow the structure closer.

mlir/core/include/mlir/Interfaces/DataLayoutInterfaces.h
15

Shouldn't header guards be updated?

mehdi_amini updated this revision to Diff 414973.Mar 13 2022, 6:56 PM

Address Stella's comments

mehdi_amini marked 5 inline comments as done.Mar 13 2022, 6:58 PM
mehdi_amini added inline comments.
mlir/CMakeLists.txt
144

I "fixed" it by removing it from here and moving it in mlir_tablegen : see in mlir/cmake/modules/AddMLIR.cmake.

mlir/cmake/modules/AddMLIR.cmake
7

@stellaraccident : I'm not sure this has a downside?

7–8

This is unrelated to the current patch, I'll try to land this ahead.

mlir/core/include/mlir/Interfaces/DataLayoutInterfaces.h
15

From the install path point of view, nothing changed?

Harbormaster completed remote builds in B154018: Diff 414973.Mar 13 2022, 7:06 PM
stellaraccident added inline comments.Mar 13 2022, 7:07 PM
mlir/CMakeLists.txt
144

Ugh, the tablegen macros are... esoteric and I recall them being weird.

So here is the relevant bit from TableGen.cmake:

get_directory_property(tblgen_includes INCLUDE_DIRECTORIES)
list(TRANSFORM tblgen_includes PREPEND -I)

My personal opinion: we should extend the tablegen function to allow its include directories to be set in another way and sever this dependency on directory-level include_directories. Options here include:

  • extending the current state a bit more and consulting any TABLEGEN_INCLUDES variable in scope (in addition to the directory property)
  • using source file properties in some way (not recommended)
  • teaching tablegen() how to parse arguments like everything else does and have an INCLUDES section on it.

So we also have this lovely thing going on:

function(mlir_tablegen ofn)
  tablegen(MLIR ${ARGV})
  set(TABLEGEN_OUTPUT ${TABLEGEN_OUTPUT} ${CMAKE_CURRENT_BINARY_DIR}/${ofn}
      PARENT_SCOPE)
  include_directories(${CMAKE_CURRENT_BINARY_DIR})
endfunction()

That last include_directories gives me the creeps and we should figure out how to excise it. I think that is explaining why I sometimes see redundant include directories on the tablegen invocations (since multiple calls to tablegen in the same directory will just blindly append the current binary directory INCLUDE_DIRECTORIES directory property multiple times).

I do think that we need to fix this before landing this change: This is already really fragile for out of tree users and making it worse means that everyone adds yet more opaque top level includes that don't make a lot of sense to their projects.

mlir/core/lib/IR/CMakeLists.txt
60

I think both target_include_directories path in your patch becomes obsolete then, the generated binary files are also in a different paths?

I'm don't really understand the CMake model of how this all interacts with out-of-tree users unfortunately.

Yes, was just following up with Marius on that patch and think it should not be needed if being explicit like this. I'll abandon that patch and apply the fixes to llvm/ libraries separately.

The general idea is that you need to make sure that all of the paths needed to include headers make it into INTERFACE_INCLUDE_DIRECTORIES on each library target. The usual way to do that is to call target_include_directories(tgt PUBLIC ...). This appends to both the INTERFACE_INCLUDE_DIRECTORIES and INCLUDE_DIRECTORIES properties on the target. The first is used by libraries that depend on this one. The second is used to build the libraries. Just calling include_directories(...) at the directory level means that every target created in that directory or below will magically have those directories added to its INCLUDE_DIRECTORIES property. This is sufficient to build but offers nothing to people depending/using it.

So you really want to be in a world where you are only using target_include_directories(tgt PUBLIC ...) with no usage of directory level include_directories(...) as that treats all users the same (in tree or out of tree). There may also be occasional need to use target_include_directories(tgt PRIVATE ...) for truly implementation-only include directories, but I don't think we have any of those in practice for this project.

There is another wrinkle: out of tree *installed* users will also get their include directories from INTERFACE_INCLUDE_DIRECTORIES. So typically, we would also want to have something like $<INSTALL_INTERFACE:include>. We may just want to add that automatically in add_mlir_library with something like:

target_include_directories(${name} INTERFACE "$<INSTALL_INTERFACE:include>")

I think we can get away with just doing it the once in the global macro because we squash all include trees down to the one for installation. I didn't recommend doing this in this patch because it isn't regressing the current state to exclude it (there is already some global CMake-ism that slides it in there in that case).

stellaraccident added inline comments.Mar 13 2022, 7:10 PM
mlir/CMakeLists.txt
144

Ok, that is better (it at least won't apply to the whole tree, which will hide bugs).

mlir/cmake/modules/AddMLIR.cmake
7

Yeah, see my comment that we just mid-air collided on. These are not just setting variables in scope. They are appending to the current directory INCLUDE_DIRECTORIES property, which is global. So every time we call mlir_tablegen in a directory, it will get two more. If this is just to get us out of a weird state, we can probably live with it, but better to create a way to directly instruct the tablegen() function to do exactly what we want without it consulting global properties.

mehdi_amini marked 3 inline comments as done.Mar 13 2022, 9:34 PM
mehdi_amini added inline comments.
mlir/core/lib/IR/CMakeLists.txt
60

The general idea is that you need to make sure that all of the paths needed to include headers make it into INTERFACE_INCLUDE_DIRECTORIES on each library target.

Right. Now how do you translate this to TableGen though?

The thing is that we don't even declare the DEPENDS right now since we rely on the global include flag set in the top level CMakeLists as far as I can tell. If this was a C++ library, we'd have the tablegen invocation that has an #include "mlir/IR/OpBase.td" also has a DEPENDS on a target that provide the include path.

We may have to start by revamping the whole TableGen cmake machinery to work closer to regular libraries? (that is to begin with: setting up and reading the "properties" set on dependencies)

mstorsjo removed a subscriber: mstorsjo.Mar 13 2022, 9:56 PM
mehdi_amini updated this revision to Diff 414996.Mar 13 2022, 10:04 PM

Rebase

mehdi_amini added a parent revision: D121568: Add cmake_parse_arguments() to `tablegen()` CMake function.Mar 13 2022, 10:05 PM
mehdi_amini marked an inline comment as done.
mehdi_amini added inline comments.
mlir/cmake/modules/AddMLIR.cmake
7

PTAL!

mehdi_amini marked 3 inline comments as done.Mar 13 2022, 10:08 PM
Harbormaster completed remote builds in B154033: Diff 414996.Mar 13 2022, 10:26 PM
stellaraccident added inline comments.Mar 13 2022, 10:27 PM
mlir/cmake/modules/AddMLIR.cmake
7

So for the interim, we just hard-code all tablegen directories here? I can live with that until we get the refactor landed and can then turn these into more of first class targets (which is what we do in IREE, and it makes a lot of the kind of weird dependency issues we have upstream impossible).

Does this actually work? (or is this dependent on an update to TableGen.cmake that is separate?)

mlir/core/lib/IR/CMakeLists.txt
60

I'd like to aim for revamping it (these concepts can be translated to tablegen but it was never really integrated right), but would like to unblock this work with something minimal to get started with. The directory structure you have proposed is a lot more amenable to something better and if we can get that minimally working, we can then come back and revamp.

stellaraccident accepted this revision.Mar 13 2022, 10:36 PM

Found the dependent https://reviews.llvm.org/D121568. With that, these CMake changes look good to me (at least to the level of unblocking the refactor -- I think we will want to come back and clean some things up when you are done).

This revision is now accepted and ready to land.Mar 13 2022, 10:36 PM
rriddle requested changes to this revision.Mar 13 2022, 10:45 PM

I'd prefer we resolve Jacques comments, and get a good understanding of what the final plan is before moving forward with anything (adding a block until then).

This revision now requires changes to proceed.Mar 13 2022, 10:45 PM
rriddle added a comment.Mar 13 2022, 11:02 PM
In D121562#3378546, @rriddle wrote:

I'd prefer we resolve Jacques comments, and get a good understanding of what the final plan is before moving forward with anything (adding a block until then).

By "final plan" here, I don't mean the perfect state of the world. I'm more interested in communicating with the community what is happening right now, and the path we will take moving forward (even if it's incremental).

rriddle accepted this revision.Mar 13 2022, 11:12 PM

LGTM on the patch itself, but I think core/ should retain a lib/ directory. I don't see a huge cost in doing so, and it has a big benefit (IMO) of maintaining the separation between public/private API.

Relaying the current plan to the community though is still very important to me here, and I think that should be done before we starting submitting patches.

This revision is now accepted and ready to land.Mar 13 2022, 11:12 PM
stellaraccident added a comment.Mar 13 2022, 11:19 PM

(agreed with River: my acceptance is of the cmake changes specifically, which look good and I think are big step forward for the project)

mehdi_amini updated this revision to Diff 415019.Mar 14 2022, 12:45 AM

Fix standalone test

mehdi_amini updated this revision to Diff 415020.Mar 14 2022, 12:53 AM

Move under core/lib/...

mehdi_amini mentioned this in D121577: Move MLIR CAPI to mlir/core (NFC).Mar 14 2022, 1:01 AM
Harbormaster completed remote builds in B154052: Diff 415020.Mar 14 2022, 1:03 AM
mehdi_amini added a child revision: D121577: Move MLIR CAPI to mlir/core (NFC).Mar 14 2022, 1:10 AM

Large Diff

This large diff affects 330 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
mlir/
27 lines
cmake/
modules/
36 lines
1 line
core/
2 lines
include/
1 line
mlir/
3 lines
lib/
2 lines
core/
include/
mlir/
IR/
364 lines
345 lines
596 lines
74 lines
256 lines
300 lines
368 lines
99 lines
262 lines
523 lines
317 lines
471 lines
984 lines
1113 lines
25 lines
40 lines
272 lines
61 lines
273 lines
191 lines
500 lines
1026 lines
62 lines
652 lines
497 lines
132 lines
180 lines
226 lines
99 lines
113 lines
297 lines
558 lines
114 lines
149 lines
163 lines
247 lines
373 lines
108 lines
3257 lines
1993 lines
1367 lines
777 lines
1247 lines
67 lines
1094 lines
355 lines
85 lines
45 lines
64 lines
189 lines
24 lines
114 lines
241 lines
389 lines
21 lines
44 lines
153 lines
227 lines
234 lines
102 lines
299 lines
301 lines
538 lines
22 lines
324 lines
Interfaces/
36 lines
31 lines
90 lines
22 lines
51 lines
177 lines
263 lines
21 lines
38 lines
187 lines
355 lines
37 lines
21 lines
46 lines
49 lines
294 lines
187 lines
34 lines
86 lines
193 lines
269 lines
85 lines
26 lines
104 lines
35 lines
249 lines
136 lines
482 lines
lib/
IR/
1415 lines
97 lines
766 lines
68 lines
3014 lines
359 lines
49 lines
358 lines
475 lines
89 lines
1389 lines
327 lines
51 lines
1053 lines
3 lines
976 lines
218 lines
351 lines
371 lines
322 lines
78 lines
57 lines
123 lines
1016 lines
1199 lines
738 lines
363 lines
245 lines
18 lines
65 lines
1111 lines
17 lines
150 lines
60 lines
173 lines
96 lines
215 lines
360 lines
207 lines
Interfaces/
56 lines
38 lines
17 lines
349 lines
18 lines
565 lines
19 lines
218 lines
101 lines
97 lines
17 lines
31 lines
242 lines
examples/
standalone/
1 line
include/
2 lines
mlir-c/
1 line
mlir/
4 lines
IR/
Interfaces/
lib/
2 lines
IR/
Interfaces/
test/
mlir-pdll/
CodeGen/
MLIR/
2 lines
Parser/
2 lines
2 lines
2 lines
2 lines
mlir-tblgen/
2 lines
4 lines
4 lines
2 lines
4 lines
4 lines
2 lines
2 lines
2 lines
6 lines
8 lines
26 lines
2 lines
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
14 lines
2 lines
2 lines
4 lines

Diff 415020

mlir/CMakeLists.txt

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Linesset(MLIR_DETECT_PYTHON_ENV_PRIME_SEARCH 1 CACHE BOOL
detection issues)") detection issues)")
if(MLIR_ENABLE_BINDINGS_PYTHON) if(MLIR_ENABLE_BINDINGS_PYTHON)
include(MLIRDetectPythonEnv) include(MLIRDetectPythonEnv)
mlir_configure_python_dev_packages() mlir_configure_python_dev_packages()
endif() endif()
include_directories( "include") include_directories( "include")
include_directories( ${MLIR_INCLUDE_DIR}) include_directories( ${MLIR_INCLUDE_DIR})
stellaraccidentUnsubmitted
Done
ReplyInline Actions

Why wouldn't it be practical? I think if you add the generated binary include dir at the library level similar to how adding the source include, it should work (or it will once the AddLLVM.cmake changes in https://reviews.llvm.org/D120788 go in).

stellaraccident: Why wouldn't it be practical? I think if you add the generated binary include dir at the…
mehdi_aminiAuthorUnsubmitted
Done
ReplyInline Actions

The problem I see is every single call to mlir_tablegen need to express a dependency on some target in core to get the include path somehow to resolve things like mlir/IR/OpBase.td.

mehdi_amini: The problem I see is every single call to `mlir_tablegen` need to express a dependency on some…
stellaraccidentUnsubmitted
Not Done
ReplyInline Actions

Ugh, the tablegen macros are... esoteric and I recall them being weird.

So here is the relevant bit from TableGen.cmake:

get_directory_property(tblgen_includes INCLUDE_DIRECTORIES)
list(TRANSFORM tblgen_includes PREPEND -I)

My personal opinion: we should extend the tablegen function to allow its include directories to be set in another way and sever this dependency on directory-level include_directories. Options here include:

  • extending the current state a bit more and consulting any TABLEGEN_INCLUDES variable in scope (in addition to the directory property)
  • using source file properties in some way (not recommended)
  • teaching tablegen() how to parse arguments like everything else does and have an INCLUDES section on it.

So we also have this lovely thing going on:

function(mlir_tablegen ofn)
  tablegen(MLIR ${ARGV})
  set(TABLEGEN_OUTPUT ${TABLEGEN_OUTPUT} ${CMAKE_CURRENT_BINARY_DIR}/${ofn}
      PARENT_SCOPE)
  include_directories(${CMAKE_CURRENT_BINARY_DIR})
endfunction()

That last include_directories gives me the creeps and we should figure out how to excise it. I think that is explaining why I sometimes see redundant include directories on the tablegen invocations (since multiple calls to tablegen in the same directory will just blindly append the current binary directory INCLUDE_DIRECTORIES directory property multiple times).

I do think that we need to fix this before landing this change: This is already really fragile for out of tree users and making it worse means that everyone adds yet more opaque top level includes that don't make a lot of sense to their projects.

stellaraccident: Ugh, the tablegen macros are... esoteric and I recall them being weird. So here is the…
stellaraccidentUnsubmitted
Done
ReplyInline Actions

I think it is actually pretty important that we fix this before submission so that these include_directories are not required for the new core directories. If they are excluded, then the in-tree includes will be a good mirror/test as for out of tree usage. As written, every out of tree may need to specify these manually in some way if something is gotten wrong.

If it fails in-tree with these removed, that is an indication that we just broke everyone else :)

stellaraccident: I think it is actually pretty important that we fix this before submission so that these…
mehdi_aminiAuthorUnsubmitted
Done
ReplyInline Actions

I "fixed" it by removing it from here and moving it in mlir_tablegen : see in mlir/cmake/modules/AddMLIR.cmake.

mehdi_amini: I "fixed" it by removing it from here and moving it in `mlir_tablegen` : see in…
stellaraccidentUnsubmitted
Done
ReplyInline Actions

Ok, that is better (it at least won't apply to the whole tree, which will hide bugs).

stellaraccident: Ok, that is better (it at least won't apply to the whole tree, which will hide bugs).
# Adding tools/mlir-tblgen here as calling add_tablegen sets some variables like # Adding tools/mlir-tblgen here as calling add_tablegen sets some variables like
# MLIR_TABLEGEN_EXE in PARENT_SCOPE which gets lost if that folder is included # MLIR_TABLEGEN_EXE in PARENT_SCOPE which gets lost if that folder is included
# from another directory like tools # from another directory like tools
add_subdirectory(tools/mlir-tblgen) add_subdirectory(tools/mlir-tblgen)
add_subdirectory(tools/mlir-linalg-ods-gen) add_subdirectory(tools/mlir-linalg-ods-gen)
add_subdirectory(include/mlir) add_subdirectory(core)
add_subdirectory(include)
add_subdirectory(lib) add_subdirectory(lib)
# C API needs all dialects for registration, but should be built before tests. # C API needs all dialects for registration, but should be built before tests.
add_subdirectory(lib/CAPI) add_subdirectory(lib/CAPI)
if (MLIR_INCLUDE_TESTS) if (MLIR_INCLUDE_TESTS)
add_definitions(-DMLIR_INCLUDE_TESTS) add_definitions(-DMLIR_INCLUDE_TESTS)
add_custom_target(MLIRUnitTests) add_custom_target(MLIRUnitTests)
if (EXISTS ${LLVM_MAIN_SRC_DIR}/utils/unittest/googletest/include/gtest/gtest.h) if (EXISTS ${LLVM_MAIN_SRC_DIR}/utils/unittest/googletest/include/gtest/gtest.h)
Show All 18 Lines
option(MLIR_INCLUDE_DOCS "Generate build targets for the MLIR docs." option(MLIR_INCLUDE_DOCS "Generate build targets for the MLIR docs."
${LLVM_INCLUDE_DOCS}) ${LLVM_INCLUDE_DOCS})
if (MLIR_INCLUDE_DOCS) if (MLIR_INCLUDE_DOCS)
add_subdirectory(docs) add_subdirectory(docs)
endif() endif()
if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY) if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
install(DIRECTORY include/mlir include/mlir-c
DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}"
COMPONENT mlir-headers
FILES_MATCHING
PATTERN "*.def"
PATTERN "*.h"
PATTERN "*.inc"
PATTERN "*.td"
PATTERN "LICENSE.TXT"
)
install(DIRECTORY ${MLIR_INCLUDE_DIR}/mlir ${MLIR_INCLUDE_DIR}/mlir-c
DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}"
COMPONENT mlir-headers
FILES_MATCHING
PATTERN "*.def"
PATTERN "*.h"
PATTERN "*.gen"
PATTERN "*.inc"
PATTERN "*.td"
PATTERN "CMakeFiles" EXCLUDE
PATTERN "config.h" EXCLUDE
)
if (NOT LLVM_ENABLE_IDE) if (NOT LLVM_ENABLE_IDE)
add_llvm_install_targets(install-mlir-headers add_llvm_install_targets(install-mlir-headers
DEPENDS mlir-headers DEPENDS mlir-headers
COMPONENT mlir-headers) COMPONENT mlir-headers)
endif() endif()
endif() endif()
add_subdirectory(cmake/modules) add_subdirectory(cmake/modules)
if (MLIR_ENABLE_PYTHON_BENCHMARKS) if (MLIR_ENABLE_PYTHON_BENCHMARKS)
add_subdirectory(utils/mbr) add_subdirectory(utils/mbr)
endif() endif()

mlir/cmake/modules/AddMLIR.cmake

include(GNUInstallDirs) include(GNUInstallDirs)
include(LLVMDistributionSupport) include(LLVMDistributionSupport)
function(mlir_tablegen ofn) function(mlir_tablegen ofn)
tablegen(MLIR ${ARGV}) # Add the core includes to make things like OpBase.td always available.
tablegen(MLIR ${ARGV}
EXTRA_INCLUDES
mehdi_aminiAuthorUnsubmitted
Done
ReplyInline Actions

@stellaraccident : I'm not sure this has a downside?

mehdi_amini: @stellaraccident : I'm not sure this has a downside?
stellaraccidentUnsubmitted
Done
ReplyInline Actions

Yeah, see my comment that we just mid-air collided on. These are not just setting variables in scope. They are appending to the current directory INCLUDE_DIRECTORIES property, which is global. So every time we call mlir_tablegen in a directory, it will get two more. If this is just to get us out of a weird state, we can probably live with it, but better to create a way to directly instruct the tablegen() function to do exactly what we want without it consulting global properties.

stellaraccident: Yeah, see my comment that we just mid-air collided on. These are not just setting variables in…
mehdi_aminiAuthorUnsubmitted
Done
ReplyInline Actions

PTAL!

mehdi_amini: PTAL!
stellaraccidentUnsubmitted
Not Done
ReplyInline Actions

So for the interim, we just hard-code all tablegen directories here? I can live with that until we get the refactor landed and can then turn these into more of first class targets (which is what we do in IREE, and it makes a lot of the kind of weird dependency issues we have upstream impossible).

Does this actually work? (or is this dependent on an update to TableGen.cmake that is separate?)

stellaraccident: So for the interim, we just hard-code all tablegen directories here? I can live with that until…
${MLIR_MAIN_SRC_DIR}/core/include
${MLIR_BINARY_DIR}/core/include)
set(TABLEGEN_OUTPUT ${TABLEGEN_OUTPUT} ${CMAKE_CURRENT_BINARY_DIR}/${ofn} set(TABLEGEN_OUTPUT ${TABLEGEN_OUTPUT} ${CMAKE_CURRENT_BINARY_DIR}/${ofn}
PARENT_SCOPE) PARENT_SCOPE)
endfunction() endfunction()
mehdi_aminiAuthorUnsubmitted
Done
ReplyInline Actions

This is unrelated to the current patch, I'll try to land this ahead.

mehdi_amini: This is unrelated to the current patch, I'll try to land this ahead.
# Declare a dialect in the include directory # Declare a dialect in the include directory
function(add_mlir_dialect dialect dialect_namespace) function(add_mlir_dialect dialect dialect_namespace)
set(LLVM_TARGET_DEFINITIONS ${dialect}.td) set(LLVM_TARGET_DEFINITIONS ${dialect}.td)
mlir_tablegen(${dialect}.h.inc -gen-op-decls) mlir_tablegen(${dialect}.h.inc -gen-op-decls)
mlir_tablegen(${dialect}.cpp.inc -gen-op-defs) mlir_tablegen(${dialect}.cpp.inc -gen-op-defs)
mlir_tablegen(${dialect}Types.h.inc -gen-typedef-decls -typedefs-dialect=${dialect_namespace}) mlir_tablegen(${dialect}Types.h.inc -gen-typedef-decls -typedefs-dialect=${dialect_namespace})
mlir_tablegen(${dialect}Types.cpp.inc -gen-typedef-defs -typedefs-dialect=${dialect_namespace}) mlir_tablegen(${dialect}Types.cpp.inc -gen-typedef-defs -typedefs-dialect=${dialect_namespace})
▲ Show 20 Lines • Show All 437 Lines • ▼ Show 20 Linesfunction(mlir_check_all_link_libraries name)
if(TARGET ${name}) if(TARGET ${name})
get_target_property(libs ${name} LINK_LIBRARIES) get_target_property(libs ${name} LINK_LIBRARIES)
# message("${name} libs are: ${libs}") # message("${name} libs are: ${libs}")
foreach(lib ${libs}) foreach(lib ${libs})
mlir_check_link_libraries(${lib}) mlir_check_link_libraries(${lib})
endforeach() endforeach()
endif() endif()
endfunction(mlir_check_all_link_libraries) endfunction(mlir_check_all_link_libraries)
function(add_mlir_current_dir_public_header_dir)
if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}"
COMPONENT mlir-headers
FILES_MATCHING
PATTERN "*.def"
PATTERN "*.h"
PATTERN "*.inc"
PATTERN "*.td"
PATTERN "LICENSE.TXT"
PATTERN "CMakeFiles" EXCLUDE
PATTERN "config.h" EXCLUDE
)
install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}"
COMPONENT mlir-headers
FILES_MATCHING
PATTERN "*.def"
PATTERN "*.h"
PATTERN "*.gen"
PATTERN "*.inc"
PATTERN "*.td"
PATTERN "CMakeFiles" EXCLUDE
PATTERN "config.h" EXCLUDE
)
endif()
endfunction(add_mlir_current_dir_public_header_dir)
No newline at end of file

mlir/cmake/modules/MLIRConfig.cmake.in

mlir/core/CMakeLists.txt

mlir/core/include/CMakeLists.txt

  • This file was added.
add_subdirectory(mlir)
stellaraccidentUnsubmitted
Done
ReplyInline Actions

What is your expectation that these include_directories are doing?

stellaraccident: What is your expectation that these include_directories are doing?
mehdi_aminiAuthorUnsubmitted
Done
ReplyInline Actions

Oh this is some leftover test I was doing, this is not doing anything useful.

mehdi_amini: Oh this is some leftover test I was doing, this is not doing anything useful.

mlir/core/include/mlir/CMakeLists.txt

mlir/core/include/mlir/IR/AffineExpr.h

mlir/core/include/mlir/IR/AffineExprVisitor.h

mlir/core/include/mlir/IR/AffineMap.h

mlir/core/include/mlir/IR/AsmState.h

mlir/core/include/mlir/IR/AttributeSupport.h

mlir/core/include/mlir/IR/Attributes.h

mlir/core/include/mlir/IR/Block.h

mlir/core/include/mlir/IR/BlockAndValueMapping.h

mlir/core/include/mlir/IR/BlockSupport.h

mlir/core/include/mlir/IR/Builders.h

mlir/core/include/mlir/IR/BuiltinAttributeInterfaces.h

mlir/core/include/mlir/IR/BuiltinAttributeInterfaces.td

mlir/core/include/mlir/IR/BuiltinAttributes.h

mlir/core/include/mlir/IR/BuiltinAttributes.td

mlir/core/include/mlir/IR/BuiltinDialect.h

mlir/core/include/mlir/IR/BuiltinDialect.td

mlir/core/include/mlir/IR/BuiltinLocationAttributes.td

mlir/core/include/mlir/IR/BuiltinOps.h

mlir/core/include/mlir/IR/BuiltinOps.td

mlir/core/include/mlir/IR/BuiltinTypeInterfaces.td

mlir/core/include/mlir/IR/BuiltinTypes.h

mlir/core/include/mlir/IR/BuiltinTypes.td

mlir/core/include/mlir/IR/CMakeLists.txt

mlir/core/include/mlir/IR/Diagnostics.h

mlir/core/include/mlir/IR/Dialect.h

mlir/core/include/mlir/IR/DialectImplementation.h

mlir/core/include/mlir/IR/DialectInterface.h

mlir/core/include/mlir/IR/Dominance.h

mlir/core/include/mlir/IR/EnumAttr.td

mlir/core/include/mlir/IR/FunctionImplementation.h

mlir/core/include/mlir/IR/FunctionInterfaces.h

mlir/core/include/mlir/IR/FunctionInterfaces.td

mlir/core/include/mlir/IR/ImplicitLocOpBuilder.h

mlir/core/include/mlir/IR/IntegerSet.h

mlir/core/include/mlir/IR/Location.h

mlir/core/include/mlir/IR/MLIRContext.h

mlir/core/include/mlir/IR/Matchers.h

mlir/core/include/mlir/IR/OpAsmInterface.td

mlir/core/include/mlir/IR/OpBase.td

mlir/core/include/mlir/IR/OpDefinition.h

mlir/core/include/mlir/IR/OpImplementation.h

mlir/core/include/mlir/IR/Operation.h

mlir/core/include/mlir/IR/OperationSupport.h

mlir/core/include/mlir/IR/OwningOpRef.h

mlir/core/include/mlir/IR/PatternMatch.h

mlir/core/include/mlir/IR/Region.h

mlir/core/include/mlir/IR/RegionGraphTraits.h

mlir/core/include/mlir/IR/RegionKindInterface.h

mlir/core/include/mlir/IR/RegionKindInterface.td

mlir/core/include/mlir/IR/StorageUniquerSupport.h

mlir/core/include/mlir/IR/SubElementInterfaces.h

mlir/core/include/mlir/IR/SubElementInterfaces.td

mlir/core/include/mlir/IR/SymbolInterfaces.td

mlir/core/include/mlir/IR/SymbolTable.h

mlir/core/include/mlir/IR/TensorEncoding.h

mlir/core/include/mlir/IR/TensorEncoding.td

mlir/core/include/mlir/IR/Threading.h

mlir/core/include/mlir/IR/TypeRange.h

mlir/core/include/mlir/IR/TypeSupport.h

mlir/core/include/mlir/IR/TypeUtilities.h

mlir/core/include/mlir/IR/Types.h

mlir/core/include/mlir/IR/UseDefLists.h

mlir/core/include/mlir/IR/Value.h

mlir/core/include/mlir/IR/Verifier.h

mlir/core/include/mlir/IR/Visitors.h

mlir/core/include/mlir/Interfaces/CMakeLists.txt

mlir/core/include/mlir/Interfaces/CallInterfaces.h

mlir/core/include/mlir/Interfaces/CallInterfaces.td

mlir/core/include/mlir/Interfaces/CastInterfaces.h

mlir/core/include/mlir/Interfaces/CastInterfaces.td

mlir/core/include/mlir/Interfaces/ControlFlowInterfaces.h

mlir/core/include/mlir/Interfaces/ControlFlowInterfaces.td

mlir/core/include/mlir/Interfaces/CopyOpInterface.h

mlir/core/include/mlir/Interfaces/CopyOpInterface.td

mlir/core/include/mlir/Interfaces/DataLayoutInterfaces.h

  • This file was moved from mlir/include/mlir/Interfaces/DataLayoutInterfaces.h.
//===- DataLayoutInterfaces.h - Data Layout Interface Decls -----*- C++ -*-===// //===- DataLayoutInterfaces.h - Data Layout Interface Decls -----*- C++ -*-===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Defines the interfaces for the data layout specification, operations to which // Defines the interfaces for the data layout specification, operations to which
// they can be attached, types subject to data layout and dialects containing // they can be attached, types subject to data layout and dialects containing
// data layout entries. // data layout entries.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef MLIR_INTERFACES_DATALAYOUTINTERFACES_H #ifndef MLIR_INTERFACES_DATALAYOUTINTERFACES_H
jpienaarUnsubmitted
Done
ReplyInline Actions

Shouldn't header guards be updated?

jpienaar: Shouldn't header guards be updated?
mehdi_aminiAuthorUnsubmitted
Done
ReplyInline Actions

From the install path point of view, nothing changed?

mehdi_amini: From the install path point of view, nothing changed?
#define MLIR_INTERFACES_DATALAYOUTINTERFACES_H #define MLIR_INTERFACES_DATALAYOUTINTERFACES_H
#include "mlir/IR/DialectInterface.h" #include "mlir/IR/DialectInterface.h"
#include "mlir/IR/OpDefinition.h" #include "mlir/IR/OpDefinition.h"
#include "llvm/ADT/DenseMap.h" #include "llvm/ADT/DenseMap.h"
namespace mlir { namespace mlir {
class DataLayout; class DataLayout;
▲ Show 20 Lines • Show All 164 Lines • Show Last 20 Lines

mlir/core/include/mlir/Interfaces/DataLayoutInterfaces.td

mlir/core/include/mlir/Interfaces/DecodeAttributesInterfaces.h

mlir/core/include/mlir/Interfaces/DerivedAttributeOpInterface.h

mlir/core/include/mlir/Interfaces/DerivedAttributeOpInterface.td

mlir/core/include/mlir/Interfaces/FoldInterfaces.h

mlir/core/include/mlir/Interfaces/InferTypeOpInterface.h

mlir/core/include/mlir/Interfaces/InferTypeOpInterface.td

mlir/core/include/mlir/Interfaces/LoopLikeInterface.h

mlir/core/include/mlir/Interfaces/LoopLikeInterface.td

mlir/core/include/mlir/Interfaces/SideEffectInterfaceBase.td

mlir/core/include/mlir/Interfaces/SideEffectInterfaces.h

mlir/core/include/mlir/Interfaces/SideEffectInterfaces.td

mlir/core/include/mlir/Interfaces/TilingInterface.h

mlir/core/include/mlir/Interfaces/TilingInterface.td

mlir/core/include/mlir/Interfaces/VectorInterfaces.h

mlir/core/include/mlir/Interfaces/VectorInterfaces.td

mlir/core/include/mlir/Interfaces/ViewLikeInterface.h

mlir/core/include/mlir/Interfaces/ViewLikeInterface.td

mlir/core/lib/CMakeLists.txt

mlir/core/lib/IR/AffineExpr.cpp

mlir/core/lib/IR/AffineExprDetail.h

mlir/core/lib/IR/AffineMap.cpp

mlir/core/lib/IR/AffineMapDetail.h

mlir/core/lib/IR/AsmPrinter.cpp

mlir/core/lib/IR/AttributeDetail.h

mlir/core/lib/IR/Attributes.cpp

mlir/core/lib/IR/Block.cpp

mlir/core/lib/IR/Builders.cpp

mlir/core/lib/IR/BuiltinAttributeInterfaces.cpp

mlir/core/lib/IR/BuiltinAttributes.cpp

mlir/core/lib/IR/BuiltinDialect.cpp

mlir/core/lib/IR/BuiltinTypeInterfaces.cpp

mlir/core/lib/IR/BuiltinTypes.cpp

mlir/core/lib/IR/CMakeLists.txt

  • This file was moved from mlir/lib/IR/CMakeLists.txt.
Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Linesadd_mlir_library(MLIRIR
MLIRSideEffectInterfacesIncGen MLIRSideEffectInterfacesIncGen
MLIRSubElementInterfacesIncGen MLIRSubElementInterfacesIncGen
MLIRSymbolInterfacesIncGen MLIRSymbolInterfacesIncGen
MLIRTensorEncodingIncGen MLIRTensorEncodingIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRSupport MLIRSupport
) )
target_include_directories(MLIRIR PUBLIC
stellaraccidentUnsubmitted
Done
ReplyInline Actions

This isn't quite sufficient.

We will also at least need the changes to llvm_add_library from https://reviews.llvm.org/D120788 (sorry meant to triage the build issues and land this ahead of you).

If we're going this way for the whole tree, then I think I should back out the $<BUILD_INTERFACE:${MLIR_SOURCE_DIR}/include> from the above patch (i.e. only auto-add the the generated files include dir in add_mlir_library). Thoughts?

stellaraccident: This isn't quite sufficient. We will also at least need the changes to llvm_add_library from…
mehdi_aminiAuthorUnsubmitted
Done
ReplyInline Actions

I think both target_include_directories path in your patch becomes obsolete then, the generated binary files are also in a different paths?

I'm don't really understand the CMake model of how this all interacts with out-of-tree users unfortunately.

mehdi_amini: I think both `target_include_directories` path in your patch becomes obsolete then, the…
stellaraccidentUnsubmitted
Done
ReplyInline Actions

I think both target_include_directories path in your patch becomes obsolete then, the generated binary files are also in a different paths?

I'm don't really understand the CMake model of how this all interacts with out-of-tree users unfortunately.

Yes, was just following up with Marius on that patch and think it should not be needed if being explicit like this. I'll abandon that patch and apply the fixes to llvm/ libraries separately.

The general idea is that you need to make sure that all of the paths needed to include headers make it into INTERFACE_INCLUDE_DIRECTORIES on each library target. The usual way to do that is to call target_include_directories(tgt PUBLIC ...). This appends to both the INTERFACE_INCLUDE_DIRECTORIES and INCLUDE_DIRECTORIES properties on the target. The first is used by libraries that depend on this one. The second is used to build the libraries. Just calling include_directories(...) at the directory level means that every target created in that directory or below will magically have those directories added to its INCLUDE_DIRECTORIES property. This is sufficient to build but offers nothing to people depending/using it.

So you really want to be in a world where you are only using target_include_directories(tgt PUBLIC ...) with no usage of directory level include_directories(...) as that treats all users the same (in tree or out of tree). There may also be occasional need to use target_include_directories(tgt PRIVATE ...) for truly implementation-only include directories, but I don't think we have any of those in practice for this project.

There is another wrinkle: out of tree *installed* users will also get their include directories from INTERFACE_INCLUDE_DIRECTORIES. So typically, we would also want to have something like $<INSTALL_INTERFACE:include>. We may just want to add that automatically in add_mlir_library with something like:

target_include_directories(${name} INTERFACE "$<INSTALL_INTERFACE:include>")

I think we can get away with just doing it the once in the global macro because we squash all include trees down to the one for installation. I didn't recommend doing this in this patch because it isn't regressing the current state to exclude it (there is already some global CMake-ism that slides it in there in that case).

stellaraccident: > I think both `target_include_directories` path in your patch becomes obsolete then, the…
mehdi_aminiAuthorUnsubmitted
Done
ReplyInline Actions

The general idea is that you need to make sure that all of the paths needed to include headers make it into INTERFACE_INCLUDE_DIRECTORIES on each library target.

Right. Now how do you translate this to TableGen though?

The thing is that we don't even declare the DEPENDS right now since we rely on the global include flag set in the top level CMakeLists as far as I can tell. If this was a C++ library, we'd have the tablegen invocation that has an #include "mlir/IR/OpBase.td" also has a DEPENDS on a target that provide the include path.

We may have to start by revamping the whole TableGen cmake machinery to work closer to regular libraries? (that is to begin with: setting up and reading the "properties" set on dependencies)

mehdi_amini: > The general idea is that you need to make sure that all of the paths needed to include…
stellaraccidentUnsubmitted
Not Done
ReplyInline Actions

I'd like to aim for revamping it (these concepts can be translated to tablegen but it was never really integrated right), but would like to unblock this work with something minimal to get started with. The directory structure you have proposed is a lot more amenable to something better and if we can get that minimally working, we can then come back and revamp.

stellaraccident: I'd like to aim for revamping it (these concepts can be translated to tablegen but it was never…
$<BUILD_INTERFACE:${MLIR_SOURCE_DIR}/core/include>
stellaraccidentUnsubmitted
Done
ReplyInline Actions

This should be:

$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../include>
stellaraccident: This should be: ``` $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../include> ```
mehdi_aminiAuthorUnsubmitted
Done
ReplyInline Actions

Oh right!

mehdi_amini: Oh right!
)

mlir/core/lib/IR/Diagnostics.cpp

mlir/core/lib/IR/Dialect.cpp

mlir/core/lib/IR/Dominance.cpp

mlir/core/lib/IR/FunctionImplementation.cpp

mlir/core/lib/IR/FunctionInterfaces.cpp

mlir/core/lib/IR/IntegerSet.cpp

mlir/core/lib/IR/IntegerSetDetail.h

mlir/core/lib/IR/Location.cpp

mlir/core/lib/IR/MLIRContext.cpp

mlir/core/lib/IR/Operation.cpp

mlir/core/lib/IR/OperationSupport.cpp

mlir/core/lib/IR/PatternMatch.cpp

mlir/core/lib/IR/Region.cpp

mlir/core/lib/IR/RegionKindInterface.cpp

mlir/core/lib/IR/SubElementInterfaces.cpp

mlir/core/lib/IR/SymbolTable.cpp

mlir/core/lib/IR/TensorEncoding.cpp

mlir/core/lib/IR/TypeDetail.h

mlir/core/lib/IR/TypeRange.cpp

mlir/core/lib/IR/TypeUtilities.cpp

mlir/core/lib/IR/Types.cpp

mlir/core/lib/IR/Value.cpp

mlir/core/lib/IR/Verifier.cpp

mlir/core/lib/IR/Visitors.cpp

mlir/core/lib/Interfaces/CMakeLists.txt

  • This file was moved from mlir/lib/Interfaces/CMakeLists.txt.
set(LLVM_OPTIONAL_SOURCES set(LLVM_OPTIONAL_SOURCES
CallInterfaces.cpp CallInterfaces.cpp
CastInterfaces.cpp CastInterfaces.cpp
ControlFlowInterfaces.cpp ControlFlowInterfaces.cpp
CopyOpInterface.cpp CopyOpInterface.cpp
DataLayoutInterfaces.cpp DataLayoutInterfaces.cpp
DerivedAttributeOpInterface.cpp DerivedAttributeOpInterface.cpp
InferTypeOpInterface.cpp InferTypeOpInterface.cpp
LoopLikeInterface.cpp LoopLikeInterface.cpp
SideEffectInterfaces.cpp SideEffectInterfaces.cpp
TilingInterface.cpp TilingInterface.cpp
VectorInterfaces.cpp VectorInterfaces.cpp
ViewLikeInterface.cpp ViewLikeInterface.cpp
) )
function(add_mlir_interface_library name) function(add_mlir_interface_library name)
stellaraccidentUnsubmitted
Not Done
ReplyInline Actions

I think you need to set target_include_directories here and below as well.

stellaraccident: I think you need to set target_include_directories here and below as well.
mehdi_aminiAuthorUnsubmitted
Done
ReplyInline Actions

Right.
It works now because there is a dependency here on MLIRIR which already provides the include path.

mehdi_amini: Right. It works now because there is a dependency here on MLIRIR which already provides the…
add_mlir_library(MLIR${name} add_mlir_library(MLIR${name}
${name}.cpp ${name}.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
DEPENDS DEPENDS
MLIR${name}IncGen MLIR${name}IncGen
Show All 32 Lines

mlir/core/lib/Interfaces/CallInterfaces.cpp

mlir/core/lib/Interfaces/CastInterfaces.cpp

mlir/core/lib/Interfaces/ControlFlowInterfaces.cpp

mlir/core/lib/Interfaces/CopyOpInterface.cpp

mlir/core/lib/Interfaces/DataLayoutInterfaces.cpp

mlir/core/lib/Interfaces/DerivedAttributeOpInterface.cpp

mlir/core/lib/Interfaces/InferTypeOpInterface.cpp

mlir/core/lib/Interfaces/LoopLikeInterface.cpp

mlir/core/lib/Interfaces/SideEffectInterfaces.cpp

mlir/core/lib/Interfaces/TilingInterface.cpp

mlir/core/lib/Interfaces/VectorInterfaces.cpp

mlir/core/lib/Interfaces/ViewLikeInterface.cpp

mlir/examples/standalone/CMakeLists.txt

mlir/include/CMakeLists.txt

mlir/include/mlir-c/CMakeLists.txt

mlir/include/mlir/CMakeLists.txt

mlir/include/mlir/IR/AffineExpr.h

mlir/include/mlir/IR/AffineExprVisitor.h

mlir/include/mlir/IR/AffineMap.h

mlir/include/mlir/IR/AsmState.h

mlir/include/mlir/IR/AttributeSupport.h

mlir/include/mlir/IR/Attributes.h

mlir/include/mlir/IR/Block.h

mlir/include/mlir/IR/BlockAndValueMapping.h

mlir/include/mlir/IR/BlockSupport.h

mlir/include/mlir/IR/Builders.h

mlir/include/mlir/IR/BuiltinAttributeInterfaces.h

mlir/include/mlir/IR/BuiltinAttributeInterfaces.td

mlir/include/mlir/IR/BuiltinAttributes.h

mlir/include/mlir/IR/BuiltinAttributes.td

mlir/include/mlir/IR/BuiltinDialect.h

mlir/include/mlir/IR/BuiltinDialect.td

mlir/include/mlir/IR/BuiltinLocationAttributes.td

mlir/include/mlir/IR/BuiltinOps.h

mlir/include/mlir/IR/BuiltinOps.td

mlir/include/mlir/IR/BuiltinTypeInterfaces.td

mlir/include/mlir/IR/BuiltinTypes.h

mlir/include/mlir/IR/BuiltinTypes.td

mlir/include/mlir/IR/CMakeLists.txt

mlir/include/mlir/IR/Diagnostics.h

mlir/include/mlir/IR/Dialect.h

mlir/include/mlir/IR/DialectImplementation.h

mlir/include/mlir/IR/DialectInterface.h

mlir/include/mlir/IR/Dominance.h

mlir/include/mlir/IR/EnumAttr.td

mlir/include/mlir/IR/FunctionImplementation.h

mlir/include/mlir/IR/FunctionInterfaces.h

mlir/include/mlir/IR/FunctionInterfaces.td

mlir/include/mlir/IR/ImplicitLocOpBuilder.h

mlir/include/mlir/IR/IntegerSet.h

mlir/include/mlir/IR/Location.h

mlir/include/mlir/IR/MLIRContext.h

mlir/include/mlir/IR/Matchers.h

mlir/include/mlir/IR/OpAsmInterface.td

mlir/include/mlir/IR/OpBase.td

mlir/include/mlir/IR/OpDefinition.h

mlir/include/mlir/IR/OpImplementation.h

mlir/include/mlir/IR/Operation.h

mlir/include/mlir/IR/OperationSupport.h

mlir/include/mlir/IR/OwningOpRef.h

mlir/include/mlir/IR/PatternMatch.h

mlir/include/mlir/IR/Region.h

mlir/include/mlir/IR/RegionGraphTraits.h

mlir/include/mlir/IR/RegionKindInterface.h

mlir/include/mlir/IR/RegionKindInterface.td

mlir/include/mlir/IR/StorageUniquerSupport.h

mlir/include/mlir/IR/SubElementInterfaces.h

mlir/include/mlir/IR/SubElementInterfaces.td

mlir/include/mlir/IR/SymbolInterfaces.td

mlir/include/mlir/IR/SymbolTable.h

mlir/include/mlir/IR/TensorEncoding.h

mlir/include/mlir/IR/TensorEncoding.td

mlir/include/mlir/IR/Threading.h

mlir/include/mlir/IR/TypeRange.h

mlir/include/mlir/IR/TypeSupport.h

mlir/include/mlir/IR/TypeUtilities.h

mlir/include/mlir/IR/Types.h

mlir/include/mlir/IR/UseDefLists.h

mlir/include/mlir/IR/Value.h

mlir/include/mlir/IR/Verifier.h

mlir/include/mlir/IR/Visitors.h

mlir/include/mlir/Interfaces/CMakeLists.txt

mlir/include/mlir/Interfaces/CallInterfaces.h

mlir/include/mlir/Interfaces/CallInterfaces.td

mlir/include/mlir/Interfaces/CastInterfaces.h

mlir/include/mlir/Interfaces/CastInterfaces.td

mlir/include/mlir/Interfaces/ControlFlowInterfaces.h

mlir/include/mlir/Interfaces/ControlFlowInterfaces.td

mlir/include/mlir/Interfaces/CopyOpInterface.h

mlir/include/mlir/Interfaces/CopyOpInterface.td

mlir/include/mlir/Interfaces/DataLayoutInterfaces.h

mlir/include/mlir/Interfaces/DataLayoutInterfaces.td

mlir/include/mlir/Interfaces/DecodeAttributesInterfaces.h

mlir/include/mlir/Interfaces/DerivedAttributeOpInterface.h

mlir/include/mlir/Interfaces/DerivedAttributeOpInterface.td

mlir/include/mlir/Interfaces/FoldInterfaces.h

mlir/include/mlir/Interfaces/InferTypeOpInterface.h

mlir/include/mlir/Interfaces/InferTypeOpInterface.td

mlir/include/mlir/Interfaces/LoopLikeInterface.h

mlir/include/mlir/Interfaces/LoopLikeInterface.td

mlir/include/mlir/Interfaces/SideEffectInterfaceBase.td

mlir/include/mlir/Interfaces/SideEffectInterfaces.h

mlir/include/mlir/Interfaces/SideEffectInterfaces.td

mlir/include/mlir/Interfaces/TilingInterface.h

mlir/include/mlir/Interfaces/TilingInterface.td

mlir/include/mlir/Interfaces/VectorInterfaces.h

mlir/include/mlir/Interfaces/VectorInterfaces.td

mlir/include/mlir/Interfaces/ViewLikeInterface.h

mlir/include/mlir/Interfaces/ViewLikeInterface.td

mlir/lib/CMakeLists.txt

mlir/lib/IR/AffineExpr.cpp

mlir/lib/IR/AffineExprDetail.h

mlir/lib/IR/AffineMap.cpp

mlir/lib/IR/AffineMapDetail.h

mlir/lib/IR/AsmPrinter.cpp

mlir/lib/IR/AttributeDetail.h

mlir/lib/IR/Attributes.cpp

mlir/lib/IR/Block.cpp

mlir/lib/IR/Builders.cpp

mlir/lib/IR/BuiltinAttributeInterfaces.cpp

mlir/lib/IR/BuiltinAttributes.cpp

mlir/lib/IR/BuiltinDialect.cpp

mlir/lib/IR/BuiltinTypeInterfaces.cpp

mlir/lib/IR/BuiltinTypes.cpp

mlir/lib/IR/CMakeLists.txt

mlir/lib/IR/Diagnostics.cpp

mlir/lib/IR/Dialect.cpp

mlir/lib/IR/Dominance.cpp

mlir/lib/IR/FunctionImplementation.cpp

mlir/lib/IR/FunctionInterfaces.cpp

mlir/lib/IR/IntegerSet.cpp

mlir/lib/IR/IntegerSetDetail.h

mlir/lib/IR/Location.cpp

mlir/lib/IR/MLIRContext.cpp

mlir/lib/IR/Operation.cpp

mlir/lib/IR/OperationSupport.cpp

mlir/lib/IR/PatternMatch.cpp

mlir/lib/IR/Region.cpp

mlir/lib/IR/RegionKindInterface.cpp

mlir/lib/IR/SubElementInterfaces.cpp

mlir/lib/IR/SymbolTable.cpp

mlir/lib/IR/TensorEncoding.cpp

mlir/lib/IR/TypeDetail.h

mlir/lib/IR/TypeRange.cpp

mlir/lib/IR/TypeUtilities.cpp

mlir/lib/IR/Types.cpp

mlir/lib/IR/Value.cpp

mlir/lib/IR/Verifier.cpp

mlir/lib/IR/Visitors.cpp

mlir/lib/Interfaces/CMakeLists.txt

mlir/lib/Interfaces/CallInterfaces.cpp

mlir/lib/Interfaces/CastInterfaces.cpp

mlir/lib/Interfaces/ControlFlowInterfaces.cpp

mlir/lib/Interfaces/CopyOpInterface.cpp

mlir/lib/Interfaces/DataLayoutInterfaces.cpp

mlir/lib/Interfaces/DerivedAttributeOpInterface.cpp

mlir/lib/Interfaces/InferTypeOpInterface.cpp

mlir/lib/Interfaces/LoopLikeInterface.cpp

mlir/lib/Interfaces/SideEffectInterfaces.cpp

mlir/lib/Interfaces/TilingInterface.cpp

mlir/lib/Interfaces/VectorInterfaces.cpp

mlir/lib/Interfaces/ViewLikeInterface.cpp

mlir/test/mlir-pdll/CodeGen/MLIR/expr.pdll

mlir/test/mlir-pdll/Parser/expr-failure.pdll

mlir/test/mlir-pdll/Parser/expr.pdll

mlir/test/mlir-pdll/Parser/include_td.pdll

mlir/test/mlir-pdll/Parser/stmt-failure.pdll

mlir/test/mlir-tblgen/attr-or-type-format-invalid.td

mlir/test/mlir-tblgen/attr-or-type-format.td

mlir/test/mlir-tblgen/attrdefs.td

mlir/test/mlir-tblgen/constraint-unique.td

mlir/test/mlir-tblgen/default-type-attr-print-parser.td

mlir/test/mlir-tblgen/dialect.td

mlir/test/mlir-tblgen/expect-symbol.td

mlir/test/mlir-tblgen/gen-dialect-doc.td

mlir/test/mlir-tblgen/llvm-intrinsics.td

mlir/test/mlir-tblgen/op-attribute.td

mlir/test/mlir-tblgen/op-decl-and-defs.td

mlir/test/mlir-tblgen/op-error.td

mlir/test/mlir-tblgen/op-format-spec.td

mlir/test/mlir-tblgen/op-interface.td

mlir/test/mlir-tblgen/op-operand.td

mlir/test/mlir-tblgen/op-python-bindings.td

mlir/test/mlir-tblgen/op-result.td

mlir/test/mlir-tblgen/op-side-effects.td

mlir/test/mlir-tblgen/predicate.td

mlir/test/mlir-tblgen/rewriter-errors.td

mlir/test/mlir-tblgen/rewriter-indexing.td

mlir/test/mlir-tblgen/rewriter-static-matcher.td

mlir/test/mlir-tblgen/typedefs.td