This is an archive of the discontinued LLVM Phabricator instance.

[mlir][NFC] Rename StandardToLLVM to FuncToLLVM
ClosedPublic

Authored by rriddle on Mar 1 2022, 2:53 PM.

Details

Summary

The current StandardToLLVM conversion patterns only really handle
the Func dialect. The pass itself adds patterns for Arithmetic/CFToLLVM, but
those should be/will be split out in a followup. This commit focuses solely
on being an NFC rename.

Aside from the directory change, the pattern and pass creation API have been renamed:

  • populateStdToLLVMFuncOpConversionPattern -> populateFuncToLLVMFuncOpConversionPattern
  • populateStdToLLVMConversionPatterns -> populateFuncToLLVMConversionPatterns
  • createLowerToLLVMPass -> createConvertFuncToLLVMPass

Diff Detail

Event Timeline

rriddle created this revision.Mar 1 2022, 2:53 PM
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
rriddle requested review of this revision.Mar 1 2022, 2:54 PM
rriddle updated this revision to Diff 412271.Mar 1 2022, 3:10 PM
rriddle edited the summary of this revision. (Show Details)
rriddle updated this revision to Diff 412582.Mar 2 2022, 5:55 PM

@ftynse Could you take a look when you have the chance? Essentially just an NFC rename.

ftynse accepted this revision.Mar 7 2022, 1:58 AM
This revision is now accepted and ready to land.Mar 7 2022, 1:58 AM
This revision was landed with ongoing or failed builds.Mar 7 2022, 11:25 AM
This revision was automatically updated to reflect the committed changes.
mlir/test/Conversion/FuncToLLVM/invalid.mlir