This is an archive of the discontinued LLVM Phabricator instance.

[mlir][SPIRV] Split up StandardToSPIRV now that the Standard dialect is gone
ClosedPublic

Authored by rriddle on Mar 1 2022, 1:30 PM.

Details

Summary

StandardToSPIRV currently contains an assortment of patterns converting from
different dialects to SPIRV. This commit splits up StandardToSPIRV into separate
conversions for each of the dialects involved (some of which already exist).

Diff Detail

Event Timeline

rriddle created this revision.Mar 1 2022, 1:30 PM
Herald added a project: Restricted Project. · View Herald Transcript
rriddle requested review of this revision.Mar 1 2022, 1:30 PM
rriddle updated this revision to Diff 412225.Mar 1 2022, 1:34 PM
antiagainst accepted this revision.Mar 2 2022, 4:25 AM

Thanks a lot for handling this, River! I'll do some follow up touches to clean stuff further later. :)

This revision is now accepted and ready to land.Mar 2 2022, 4:25 AM

Thanks for the review Lei! Definitely lots of room for cleanup now.

This revision was landed with ongoing or failed builds.Mar 2 2022, 1:15 PM
This revision was automatically updated to reflect the committed changes.
mlir/test/Conversion/FuncToSPIRV/func-ops-to-spirv.mlir