This is an archive of the discontinued LLVM Phabricator instance.

[LV] Rename CountRoundDown to VectorTripCount (NFC)
ClosedPublic

Authored by rickyz on Feb 13 2022, 3:12 PM.

Details

Summary

The name CountRoundDown is potentially misleading, as the number of
iterations can be rounded up when folding the tail.

Diff Detail

Event Timeline

rickyz created this revision.Feb 13 2022, 3:12 PM
rickyz requested review of this revision.Feb 13 2022, 3:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2022, 3:12 PM
rickyz updated this revision to Diff 408299.Feb 13 2022, 3:33 PM

Rebase again main.

fhahn added a reviewer: Ayal.Apr 28 2022, 9:50 AM

Thanks for the patch and sorry for the delay. It's common practice to 'ping' a patch regularly (curtesy ping period is roughly every 7 days), otherwise it is very easy for patches to fall through the cracks.

The renaming makes sense to me and makes the code more consistent as a whole, as VectorTripCount is used elsewhere for the same thing already. Please move the changes unrelated to the renaming to a separate patch.

llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
3602

Can you limit this patch to *only* adjust CountRoundDown -> VectorTripCount? And mov eat either refactoring changes to a separate patch?

Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2022, 9:50 AM
rickyz updated this revision to Diff 425852.Apr 28 2022, 11:17 AM
rickyz marked an inline comment as done.

Remove loop refactor so that this change is rename-only.

Thanks for the patch and sorry for the delay. It's common practice to 'ping' a patch regularly (curtesy ping period is roughly every 7 days), otherwise it is very easy for patches to fall through the cracks.

Thanks for the tip and for noticing this - will keep in mind in the future!

fhahn accepted this revision.Apr 28 2022, 12:34 PM

LGTM, thanks!

This revision is now accepted and ready to land.Apr 28 2022, 12:34 PM

LGTM, thanks!

I'm not a committer, so can you land this on my behalf? Thanks!

fhahn added a comment.Apr 28 2022, 2:18 PM

LGTM, thanks!

I'm not a committer, so can you land this on my behalf? Thanks!

sure, please let me know what name & email to use

sure, please let me know what name & email to use

Ricky Zhou <ricky@rzhou.org>

Thanks!

This revision was automatically updated to reflect the committed changes.