This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Use new target MMO flag MONoClobber
ClosedPublic

Authored by foad on Feb 2 2022, 4:08 AM.

Details

Summary

This allows us to set the noclobber flag on (the MMO of) a load
instruction instead of on the pointer. This fixes a bug where noclobber
was being applied to all loads from the same pointer, even if some of
them were clobbered.

Diff Detail

Event Timeline

foad created this revision.Feb 2 2022, 4:08 AM
foad requested review of this revision.Feb 2 2022, 4:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2022, 4:08 AM
foad added inline comments.
llvm/test/CodeGen/AMDGPU/global_smrd.ll
31

Here's the bug fix.

arsenm added a comment.Feb 2 2022, 5:24 AM

Could use some round trip MIR parsing tests

foad updated this revision to Diff 405294.Feb 2 2022, 8:44 AM

Added a MIR parsing test case.

arsenm accepted this revision.Feb 2 2022, 8:52 AM
This revision is now accepted and ready to land.Feb 2 2022, 8:52 AM
This revision was landed with ongoing or failed builds.Feb 2 2022, 9:12 AM
This revision was automatically updated to reflect the committed changes.

Thanks Jay!