Page MenuHomePhabricator

[OpenMPIRBuilder] Store element type in AtomicOpValue
ClosedPublic

Authored by nikic on Jan 27 2022, 6:00 AM.

Details

Summary

With opaque pointers, we can no longer derive this from the pointer type, so we need to explicitly provide the element type the atomic operation should work with.

Diff Detail

Event Timeline

nikic created this revision.Jan 27 2022, 6:00 AM
nikic requested review of this revision.Jan 27 2022, 6:00 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 27 2022, 6:00 AM
nikic updated this revision to Diff 403629.Jan 27 2022, 6:15 AM
nikic edited the summary of this revision. (Show Details)

Okay, I think I figured out the right incantation to avoid the getPointerElementType() on the MLIR side as well.

jdoerfert accepted this revision.Jan 27 2022, 7:09 AM

LG, thanks!

This revision is now accepted and ready to land.Jan 27 2022, 7:09 AM
This revision was landed with ongoing or failed builds.Jan 28 2022, 12:36 AM
This revision was automatically updated to reflect the committed changes.