This is an archive of the discontinued LLVM Phabricator instance.

[JITLink][RISCV] Refactor range checking and alignment checking
ClosedPublic

Authored by fourdim on Jan 22 2022, 12:18 AM.

Details

Summary

This patch refactors the range checking function to make it compatible with all relocation types and supports range checking for R_RISCV_BRANCH. Moreover, it refactors the alignment check functions.

Diff Detail

Event Timeline

fourdim created this revision.Jan 22 2022, 12:18 AM
fourdim requested review of this revision.Jan 22 2022, 12:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2022, 12:18 AM
fourdim updated this revision to Diff 414003.Mar 8 2022, 9:39 PM

Include the recent commits and update the alignment check.

Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2022, 9:39 PM
fourdim retitled this revision from [JITLink][RISCV] Refactor range checking to make it compatible with all relocation types and add range checking for R_RISCV_BRANCH to [JITLink][RISCV] Refactor range checking and alignment checking.Mar 8 2022, 9:41 PM
fourdim edited the summary of this revision. (Show Details)
fourdim removed a reviewer: luismarques.
fourdim updated this revision to Diff 414006.Mar 8 2022, 9:44 PM

Fix the variable's name.

StephenFan added inline comments.Mar 8 2022, 11:17 PM
llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
375

Don't modify irrelevant parts

fourdim added inline comments.Mar 8 2022, 11:19 PM
llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
375

I'm sorry but it is automatically modified by clang-format. Should I disable this?

StephenFan added inline comments.Mar 8 2022, 11:36 PM
llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
375

I usually use git clang-format to clang-format the staged changes. This would not format irrelevant parts

fourdim updated this revision to Diff 414019.Mar 9 2022, 12:07 AM

Revert partial clang format.

This revision is now accepted and ready to land.Mar 9 2022, 3:02 AM
fourdim updated this revision to Diff 414071.Mar 9 2022, 5:03 AM

Remove unused parameter.

This revision was landed with ongoing or failed builds.Mar 9 2022, 6:14 AM
This revision was automatically updated to reflect the committed changes.