[1/4] [llvm-objdump][test] Add RISC-V objdump test case

[asb]

Summary

This test case captures the current state of support for printing branch targets.

[MaskRay]

llvm/test/tools/llvm-objdump/ELF/RISCV/branches.s

4

Remove --match-full-lines

In most test/tools/, the prevailing continuation-line format is to place | at the line end.

# RUN: llvm-mc -filetype=obj -triple riscv32 -mattr=+c %s |
# RUN:     llvm-objdump -d -M no-aliases --no-show-raw-insn - |

6

The address formatting is checked by other tests so this test doesn't need to check it.

By removing addresses, when the number of instruction changes, the update (ongoing maintenance) will touch fewer lines.

8

For similar reasons, remove leading addresses.

9

I have a slight preference that instructions are indented by two: to be clearer that they belong to the function (nearest label).

78

80

60: c.nop should probably keep its address to be clear that its a jump target.

[MaskRay]

[NFC]

I prefer [test] to be clear that no code is touched.

[asb]

Thank for such a rapid review @MaskRay! I've left a couple of queries in response, but otherwise I'll refresh the test case once I've had feedback on other patches in the series (to minimise repeated rebase effort).

llvm/test/tools/llvm-objdump/ELF/RISCV/branches.s

4

The reasoning behind --match-full-lines was that it will catch changes to printing of branch targets (as in D116678), ensuring the test case is updated.

9

Do you still feel it's worth doing, when taking into account the changes to this test in D116678?

[MaskRay]

llvm/test/tools/llvm-objdump/ELF/RISCV/branches.s

4

An alternative is to add {{$}} in a few places where it is significant.

[asb]

Address review comments.

llvm/test/tools/llvm-objdump/ELF/RISCV/branches.s

+# RUN: llvm-mc -filetype=obj -triple riscv32 -mattr=+c < %s | \
+# RUN:     llvm-objdump -d -M no-aliases --no-show-raw-insn - | \
+# RUN:     FileCheck %s
+
+# CHECK-LABEL: <foo>:
+foo:
+# CHECK: beq t0, t1, 0x58 <foo+0x58>
+beq t0, t1, .Llocal
+# CHECK: bne t0, t1, 0x58 <foo+0x58>
+bne t0, t1, .Llocal
+# CHECK: blt t0, t1, 0x58 <foo+0x58>
+blt t0, t1, .Llocal
+# CHECK: bge t0, t1, 0x58 <foo+0x58>
+bge t0, t1, .Llocal
+# CHECK: bltu t0, t1, 0x58 <foo+0x58>
+bltu t0, t1, .Llocal
+# CHECK: bgeu t0, t1, 0x58 <foo+0x58>
+bgeu t0, t1, .Llocal
+
+# CHECK: c.beqz a0, 0x58 <foo+0x58>
+beq a0, zero, .Llocal
+# CHECK: c.bnez a0, 0x58 <foo+0x58>
+bne a0, zero, .Llocal
+
+# CHECK: beq t0, t1, 0x60 <bar>
+beq t0, t1, bar
+# CHECK: bne t0, t1, 0x60 <bar>
+bne t0, t1, bar
+# CHECK: blt t0, t1, 0x60 <bar>
+blt t0, t1, bar
+# CHECK: bge t0, t1, 0x60 <bar>
+bge t0, t1, bar
+# CHECK: bltu t0, t1, 0x60 <bar>
+bltu t0, t1, bar
+# CHECK: bgeu t0, t1, 0x60 <bar>
+bgeu t0, t1, bar
+
+# CHECK: c.beqz a0, 0x60 <bar>
+beq a0, zero, bar
+# CHECK: c.bnez a0, 0x60 <bar>
+bne a0, zero, bar
+
+# CHECK: jal t0, 0x58 <foo+0x58>
+jal t0, .Llocal
+# CHECK: c.jal 0x58 <foo+0x58>
+c.jal .Llocal
+
+# CHECK: c.j 0x58 <foo+0x58>
+c.j .Llocal
+
+# CHECK: jal t0, 0x60 <bar>
+jal t0, bar
+# CHECK: c.jal 0x60 <bar>
+c.jal bar
+
+# CHECK: c.j 0x60 <bar>
+c.j bar
+
+# CHECK: auipc ra, 0
+# CHECK: jalr ra, 16(ra){{$}}
+call .Llocal
+
+# CHECK: auipc ra, 0
+# CHECK: jalr ra, 16(ra){{$}}
+call bar
+
+.Llocal:
+# CHECK: 58: c.nop
+# CHECK: c.nop
+# CHECK: c.nop
+# CHECK: c.nop
+nop
+nop
+nop
+nop
+
+# CHECK-LABEL: <bar>:
+bar:
+# CHECK: 60: c.nop
+nop