Differential D116394

Adopt DimensionListAttr in TOSA op definition (NFC)
AcceptedPublic
Actions

Authored by mehdi_amini on Dec 29 2021, 10:34 PM.

Details

Reviewers

jpienaar
Mogball
rriddle
sjarus

Summary

Depends On D116391

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

mehdi_amini created this revision.Dec 29 2021, 10:34 PM

Herald added a reviewer: sjarus. · View Herald TranscriptDec 29 2021, 10:34 PM

Herald added subscribers: sdasgup3, wenzhicui, wrengr and 23 others. · View Herald Transcript

mehdi_amini requested review of this revision.Dec 29 2021, 10:34 PM

Herald added a project: Restricted Project. · View Herald TranscriptDec 29 2021, 10:34 PM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

mehdi_amini mentioned this in D116391: Add a builtin DimensionListAttribute intended to handle the many ops that just want a small array of int64_t as an attribute.Dec 29 2021, 10:35 PM

Harbormaster completed remote builds in B140964: Diff 396607.Dec 29 2021, 10:43 PM

Mogball added inline comments.Dec 30 2021, 9:08 AM

mlir/include/mlir/IR/Builders.h
146 ↗	(On Diff #396607)	Should this be in the main patch?
mlir/include/mlir/IR/BuiltinAttributes.td
365 ↗	(On Diff #396607)	Should these be in the main patch too?

I can back port these if you prefer, the original patch was written without and I added these as I got for the need of this migration, so either way is fine.

Rebase

Harbormaster completed remote builds in B141081: Diff 396752.Dec 30 2021, 10:25 PM

Mogball accepted this revision.Dec 31 2021, 8:25 AM

Mogball added inline comments.

mlir/include/mlir/IR/AttributeSupport.h
263 ↗	(On Diff #396752)	The changes here should be moved into the previous patch
mlir/lib/IR/Builders.cpp
231 ↗	(On Diff #396752)	Missed this file in the backport?

This revision is now accepted and ready to land.Dec 31 2021, 8:25 AM

Rebase

mehdi_amini marked 2 inline comments as done.Dec 31 2021, 12:41 PM

Rebase

Harbormaster completed remote builds in B141139: Diff 396820.Dec 31 2021, 1:10 PM

mehdi_amini added a parent revision: D116466: Align adaptor's generator accessors for attribute on the Op class.Dec 31 2021, 3:30 PM

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Dialect/

Tosa/

IR/

11 lines

TosaTypesBase.td

21 lines

lib/

Conversion/

TosaToLinalg/

TosaToLinalg.cpp

40 lines

TosaToLinalgNamed.cpp

43 lines

Dialect/

Tosa/

IR/

89 lines

Transforms/

TosaDecomposeTransposeConv.cpp

49 lines

TosaOptimization.cpp

14 lines

test/

Conversion/

TosaToLinalg/

tosa-to-linalg-named.mlir

30 lines

tosa-to-linalg.mlir

8 lines

Dialect/

Tosa/

canonicalize.mlir

10 lines

8 lines

operation_optimization.mlir

8 lines

18 lines

quant-test.mlir

2 lines

tosa-decompose-transpose-conv.mlir

26 lines

tosa-infer-shapes.mlir

92 lines

lib/

Dialect/

Tosa/

TosaTestPasses.cpp

4 lines

utils/

bazel/

llvm-project-overlay/

mlir/

11 lines

Diff 396818

mlir/include/mlir/Dialect/Tosa/IR/TosaOpBase.td

Loading...

mlir/include/mlir/Dialect/Tosa/IR/TosaTypesBase.td

Loading...

mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp

Loading...

mlir/lib/Conversion/TosaToLinalg/TosaToLinalgNamed.cpp

Loading...

mlir/lib/Dialect/Tosa/IR/TosaOps.cpp

Loading...

mlir/lib/Dialect/Tosa/Transforms/TosaDecomposeTransposeConv.cpp

Loading...

mlir/lib/Dialect/Tosa/Transforms/TosaOptimization.cpp

Loading...

mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir

Loading...

mlir/test/Conversion/TosaToLinalg/tosa-to-linalg.mlir

Loading...

mlir/test/Dialect/Tosa/canonicalize.mlir

Loading...

mlir/test/Dialect/Tosa/invalid.mlir

Loading...

mlir/test/Dialect/Tosa/operation_optimization.mlir

Loading...

mlir/test/Dialect/Tosa/ops.mlir

Loading...

mlir/test/Dialect/Tosa/quant-test.mlir

Loading...

mlir/test/Dialect/Tosa/tosa-decompose-transpose-conv.mlir

Loading...

mlir/test/Dialect/Tosa/tosa-infer-shapes.mlir

Loading...

mlir/test/lib/Dialect/Tosa/TosaTestPasses.cpp

Loading...

utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

Loading...