Page MenuHomePhabricator

Adopt DimensionListAttr in TOSA op definition (NFC)
AcceptedPublic

Authored by mehdi_amini on Dec 29 2021, 10:34 PM.

Details

Summary

Depends On D116391

Diff Detail

Event Timeline

mehdi_amini created this revision.Dec 29 2021, 10:34 PM
mehdi_amini requested review of this revision.Dec 29 2021, 10:34 PM
Mogball added inline comments.Dec 30 2021, 9:08 AM
mlir/include/mlir/IR/Builders.h
146 ↗(On Diff #396607)

Should this be in the main patch?

mlir/include/mlir/IR/BuiltinAttributes.td
365 ↗(On Diff #396607)

Should these be in the main patch too?

I can back port these if you prefer, the original patch was written without and I added these as I got for the need of this migration, so either way is fine.

mehdi_amini marked 2 inline comments as done.

Rebase

Mogball accepted this revision.Dec 31 2021, 8:25 AM
Mogball added inline comments.
mlir/include/mlir/IR/AttributeSupport.h
263 ↗(On Diff #396752)

The changes here should be moved into the previous patch

mlir/lib/IR/Builders.cpp
231 ↗(On Diff #396752)

Missed this file in the backport?

This revision is now accepted and ready to land.Dec 31 2021, 8:25 AM
mehdi_amini marked 2 inline comments as done.Dec 31 2021, 12:41 PM