Page MenuHomePhabricator

Adopt DimensionListAttr in TOSA op definition (NFC)
Needs ReviewPublic

Authored by mehdi_amini on Dec 29 2021, 10:34 PM.



Depends On D116391

Diff Detail

Event Timeline

mehdi_amini created this revision.Dec 29 2021, 10:34 PM
mehdi_amini requested review of this revision.Dec 29 2021, 10:34 PM
Mogball added inline comments.Dec 30 2021, 9:08 AM
146 ↗(On Diff #396607)

Should this be in the main patch?

365 ↗(On Diff #396607)

Should these be in the main patch too?

I can back port these if you prefer, the original patch was written without and I added these as I got for the need of this migration, so either way is fine.

mehdi_amini marked 2 inline comments as done.


Mogball accepted this revision.Dec 31 2021, 8:25 AM
Mogball added inline comments.
263 ↗(On Diff #396752)

The changes here should be moved into the previous patch

231 ↗(On Diff #396752)

Missed this file in the backport?

This revision is now accepted and ready to land.Dec 31 2021, 8:25 AM
mehdi_amini marked 2 inline comments as done.Dec 31 2021, 12:41 PM
This revision now requires review to proceed.Aug 25 2022, 3:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2022, 3:34 PM
Herald added a subscriber: bzcheeseman. · View Herald Transcript

This looks nice. Is there something needed before this can be merged? Presumably any user of the tosa dialect that has lit tests would also need their tests to be modified.

We went with a different solution for the attribute, I would need to rebase this and update it to use DenseI64ArrayAttr instead. I don't have a timeline for this right now.