This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Adding macros for coprocessor intrinsics as per ACLE
Changes PlannedPublic

Authored by tmatheson on Dec 22 2021, 3:13 AM.

Details

Summary

Patch by Ranjeet Singh and Son Tuan Vu.

Diff Detail

Unit TestsFailed

Event Timeline

tmatheson created this revision.Dec 22 2021, 3:13 AM
tmatheson requested review of this revision.Dec 22 2021, 3:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 22 2021, 3:13 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
tmatheson edited the summary of this revision. (Show Details)
tmatheson updated this revision to Diff 397071.Jan 3 2022, 8:39 AM

Add 8.8 and 9.3; patches adding these were merged first in the end.

tmatheson updated this revision to Diff 397127.Jan 3 2022, 12:56 PM

Combine V8 and V9 macros

vhscampos added inline comments.Jan 4 2022, 4:10 AM
clang/lib/Basic/Targets/ARM.cpp
925–945

Consider merging these two if statements.

947

Is v8.1-M not included on purpose?

clang/test/Preprocessor/aarch64-target-features.c
46

I don't see any change to the AArch64 target macros. Does it use the same function as ARM?

tmatheson planned changes to this revision.Jan 4 2022, 5:20 AM
tmatheson marked an inline comment as done.
Matt added a subscriber: Matt.Jan 4 2022, 9:39 AM
miyuki added a subscriber: miyuki.Jan 5 2022, 9:08 AM