User Details
User Details
- User Since
- Mar 30 2018, 8:00 AM (286 w, 4 d)
May 4 2023
May 4 2023
tyb0807 requested review of D149835: [mlir] Fix stackoverflow in propagateLiveness.
Apr 18 2023
Apr 18 2023
tyb0807 accepted D148636: [vector] When trimming leading insertion dimensions, base the final result on the ranks.
Thanks for the fix!
Mar 31 2023
Mar 31 2023
tyb0807 committed rG942b403ff1a4: [mlir] Fix casting of leading unit dims for vector.insert (authored by tyb0807).
[mlir] Fix casting of leading unit dims for vector.insert
Mar 30 2023
Mar 30 2023
tyb0807 requested review of D147280: [mlir] Fix casting of leading unit dims for vector.insert.
Mar 21 2023
Mar 21 2023
LGTM! Thanks!
Jan 11 2023
Jan 11 2023
Thank you, LGTM
LGTM, thank you!
Jan 6 2023
Jan 6 2023
tyb0807 added inline comments to D141099: [mlir][tensor] Add patterns that fold ops into pack and unpack ops..
Dec 17 2022
Dec 17 2022
Thanks, LGTM
Dec 15 2022
Dec 15 2022
LGTM
tyb0807 added inline comments to D140060: [mlir][tensor][linalg] Add a pattern that generalizes tensor.pack op..
Oct 6 2022
Oct 6 2022
tyb0807 committed rGa4deb14fdfaa: [LLVM][Support] Support for `llvm::cl::list`'s default values (authored by tyb0807).
[LLVM][Support] Support for `llvm::cl::list`'s default values
tyb0807 added inline comments to D135311: [LLVM][Support] Support for `llvm::cl::list`'s default values.
tyb0807 updated the diff for D135311: [LLVM][Support] Support for `llvm::cl::list`'s default values.
Change initialization functions' names and correctly use ArrayRef
Oct 5 2022
Oct 5 2022
tyb0807 added reviewers for D135311: [LLVM][Support] Support for `llvm::cl::list`'s default values: mehdi_amini, pifon2a, bkramer.
tyb0807 requested review of D135311: [LLVM][Support] Support for `llvm::cl::list`'s default values.
Jun 15 2022
Jun 15 2022
tyb0807 added a comment to D127798: [AArch64] Define __ARM_FEATURE_RCPC.
The patch looks correct to me, but looking at https://github.com/ARM-software/acle/blob/main/main/acle.md where all the ACLE macros are defined, I'm not sure that __ARM_FEATURE_RCPC is there currently. Maybe you also want to submit a patch there, or at least explain the context of this change please?
Apr 2 2022
Apr 2 2022
tyb0807 committed rG43d758b142bb: [Driver][AArch64] Split up aarch64-cpus.c tests further (authored by tyb0807).
[Driver][AArch64] Split up aarch64-cpus.c tests further
tyb0807 committed rG9a015ee1f948: [AArch64] Avoid scanning feature list for target parsing (authored by tyb0807).
[AArch64] Avoid scanning feature list for target parsing
tyb0807 committed rGb93893e60f0c: [AArch64] Default HBC/MOPS features in clang (authored by tyb0807).
[AArch64] Default HBC/MOPS features in clang
Apr 1 2022
Apr 1 2022
tyb0807 updated the diff for D120864: [AArch64] Avoid scanning feature list for target parsing.
Refactor fp16 feature handling and add more fp16 tests for v8.5 and later
Mar 7 2022
Mar 7 2022
tyb0807 added inline comments to D121093: [Driver][AArch64] Split up aarch64-cpus.c test further.
tyb0807 added a comment to D121093: [Driver][AArch64] Split up aarch64-cpus.c test further.
Yeah that sounds good. Maybe aarch64-cortex-cpus.c might be a good start, to avoid having too many small files.
tyb0807 updated the diff for D121093: [Driver][AArch64] Split up aarch64-cpus.c test further.
Further split aarch64-cpus-1.c
tyb0807 added inline comments to D121093: [Driver][AArch64] Split up aarch64-cpus.c test further.
tyb0807 requested review of D121093: [Driver][AArch64] Split up aarch64-cpus.c test further.
Mar 3 2022
Mar 3 2022
tyb0807 added a comment to D120875: [Driver] Split up huge aarch64-cpus.c test..
Thanks for making this change. However, I think a better naming would be
Mar 2 2022
Mar 2 2022
tyb0807 updated the diff for D120864: [AArch64] Avoid scanning feature list for target parsing.
Update logic to define crypto extensions, strictly following the old implementation
tyb0807 requested review of D120864: [AArch64] Avoid scanning feature list for target parsing.
Mar 1 2022
Mar 1 2022
tyb0807 updated the diff for D120111: [AArch64] Default HBC/MOPS features in clang.
Taking into account remarks from @tmatheson, I'm reverting my latest changes
consisting in caching architecture feature into a variable, which makes the
getAArch64ArchFeaturesFrom* interfaces more complicated.
Feb 25 2022
Feb 25 2022
tyb0807 added inline comments to D120111: [AArch64] Default HBC/MOPS features in clang.
tyb0807 added reviewers for D120111: [AArch64] Default HBC/MOPS features in clang: SjoerdMeijer, vhscampos.
Feb 22 2022
Feb 22 2022
tyb0807 committed rG8e10448cbbd9: [AArch64] Remove unused feature flags from AArch64TargetInfo (authored by tyb0807).
[AArch64] Remove unused feature flags from AArch64TargetInfo
Feb 22 2022, 8:14 AM · Restricted Project
[ARM][AArch64] Add missing v8.x checks
Feb 22 2022, 1:08 AM · Restricted Project
Feb 21 2022
Feb 21 2022
tyb0807 added a reviewer for D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo: vhscampos.
Feb 21 2022, 5:14 PM · Restricted Project
tyb0807 updated the diff for D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo.
Revert latest change, as it is likely that people still rely on __ARM_FEATURE_CRYPTO
Feb 21 2022, 5:13 PM · Restricted Project
tyb0807 updated the diff for D116153: [ARM][AArch64] Add missing v8.x checks.
Add checks for default ACLE macros for different architecture versions
Feb 21 2022, 3:15 PM · Restricted Project
tyb0807 added inline comments to D116153: [ARM][AArch64] Add missing v8.x checks.
Feb 21 2022, 8:41 AM · Restricted Project
tyb0807 added inline comments to D116153: [ARM][AArch64] Add missing v8.x checks.
Feb 21 2022, 8:29 AM · Restricted Project
tyb0807 updated the diff for D116153: [ARM][AArch64] Add missing v8.x checks.
Rebase
Feb 21 2022, 8:00 AM · Restricted Project
Feb 21 2022, 3:01 AM · Restricted Project
Feb 20 2022
Feb 20 2022
tyb0807 added inline comments to D120111: [AArch64] Default HBC/MOPS features in clang.
tyb0807 updated the diff for D120111: [AArch64] Default HBC/MOPS features in clang.
Cache architecture feature to avoid scanning the feature list over and over again.
Feb 18 2022
Feb 18 2022
tyb0807 added reviewers for D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo: pratlucas, tmatheson.
Feb 18 2022, 12:30 AM · Restricted Project
tyb0807 added reviewers for D120111: [AArch64] Default HBC/MOPS features in clang: lenary, dmgreen, momchil.velikov, pratlucas, nickdesaulniers, t.p.northover, tmatheson.
tyb0807 requested review of D120111: [AArch64] Default HBC/MOPS features in clang.
Feb 17 2022
Feb 17 2022
tyb0807 updated the diff for D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo.
Remove reference to unused ACLE macro __ARM_FEATURE_CRYPTO
Feb 17 2022, 2:31 PM · Restricted Project
Feb 10 2022
Feb 10 2022
tyb0807 committed rGc70b93508901: [AArch64] ACLE feature macro for Armv8.8-A MOPS (authored by tyb0807).
[AArch64] ACLE feature macro for Armv8.8-A MOPS
Feb 10 2022, 1:09 AM · Restricted Project
Feb 9 2022
Feb 9 2022
tyb0807 updated the diff for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.
Turn off warnings for negative tests
Feb 9 2022, 7:31 AM · Restricted Project
tyb0807 added reviewers for D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo: chill, dmgreen.
Feb 9 2022, 7:24 AM · Restricted Project
tyb0807 updated the diff for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.
Fix buildbots failures
Feb 9 2022, 7:10 AM · Restricted Project
Feb 8 2022
Feb 8 2022
Reverted due to buildbots failures
Feb 8 2022, 4:12 PM · Restricted Project
tyb0807 committed rG9b81d2fae8c0: Revert "[AArch64] ACLE feature macro for Armv8.8-A MOPS" (authored by tyb0807).
Revert "[AArch64] ACLE feature macro for Armv8.8-A MOPS"
tyb0807 added a reverting change for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS: rG9b81d2fae8c0: Revert "[AArch64] ACLE feature macro for Armv8.8-A MOPS".
Feb 8 2022, 4:11 PM · Restricted Project
tyb0807 committed rGd379ec99085e: [AArch64] ACLE feature macro for Armv8.8-A MOPS (authored by tyb0807).
[AArch64] ACLE feature macro for Armv8.8-A MOPS
Feb 8 2022, 1:08 PM · Restricted Project
Feb 7 2022
Feb 7 2022
This is superseded by https://reviews.llvm.org/D118199. Comments have been addressed in the new patch. I should have commandeered this patch instead (did not know about this, sorry...).
Feb 3 2022
Feb 3 2022
tyb0807 edited reviewers for D116153: [ARM][AArch64] Add missing v8.x checks, added: lenary; removed: tmatheson.
Feb 3 2022, 2:38 PM · Restricted Project
tyb0807 added inline comments to D116153: [ARM][AArch64] Add missing v8.x checks.
Feb 3 2022, 2:29 PM · Restricted Project
tyb0807 updated the summary of D116153: [ARM][AArch64] Add missing v8.x checks.
Feb 3 2022, 2:22 PM · Restricted Project
tyb0807 updated the diff for D116153: [ARM][AArch64] Add missing v8.x checks.
Add more tests
Feb 3 2022, 2:21 PM · Restricted Project
tyb0807 commandeered D116153: [ARM][AArch64] Add missing v8.x checks.
Feb 3 2022, 5:56 AM · Restricted Project
Feb 2 2022
Feb 2 2022
tyb0807 added a comment to D118009: [ARM] Make getInstSizeInBytes() use instruction size from InstrInfo.td.
Sorry for the linking issue, this has been fixed in commit ec00c9cdeb5ee9fc7846cb3d2a4d53eba2c35a43
Feb 2 2022, 10:10 AM · Restricted Project
Already fixed by commit ec00c9cdeb5ee9fc7846cb3d2a4d53eba2c35a43
Feb 2 2022, 10:08 AM · Restricted Project
tyb0807 requested review of D118811: [ARM] Fix linking issue for ARM unittests.
Feb 2 2022, 9:43 AM · Restricted Project
tyb0807 added a comment to D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo.
TL;DR, I think these Has* flags have different meaning in different places of the code base.
Feb 2 2022, 8:51 AM · Restricted Project
tyb0807 added a reviewer for D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo: lenary.
Feb 2 2022, 12:34 AM · Restricted Project
tyb0807 requested review of D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo.
Feb 2 2022, 12:33 AM · Restricted Project
Feb 1 2022
Feb 1 2022
tyb0807 updated the diff for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.
Remove prefix from tests
Feb 1 2022, 1:39 PM · Restricted Project
tyb0807 updated the diff for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.
Update tests with clang -Xclang -verify
Feb 1 2022, 1:37 PM · Restricted Project
tyb0807 added inline comments to D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.
Feb 1 2022, 1:31 PM · Restricted Project
tyb0807 updated the diff for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.
Update tests with clang_cc1 -verify
Feb 1 2022, 1:31 PM · Restricted Project
tyb0807 updated the diff for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.
Revert latest patchset, as it should be put into a separate commit for clarity
Feb 1 2022, 5:36 AM · Restricted Project
tyb0807 added inline comments to D117764: [AArch64][SelectionDAG] CodeGen for Armv8.8/9.3 MOPS.
Feb 1 2022, 4:41 AM · Restricted Project
tyb0807 committed rG762f0b546328: [ARM] Make getInstSizeInBytes() use instruction size from InstrInfo.td (authored by tyb0807).
[ARM] Make getInstSizeInBytes() use instruction size from InstrInfo.td
tyb0807 committed rGdd88f40c80f5: [AArch64] Make getInstSizeInBytes() use instruction size from InstrInfo.td (authored by tyb0807).
[AArch64] Make getInstSizeInBytes() use instruction size from InstrInfo.td
Feb 1 2022, 2:40 AM · Restricted Project
Feb 1 2022, 2:39 AM · Restricted Project
tyb0807 updated the diff for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.
Add support for +nomops
Feb 1 2022, 2:29 AM · Restricted Project
Jan 31 2022
Jan 31 2022
[AArch64] Removing redundant PAuth flag
Jan 31 2022, 1:01 PM · Restricted Project
tyb0807 committed rG5aa08bf70854: [AArch64][SelectionDAG] CodeGen for Armv8.8/9.3 MOPS (authored by tyb0807).
[AArch64][SelectionDAG] CodeGen for Armv8.8/9.3 MOPS
Jan 31 2022, 12:56 PM · Restricted Project
tyb0807 committed rG78fd413cf736: [AArch64][GlobalISel] CodeGen for Armv8.8/9.3 MOPS (authored by tyb0807).
[AArch64][GlobalISel] CodeGen for Armv8.8/9.3 MOPS
Jan 31 2022, 12:54 PM · Restricted Project
tyb0807 committed rG13660715e677: [AArch64] Modeling NZCV read/write for MOPS instructions (authored by tyb0807).
[AArch64] Modeling NZCV read/write for MOPS instructions
Jan 31 2022, 12:52 PM · Restricted Project
tyb0807 committed rG51e188d079f6: [AArch64] Support for memset tagged intrinsic (authored by tyb0807).
[AArch64] Support for memset tagged intrinsic
tyb0807 updated the diff for D117970: [AArch64] Make getInstSizeInBytes() use instruction size from InstrInfo.td.
Add more tests
Jan 31 2022, 10:29 AM · Restricted Project