Page MenuHomePhabricator

tyb0807 (Son Tuan Vu)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 30 2018, 8:00 AM (222 w, 3 h)

Recent Activity

Wed, Jun 15

tyb0807 added a comment to D127798: [AArch64] Define __ARM_FEATURE_RCPC.

The patch looks correct to me, but looking at https://github.com/ARM-software/acle/blob/main/main/acle.md where all the ACLE macros are defined, I'm not sure that __ARM_FEATURE_RCPC is there currently. Maybe you also want to submit a patch there, or at least explain the context of this change please?

Wed, Jun 15, 5:40 AM · Restricted Project, Restricted Project

Apr 2 2022

tyb0807 committed rG43d758b142bb: [Driver][AArch64] Split up aarch64-cpus.c tests further (authored by tyb0807).
[Driver][AArch64] Split up aarch64-cpus.c tests further
Apr 2 2022, 6:57 AM · Restricted Project, Restricted Project
tyb0807 committed rG9a015ee1f948: [AArch64] Avoid scanning feature list for target parsing (authored by tyb0807).
[AArch64] Avoid scanning feature list for target parsing
Apr 2 2022, 6:57 AM · Restricted Project, Restricted Project
tyb0807 committed rGb93893e60f0c: [AArch64] Default HBC/MOPS features in clang (authored by tyb0807).
[AArch64] Default HBC/MOPS features in clang
Apr 2 2022, 6:57 AM · Restricted Project, Restricted Project
tyb0807 closed D121093: [Driver][AArch64] Split up aarch64-cpus.c test further.
Apr 2 2022, 6:57 AM · Restricted Project, Restricted Project
tyb0807 closed D120864: [AArch64] Avoid scanning feature list for target parsing.
Apr 2 2022, 6:57 AM · Restricted Project, Restricted Project
tyb0807 closed D120111: [AArch64] Default HBC/MOPS features in clang.
Apr 2 2022, 6:57 AM · Restricted Project, Restricted Project

Apr 1 2022

tyb0807 updated the diff for D120864: [AArch64] Avoid scanning feature list for target parsing.

Refactor fp16 feature handling and add more fp16 tests for v8.5 and later

Apr 1 2022, 2:55 PM · Restricted Project, Restricted Project

Mar 7 2022

tyb0807 added inline comments to D121093: [Driver][AArch64] Split up aarch64-cpus.c test further.
Mar 7 2022, 5:24 AM · Restricted Project, Restricted Project
tyb0807 added a comment to D121093: [Driver][AArch64] Split up aarch64-cpus.c test further.

Yeah that sounds good. Maybe aarch64-cortex-cpus.c might be a good start, to avoid having too many small files.

Mar 7 2022, 5:18 AM · Restricted Project, Restricted Project
tyb0807 updated the diff for D121093: [Driver][AArch64] Split up aarch64-cpus.c test further.

Further split aarch64-cpus-1.c

Mar 7 2022, 5:13 AM · Restricted Project, Restricted Project
tyb0807 added inline comments to D121093: [Driver][AArch64] Split up aarch64-cpus.c test further.
Mar 7 2022, 3:03 AM · Restricted Project, Restricted Project
tyb0807 requested review of D121093: [Driver][AArch64] Split up aarch64-cpus.c test further.
Mar 7 2022, 2:21 AM · Restricted Project, Restricted Project

Mar 3 2022

tyb0807 added a comment to D120875: [Driver] Split up huge aarch64-cpus.c test..

Thanks for making this change. However, I think a better naming would be

Mar 3 2022, 1:26 AM · Restricted Project, Restricted Project

Mar 2 2022

tyb0807 updated the diff for D120864: [AArch64] Avoid scanning feature list for target parsing.

Update logic to define crypto extensions, strictly following the old implementation

Mar 2 2022, 7:04 PM · Restricted Project, Restricted Project
tyb0807 requested review of D120864: [AArch64] Avoid scanning feature list for target parsing.
Mar 2 2022, 6:59 PM · Restricted Project, Restricted Project

Mar 1 2022

tyb0807 updated the diff for D120111: [AArch64] Default HBC/MOPS features in clang.

Taking into account remarks from @tmatheson, I'm reverting my latest changes
consisting in caching architecture feature into a variable, which makes the
getAArch64ArchFeaturesFrom* interfaces more complicated.

Mar 1 2022, 1:35 AM · Restricted Project, Restricted Project

Feb 25 2022

tyb0807 added inline comments to D120111: [AArch64] Default HBC/MOPS features in clang.
Feb 25 2022, 7:12 AM · Restricted Project, Restricted Project
tyb0807 added reviewers for D120111: [AArch64] Default HBC/MOPS features in clang: SjoerdMeijer, vhscampos.
Feb 25 2022, 6:51 AM · Restricted Project, Restricted Project

Feb 22 2022

tyb0807 committed rG8e10448cbbd9: [AArch64] Remove unused feature flags from AArch64TargetInfo (authored by tyb0807).
[AArch64] Remove unused feature flags from AArch64TargetInfo
Feb 22 2022, 8:14 AM
tyb0807 closed D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo.
Feb 22 2022, 8:14 AM · Restricted Project
tyb0807 committed rG650aec687eb5: [ARM][AArch64] Add missing v8.x checks (authored by tyb0807).
[ARM][AArch64] Add missing v8.x checks
Feb 22 2022, 1:09 AM
tyb0807 closed D116153: [ARM][AArch64] Add missing v8.x checks.
Feb 22 2022, 1:08 AM · Restricted Project

Feb 21 2022

tyb0807 added a reviewer for D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo: vhscampos.
Feb 21 2022, 5:14 PM · Restricted Project
tyb0807 updated the diff for D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo.

Revert latest change, as it is likely that people still rely on __ARM_FEATURE_CRYPTO

Feb 21 2022, 5:13 PM · Restricted Project
tyb0807 updated the diff for D116153: [ARM][AArch64] Add missing v8.x checks.

Add checks for default ACLE macros for different architecture versions

Feb 21 2022, 3:15 PM · Restricted Project
tyb0807 added inline comments to D116153: [ARM][AArch64] Add missing v8.x checks.
Feb 21 2022, 8:41 AM · Restricted Project
tyb0807 added inline comments to D116153: [ARM][AArch64] Add missing v8.x checks.
Feb 21 2022, 8:29 AM · Restricted Project
tyb0807 updated the diff for D116153: [ARM][AArch64] Add missing v8.x checks.

Rebase

Feb 21 2022, 8:00 AM · Restricted Project
tyb0807 added a reviewer for D116153: [ARM][AArch64] Add missing v8.x checks: vhscampos.
Feb 21 2022, 3:01 AM · Restricted Project

Feb 20 2022

tyb0807 added inline comments to D120111: [AArch64] Default HBC/MOPS features in clang.
Feb 20 2022, 11:29 PM · Restricted Project, Restricted Project
tyb0807 updated the diff for D120111: [AArch64] Default HBC/MOPS features in clang.

Cache architecture feature to avoid scanning the feature list over and over again.

Feb 20 2022, 11:21 PM · Restricted Project, Restricted Project

Feb 18 2022

tyb0807 added reviewers for D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo: pratlucas, tmatheson.
Feb 18 2022, 12:30 AM · Restricted Project
tyb0807 added reviewers for D120111: [AArch64] Default HBC/MOPS features in clang: lenary, dmgreen, momchil.velikov, pratlucas, nickdesaulniers, t.p.northover, tmatheson.
Feb 18 2022, 12:12 AM · Restricted Project, Restricted Project
tyb0807 requested review of D120111: [AArch64] Default HBC/MOPS features in clang.
Feb 18 2022, 12:10 AM · Restricted Project, Restricted Project

Feb 17 2022

tyb0807 updated the diff for D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo.

Remove reference to unused ACLE macro __ARM_FEATURE_CRYPTO

Feb 17 2022, 2:31 PM · Restricted Project

Feb 10 2022

tyb0807 committed rGc70b93508901: [AArch64] ACLE feature macro for Armv8.8-A MOPS (authored by tyb0807).
[AArch64] ACLE feature macro for Armv8.8-A MOPS
Feb 10 2022, 1:09 AM
tyb0807 closed D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.
Feb 10 2022, 1:09 AM · Restricted Project

Feb 9 2022

tyb0807 updated the diff for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.

Turn off warnings for negative tests

Feb 9 2022, 7:31 AM · Restricted Project
tyb0807 added reviewers for D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo: chill, dmgreen.
Feb 9 2022, 7:24 AM · Restricted Project
tyb0807 updated the diff for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.

Fix buildbots failures

Feb 9 2022, 7:10 AM · Restricted Project

Feb 8 2022

tyb0807 reopened D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.

Reverted due to buildbots failures

Feb 8 2022, 4:12 PM · Restricted Project
tyb0807 added a reverting change for rGd379ec99085e: [AArch64] ACLE feature macro for Armv8.8-A MOPS: rG9b81d2fae8c0: Revert "[AArch64] ACLE feature macro for Armv8.8-A MOPS".
Feb 8 2022, 4:11 PM
tyb0807 committed rG9b81d2fae8c0: Revert "[AArch64] ACLE feature macro for Armv8.8-A MOPS" (authored by tyb0807).
Revert "[AArch64] ACLE feature macro for Armv8.8-A MOPS"
Feb 8 2022, 4:11 PM
tyb0807 added a reverting change for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS: rG9b81d2fae8c0: Revert "[AArch64] ACLE feature macro for Armv8.8-A MOPS".
Feb 8 2022, 4:11 PM · Restricted Project
tyb0807 committed rGd379ec99085e: [AArch64] ACLE feature macro for Armv8.8-A MOPS (authored by tyb0807).
[AArch64] ACLE feature macro for Armv8.8-A MOPS
Feb 8 2022, 1:08 PM
tyb0807 closed D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.
Feb 8 2022, 1:08 PM · Restricted Project

Feb 7 2022

tyb0807 abandoned D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS.

This is superseded by https://reviews.llvm.org/D118199. Comments have been addressed in the new patch. I should have commandeered this patch instead (did not know about this, sorry...).

Feb 7 2022, 3:24 AM · Restricted Project, Restricted Project
tyb0807 commandeered D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS.
Feb 7 2022, 3:22 AM · Restricted Project, Restricted Project

Feb 3 2022

tyb0807 edited reviewers for D116153: [ARM][AArch64] Add missing v8.x checks, added: lenary; removed: tmatheson.
Feb 3 2022, 2:38 PM · Restricted Project
tyb0807 added inline comments to D116153: [ARM][AArch64] Add missing v8.x checks.
Feb 3 2022, 2:29 PM · Restricted Project
tyb0807 updated the summary of D116153: [ARM][AArch64] Add missing v8.x checks.
Feb 3 2022, 2:22 PM · Restricted Project
tyb0807 updated the diff for D116153: [ARM][AArch64] Add missing v8.x checks.

Add more tests

Feb 3 2022, 2:21 PM · Restricted Project
tyb0807 commandeered D116153: [ARM][AArch64] Add missing v8.x checks.
Feb 3 2022, 5:56 AM · Restricted Project

Feb 2 2022

tyb0807 added a comment to D118009: [ARM] Make getInstSizeInBytes() use instruction size from InstrInfo.td.

Sorry for the linking issue, this has been fixed in commit ec00c9cdeb5ee9fc7846cb3d2a4d53eba2c35a43

Feb 2 2022, 10:10 AM · Restricted Project
tyb0807 abandoned D118811: [ARM] Fix linking issue for ARM unittests.

Already fixed by commit ec00c9cdeb5ee9fc7846cb3d2a4d53eba2c35a43

Feb 2 2022, 10:08 AM · Restricted Project
tyb0807 requested review of D118811: [ARM] Fix linking issue for ARM unittests.
Feb 2 2022, 9:43 AM · Restricted Project
tyb0807 added a comment to D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo.

TL;DR, I think these Has* flags have different meaning in different places of the code base.

Feb 2 2022, 8:51 AM · Restricted Project
tyb0807 added a reviewer for D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo: lenary.
Feb 2 2022, 12:34 AM · Restricted Project
tyb0807 requested review of D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo.
Feb 2 2022, 12:33 AM · Restricted Project

Feb 1 2022

tyb0807 updated the diff for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.

Remove prefix from tests

Feb 1 2022, 1:39 PM · Restricted Project
tyb0807 updated the diff for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.

Update tests with clang -Xclang -verify

Feb 1 2022, 1:37 PM · Restricted Project
tyb0807 added inline comments to D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.
Feb 1 2022, 1:31 PM · Restricted Project
tyb0807 updated the diff for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.

Update tests with clang_cc1 -verify

Feb 1 2022, 1:31 PM · Restricted Project
tyb0807 updated the diff for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.

Revert latest patchset, as it should be put into a separate commit for clarity

Feb 1 2022, 5:36 AM · Restricted Project
tyb0807 added inline comments to D117764: [AArch64][SelectionDAG] CodeGen for Armv8.8/9.3 MOPS.
Feb 1 2022, 4:41 AM · Restricted Project
tyb0807 committed rG762f0b546328: [ARM] Make getInstSizeInBytes() use instruction size from InstrInfo.td (authored by tyb0807).
[ARM] Make getInstSizeInBytes() use instruction size from InstrInfo.td
Feb 1 2022, 2:40 AM
tyb0807 committed rGdd88f40c80f5: [AArch64] Make getInstSizeInBytes() use instruction size from InstrInfo.td (authored by tyb0807).
[AArch64] Make getInstSizeInBytes() use instruction size from InstrInfo.td
Feb 1 2022, 2:40 AM
tyb0807 closed D118009: [ARM] Make getInstSizeInBytes() use instruction size from InstrInfo.td.
Feb 1 2022, 2:40 AM · Restricted Project
tyb0807 closed D117970: [AArch64] Make getInstSizeInBytes() use instruction size from InstrInfo.td.
Feb 1 2022, 2:39 AM · Restricted Project
tyb0807 updated the diff for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.

Add support for +nomops

Feb 1 2022, 2:29 AM · Restricted Project

Jan 31 2022

tyb0807 committed rGe21f90dba28c: [AArch64] Removing redundant PAuth flag (authored by tyb0807).
[AArch64] Removing redundant PAuth flag
Jan 31 2022, 1:01 PM
tyb0807 closed D117782: [AArch64] Removing redundant PAuth flag.
Jan 31 2022, 1:01 PM · Restricted Project
tyb0807 committed rG5aa08bf70854: [AArch64][SelectionDAG] CodeGen for Armv8.8/9.3 MOPS (authored by tyb0807).
[AArch64][SelectionDAG] CodeGen for Armv8.8/9.3 MOPS
Jan 31 2022, 12:56 PM
tyb0807 closed D117764: [AArch64][SelectionDAG] CodeGen for Armv8.8/9.3 MOPS.
Jan 31 2022, 12:56 PM · Restricted Project
tyb0807 committed rG78fd413cf736: [AArch64][GlobalISel] CodeGen for Armv8.8/9.3 MOPS (authored by tyb0807).
[AArch64][GlobalISel] CodeGen for Armv8.8/9.3 MOPS
Jan 31 2022, 12:55 PM
tyb0807 closed D117763: [AArch64][GlobalISel] CodeGen for Armv8.8/9.3 MOPS.
Jan 31 2022, 12:54 PM · Restricted Project
tyb0807 committed rG13660715e677: [AArch64] Modeling NZCV read/write for MOPS instructions (authored by tyb0807).
[AArch64] Modeling NZCV read/write for MOPS instructions
Jan 31 2022, 12:52 PM
tyb0807 closed D117757: [AArch64] Modeling NZCV read/write for MOPS instructions.
Jan 31 2022, 12:52 PM · Restricted Project
tyb0807 committed rG51e188d079f6: [AArch64] Support for memset tagged intrinsic (authored by tyb0807).
[AArch64] Support for memset tagged intrinsic
Jan 31 2022, 12:50 PM
tyb0807 closed D117753: [AArch64] Support for memset tagged intrinsic.
Jan 31 2022, 12:49 PM · Restricted Project, Restricted Project
tyb0807 updated the diff for D117970: [AArch64] Make getInstSizeInBytes() use instruction size from InstrInfo.td.

Add more tests

Jan 31 2022, 10:29 AM · Restricted Project

Jan 30 2022

tyb0807 updated the diff for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.

Add more tests and update accordingly to change from ACLE specification: __builtin_arm_mops_memset_tag requires _both_ MOPS and MTE features

Jan 30 2022, 12:05 AM · Restricted Project
tyb0807 updated the diff for D117764: [AArch64][SelectionDAG] CodeGen for Armv8.8/9.3 MOPS.

Update accordingly to change from ACLE specification: __builtin_arm_mops_memset_tag requires _both_ MOPS and MTE features

Jan 30 2022, 12:04 AM · Restricted Project

Jan 29 2022

tyb0807 updated the diff for D117763: [AArch64][GlobalISel] CodeGen for Armv8.8/9.3 MOPS.

Remove unused declaration

Jan 29 2022, 12:54 PM · Restricted Project

Jan 28 2022

tyb0807 added inline comments to D117763: [AArch64][GlobalISel] CodeGen for Armv8.8/9.3 MOPS.
Jan 28 2022, 1:45 PM · Restricted Project
tyb0807 updated the diff for D117763: [AArch64][GlobalISel] CodeGen for Armv8.8/9.3 MOPS.

Refactor tests and update accordingly to change from ACLE specification: __builtin_arm_mops_memset_tag requires _both_ MOPS and MTE features

Jan 28 2022, 1:44 PM · Restricted Project

Jan 27 2022

tyb0807 updated the diff for D117753: [AArch64] Support for memset tagged intrinsic.

Update link to the relevant section of ACLE specification

Jan 27 2022, 8:58 AM · Restricted Project, Restricted Project
tyb0807 updated the diff for D117753: [AArch64] Support for memset tagged intrinsic.

Update accordingly to change from ACLE specification: __builtin_arm_mops_memset_tag requires _both_ MOPS and MTE features

Jan 27 2022, 8:57 AM · Restricted Project, Restricted Project
tyb0807 added inline comments to D117763: [AArch64][GlobalISel] CodeGen for Armv8.8/9.3 MOPS.
Jan 27 2022, 2:05 AM · Restricted Project

Jan 26 2022

tyb0807 added inline comments to D117763: [AArch64][GlobalISel] CodeGen for Armv8.8/9.3 MOPS.
Jan 26 2022, 8:16 PM · Restricted Project
tyb0807 updated the diff for D117763: [AArch64][GlobalISel] CodeGen for Armv8.8/9.3 MOPS.

Be conservative on when to inline mem* functions. Remove dead code. Add more tests

Jan 26 2022, 8:16 PM · Restricted Project
tyb0807 updated the diff for D118009: [ARM] Make getInstSizeInBytes() use instruction size from InstrInfo.td.

Update new tests for variable-sized pseudo-instructions

Jan 26 2022, 1:58 AM · Restricted Project

Jan 25 2022

tyb0807 added a comment to D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.

Yes, https://reviews.llvm.org/D116160 is deprecated and will be abandoned.

Jan 25 2022, 8:24 PM · Restricted Project
tyb0807 added reviewers for D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS: ktkachov, chill, SjoerdMeijer, lenary, Matt, dmgreen, nickdesaulniers, t.p.northover, ab.
Jan 25 2022, 3:00 PM · Restricted Project
tyb0807 requested review of D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS.
Jan 25 2022, 2:58 PM · Restricted Project
tyb0807 updated the diff for D117763: [AArch64][GlobalISel] CodeGen for Armv8.8/9.3 MOPS.

clang-format tests

Jan 25 2022, 6:23 AM · Restricted Project
tyb0807 updated the diff for D117764: [AArch64][SelectionDAG] CodeGen for Armv8.8/9.3 MOPS.

Re-add comment explaining that llvm.mem* intrinsics can be either lowered to
ldr/str sequences or pseudo-instructions

Jan 25 2022, 6:18 AM · Restricted Project
tyb0807 added inline comments to D117753: [AArch64] Support for memset tagged intrinsic.
Jan 25 2022, 6:13 AM · Restricted Project, Restricted Project
tyb0807 updated the diff for D117970: [AArch64] Make getInstSizeInBytes() use instruction size from InstrInfo.td.

Move the tablegen querying to the default case to make the code consistent with
ARM version. Update the comment accordingly to clarify the intention of the code

Jan 25 2022, 2:19 AM · Restricted Project