This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Vector] Support 0-D vectors in TransposeOp
ClosedPublic

Authored by nicolasvasilache on Dec 14 2021, 10:23 AM.

Details

Summary

Co-authored-by: Michal Terepeta <michalt@google.com>

Reviewed-by: ftynse

Diff Detail

Event Timeline

michalt created this revision.Dec 14 2021, 10:23 AM
michalt requested review of this revision.Dec 14 2021, 10:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2021, 10:23 AM
ftynse accepted this revision.Dec 20 2021, 5:16 AM
ftynse added inline comments.
mlir/test/Dialect/Vector/invalid.mlir
1149

Nit: I find this error message quite cryptic -- what is "1"? Expected rank? Actual rank? Of what? I see that it is not introduced by this patch, but if you can fix that in a separate follow-up, it would be appreciated.

This revision is now accepted and ready to land.Dec 20 2021, 5:16 AM
nicolasvasilache commandeered this revision.Aug 26 2022, 3:34 AM
nicolasvasilache edited reviewers, added: michalt; removed: nicolasvasilache.
nicolasvasilache edited the summary of this revision. (Show Details)

Rebase

This revision was landed with ongoing or failed builds.Aug 26 2022, 3:40 AM
This revision was automatically updated to reflect the committed changes.